adespresso / FeatureBundle

Security/FeatureSecurity.php

<?php

namespace Ae\FeatureBundle\Security;

use Symfony\Component\Security\Core\SecurityContextInterface;
use Ae\FeatureBundle\Entity\Feature;

/**
 * Controls access to a Feature.
 *
 * @author Carlo Forghieri <carlo@adespresso.com>
 */
class FeatureSecurity
{
    protected $context;

    /**
     * @param \Symfony\Component\Security\Core\SecurityContextInterface $context
     */
    public function __construct(SecurityContextInterface $context = null)
    {
        $this->context = $context;
    }

    /**
     * @param \Ae\FeatureBundle\Entity\Feature $feature
     *
     * @return bool
     */
    public function isGranted(Feature $feature)
    {
        if (null === $this->context) {
            return false;
        }

        if (!$feature->isEnabled()) {
            return false;
        }

        if ($feature->getRole()) {
            if (!$this->context->isGranted($feature->getRole())) {
                return false;
            }
        }

        if ($feature->getParentRole()) {

The expression $feature->getParentRole() of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            if (!$this->context->isGranted($feature->getParentRole())) {
                return false;
            }
        }

        return true;
    }
}