FeatureSecurity::isGranted() - Code Metrics - Inspection of "Doctrine entity annotations" - adespresso/FeatureBundle - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#12)

by Emanuele

created 2016-03-31 20:59 UTC

FeatureSecurity::isGranted() C

↳ Parent: FeatureSecurity

Complexity

Conditions	7
Paths	9

Size

Total Lines	24
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	7.4822

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	24
ccs	11
cts	14
cp	0.7856
rs	6.7272
cc	7
eloc	12
nc	9
nop	1
crap	7.4822

<?php

namespace Ae\FeatureBundle\Security;

use Symfony\Component\Security\Core\SecurityContextInterface;
use Ae\FeatureBundle\Entity\Feature;

/**
 * Controls access to a Feature.
 *
 * @author Carlo Forghieri <[email protected]>
 */
class FeatureSecurity
{
    protected $context;

    /**
     * @param \Symfony\Component\Security\Core\SecurityContextInterface $context
     */
    public function __construct(SecurityContextInterface $context = null)
    {
        $this->context = $context;
    }

    /**
     * @param \Ae\FeatureBundle\Entity\Feature $feature
     *
     * @return bool
     */
    public function isGranted(Feature $feature)
    {
        if (null === $this->context) {
            return false;
        }

        if (!$feature->isEnabled()) {
            return false;
        }

        if ($feature->getRole()) {
            if (!$this->context->isGranted($feature->getRole())) {
                return false;
            }
        }

        if ($feature->getParentRole()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            if (!$this->context->isGranted($feature->getParentRole())) {
                return false;
            }
        }

        return true;
    }
}


1		<?php
2
3		namespace Ae\FeatureBundle\Security;
4
5		use Symfony\Component\Security\Core\SecurityContextInterface;
6		use Ae\FeatureBundle\Entity\Feature;
7
8		/**
9		* Controls access to a Feature.
10		*
11		* @author Carlo Forghieri <[email protected]>
12		*/
13		class FeatureSecurity
14		{
15		protected $context;
16
17		/**
18		* @param \Symfony\Component\Security\Core\SecurityContextInterface $context
19		*/
20	4	public function __construct(SecurityContextInterface $context = null)
21		{
22	4	$this->context = $context;
23	4	}
24
25		/**
26		* @param \Ae\FeatureBundle\Entity\Feature $feature
27		*
28		* @return bool
29		*/
30	4	public function isGranted(Feature $feature)
31		{
32	4	if (null === $this->context) {
33		return false;
34		}
35
36	4	if (!$feature->isEnabled()) {
37	1	return false;
38		}
39
40	3	if ($feature->getRole()) {
41	2	if (!$this->context->isGranted($feature->getRole())) {
42		return false;
43		}
44	2	}
45
46	3	if ($feature->getParentRole()) {
		0 ignored issues – show Bug Best Practice introduced 2016-01-29 19:17 UTC by Report Bug Copy Issue Report The expression `$feature->getParentRole()` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
47	1	if (!$this->context->isGranted($feature->getParentRole())) {
48	1	return false;
49		}
50		}
51
52	2	return true;
53		}
54		}
55

adespresso / FeatureBundle

Pull Request — master (#12)

FeatureSecurity::isGranted() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like