addiks / symfony_rdm

Mapping/ChoiceMapping.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Addiks\RDMBundle\Mapping\MappingInterface;
 use Doctrine\DBAL\Schema\Column;
 use Doctrine\DBAL\Types\Type;
-use Doctrine\DBAL\Types\TextType;
 use Addiks\RDMBundle\Exception\InvalidMappingException;
 use Addiks\RDMBundle\Hydration\HydrationContextInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;

Indentation +1 added lines, -1 removed lines

@@ -165,7 +165,7 @@
             $choiceValue = $choiceMapping->resolveValue(
                 $context,
                 [] # <= I'm not sure how this parameter should be handled correctly in the future,
-                   #    but with the current supported features it *should* be irrelevant.
+                    #    but with the current supported features it *should* be irrelevant.
             );
 
             if ($choiceValue === $valueFromEntityField) {

Mapping/Drivers/MappingXmlDriver.php

Unused Use Statements -1 removed lines

@@ -40,7 +40,6 @@
 use Symfony\Component\HttpKernel\KernelInterface;
 use Addiks\RDMBundle\Mapping\NullableMapping;
 use Addiks\RDMBundle\Mapping\NullableMappingInterface;
-use Symfony\Component\DependencyInjection\ContainerInterface;
 
 final class MappingXmlDriver implements MappingDriverInterface
 {

Tests/DataLoader/SimpleSelectDataLoaderTest.php

Unused Use Statements -2 removed lines

@@ -12,7 +12,6 @@ 
 
 use Addiks\RDMBundle\DataLoader\SimpleSelectDataLoader;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
-use Addiks\RDMBundle\Mapping\EntityMapping;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
 use Addiks\RDMBundle\Mapping\ChoiceMapping;
 use Addiks\RDMBundle\ValueResolver\ValueResolverInterface;
@@ -23,7 +22,6 @@ 
 use Doctrine\ORM\Query\Expr;
 use Doctrine\DBAL\Driver\Statement;
 use PHPUnit\Framework\TestCase;
-use Addiks\RDMBundle\Mapping\ServiceMapping;
 use Doctrine\ORM\UnitOfWork;
 use Addiks\RDMBundle\Tests\Hydration\ServiceExample;
 use Addiks\RDMBundle\Mapping\MappingInterface;

Tests/Hydration/EntityHydratorTest.php

Unused Use Statements -6 removed lines

@@ -13,17 +13,11 @@
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Hydration\EntityHydrator;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
 use Addiks\RDMBundle\Tests\Hydration\ServiceExample;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use ErrorException;
-use Addiks\RDMBundle\Mapping\ServiceMapping;
 use Addiks\RDMBundle\Mapping\EntityMapping;
-use Addiks\RDMBundle\ValueResolver\ValueResolverInterface;
-use Addiks\RDMBundle\Exception\FailedRDMAssertionExceptionInterface;
 use Addiks\RDMBundle\DataLoader\DataLoaderInterface;
 use Doctrine\ORM\EntityManagerInterface;
-use Addiks\RDMBundle\Mapping\EntityMappingInterface;
 use Addiks\RDMBundle\Mapping\MappingInterface;
 use Addiks\RDMBundle\Hydration\HydrationContextInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;

Tests/Mapping/ArrayMappingTest.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Addiks\RDMBundle\Mapping\ArrayMapping;
 use Addiks\RDMBundle\Mapping\MappingInterface;
 use Doctrine\DBAL\Schema\Column;
-use InvalidArgumentException;
 use Addiks\RDMBundle\Hydration\HydrationContextInterface;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
 use Addiks\RDMBundle\Exception\FailedRDMAssertionExceptionInterface;

Tests/Mapping/ChoiceMappingTest.php

Doc Comments +3 added lines

@@ -37,6 +37,9 @@
      */
     private $optionMappingB;
 
+    /**
+     * @param string $column
+     */
     public function setUp(
         $column = null
     ) {

Tests/Mapping/Drivers/MappingStaticPHPDriverTest.php

Unused Use Statements -3 removed lines

@@ -12,9 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
-use ReflectionProperty;
-use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Addiks\RDMBundle\Mapping\Drivers\MappingStaticPHPDriver;
 use Addiks\RDMBundle\Mapping\EntityMapping;
 use Addiks\RDMBundle\Mapping\ServiceMapping;

Tests/Mapping/Drivers/MappingXmlDriverTest.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
             'bar' => new ServiceMapping($this->container, 'other_service', false, "in file '{$mappingFilePath}'"),
             'baz' => new ChoiceMapping('baz_column', [
                 'lorem' => new ServiceMapping($this->container, "lorem_service", false, "in file '{$mappingFilePath}'"),
-                'ipsum' => new ServiceMapping($this->container, "ipsum_service", true,  "in file '{$mappingFilePath}'"),
+                'ipsum' => new ServiceMapping($this->container, "ipsum_service", true, "in file '{$mappingFilePath}'"),
             ], "in file '{$mappingFilePath}'"),
             'faz' => new ChoiceMapping(new Column("faz_column", Type::getType('string'), ['notnull' => true]), [
                 'lorem' => new ServiceMapping($this->container, "lorem_service", false, "in file '{$mappingFilePath}'"),