addiks / symfony_rdm

Tests/Mapping/Drivers/MappingPHPDriverTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
-use ReflectionProperty;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Addiks\RDMBundle\Mapping\Drivers\MappingPHPDriver;
 use Doctrine\Common\Persistence\Mapping\Driver\FileLocator;

Tests/Mapping/Drivers/MappingXmlDriverTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
-use ReflectionProperty;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Doctrine\Common\Persistence\Mapping\Driver\FileLocator;
 use Addiks\RDMBundle\Mapping\Drivers\MappingXmlDriver;

Spacing +2 added lines, -2 removed lines

@@ -64,7 +64,7 @@ 
             'bar' => new ServiceMapping('other_service', false, "in file '{$mappingFilePath}'"),
             'baz' => new ChoiceMapping('baz_column', [
                 'lorem' => new ServiceMapping("lorem_service", false, "in file '{$mappingFilePath}'"),
-                'ipsum' => new ServiceMapping("ipsum_service", true,  "in file '{$mappingFilePath}'"),
+                'ipsum' => new ServiceMapping("ipsum_service", true, "in file '{$mappingFilePath}'"),
             ], "in file '{$mappingFilePath}'"),
             'faz' => new ChoiceMapping(new Column("faz_column", Type::getType('string'), ['notnull' => true]), [
                 'lorem' => new ServiceMapping("lorem_service", false, "in file '{$mappingFilePath}'"),
@@ -129,7 +129,7 @@ 
                 new CallDefinition("createValueObject", "@value_object.factory", [
                     new ChoiceMapping('baz_column', [
                         'lorem' => new ServiceMapping("lorem_service", false, "in file '{$mappingFilePath}'"),
-                        'ipsum' => new ServiceMapping("ipsum_service", true,  "in file '{$mappingFilePath}'"),
+                        'ipsum' => new ServiceMapping("ipsum_service", true, "in file '{$mappingFilePath}'"),
                     ], "in file '{$mappingFilePath}'")
                 ])
             ),

Tests/Mapping/Drivers/MappingYamlDriverTest.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
-use ReflectionProperty;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
 use Doctrine\Common\Persistence\Mapping\Driver\FileLocator;
 use Addiks\RDMBundle\Mapping\Drivers\MappingYamlDriver;

DependencyInjection/AddiksRDMExtension.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.xml');
     }
 }

DataLoader/SimpleSelectDataLoader.php

Doc Comments +3 added lines, -3 removed lines

@@ -69,7 +69,7 @@ 
     }
 
     /**
-     * @param object $entity
+     * @param \Addiks\RDMBundle\Tests\Hydration\EntityExample $entity
      */
     public function loadDBALDataForEntity($entity, EntityManagerInterface $entityManager): array
     {
@@ -160,7 +160,7 @@ 
     }
 
     /**
-     * @param object $entity
+     * @param \Addiks\RDMBundle\Tests\Hydration\EntityExample $entity
      */
     public function storeDBALDataForEntity($entity, EntityManagerInterface $entityManager): void
     {
@@ -197,7 +197,7 @@ 
     }
 
     /**
-     * @param object $entity
+     * @param \Addiks\RDMBundle\Tests\Hydration\EntityExample $entity
      */
     public function removeDBALDataForEntity($entity, EntityManagerInterface $entityManager): void
     {

Tests/DataLoader/SimpleSelectDataLoaderTest.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 use Doctrine\ORM\Query\Expr;
 use Doctrine\DBAL\Driver\Statement;
 use PHPUnit\Framework\TestCase;
-use Addiks\RDMBundle\Mapping\ServiceMapping;
 use Doctrine\ORM\UnitOfWork;
 use Addiks\RDMBundle\Tests\Hydration\ServiceExample;
 

Tests/Mapping/ArrayMappingTest.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Addiks\RDMBundle\Mapping\ArrayMapping;
 use Addiks\RDMBundle\Mapping\MappingInterface;
 use Doctrine\DBAL\Schema\Column;
-use InvalidArgumentException;
 
 final class ArrayMappingTest extends TestCase
 {

Tests/ValueObjectExample.php

Doc Comments +3 added lines

@@ -59,6 +59,9 @@
         return [$this->scalarValue, $this->lorem, $this->dolor];
     }
 
+    /**
+     * @param string $amet
+     */
     public function setAmet($amet)
     {
         $this->amet = $amet;

Mapping/ObjectMappingInterface.php

Doc Comments +15 added lines

@@ -21,6 +21,9 @@ 
 
     public function getClassName(): string;
 
+    /**
+     * @return null|Column
+     */
     public function getDBALColumn(): ?Column;
 
     /**
@@ -28,12 +31,24 @@ 
      */
     public function getFieldMappings(): array;
 
+    /**
+     * @return null|CallDefinitionInterface
+     */
     public function getFactory(): ?CallDefinitionInterface;
 
+    /**
+     * @return null|CallDefinitionInterface
+     */
     public function getSerializer(): ?CallDefinitionInterface;
 
+    /**
+     * @return null|string
+     */
     public function getId(): ?string;
 
+    /**
+     * @return null|string
+     */
     public function getReferencedId(): ?string;
 
 }