addiks / symfony_rdm

Mapping/ObjectMappingInterface.php

Doc Comments +15 added lines

@@ -21,6 +21,9 @@ 
 
     public function getClassName(): string;
 
+    /**
+     * @return null|Column
+     */
     public function getDBALColumn(): ?Column;
 
     /**
@@ -28,12 +31,24 @@ 
      */
     public function getFieldMappings(): array;
 
+    /**
+     * @return null|CallDefinitionInterface
+     */
     public function getFactory(): ?CallDefinitionInterface;
 
+    /**
+     * @return null|CallDefinitionInterface
+     */
     public function getSerializer(): ?CallDefinitionInterface;
 
+    /**
+     * @return null|string
+     */
     public function getId(): ?string;
 
+    /**
+     * @return null|string
+     */
     public function getReferencedId(): ?string;
 
 }

Tests/Hydration/EntityHydratorTest.php

Unused Use Statements -5 removed lines

@@ -13,18 +13,13 @@
 use PHPUnit\Framework\TestCase;
 use Addiks\RDMBundle\Hydration\EntityHydrator;
 use Addiks\RDMBundle\Mapping\Drivers\MappingDriverInterface;
-use Addiks\RDMBundle\Mapping\Annotation\Service;
 use Addiks\RDMBundle\Tests\Hydration\ServiceExample;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
-use ErrorException;
 use Addiks\RDMBundle\Mapping\ServiceMapping;
 use Addiks\RDMBundle\Mapping\EntityMapping;
 use Addiks\RDMBundle\ValueResolver\ValueResolverInterface;
-use Addiks\RDMBundle\Exception\FailedRDMAssertionExceptionInterface;
 use Addiks\RDMBundle\DataLoader\DataLoaderInterface;
 use Doctrine\ORM\EntityManagerInterface;
-use Addiks\RDMBundle\Mapping\EntityMappingInterface;
-use Addiks\RDMBundle\Mapping\MappingInterface;
 use Addiks\RDMBundle\Hydration\HydrationContextInterface;
 
 final class EntityHydratorTest extends TestCase

Tests/Mapping/Drivers/MappingAnnotationDriverTest.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 use Doctrine\DBAL\Schema\Column as DBALColumn;
 use Doctrine\DBAL\Types\Type;
 use Addiks\RDMBundle\Mapping\MappingInterface;
-use Addiks\RDMBundle\Mapping\Annotation\Obj;
 use Addiks\RDMBundle\Tests\ValueObjectExample;
 use Addiks\RDMBundle\Mapping\ObjectMapping;
 use Doctrine\ORM\Mapping\Column as ORMColumn;

Tests/ValueResolver/ChoiceValueResolverTest.php

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 use Addiks\RDMBundle\Mapping\ChoiceMapping;
 use Addiks\RDMBundle\Tests\Hydration\EntityExample;
 use Addiks\RDMBundle\Mapping\ServiceMapping;
-use Addiks\RDMBundle\Mapping\MappingInterface;
 use Addiks\RDMBundle\Hydration\HydrationContextInterface;
 
 final class ChoiceValueResolverTest extends TestCase

ValueResolver/CallDefinitionExecuter.php

Doc Comments +1 added lines, -1 removed lines

@@ -138,7 +138,7 @@
      * @param array<MappingInterface> $argumentMappings
      * @param array<scalar>           $dataFromAdditionalColumns
      *
-     * @return array<mixed>
+     * @return callable
      */
     private function resolveArguments(
         array $argumentMappings,

Unused Use Statements -1 removed lines

@@ -18,7 +18,6 @@
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Addiks\RDMBundle\ValueResolver\ValueResolverInterface;
 use Addiks\RDMBundle\Hydration\HydrationContextInterface;
-use Addiks\RDMBundle\Exception\InvalidMappingException;
 
 final class CallDefinitionExecuter implements CallDefinitionExecuterInterface
 {

Spacing +2 added lines, -2 removed lines

@@ -112,10 +112,10 @@
                 $callee = $context->getEntity();
 
             } elseif (in_array($objectReference, ['self', 'this'])) {
-                $callee = $hydrationStack[count($hydrationStack)-1];
+                $callee = $hydrationStack[count($hydrationStack) - 1];
 
             } elseif (in_array($objectReference, ['parent'])) {
-                $callee = $hydrationStack[count($hydrationStack)-2];
+                $callee = $hydrationStack[count($hydrationStack) - 2];
 
             } elseif ($objectReference[0] === '@') {
                 /** @var string $serviceId */

ValueResolver/CallDefinitionExecuterInterface.php

Doc Comments -1 removed lines

@@ -19,7 +19,6 @@
 {
 
     /**
-     * @param object                  $entity
      * @param array<scalar>           $dataFromAdditionalColumns
      *
      * @return mixed

ValueResolver/ChoiceValueResolver.php

Indentation +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
                     $choiceMapping,
                     $context,
                     [] # <= I'm not sure how this parameter should be handled correctly in the future,
-                       #    but with the current supported features it *should* be irrelevant.
+                        #    but with the current supported features it *should* be irrelevant.
                 );
 
                 if ($choiceValue === $valueFromEntityField) {