NullValueResolverTest - Code Metrics - Inspection of "added some XML mapping examples to the docs" - addiks/symfony_rdm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 356755...14835f )

by Gerrit

created 2018-05-19 19:54 UTC

NullValueResolverTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	51
Duplicated Lines	17.65 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	2
dl	9
loc	51
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
A	shouldNotResolveValue()	0	8	1
A	shouldNotRevertValue()	0	8	1
A	shouldNotAssertValue()	9	9	1

How to fix Duplicated Code

<?php
/**
 * Copyright (C) 2017  Gerrit Addiks.
 * This package (including this file) was released under the terms of the GPL-3.0.
 * You should have received a copy of the GNU General Public License along with this program.
 * If not, see <http://www.gnu.org/licenses/> or send me a mail so i can send you a copy.
 * @license GPL-3.0
 * @author Gerrit Addiks <[email protected]>
 */

namespace Addiks;

use PHPUnit\Framework\TestCase;
use Addiks\RDMBundle\ValueResolver\NullValueResolver;
use Addiks\RDMBundle\Mapping\MappingInterface;
use Addiks\RDMBundle\Hydration\HydrationContextInterface;

final class NullValueResolverTest extends TestCase
{

    /**
     * @var NullValueResolver
     */
    private $valueResolver;

    public function setUp()
    {
        $this->valueResolver = new NullValueResolver();
    }

    /**
     * @test
     */
    public function shouldNotResolveValue()
    {
        $this->assertNull($this->valueResolver->resolveValue(
            $this->createMock(MappingInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock(HydrationContextInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            []
        ));
    }

    /**
     * @test
     */
    public function shouldNotRevertValue()
    {
        $this->assertEmpty($this->valueResolver->revertValue(
            $this->createMock(MappingInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock(HydrationContextInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            null
        ));
    }

    /**
     * @test
     */
    public function shouldNotAssertValue()

    {
        $this->assertNull($this->valueResolver->assertValue(
            $this->createMock(MappingInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock(HydrationContextInterface::class),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [],
            null
        ));
    }

}


1		<?php
2		/**
3		* Copyright (C) 2017 Gerrit Addiks.
4		* This package (including this file) was released under the terms of the GPL-3.0.
5		* You should have received a copy of the GNU General Public License along with this program.
6		* If not, see <http://www.gnu.org/licenses/> or send me a mail so i can send you a copy.
7		* @license GPL-3.0
8		* @author Gerrit Addiks <[email protected]>
9		*/
10
11		namespace Addiks;
12
13		use PHPUnit\Framework\TestCase;
14		use Addiks\RDMBundle\ValueResolver\NullValueResolver;
15		use Addiks\RDMBundle\Mapping\MappingInterface;
16		use Addiks\RDMBundle\Hydration\HydrationContextInterface;
17
18		final class NullValueResolverTest extends TestCase
19		{
20
21		/**
22		* @var NullValueResolver
23		*/
24		private $valueResolver;
25
26		public function setUp()
27		{
28		$this->valueResolver = new NullValueResolver();
29		}
30
31		/**
32		* @test
33		*/
34		public function shouldNotResolveValue()
35		{
36		$this->assertNull($this->valueResolver->resolveValue(
37		$this->createMock(MappingInterface::class),
		0 ignored issues – show Documentation introduced 2018-05-19 19:58 UTC by Report Bug Copy Issue Report `$this->createMock(\Addik...appingInterface::class)` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Addiks\RDMBundle\Mapping\MappingInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38		$this->createMock(HydrationContextInterface::class),
		0 ignored issues – show Documentation introduced 2018-05-19 19:58 UTC by Report Bug Copy Issue Report `$this->createMock(\Addik...ontextInterface::class)` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Addiks\RDMBundle\...rationContextInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39		[]
40		));
41		}
42
43		/**
44		* @test
45		*/
46		public function shouldNotRevertValue()
47		{
48		$this->assertEmpty($this->valueResolver->revertValue(
49		$this->createMock(MappingInterface::class),
		0 ignored issues – show Documentation introduced 2018-05-19 19:58 UTC by Report Bug Copy Issue Report `$this->createMock(\Addik...appingInterface::class)` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Addiks\RDMBundle\Mapping\MappingInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
50		$this->createMock(HydrationContextInterface::class),
		0 ignored issues – show Documentation introduced 2018-05-19 19:58 UTC by Report Bug Copy Issue Report `$this->createMock(\Addik...ontextInterface::class)` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Addiks\RDMBundle\...rationContextInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
51		null
52		));
53		}
54
55		/**
56		* @test
57		*/
58	View Code Duplication	public function shouldNotAssertValue()
		0 ignored issues – show Duplication introduced 2018-05-19 19:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		{
60		$this->assertNull($this->valueResolver->assertValue(
61		$this->createMock(MappingInterface::class),
		0 ignored issues – show Documentation introduced 2018-05-19 19:58 UTC by Report Bug Copy Issue Report `$this->createMock(\Addik...appingInterface::class)` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Addiks\RDMBundle\Mapping\MappingInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
62		$this->createMock(HydrationContextInterface::class),
		0 ignored issues – show Documentation introduced 2018-05-19 19:58 UTC by Report Bug Copy Issue Report `$this->createMock(\Addik...ontextInterface::class)` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Addiks\RDMBundle\...rationContextInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
63		[],
64		null
65		));
66		}
67
68		}
69

addiks / symfony_rdm

Push — master ( 356755...14835f )

NullValueResolverTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like