Issues in AOPInboundEmail.php (scrutinizer-code-quality) - Issues in scrutinizer-code-quality - adamjakab/SuiteCRM - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4069)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

modules/InboundEmail/AOPInboundEmail.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
 /**
 * 
 * 
 * @package 
 * @copyright SalesAgility Ltd http://www.salesagility.com
 * 
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE as published by
 * the Free Software Foundation; either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU AFFERO GENERAL PUBLIC LICENSE
 * along with this program; if not, see http://www.gnu.org/licenses
 * or write to the Free Software Foundation,Inc., 51 Franklin Street,
 * Fifth Floor, Boston, MA 02110-1301  USA
 *
 * @author Salesagility Ltd <[email protected]>
 */
require_once 'modules/InboundEmail/InboundEmail.php';
require_once 'include/clean.php';
class AOPInboundEmail extends InboundEmail {

    /**
     * Replaces embedded image links with links to the appropriate note in the CRM.
     * @param $string
     * @param $noteIds A whitelist of note ids to replace
     * @return mixed
     */
    function processImageLinks($string, $noteIds){
        global $sugar_config;
        if(!$noteIds){
            return $string;
        }
        $matches = array();
        preg_match('/cid:([[:alnum:]-]*)/',$string,$matches);
        if(!$matches){

            return $string;
        }
        array_shift($matches);
        $matches = array_unique($matches);
        foreach($matches as $match){
            if(in_array($match,$noteIds)){
                $string = str_replace('cid:'.$match,$sugar_config['site_url']."/index.php?entryPoint=download&id={$match}&type=Notes&",$string);
            }
        }
        return $string;
    }


    function handleCreateCase($email, $userId) {
        global $current_user, $mod_strings, $current_language;
        $mod_strings = return_module_language($current_language, "Emails");
        $GLOBALS['log']->debug('In handleCreateCase in AOPInboundEmail');
        $c = new aCase();
        $this->getCaseIdFromCaseNumber($email->name, $c);

        if (!$this->handleCaseAssignment($email) && $this->isMailBoxTypeCreateCase()) {
            // create a case
            $GLOBALS['log']->debug('retrieveing email');
            $email->retrieve($email->id);
            $c = new aCase();

            $notes = $email->get_linked_beans('notes','Notes');
            $noteIds = array();
            foreach($notes as $note){
                $noteIds[] = $note->id;
            }
            if($email->description_html) {
                $c->description = $this->processImageLinks(SugarCleaner::cleanHtml($email->description_html),$noteIds);
            }else{
                $c->description = $email->description;
            }
            $c->assigned_user_id = $userId;
            $c->name = $email->name;
            $c->status = 'New';
            $c->priority = 'P1';

            if(!empty($email->reply_to_email)) {
                $contactAddr = $email->reply_to_email;
            } else {
                $contactAddr = $email->from_addr;
            }

            $GLOBALS['log']->debug('finding related accounts with address ' . $contactAddr);
            if($accountIds = $this->getRelatedId($contactAddr, 'accounts')) {
                if (sizeof($accountIds) == 1) {
                    $c->account_id = $accountIds[0];

                    $acct = new Account();
                    $acct->retrieve($c->account_id);
                    $c->account_name = $acct->name;
                } // if
            } // if
            $contactIds = $this->getRelatedId($contactAddr, 'contacts');
            if(!empty($contactIds)) {
                $c->contact_created_by_id = $contactIds[0];
            }

            $c->save(true);
            $caseId = $c->id;
            $c = new aCase();
            $c->retrieve($caseId);
            if($c->load_relationship('emails')) {
                $c->emails->add($email->id);
            } // if
                if(!empty($contactIds) && $c->load_relationship('contacts')) {
                    if (!$accountIds && count($contactIds) == 1) {
                        $contact = BeanFactory::getBean('Contacts', $contactIds[0]);
                        if ($contact->load_relationship('accounts')) {
                            $acct = $contact->accounts->get();
                            if ($c->load_relationship('accounts') && !empty($acct[0])) {
                                $c->accounts->add($acct[0]);
                            }
                        }
                    }
                    $c->contacts->add($contactIds);
                } // if
            foreach($notes as $note){
                //Link notes to case also
                $newNote = BeanFactory::newBean('Notes');
                $newNote->name = $note->name;
                $newNote->file_mime_type = $note->file_mime_type;
                $newNote->filename = $note->filename;
                $newNote->parent_type = 'Cases';
                $newNote->parent_id = $c->id;
                $newNote->save();
                $srcFile = "upload://{$note->id}";
                $destFile = "upload://{$newNote->id}";
                copy($srcFile,$destFile);

            }

            $c->email_id = $email->id;
            $email->parent_type = "Cases";
            $email->parent_id = $caseId;
            // assign the email to the case owner
            $email->assigned_user_id = $c->assigned_user_id;
            $email->name = str_replace('%1', $c->case_number, $c->getEmailSubjectMacro()) . " ". $email->name;
            $email->save();
            $GLOBALS['log']->debug('InboundEmail created one case with number: '.$c->case_number);
            $createCaseTemplateId = $this->get_stored_options('create_case_email_template', "");
            if(!empty($this->stored_options)) {
                $storedOptions = unserialize(base64_decode($this->stored_options));
            }
            if(!empty($createCaseTemplateId)) {
                $fromName = "";
                $fromAddress = "";
                if (!empty($this->stored_options)) {
                    $fromAddress = $storedOptions['from_addr'];
                    $fromName = from_html($storedOptions['from_name']);
                    $replyToName = (!empty($storedOptions['reply_to_name']))? from_html($storedOptions['reply_to_name']) :$fromName ;
                    $replyToAddr = (!empty($storedOptions['reply_to_addr'])) ? $storedOptions['reply_to_addr'] : $fromAddress;
                } // if
                $defaults = $current_user->getPreferredEmail();
                $fromAddress = (!empty($fromAddress)) ? $fromAddress : $defaults['email'];
                $fromName = (!empty($fromName)) ? $fromName : $defaults['name'];
                $to[0]['email'] = $contactAddr;

                // handle to name: address, prefer reply-to
                if(!empty($email->reply_to_name)) {
                    $to[0]['display'] = $email->reply_to_name;
                } elseif(!empty($email->from_name)) {
                    $to[0]['display'] = $email->from_name;
                }

                $et = new EmailTemplate();
                $et->retrieve($createCaseTemplateId);
                if(empty($et->subject))		{ $et->subject = ''; }
                if(empty($et->body))		{ $et->body = ''; }
                if(empty($et->body_html))	{ $et->body_html = ''; }

                $et->subject = "Re:" . " " . str_replace('%1', $c->case_number, $c->getEmailSubjectMacro() . " ". $c->name);

                $html = trim($email->description_html);
                $plain = trim($email->description);

                $email->email2init();
                $email->from_addr = $email->from_addr_name;
                $email->to_addrs = $email->to_addrs_names;
                $email->cc_addrs = $email->cc_addrs_names;
                $email->bcc_addrs = $email->bcc_addrs_names;
                $email->from_name = $email->from_addr;

                $email = $email->et->handleReplyType($email, "reply");
                $ret = $email->et->displayComposeEmail($email);
                $ret['description'] = empty($email->description_html) ?  str_replace("\n", "\n<BR/>", $email->description) : $email->description_html;

                $reply = new Email();
                $reply->type				= 'out';
                $reply->to_addrs			= $to[0]['email'];
                $reply->to_addrs_arr		= $to;
                $reply->cc_addrs_arr		= array();
                $reply->bcc_addrs_arr		= array();
                $reply->from_name			= $fromName;
                $reply->from_addr			= $fromAddress;
                $reply->reply_to_name		= $replyToName;
                $reply->reply_to_addr		= $replyToAddr;
                $reply->name				= $et->subject;
                $reply->description			= $et->body . "<div><hr /></div>" .  $email->description;
                if (!$et->text_only) {
                    $reply->description_html	= $et->body_html .  "<div><hr /></div>" . $email->description;
                }
                $GLOBALS['log']->debug('saving and sending auto-reply email');
                //$reply->save(); // don't save the actual email.
                $reply->send();
            } // if

        } else {
            echo "First if not matching\n";
            if(!empty($email->reply_to_email)) {
                $contactAddr = $email->reply_to_email;
            } else {
                $contactAddr = $email->from_addr;
            }
            $this->handleAutoresponse($email, $contactAddr);
        }
        echo "End of handle create case\n";

    } // fn
}

1			<?php
2			/**
3			*
4			*
5			* @package
6			* @copyright SalesAgility Ltd http://www.salesagility.com
7			*
8			* This program is free software; you can redistribute it and/or modify
9			* it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE as published by
10			* the Free Software Foundation; either version 3 of the License, or
11			* (at your option) any later version.
12			*
13			* This program is distributed in the hope that it will be useful,
14			* but WITHOUT ANY WARRANTY; without even the implied warranty of
15			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16			* GNU General Public License for more details.
17			*
18			* You should have received a copy of the GNU AFFERO GENERAL PUBLIC LICENSE
19			* along with this program; if not, see http://www.gnu.org/licenses
20			* or write to the Free Software Foundation,Inc., 51 Franklin Street,
21			* Fifth Floor, Boston, MA 02110-1301 USA
22			*
23			* @author Salesagility Ltd <[email protected]>
24			*/
25			require_once 'modules/InboundEmail/InboundEmail.php';
26			require_once 'include/clean.php';
27			class AOPInboundEmail extends InboundEmail {
28
29			/**
30			* Replaces embedded image links with links to the appropriate note in the CRM.
31			* @param $string
32			* @param $noteIds A whitelist of note ids to replace
33			* @return mixed
34			*/
35			function processImageLinks($string, $noteIds){
36			global $sugar_config;
37			if(!$noteIds){
38			return $string;
39			}
40			$matches = array();
41			preg_match('/cid:([[:alnum:]-]*)/',$string,$matches);
42			if(!$matches){
			0 ignored issues – show Bug Best Practice introduced 2016-03-07 15:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$matches` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
43			return $string;
44			}
45			array_shift($matches);
46			$matches = array_unique($matches);
47			foreach($matches as $match){
48			if(in_array($match,$noteIds)){
49			$string = str_replace('cid:'.$match,$sugar_config['site_url']."/index.php?entryPoint=download&id={$match}&type=Notes&",$string);
50			}
51			}
52			return $string;
53			}
54
55
56			function handleCreateCase($email, $userId) {
57			global $current_user, $mod_strings, $current_language;
58			$mod_strings = return_module_language($current_language, "Emails");
59			$GLOBALS['log']->debug('In handleCreateCase in AOPInboundEmail');
60			$c = new aCase();
61			$this->getCaseIdFromCaseNumber($email->name, $c);
62
63			if (!$this->handleCaseAssignment($email) && $this->isMailBoxTypeCreateCase()) {
64			// create a case
65			$GLOBALS['log']->debug('retrieveing email');
66			$email->retrieve($email->id);
67			$c = new aCase();
68
69			$notes = $email->get_linked_beans('notes','Notes');
70			$noteIds = array();
71			foreach($notes as $note){
72			$noteIds[] = $note->id;
73			}
74			if($email->description_html) {
75			$c->description = $this->processImageLinks(SugarCleaner::cleanHtml($email->description_html),$noteIds);
76			}else{
77			$c->description = $email->description;
78			}
79			$c->assigned_user_id = $userId;
80			$c->name = $email->name;
81			$c->status = 'New';
82			$c->priority = 'P1';
83
84			if(!empty($email->reply_to_email)) {
85			$contactAddr = $email->reply_to_email;
86			} else {
87			$contactAddr = $email->from_addr;
88			}
89
90			$GLOBALS['log']->debug('finding related accounts with address ' . $contactAddr);
91			if($accountIds = $this->getRelatedId($contactAddr, 'accounts')) {
92			if (sizeof($accountIds) == 1) {
93			$c->account_id = $accountIds[0];
94
95			$acct = new Account();
96			$acct->retrieve($c->account_id);
97			$c->account_name = $acct->name;
98			} // if
99			} // if
100			$contactIds = $this->getRelatedId($contactAddr, 'contacts');
101			if(!empty($contactIds)) {
102			$c->contact_created_by_id = $contactIds[0];
103			}
104
105			$c->save(true);
106			$caseId = $c->id;
107			$c = new aCase();
108			$c->retrieve($caseId);
109			if($c->load_relationship('emails')) {
110			$c->emails->add($email->id);
111			} // if
112			if(!empty($contactIds) && $c->load_relationship('contacts')) {
113			if (!$accountIds && count($contactIds) == 1) {
114			$contact = BeanFactory::getBean('Contacts', $contactIds[0]);
115			if ($contact->load_relationship('accounts')) {
116			$acct = $contact->accounts->get();
117			if ($c->load_relationship('accounts') && !empty($acct[0])) {
118			$c->accounts->add($acct[0]);
119			}
120			}
121			}
122			$c->contacts->add($contactIds);
123			} // if
124			foreach($notes as $note){
125			//Link notes to case also
126			$newNote = BeanFactory::newBean('Notes');
127			$newNote->name = $note->name;
128			$newNote->file_mime_type = $note->file_mime_type;
129			$newNote->filename = $note->filename;
130			$newNote->parent_type = 'Cases';
131			$newNote->parent_id = $c->id;
132			$newNote->save();
133			$srcFile = "upload://{$note->id}";
134			$destFile = "upload://{$newNote->id}";
135			copy($srcFile,$destFile);
136
137			}
138
139			$c->email_id = $email->id;
140			$email->parent_type = "Cases";
141			$email->parent_id = $caseId;
142			// assign the email to the case owner
143			$email->assigned_user_id = $c->assigned_user_id;
144			$email->name = str_replace('%1', $c->case_number, $c->getEmailSubjectMacro()) . " ". $email->name;
145			$email->save();
146			$GLOBALS['log']->debug('InboundEmail created one case with number: '.$c->case_number);
147			$createCaseTemplateId = $this->get_stored_options('create_case_email_template', "");
148			if(!empty($this->stored_options)) {
149			$storedOptions = unserialize(base64_decode($this->stored_options));
150			}
151			if(!empty($createCaseTemplateId)) {
152			$fromName = "";
153			$fromAddress = "";
154			if (!empty($this->stored_options)) {
155			$fromAddress = $storedOptions['from_addr'];
156			$fromName = from_html($storedOptions['from_name']);
157			$replyToName = (!empty($storedOptions['reply_to_name']))? from_html($storedOptions['reply_to_name']) :$fromName ;
158			$replyToAddr = (!empty($storedOptions['reply_to_addr'])) ? $storedOptions['reply_to_addr'] : $fromAddress;
159			} // if
160			$defaults = $current_user->getPreferredEmail();
161			$fromAddress = (!empty($fromAddress)) ? $fromAddress : $defaults['email'];
162			$fromName = (!empty($fromName)) ? $fromName : $defaults['name'];
163			$to[0]['email'] = $contactAddr;
164
165			// handle to name: address, prefer reply-to
166			if(!empty($email->reply_to_name)) {
167			$to[0]['display'] = $email->reply_to_name;
168			} elseif(!empty($email->from_name)) {
169			$to[0]['display'] = $email->from_name;
170			}
171
172			$et = new EmailTemplate();
173			$et->retrieve($createCaseTemplateId);
174			if(empty($et->subject)) { $et->subject = ''; }
175			if(empty($et->body)) { $et->body = ''; }
176			if(empty($et->body_html)) { $et->body_html = ''; }
177
178			$et->subject = "Re:" . " " . str_replace('%1', $c->case_number, $c->getEmailSubjectMacro() . " ". $c->name);
179
180			$html = trim($email->description_html);
181			$plain = trim($email->description);
182
183			$email->email2init();
184			$email->from_addr = $email->from_addr_name;
185			$email->to_addrs = $email->to_addrs_names;
186			$email->cc_addrs = $email->cc_addrs_names;
187			$email->bcc_addrs = $email->bcc_addrs_names;
188			$email->from_name = $email->from_addr;
189
190			$email = $email->et->handleReplyType($email, "reply");
191			$ret = $email->et->displayComposeEmail($email);
192			$ret['description'] = empty($email->description_html) ? str_replace("\n", "\n<BR/>", $email->description) : $email->description_html;
193
194			$reply = new Email();
195			$reply->type = 'out';
196			$reply->to_addrs = $to[0]['email'];
197			$reply->to_addrs_arr = $to;
198			$reply->cc_addrs_arr = array();
199			$reply->bcc_addrs_arr = array();
200			$reply->from_name = $fromName;
201			$reply->from_addr = $fromAddress;
202			$reply->reply_to_name = $replyToName;
203			$reply->reply_to_addr = $replyToAddr;
204			$reply->name = $et->subject;
205			$reply->description = $et->body . "<div><hr /></div>" . $email->description;
206			if (!$et->text_only) {
207			$reply->description_html = $et->body_html . "<div><hr /></div>" . $email->description;
208			}
209			$GLOBALS['log']->debug('saving and sending auto-reply email');
210			//$reply->save(); // don't save the actual email.
211			$reply->send();
212			} // if
213
214			} else {
215			echo "First if not matching\n";
216			if(!empty($email->reply_to_email)) {
217			$contactAddr = $email->reply_to_email;
218			} else {
219			$contactAddr = $email->from_addr;
220			}
221			$this->handleAutoresponse($email, $contactAddr);
222			}
223			echo "End of handle create case\n";
224
225			} // fn
226			}

adamjakab / SuiteCRM

Issues (4069)

Security Analysis not enabled

modules/InboundEmail/AOPInboundEmail.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like