Client::toneChat() - Code Metrics - Inspection of "Merge pull request #15 from adam-paterson/feature/..." - adam-paterson/ibm-watson-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( bc21b0...0bdfd4 )

by Adam

created 2017-10-06 13:14 UTC

Client::toneChat() A

↳ Parent: Client

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace IBM\Watson\ToneAnalyzer;

use Http\Client\HttpClient;
use Http\Discovery\HttpClientDiscovery;
use IBM\Watson\Common\HttpClient\Builder;
use IBM\Watson\Common\Hydrator\HydratorInterface;
use IBM\Watson\Common\Hydrator\ModelHydrator;
use IBM\Watson\Common\RequestBuilder;

final class Client
{
    /**
     * Base tone analyzer uri
     */
    const BASE_URI = 'https://gateway.watsonplatform.net/tone-analyzer';

    /**
     * @var \Http\Client\HttpClient
     */
    private $httpClient;

    /**
     * @var \IBM\Watson\Common\Hydrator\ModelHydrator
     */
    private $hydrator;

    /**
     * @var \IBM\Watson\Common\RequestBuilder
     */
    private $requestBuilder;

    /**
     * Client constructor.
     *
     * @param \Http\Client\HttpClient|null                       $httpClient
     * @param \IBM\Watson\Common\Hydrator\HydratorInterface|null $hydrator
     * @param \IBM\Watson\Common\RequestBuilder|null             $requestBuilder
     *
     * @throws \Http\Discovery\Exception\NotFoundException
     */
    public function __construct(

        HttpClient $httpClient = null,
        HydratorInterface $hydrator = null,
        RequestBuilder $requestBuilder = null
    ) {
        $this->httpClient = $httpClient ?: HttpClientDiscovery::find();
        $this->hydrator = $hydrator ?: new ModelHydrator;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->requestBuilder = $requestBuilder ?: new RequestBuilder;
    }

    /**
     * Create tone analyzer client with username and password
     *
     * @param string $username
     * @param string $password
     *
     * @return \IBM\Watson\ToneAnalyzer\Client
     *
     * @throws \Http\Discovery\Exception\NotFoundException
     * @throws \RuntimeException
     * @throws \InvalidArgumentException
     */
    public static function create($username, $password)
    {
        $httpClient = (new Builder())
            ->withEndpoint(static::BASE_URI)
            ->withCredentials($username, $password)
            ->createConfiguredClient();

        return new self($httpClient);
    }

    /**
     * Create tone api request
     *
     * @return \IBM\Watson\ToneAnalyzer\Api\Tone
     */
    public function tone()
    {
        return new Api\Tone($this->httpClient, $this->hydrator, $this->requestBuilder);
    }

    /**
     * Create tone chat api request
     *
     * @return \IBM\Watson\ToneAnalyzer\Api\ToneChat
     */
    public function toneChat()
    {
        return new Api\ToneChat($this->httpClient, $this->hydrator, $this->requestBuilder);
    }
}


1		<?php
2
3		namespace IBM\Watson\ToneAnalyzer;
4
5		use Http\Client\HttpClient;
6		use Http\Discovery\HttpClientDiscovery;
7		use IBM\Watson\Common\HttpClient\Builder;
8		use IBM\Watson\Common\Hydrator\HydratorInterface;
9		use IBM\Watson\Common\Hydrator\ModelHydrator;
10		use IBM\Watson\Common\RequestBuilder;
11
12		final class Client
13		{
14		/**
15		* Base tone analyzer uri
16		*/
17		const BASE_URI = 'https://gateway.watsonplatform.net/tone-analyzer';
18
19		/**
20		* @var \Http\Client\HttpClient
21		*/
22		private $httpClient;
23
24		/**
25		* @var \IBM\Watson\Common\Hydrator\ModelHydrator
26		*/
27		private $hydrator;
28
29		/**
30		* @var \IBM\Watson\Common\RequestBuilder
31		*/
32		private $requestBuilder;
33
34		/**
35		* Client constructor.
36		*
37		* @param \Http\Client\HttpClient\|null $httpClient
38		* @param \IBM\Watson\Common\Hydrator\HydratorInterface\|null $hydrator
39		* @param \IBM\Watson\Common\RequestBuilder\|null $requestBuilder
40		*
41		* @throws \Http\Discovery\Exception\NotFoundException
42		*/
43	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2017-10-06 12:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		HttpClient $httpClient = null,
45		HydratorInterface $hydrator = null,
46		RequestBuilder $requestBuilder = null
47		) {
48		$this->httpClient = $httpClient ?: HttpClientDiscovery::find();
49		$this->hydrator = $hydrator ?: new ModelHydrator;
		0 ignored issues – show Documentation Bug introduced 2017-10-03 20:38 UTC by Report Bug Copy Issue Report `$hydrator ?: new \IBM\Wa...ydrator\ModelHydrator()` is of type `object<IBM\Watson\Common...ator\HydratorInterface>`, but the property `$hydrator` was declared to be of type `object<IBM\Watson\Common\Hydrator\ModelHydrator>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
50		$this->requestBuilder = $requestBuilder ?: new RequestBuilder;
51		}
52
53		/**
54		* Create tone analyzer client with username and password
55		*
56		* @param string $username
57		* @param string $password
58		*
59		* @return \IBM\Watson\ToneAnalyzer\Client
60		*
61		* @throws \Http\Discovery\Exception\NotFoundException
62		* @throws \RuntimeException
63		* @throws \InvalidArgumentException
64		*/
65		public static function create($username, $password)
66		{
67		$httpClient = (new Builder())
68		->withEndpoint(static::BASE_URI)
69		->withCredentials($username, $password)
70		->createConfiguredClient();
71
72		return new self($httpClient);
73		}
74
75		/**
76		* Create tone api request
77		*
78		* @return \IBM\Watson\ToneAnalyzer\Api\Tone
79		*/
80		public function tone()
81		{
82		return new Api\Tone($this->httpClient, $this->hydrator, $this->requestBuilder);
83		}
84
85		/**
86		* Create tone chat api request
87		*
88		* @return \IBM\Watson\ToneAnalyzer\Api\ToneChat
89		*/
90		public function toneChat()
91		{
92		return new Api\ToneChat($this->httpClient, $this->hydrator, $this->requestBuilder);
93		}
94		}
95

adam-paterson / ibm-watson-sdk

Push — develop ( bc21b0...0bdfd4 )

Client::toneChat() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like