Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | final class Client |
||
13 | { |
||
14 | /** |
||
15 | * Base tone analyzer uri |
||
16 | */ |
||
17 | const BASE_URI = 'https://gateway.watsonplatform.net/tone-analyzer'; |
||
18 | |||
19 | /** |
||
20 | * @var \Http\Client\HttpClient |
||
21 | */ |
||
22 | private $httpClient; |
||
23 | |||
24 | /** |
||
25 | * @var \IBM\Watson\Common\Hydrator\ModelHydrator |
||
26 | */ |
||
27 | private $hydrator; |
||
28 | |||
29 | /** |
||
30 | * @var \IBM\Watson\Common\RequestBuilder |
||
31 | */ |
||
32 | private $requestBuilder; |
||
33 | |||
34 | /** |
||
35 | * Client constructor. |
||
36 | * |
||
37 | * @param \Http\Client\HttpClient|null $httpClient |
||
38 | * @param \IBM\Watson\Common\Hydrator\HydratorInterface|null $hydrator |
||
39 | * @param \IBM\Watson\Common\RequestBuilder|null $requestBuilder |
||
40 | * |
||
41 | * @throws \Http\Discovery\Exception\NotFoundException |
||
42 | */ |
||
43 | View Code Duplication | public function __construct( |
|
|
|||
44 | HttpClient $httpClient = null, |
||
45 | HydratorInterface $hydrator = null, |
||
46 | RequestBuilder $requestBuilder = null |
||
47 | ) { |
||
48 | $this->httpClient = $httpClient ?: HttpClientDiscovery::find(); |
||
49 | $this->hydrator = $hydrator ?: new ModelHydrator; |
||
50 | $this->requestBuilder = $requestBuilder ?: new RequestBuilder; |
||
51 | } |
||
52 | |||
53 | /** |
||
54 | * Create tone analyzer client with username and password |
||
55 | * |
||
56 | * @param string $username |
||
57 | * @param string $password |
||
58 | * |
||
59 | * @return \IBM\Watson\ToneAnalyzer\Client |
||
60 | * |
||
61 | * @throws \Http\Discovery\Exception\NotFoundException |
||
62 | * @throws \RuntimeException |
||
63 | * @throws \InvalidArgumentException |
||
64 | */ |
||
65 | public static function create($username, $password) |
||
74 | |||
75 | /** |
||
76 | * Create tone api request |
||
77 | * |
||
78 | * @return \IBM\Watson\ToneAnalyzer\Api\Tone |
||
79 | */ |
||
80 | public function tone() |
||
84 | |||
85 | /** |
||
86 | * Create tone chat api request |
||
87 | * |
||
88 | * @return \IBM\Watson\ToneAnalyzer\Api\ToneChat |
||
89 | */ |
||
90 | public function toneChat() |
||
94 | } |
||
95 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.