AbstractStore::decorate() - Code Metrics - Inspection of "Decorator logic" - acredula/percy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6c04ca...a08b36 )

by Phil

created 2015-12-10 11:26 UTC

AbstractStore::decorate() A

↳ Parent: AbstractStore

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
ccs	0
cts	6
cp	0
rs	9.4286
cc	2
eloc	3
nc	2
nop	2
crap	6

<?php

namespace Percy\Store;

use InvalidArgumentException;
use Percy\Decorator\DecoratorInterface;
use Percy\Entity\Collection;
use Percy\Entity\EntityInterface;

abstract class AbstractStore implements StoreInterface
{
    /**
     * Iterate collection and apply decorators based on action.
     *
     * @param \Percy\Entity\Collection $collection
     * @param integer                  $action
     *
     * @return boolean
     */
    protected function decorate(Collection $collection, $action)

    {
        foreach ($collection->getIterator() as $entity) {
            array_walk($entity->getDecorators($type), [$this, 'invokeDecorators'], [$entity]);

        }
    }

    /**
     * Invoke callable decorator on entity.
     *
     * @param string                        $decorator
     * @param array                         $properties
     * @param \Percy\Entity\EntityInterface $entity
     *
     * @return void
     */
    protected function invokeDecorators($decorator, array $properties, EntityInterface $entity)
    {
        $decorator = new $decorator;

        if (! $decorator instanceof DecoratorInterface) {
            throw new InvalidArgumentException(
                sprintf('(%s) must be an instance of (Percy\Decorator\DecoratorInterface)', get_class($decorator))
            );
        }

        $decorator($entity, $properties);
    }

    /**
     * Iterate collection and validate data.
     *
     * @param \Percy\EntityCollection $collection
     *
     * @return boolean
     */
    public function validate(Collection $collection)

    {

    }
}


1			<?php
2
3			namespace Percy\Store;
4
5			use InvalidArgumentException;
6			use Percy\Decorator\DecoratorInterface;
7			use Percy\Entity\Collection;
8			use Percy\Entity\EntityInterface;
9
10			abstract class AbstractStore implements StoreInterface
11			{
12			/**
13			* Iterate collection and apply decorators based on action.
14			*
15			* @param \Percy\Entity\Collection $collection
16			* @param integer $action
17			*
18			* @return boolean
19			*/
20			protected function decorate(Collection $collection, $action)
			0 ignored issues – show Unused Code introduced 2015-12-10 11:34 UTC by Report Bug Copy Issue Report The parameter `$action` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
21			{
22			foreach ($collection->getIterator() as $entity) {
23			array_walk($entity->getDecorators($type), [$this, 'invokeDecorators'], [$entity]);
			0 ignored issues – show Bug introduced 2015-12-10 11:34 UTC by Report Bug Copy Issue Report `$entity->getDecorators($type)` cannot be passed to `array_walk()` as the parameter `$array` expects a reference. Loading history... Bug introduced 2015-12-10 11:34 UTC by Report Bug Copy Issue Report The variable `$type` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
24			}
25			}
26
27			/**
28			* Invoke callable decorator on entity.
29			*
30			* @param string $decorator
31			* @param array $properties
32			* @param \Percy\Entity\EntityInterface $entity
33			*
34			* @return void
35			*/
36			protected function invokeDecorators($decorator, array $properties, EntityInterface $entity)
37			{
38			$decorator = new $decorator;
39
40			if (! $decorator instanceof DecoratorInterface) {
41			throw new InvalidArgumentException(
42			sprintf('(%s) must be an instance of (Percy\Decorator\DecoratorInterface)', get_class($decorator))
43			);
44			}
45
46			$decorator($entity, $properties);
47			}
48
49			/**
50			* Iterate collection and validate data.
51			*
52			* @param \Percy\EntityCollection $collection
53			*
54			* @return boolean
55			*/
56			public function validate(Collection $collection)
			0 ignored issues – show Unused Code introduced 2015-12-10 11:34 UTC by Report Bug Copy Issue Report The parameter `$collection` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
57			{
58
59			}
60			}
61

acredula / percy

Push — master ( 6c04ca...a08b36 )

AbstractStore::decorate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like