Percy\Store\AbstractStore

Complexity

Total Complexity

5

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	decorate()	0	6	2
A	invokeDecorators()	0	12	2
A	validate()	0	4	1

<?php

namespace Percy\Store;

use InvalidArgumentException;
use Percy\Decorator\DecoratorInterface;
use Percy\Entity\Collection;
use Percy\Entity\EntityInterface;

abstract class AbstractStore implements StoreInterface
{
    /**
     * Iterate collection and apply decorators based on action.
     *
     * @param \Percy\Entity\Collection $collection
     * @param integer                  $action
     *
     * @return boolean
     */
    protected function decorate(Collection $collection, $action)

The parameter $action is not used and could be removed.

    {
        foreach ($collection->getIterator() as $entity) {
            array_walk($entity->getDecorators($type), [$this, 'invokeDecorators'], [$entity]);

$entity->getDecorators($type) cannot be passed to array_walk() as the parameter $array expects a reference.

The variable $type does not exist. Did you forget to declare it?

        }
    }

    /**
     * Invoke callable decorator on entity.
     *
     * @param string                        $decorator
     * @param array                         $properties
     * @param \Percy\Entity\EntityInterface $entity
     *
     * @return void
     */
    protected function invokeDecorators($decorator, array $properties, EntityInterface $entity)
    {
        $decorator = new $decorator;

        if (! $decorator instanceof DecoratorInterface) {
            throw new InvalidArgumentException(
                sprintf('(%s) must be an instance of (Percy\Decorator\DecoratorInterface)', get_class($decorator))
            );
        }

        $decorator($entity, $properties);
    }

    /**
     * Iterate collection and validate data.
     *
     * @param \Percy\EntityCollection $collection
     *
     * @return boolean
     */
    public function validate(Collection $collection)

The parameter $collection is not used and could be removed.

    {

    }
}