UndoContext::runAll() - Code Metrics - Inspection of "Updated layout saving behaviour in PanelsInPlaceCo..." - acquia/df - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 8.x-2.x ( bdb6af...21ed67 )

by Devin

created 2017-03-16 06:45 UTC

UndoContext::runAll() A

↳ Parent: UndoContext

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	6
nc	2
nop	0
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0

<?php

namespace Acquia\DFExtension\Context;

use Drupal\DrupalExtension\Context\DrupalSubContextBase;

/**
 * A context allowing easy undo of anything done during a scenario.
 */
class UndoContext extends DrupalSubContextBase {

  /**
   * Whether the stack is locked (i.e., not accepting new operations).
   *
   * @var bool
   */
  protected $locked = FALSE;

  /**
   * The operation stack.
   *
   * @var array
   */
  protected $stack = [];

  /**
   * Executes all undo operations in the stack.
   *
   * @AfterScenario
   */
  public function runAll() {
    $this->locked = TRUE;

    while ($this->stack) {

      $operation = array_pop($this->stack);
      call_user_func_array($operation[0], $operation[1]);
    }

    $this->locked = FALSE;
  }

  /**
   * Adds an operation to the undo stack.
   *
   * @param callable $callback
   *   The function to call.
   * @param array $arguments
   *   (optional) Arguments to pass to the callback. None of the arguments can
   *   be passed by reference.
   */
  public function push(callable $callback, array $arguments = []) {

    if ($this->locked == FALSE) {

      $this->stack[] = func_get_args();
    }
  }

}


1			<?php
2
3			namespace Acquia\DFExtension\Context;
4
5			use Drupal\DrupalExtension\Context\DrupalSubContextBase;
6
7			/**
8			* A context allowing easy undo of anything done during a scenario.
9			*/
10			class UndoContext extends DrupalSubContextBase {
11
12			/**
13			* Whether the stack is locked (i.e., not accepting new operations).
14			*
15			* @var bool
16			*/
17			protected $locked = FALSE;
18
19			/**
20			* The operation stack.
21			*
22			* @var array
23			*/
24			protected $stack = [];
25
26			/**
27			* Executes all undo operations in the stack.
28			*
29			* @AfterScenario
30			*/
31			public function runAll() {
32			$this->locked = TRUE;
33
34			while ($this->stack) {
			0 ignored issues – show Bug Best Practice introduced 2017-03-16 07:41 UTC by Report Bug Copy Issue Report The expression `$this->stack` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
35			$operation = array_pop($this->stack);
36			call_user_func_array($operation[0], $operation[1]);
37			}
38
39			$this->locked = FALSE;
40			}
41
42			/**
43			* Adds an operation to the undo stack.
44			*
45			* @param callable $callback
46			* The function to call.
47			* @param array $arguments
48			* (optional) Arguments to pass to the callback. None of the arguments can
49			* be passed by reference.
50			*/
51			public function push(callable $callback, array $arguments = []) {
			0 ignored issues – show Unused Code introduced 2017-03-16 07:41 UTC by Report Bug Copy Issue Report The parameter `$callback` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-03-16 07:41 UTC by Report Bug Copy Issue Report The parameter `$arguments` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
52			if ($this->locked == FALSE) {
			0 ignored issues – show Coding Style Best Practice introduced 2017-03-16 07:41 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
53			$this->stack[] = func_get_args();
54			}
55			}
56
57			}
58

acquia / df

GitHub Access Token became invalid

Push — 8.x-2.x ( bdb6af...21ed67 )

UndoContext::runAll() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like