Acquia\DFExtension\Context\UndoContext

Complexity

Total Complexity

4

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	runAll()	0	10	2
A	push()	0	5	2

<?php

namespace Acquia\DFExtension\Context;

use Drupal\DrupalExtension\Context\DrupalSubContextBase;

/**
 * A context allowing easy undo of anything done during a scenario.
 */
class UndoContext extends DrupalSubContextBase {

  /**
   * Whether the stack is locked (i.e., not accepting new operations).
   *
   * @var bool
   */
  protected $locked = FALSE;

  /**
   * The operation stack.
   *
   * @var array
   */
  protected $stack = [];

  /**
   * Executes all undo operations in the stack.
   *
   * @AfterScenario
   */
  public function runAll() {
    $this->locked = TRUE;

    while ($this->stack) {

The expression $this->stack of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

      $operation = array_pop($this->stack);
      call_user_func_array($operation[0], $operation[1]);
    }

    $this->locked = FALSE;
  }

  /**
   * Adds an operation to the undo stack.
   *
   * @param callable $callback
   *   The function to call.
   * @param array $arguments
   *   (optional) Arguments to pass to the callback. None of the arguments can
   *   be passed by reference.
   */
  public function push(callable $callback, array $arguments = []) {

The parameter $callback is not used and could be removed.

The parameter $arguments is not used and could be removed.

    if ($this->locked == FALSE) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

      $this->stack[] = func_get_args();
    }
  }

}