ackintosh / snidel

src/Snidel/Log.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
                 $type,
                 $pid,
                 ($this->ownerPid === $pid) ? 'p' : 'c',
-                $message . PHP_EOL
+                $message.PHP_EOL
             )
         );
     }

Switch Indentation +9 added lines, -9 removed lines

@@ -50,15 +50,15 @@
         }
         $pid = getmypid();
         switch (true) {
-        case $this->ownerPid === $pid:
-            $role = 'owner';
-            break;
-        case $this->masterPid === $pid:
-            $role = 'master';
-            break;
-        default:
-            $role = 'worker';
-            break;
+            case $this->ownerPid === $pid:
+                $role = 'owner';
+                break;
+            case $this->masterPid === $pid:
+                $role = 'master';
+                break;
+            default:
+                $role = 'worker';
+                break;
         }
         fputs(
             $this->destination,

src/Snidel/Token.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
     {
         $this->ownerPid = $ownerPid;
         $this->concurrency = $concurrency;
-        $this->ipcKey = new IpcKey($ownerPid, 'snidel_token_' . uniqid((string) mt_rand(1, 100), true));
+        $this->ipcKey = new IpcKey($ownerPid, 'snidel_token_'.uniqid((string) mt_rand(1, 100), true));
         $this->id = msg_get_queue($this->ipcKey->generate());
         $this->initializeQueue();
     }

src/Snidel/MapContainer.php

Spacing +1 added lines, -1 removed lines

@@ -137,6 +137,6 @@
             return $index;
         }
 
-        throw new MapContainerException('childPid not found. pid: ' . $childPid);
+        throw new MapContainerException('childPid not found. pid: '.$childPid);
     }
 }

src/Snidel/IpcKey.php

Spacing +3 added lines, -3 removed lines

@@ -26,7 +26,7 @@ 
      */
     public function generate()
     {
-        $pathname = '/tmp/' . $this->prefix . $this->ownerPid;
+        $pathname = '/tmp/'.$this->prefix.$this->ownerPid;
         if (!file_exists($pathname)) {
             touch($pathname);
         }
@@ -52,8 +52,8 @@ 
      */
     public function delete()
     {
-        if (file_exists('/tmp/' . $this->prefix . $this->ownerPid)) {
-            unlink('/tmp/' . $this->prefix . $this->ownerPid);
+        if (file_exists('/tmp/'.$this->prefix.$this->ownerPid)) {
+            unlink('/tmp/'.$this->prefix.$this->ownerPid);
         }
     }
 }

src/Snidel/Task/Task.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace Ackintosh\Snidel\Task;
 
 use Ackintosh\Snidel\Task\TaskInterface;
-use Ackintosh\Snidel\Task\MinifiedTask;
 
 class Task implements TaskInterface
 {

Doc Comments +2 added lines, -3 removed lines

@@ -19,7 +19,6 @@ 
     /**
      * @param   callable    $callable
      * @param   array       $args
-     * @param   string      $string
      */
     public function __construct($callable, $args, $tag)
     {
@@ -45,7 +44,7 @@ 
     }
 
     /**
-     * @return  string|null
+     * @return  string
      */
     public function getTag()
     {
@@ -53,7 +52,7 @@ 
     }
 
     /**
-     * @return  Ackintosh\Snidel\Result\Result
+     * @return  Result
      */
     public function execute()
     {

src/Snidel/ForkContainer.php

Doc Comments +8 added lines, -3 removed lines

@@ -54,6 +54,7 @@ 
 
     /**
      * @param   int     $ownerPid
+     * @param Log $log
      */
     public function __construct($ownerPid, $log, $concurrency = 5)
     {
@@ -69,6 +70,7 @@ 
 
     /**
      * @param   \Ackintosh\Snidel\Task
+     * @param Task\Task $task
      * @return  void
      * @throws  \RuntimeException
      */
@@ -303,7 +305,7 @@ 
     }
 
     /**
-     * @return  array
+     * @return  integer[]
      */
     public function getChildPids()
     {
@@ -314,13 +316,16 @@ 
      * return fork
      *
      * @param   int     $pid
-     * @return  \Ackintosh\Snidel\Fork
+     * @return  Result
      */
     public function get($pid)
     {
         return $this->results[$pid];
     }
 
+    /**
+     * @param string $tag
+     */
     public function getCollection($tag = null)
     {
         if ($tag === null) {
@@ -363,7 +368,7 @@ 
     }
 
     /**
-     * @return  \Ackintosh\Sniden\Error
+     * @return  Error
      */
     public function getError()
     {

Spacing +6 added lines, -6 removed lines

@@ -139,7 +139,7 @@ 
 
         if ($pid) {
             // owner
-            $this->log->info('pid: ' . getmypid());
+            $this->log->info('pid: '.getmypid());
 
             return $this->masterPid;
         } elseif ($pid === -1) {
@@ -147,7 +147,7 @@ 
         } else {
             // master
             $taskQueue = new TaskQueue($this->ownerPid);
-            $this->log->info('pid: ' . $this->masterPid);
+            $this->log->info('pid: '.$this->masterPid);
 
             foreach ($this->signals as $sig) {
                 $this->pcntl->signal($sig, SIG_DFL, true);
@@ -155,7 +155,7 @@ 
             $workerCount = 0;
 
             while ($task = $taskQueue->dequeue()) {
-                $this->log->info('dequeued task #' . $taskQueue->dequeuedCount());
+                $this->log->info('dequeued task #'.$taskQueue->dequeuedCount());
                 if ($workerCount >= $this->concurrency) {
                     $status = null;
                     $this->pcntl->waitpid(-1, $status);
@@ -186,10 +186,10 @@ 
 
         if (getmypid() === $this->masterPid) {
             // master
-            $this->log->info('forked worker. pid: ' . $fork->getPid());
+            $this->log->info('forked worker. pid: '.$fork->getPid());
         } else {
             // worker
-            $this->log->info('has forked. pid: ' . getmypid());
+            $this->log->info('has forked. pid: '.getmypid());
             // @codeCoverageIgnoreStart
 
             foreach ($this->signals as $sig) {
@@ -198,7 +198,7 @@ 
 
             $resultQueue = new ResultQueue($this->ownerPid);
             $resultHasQueued = false;
-            register_shutdown_function(function () use (&$resultHasQueued, $fork, $task, $resultQueue) {
+            register_shutdown_function(function() use (&$resultHasQueued, $fork, $task, $resultQueue) {
                 if (!$resultHasQueued) {
                     $result = new Result();
                     $result->setFailure();

src/Snidel/Result/Collection.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     public function toArray()
     {
         return array_map(
-            function ($result) {
+            function($result) {
                 return $result->getReturn();
             },
             $this->results

src/Snidel.php

Doc Comments +2 added lines, -1 removed lines

@@ -126,7 +126,7 @@ 
      * @param   mixed                       $args
      * @param   string                      $tag
      * @param   \Ackintosh\Snidel\Token     $token
-     * @return  void
+     * @return  null|integer
      * @throws  \RuntimeException
      */
     private function forkChild(Token $token, $callable, $args = array(), $tag = null)
@@ -313,6 +313,7 @@ 
      * fork the first processing of the map container
      *
      * @param   \Ackintosh\Snidel\MapContainer
+     * @param Token $token
      * @return  void
      * @throws  \RuntimeException
      */

Spacing +9 added lines, -9 removed lines

@@ -64,8 +64,8 @@ 
         foreach ($this->signals as $sig) {
             $this->pcntl->signal(
                 $sig,
-                function ($sig) use($log, $self) {
-                    $log->info('received signal. signo: ' . $sig);
+                function($sig) use($log, $self) {
+                    $log->info('received signal. signo: '.$sig);
                     $self->setReceivedSignal($sig);
 
                     $log->info('--> sending a signal to children.');
@@ -77,7 +77,7 @@ 
             );
         }
 
-        $this->log->info('parent pid: ' . $this->ownerPid);
+        $this->log->info('parent pid: '.$this->ownerPid);
     }
 
     /**
@@ -115,7 +115,7 @@ 
             throw $e;
         }
 
-        $this->log->info('queued task #' . $this->forkContainer->queuedCount());
+        $this->log->info('queued task #'.$this->forkContainer->queuedCount());
     }
 
     /**
@@ -142,7 +142,7 @@ 
 
         if (getmypid() === $this->ownerPid) {
             // parent
-            $this->log->info('created child process. pid: ' . $fork->getPid());
+            $this->log->info('created child process. pid: '.$fork->getPid());
         } else {
             // @codeCoverageIgnoreStart
             // child
@@ -155,7 +155,7 @@ 
              */
             $log = $this->log;
             $resultHasWritten = false;
-            register_shutdown_function(function () use (&$resultHasWritten, $fork, $task, $log, $token) {
+            register_shutdown_function(function() use (&$resultHasWritten, $fork, $task, $log, $token) {
                 if (!$resultHasWritten) {
                     $dataRepository = new DataRepository();
                     $data = $dataRepository->load(getmypid());
@@ -237,7 +237,7 @@ 
             $this->wait();
         }
         if ($tag !== null && !$this->forkContainer->hasTag($tag)) {
-            throw new \InvalidArgumentException('unknown tag: ' . $tag);
+            throw new \InvalidArgumentException('unknown tag: '.$tag);
         }
 
         return $this->forkContainer->getCollection($tag);
@@ -252,7 +252,7 @@ 
     public function sendSignalToChildren($sig)
     {
         foreach ($this->forkContainer->getChildPids() as $pid) {
-            $this->log->info('----> sending a signal to child. pid: ' . $pid);
+            $this->log->info('----> sending a signal to child. pid: '.$pid);
             posix_kill($pid, $sig);
         }
     }
@@ -353,7 +353,7 @@ 
 
             $childPid = $result->getFork()->getPid();
             if ($result->isFailure()) {
-                $message = 'an error has occurred in child process. pid: ' . $childPid;
+                $message = 'an error has occurred in child process. pid: '.$childPid;
                 $this->log->error($message);
                 throw new \RuntimeException($message);
             }