ackintosh / snidel

src/Snidel.php

Doc Comments +1 added lines, -1 removed lines

@@ -255,7 +255,7 @@
      * @param   mixed                       $args
      * @param   string                      $tag
      * @param   \Ackintosh\Snidel\Token     $token
-     * @return  void
+     * @return  integer
      * @throws  \RuntimeException
      */
     public function forkSimply($callable, $args = array(), $tag = null, Token $token = null)

Spacing +18 added lines, -18 removed lines

@@ -91,8 +91,8 @@ 
         foreach ($this->signals as $sig) {
             $this->pcntl->signal(
                 $sig,
-                function ($sig) {
-                    $this->log->info('received signal. signo: ' . $sig);
+                function($sig) {
+                    $this->log->info('received signal. signo: '.$sig);
                     $this->receivedSignal = $sig;
 
                     $this->log->info('--> sending a signal to children.');
@@ -108,7 +108,7 @@ 
             );
         }
 
-        $this->log->info('parent pid: ' . $this->ownerPid);
+        $this->log->info('parent pid: '.$this->ownerPid);
     }
 
     /**
@@ -148,7 +148,7 @@ 
             throw $e;
         }
 
-        $this->log->info('queued task #' . $this->taskQueue->queuedCount());
+        $this->log->info('queued task #'.$this->taskQueue->queuedCount());
     }
 
     /**
@@ -164,17 +164,17 @@ 
 
         if ($pid) {
             // owner
-            $this->log->info('pid: ' . getmypid());
+            $this->log->info('pid: '.getmypid());
         } elseif ($pid === -1) {
             // error
         } else {
             // master
-            $this->log->info('pid: ' . $this->masterProcessId);
+            $this->log->info('pid: '.$this->masterProcessId);
             foreach ($this->signals as $sig) {
                 $this->pcntl->signal($sig, SIG_DFL, true);
             }
             while ($task = $this->taskQueue->dequeue()) {
-                $this->log->info('dequeued task #' . $this->taskQueue->dequeuedCount());
+                $this->log->info('dequeued task #'.$this->taskQueue->dequeuedCount());
                 if ($this->token->accept()) {
                     $this->forkWorker($task['callable'], $task['args'], $task['tag']);
                 }
@@ -211,17 +211,17 @@ 
 
         if (getmypid() === $this->masterProcessId) {
             // master
-            $this->log->info('forked worker. pid: ' . $fork->getPid());
+            $this->log->info('forked worker. pid: '.$fork->getPid());
         } else {
             // worker
-            $this->log->info('has forked. pid: ' . getmypid());
+            $this->log->info('has forked. pid: '.getmypid());
             // @codeCoverageIgnoreStart
             foreach ($this->signals as $sig) {
                 $this->pcntl->signal($sig, SIG_DFL, true);
             }
 
             $resultHasQueued = false;
-            register_shutdown_function(function () use ($fork, &$resultHasQueued) {
+            register_shutdown_function(function() use ($fork, &$resultHasQueued) {
                 if ($fork->hasNoResult() || $resultHasQueued === false) {
                     $result = new Result();
                     $result->setFailure();
@@ -277,7 +277,7 @@ 
 
         if (getmypid() === $this->ownerPid) {
             // parent
-            $this->log->info('created child process. pid: ' . $fork->getPid());
+            $this->log->info('created child process. pid: '.$fork->getPid());
             $this->childPids[] = $fork->getPid();
         } else {
             // @codeCoverageIgnoreStart
@@ -293,7 +293,7 @@ 
             $dataRepository     = $this->dataRepository;
             $log                = $this->log;
             $processToken       = $this->processToken;
-            register_shutdown_function(function () use ($result, $dataRepository, $log, $processToken) {
+            register_shutdown_function(function() use ($result, $dataRepository, $log, $processToken) {
                 $data = $dataRepository->load(getmypid());
                 try {
                     $data->write($result);
@@ -344,7 +344,7 @@ 
             $childPid   = $fork->getPid();
             $result     = $fork->getResult();
             if ($fork->hasNotFinishedSuccessfully()) {
-                $message = 'an error has occurred in child process. pid: ' . $childPid;
+                $message = 'an error has occurred in child process. pid: '.$childPid;
                 $this->log->error($message);
                 $this->error[$childPid] = array(
                     'status'    => $fork->getStatus(),
@@ -411,7 +411,7 @@ 
         }
 
         if (!$this->forkContainer->hasTag($tag)) {
-            throw new \InvalidArgumentException('unknown tag: ' . $tag);
+            throw new \InvalidArgumentException('unknown tag: '.$tag);
         }
 
         return $this->forkContainer->getCollection($tag);
@@ -438,12 +438,12 @@ 
             return new ForkCollection($this->forks);
         }
 
-        $filtered = array_filter($this->forks, function ($fork) use ($tag) {
+        $filtered = array_filter($this->forks, function($fork) use ($tag) {
             return $fork->getTag() === $tag;
         });
 
         if (count($filtered) === 0) {
-            throw new \InvalidArgumentException('unknown tag: ' . $tag);
+            throw new \InvalidArgumentException('unknown tag: '.$tag);
         }
 
         return new ForkCollection($filtered);
@@ -458,7 +458,7 @@ 
     private function sendSignalToChildren($sig)
     {
         foreach ($this->childPids as $pid) {
-            $this->log->info('----> sending a signal to child. pid: ' . $pid);
+            $this->log->info('----> sending a signal to child. pid: '.$pid);
             posix_kill($pid, $sig);
         }
     }
@@ -555,7 +555,7 @@ 
 
             $childPid = $fork->getPid();
             if ($fork->hasNotFinishedSuccessfully()) {
-                $message = 'an error has occurred in child process. pid: ' . $childPid;
+                $message = 'an error has occurred in child process. pid: '.$childPid;
                 $this->log->error($message);
                 throw new \RuntimeException($message);
             }

src/Snidel/ResultQueue.php

Doc Comments +3 added lines

@@ -11,6 +11,9 @@
 
     private $dequeuedCount = 0;
 
+    /**
+     * @param integer $ownerPid
+     */
     public function __construct($ownerPid)
     {
         $this->ownerPid = $ownerPid;

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace Ackintosh\Snidel;
 
 use Ackintosh\Snidel\IpcKey;
-use Opis\Closure\SerializableClosure;
 
 class ResultQueue
 {

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
     public function __construct($ownerPid)
     {
         $this->ownerPid = $ownerPid;
-        $this->ipcKey = new IpcKey($ownerPid, 'snidel_result_' . uniqid((string) mt_rand(1, 100), true));
+        $this->ipcKey = new IpcKey($ownerPid, 'snidel_result_'.uniqid((string) mt_rand(1, 100), true));
         $this->id = msg_get_queue($this->ipcKey->generate());
     }
 

src/Snidel/TaskQueue.php

Doc Comments +3 added lines

@@ -11,6 +11,9 @@
     private $queuedCount = 0;
     private $dequeuedCount = 0;
 
+    /**
+     * @param integer $ownerPid
+     */
     public function __construct($ownerPid)
     {
         $this->ownerPid = $ownerPid;

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
     public function __construct($ownerPid)
     {
         $this->ownerPid = $ownerPid;
-        $this->ipcKey = new IpcKey($ownerPid, 'snidel_task_' . uniqid((string) mt_rand(1, 100), true));
+        $this->ipcKey = new IpcKey($ownerPid, 'snidel_task_'.uniqid((string) mt_rand(1, 100), true));
         $this->id = msg_get_queue($this->ipcKey->generate());
     }
 

src/Snidel/Log.php

Switch Indentation +9 added lines, -9 removed lines

@@ -50,15 +50,15 @@
         }
         $pid = getmypid();
         switch (true) {
-        case $this->ownerPid === $pid:
-            $role = 'owner';
-            break;
-        case $this->masterPid !== null && $this->masterPid === $pid:
-            $role = 'master';
-            break;
-        default:
-            $role = 'worker';
-            break;
+            case $this->ownerPid === $pid:
+                $role = 'owner';
+                break;
+            case $this->masterPid !== null && $this->masterPid === $pid:
+                $role = 'master';
+                break;
+            default:
+                $role = 'worker';
+                break;
         }
         fputs(
             $this->destination,

src/Snidel/ForkContainer.php

Spacing +2 added lines, -2 removed lines

@@ -98,8 +98,8 @@
      */
     private function getCollectionWithTag($tag)
     {
-        $collection = array_filter($this->forks, function ($fork) use ($tag) {
-            return $fork->getTag() ===  $tag;
+        $collection = array_filter($this->forks, function($fork) use ($tag) {
+            return $fork->getTag() === $tag;
         });
 
         return new ForkCollection($collection);