ackintosh / snidel

src/Snidel/Log.php

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
      */
     private function context()
     {
-        $pid  = getmypid();
+        $pid = getmypid();
         switch ($pid) {
             case $this->ownerPid:
                 $role = 'owner';

src/Snidel/Config.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
         $this->params['id'] = spl_object_hash($this);
         if (!$this->params['driver']) {
             $this->params['driver'] = new FlatFileDriver(
-                sys_get_temp_dir() . DIRECTORY_SEPARATOR . $this->params['id']
+                sys_get_temp_dir().DIRECTORY_SEPARATOR.$this->params['id']
             );
         }
     }

src/Snidel/Fork/Coordinator.php

Doc Comments +2 added lines, -1 removed lines

@@ -57,7 +57,7 @@ 
     private $resultQueue;
 
     /**
-     * @param   int     $ownerPid
+     * @param \Ackintosh\Snidel\Log $log
      */
     public function __construct(Config $config, $log)
     {
@@ -77,6 +77,7 @@ 
 
     /**
      * @param   \Ackintosh\Snidel\Task
+     * @param \Ackintosh\Snidel\Task\Task $task
      * @return  void
      * @throws  \RuntimeException
      */

Spacing +15 added lines, -15 removed lines

@@ -115,7 +115,7 @@ 
         try {
             $this->master = $this->pcntl->fork();
         } catch (\RuntimeException $e) {
-            $message = 'failed to fork master: ' . $e->getMessage();
+            $message = 'failed to fork master: '.$e->getMessage();
             $this->log->error($message);
             throw new \RuntimeException($message);
         }
@@ -124,8 +124,8 @@ 
 
         if (getmypid() === $this->config->get('ownerPid')) {
             // owner
-            $this->log->info('pid: ' . getmypid());
-            $this->resultQueue  = $this->factory->create('result');
+            $this->log->info('pid: '.getmypid());
+            $this->resultQueue = $this->factory->create('result');
 
             return $this->master;
         } else {
@@ -133,17 +133,17 @@ 
             // covered by SnidelTest via master process
             // master
             $workerPool = new WorkerPool();
-            $this->log->info('pid: ' . $this->master->getPid());
+            $this->log->info('pid: '.$this->master->getPid());
 
             foreach ($this->signals as $sig) {
-                $this->pcntl->signal($sig, function ($sig) use ($workerPool) {
+                $this->pcntl->signal($sig, function($sig) use ($workerPool) {
                     $this->receivedSignal = $sig;
-                    $this->log->info('received signal: ' . $sig);
+                    $this->log->info('received signal: '.$sig);
 
                     if ($workerPool->count() === 0) {
                         $this->log->info('no worker is active.');
                     } else {
-                        $this->log->info('------> sending signal to workers. signal: ' . $sig);
+                        $this->log->info('------> sending signal to workers. signal: '.$sig);
                         $workerPool->terminate($sig);
                         $this->log->info('<------ sent signal');
                     }
@@ -151,7 +151,7 @@ 
                 });
             }
 
-            $concurrency = (int)$this->config->get('concurrency');
+            $concurrency = (int) $this->config->get('concurrency');
             for ($i = 0; $i < $concurrency; $i++) {
                 $workerPool->add($this->forkWorker());
             }
@@ -181,7 +181,7 @@ 
         try {
             $process = $this->pcntl->fork();
         } catch (\RuntimeException $e) {
-            $message = 'failed to fork worker: ' . $e->getMessage();
+            $message = 'failed to fork worker: '.$e->getMessage();
             $this->log->error($message);
             throw new \RuntimeException($message);
         }
@@ -190,22 +190,22 @@ 
 
         if (getmypid() === $this->master->getPid()) {
             // master
-            $this->log->info('forked worker. pid: ' . $worker->getPid());
+            $this->log->info('forked worker. pid: '.$worker->getPid());
             return $worker;
         } else {
             // @codeCoverageIgnoreStart
             // covered by SnidelTest via worker process
             // worker
-            $this->log->info('has forked. pid: ' . getmypid());
+            $this->log->info('has forked. pid: '.getmypid());
 
             foreach ($this->signals as $sig) {
-                $this->pcntl->signal($sig, function ($sig) {
+                $this->pcntl->signal($sig, function($sig) {
                     $this->receivedSignal = $sig;
                     exit;
                 }, false);
             }
 
-            register_shutdown_function(function () use ($worker) {
+            register_shutdown_function(function() use ($worker) {
                 if ($this->receivedSignal === null && $worker->isInProgress()) {
                     $worker->error();
                 }
@@ -241,14 +241,14 @@ 
      */
     public function sendSignalToMaster($sig = SIGTERM)
     {
-        $this->log->info('----> sending signal to master. signal: ' . $sig);
+        $this->log->info('----> sending signal to master. signal: '.$sig);
         posix_kill($this->master->getPid(), $sig);
         $this->log->info('<---- sent signal.');
 
         $this->log->info('----> waiting for master shutdown.');
         $status = null;
         $this->pcntl->waitpid($this->master->getPid(), $status);
-        $this->log->info('<---- master shutdown. status: ' . $status);
+        $this->log->info('<---- master shutdown. status: '.$status);
         $this->master = null;
     }
 

src/Snidel.php

Spacing +6 added lines, -6 removed lines

@@ -37,7 +37,7 @@ 
         $this->coordinator = new Coordinator($this->config, $this->log);
         $this->coordinator->forkMaster();
         $this->registerSignalHandler($this->coordinator, $this->log);
-        $this->log->info('parent pid: ' . $this->config->get('ownerPid'));
+        $this->log->info('parent pid: '.$this->config->get('ownerPid'));
     }
 
     /**
@@ -54,11 +54,11 @@ 
         try {
             $this->coordinator->enqueue(new Task($callable, $args, $tag));
         } catch (\RuntimeException $e) {
-            $this->log->error('failed to enqueue the task: ' . $e->getMessage());
+            $this->log->error('failed to enqueue the task: '.$e->getMessage());
             throw $e;
         }
 
-        $this->log->info('queued task #' . $this->coordinator->queuedCount());
+        $this->log->info('queued task #'.$this->coordinator->queuedCount());
     }
 
     /**
@@ -78,7 +78,7 @@ 
      */
     public function results()
     {
-        foreach($this->coordinator->results() as $r) {
+        foreach ($this->coordinator->results() as $r) {
             yield $r;
         }
     }
@@ -109,8 +109,8 @@ 
         foreach ($this->signals as $sig) {
             $pcntl->signal(
                 $sig,
-                function ($sig) use ($log, $coordinator) {
-                    $log->info('received signal. signo: ' . $sig);
+                function($sig) use ($log, $coordinator) {
+                    $log->info('received signal. signo: '.$sig);
                     $log->info('--> sending a signal " to children.');
                     $coordinator->sendSignalToMaster($sig);
                     $log->info('<-- signal handling has been completed successfully.');