Passed
Push — master ( 6bd029...1cf270 )
by Thomas
11:14 queued 01:09
created
app/Http/Controllers/Admin/StudentCrudController.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -91,10 +91,10 @@  discard block
 block discarded – undo
91 91
                 'attribute' => 'lastname', // foreign key attribute that is shown to user
92 92
                 'model'     => \App\Models\User::class, // foreign key model
93 93
                 'orderable' => true,
94
-                'orderLogic' => fn ($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'students.id')
94
+                'orderLogic' => fn($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'students.id')
95 95
                     ->orderBy('users.lastname', $columnDirection)->select('students.*'),
96
-                'searchLogic' => function ($query, $column, $searchTerm) {
97
-                    $query->orWhereHas('user', function ($q) use ($searchTerm) {
96
+                'searchLogic' => function($query, $column, $searchTerm) {
97
+                    $query->orWhereHas('user', function($q) use ($searchTerm) {
98 98
                         $q->where('lastname', 'like', '%'.$searchTerm.'%');
99 99
                     });
100 100
                 },
@@ -109,10 +109,10 @@  discard block
 block discarded – undo
109 109
                 'attribute' => 'firstname', // foreign key attribute that is shown to user
110 110
                 'model'     => \App\Models\User::class, // foreign key model
111 111
                 'orderable' => true,
112
-                'orderLogic' => fn ($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'students.id')
112
+                'orderLogic' => fn($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'students.id')
113 113
                     ->orderBy('users.firstname', $columnDirection)->select('students.*'),
114
-                'searchLogic' => function ($query, $column, $searchTerm) {
115
-                    $query->orWhereHas('user', function ($q) use ($searchTerm) {
114
+                'searchLogic' => function($query, $column, $searchTerm) {
115
+                    $query->orWhereHas('user', function($q) use ($searchTerm) {
116 116
                         $q->where('firstname', 'like', '%'.$searchTerm.'%');
117 117
                     });
118 118
                 },
@@ -126,10 +126,10 @@  discard block
 block discarded – undo
126 126
                 'attribute' => 'email', // foreign key attribute that is shown to user
127 127
                 'model'     => \App\Models\User::class, // foreign key model
128 128
                 'orderable' => true,
129
-                'orderLogic' => fn ($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'students.id')
129
+                'orderLogic' => fn($query, $column, $columnDirection) => $query->leftJoin('users', 'users.id', '=', 'students.id')
130 130
                     ->orderBy('users.email', $columnDirection)->select('students.*'),
131
-                'searchLogic' => function ($query, $column, $searchTerm) {
132
-                    $query->orWhereHas('user', function ($q) use ($searchTerm) {
131
+                'searchLogic' => function($query, $column, $searchTerm) {
132
+                    $query->orWhereHas('user', function($q) use ($searchTerm) {
133 133
                         $q->where('email', 'like', '%'.$searchTerm.'%');
134 134
                     });
135 135
                 },
@@ -175,25 +175,25 @@  discard block
 block discarded – undo
175 175
 
176 176
         ]);
177 177
 
178
-        CRUD::addFilter([ // select2 filter
178
+        CRUD::addFilter([// select2 filter
179 179
             'name' => 'enrolled',
180 180
             'type' => 'select2',
181 181
             'label'=> __('Is Enrolled in'),
182
-        ], fn () => Period::all()->pluck('name', 'id')->toArray(), function ($value) { // if the filter is active
183
-            $this->crud->query = $this->crud->query->whereHas('enrollments', fn ($query) => $query->whereHas('course', function ($q) use ($value) {
182
+        ], fn() => Period::all()->pluck('name', 'id')->toArray(), function($value) { // if the filter is active
183
+            $this->crud->query = $this->crud->query->whereHas('enrollments', fn($query) => $query->whereHas('course', function($q) use ($value) {
184 184
                 $q->where('period_id', $value);
185 185
             }));
186 186
         },
187
-          function () { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
187
+          function() { // if the filter is NOT active (the GET parameter "checkbox" does not exit)
188 188
           });
189 189
 
190
-        CRUD::addFilter([ // select2_multiple filter
190
+        CRUD::addFilter([// select2_multiple filter
191 191
             'name' => 'notenrolled',
192 192
             'type' => 'select2_multiple',
193 193
             'label'=> __('Is Not Enrolled in'),
194
-        ], fn () => Period::all()->pluck('name', 'id')->toArray(), function ($values) { // if the filter is active
194
+        ], fn() => Period::all()->pluck('name', 'id')->toArray(), function($values) { // if the filter is active
195 195
             foreach (json_decode($values, null, 512, JSON_THROW_ON_ERROR) as $value) {
196
-                $this->crud->query = $this->crud->query->whereDoesntHave('enrollments', fn ($query) => $query->whereHas('course', function ($q) use ($value) {
196
+                $this->crud->query = $this->crud->query->whereDoesntHave('enrollments', fn($query) => $query->whereHas('course', function($q) use ($value) {
197 197
                     $q->where('period_id', $value);
198 198
                 }));
199 199
             }
@@ -204,8 +204,8 @@  discard block
 block discarded – undo
204 204
             'type' => 'select2',
205 205
             'label'=> __('New In'),
206 206
         ],
207
-            fn () => Period::all()->pluck('name', 'id')->toArray(),
208
-            function ($value) { // if the filter is active
207
+            fn() => Period::all()->pluck('name', 'id')->toArray(),
208
+            function($value) { // if the filter is active
209 209
                 CRUD::addClause('newInPeriod', $value);
210 210
             }
211 211
         );
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
             'name'  => 'institution_id',
216 216
             'type'  => 'select2',
217 217
             'label' => __('Institution'),
218
-        ], fn () => Institution::all()->pluck('name', 'id')->toArray(), function ($value) { // if the filter is active
218
+        ], fn() => Institution::all()->pluck('name', 'id')->toArray(), function($value) { // if the filter is active
219 219
             $this->crud->addClause('where', 'institution_id', $value);
220 220
         });
221 221
 
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
             'name'  => 'status_type_id',
224 224
             'type'  => 'select2',
225 225
             'label' => __('Lead Status'),
226
-        ], fn () => LeadType::all()->pluck('name', 'id')->toArray(), function ($value) {
226
+        ], fn() => LeadType::all()->pluck('name', 'id')->toArray(), function($value) {
227 227
             if ($value === '4') {
228 228
                 $this->crud->query = $this->crud->query->where('lead_type_id', $value)->orWhere('lead_type_id', null);
229 229
             } else {
@@ -318,8 +318,8 @@  discard block
 block discarded – undo
318 318
         $username_parts = array_filter(explode(' ', strtolower($fullName)));
319 319
         $username_parts = array_slice($username_parts, -2);
320 320
 
321
-        $part1 = (! empty($username_parts[0])) ? substr($username_parts[0], 0, 3) : '';
322
-        $part2 = (! empty($username_parts[1])) ? substr($username_parts[1], 0, 8) : '';
321
+        $part1 = (!empty($username_parts[0])) ? substr($username_parts[0], 0, 3) : '';
322
+        $part2 = (!empty($username_parts[1])) ? substr($username_parts[1], 0, 8) : '';
323 323
         $part3 = random_int(999, 9999);
324 324
 
325 325
         $username = $part1.$part2.$part3; //str_shuffle to randomly shuffle all characters
@@ -407,7 +407,7 @@  discard block
 block discarded – undo
407 407
     {
408 408
         $student = Student::findOrFail($student);
409 409
 
410
-        if (! backpack_user()->isTeacher() && ! backpack_user()->can('enrollments.view')) {
410
+        if (!backpack_user()->isTeacher() && !backpack_user()->can('enrollments.view')) {
411 411
             abort(403);
412 412
         }
413 413
 
Please login to merge, or discard this patch.