CommentController::destroy() - Code Metrics - academico-sis/academico - Measure and Improve Code Quality continuously with Scrutinizer

CommentController::destroy() A
last analyzed 2022-02-16 19:55 UTC

↳ Parent: CommentController

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	3
rs	10

<?php

namespace App\Http\Controllers;

use App\Http\Requests\CommentRequest as StoreRequest;
use App\Models\Comment;
use Illuminate\Support\Facades\Log;

class CommentController extends Controller
{
    public function __construct()
    {
        parent::__construct();
        $this->middleware('permission:comments.edit', ['only' => 'delete']);
    }

    public function store(StoreRequest $request)
    {
        Log::info('Comment created by '.backpack_user()->firstname);


        return Comment::create([
            'commentable_id' => $request->input('commentable_id'),
            'commentable_type' => $request->input('commentable_type'),
            'action' => $request->input('action') ?? 0,
            'body' => $request->input('body'),
            'author_id' => backpack_user()->id,

        ]);
    }

    public function update(Comment $comment, StoreRequest $request)
    {
        $comment->update([
            'body' => $request->input('body'),
        ]);
    }

    public function destroy(Comment $comment)
    {
        $comment->delete();
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Http\Requests\CommentRequest as StoreRequest;
6			use App\Models\Comment;
7			use Illuminate\Support\Facades\Log;
8
9			class CommentController extends Controller
10			{
11			public function __construct()
12			{
13			parent::__construct();
14			$this->middleware('permission:comments.edit', ['only' => 'delete']);
15			}
16
17			public function store(StoreRequest $request)
18			{
19			Log::info('Comment created by '.backpack_user()->firstname);
			0 ignored issues – show Bug introduced 2020-12-04 07:47 UTC by Report Bug Copy Issue Report Accessing `firstname` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
20
21			return Comment::create([
22			'commentable_id' => $request->input('commentable_id'),
23			'commentable_type' => $request->input('commentable_type'),
24			'action' => $request->input('action') ?? 0,
25			'body' => $request->input('body'),
26			'author_id' => backpack_user()->id,
			0 ignored issues – show Bug introduced 2020-12-04 07:47 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
27			]);
28			}
29
30			public function update(Comment $comment, StoreRequest $request)
31			{
32			$comment->update([
33			'body' => $request->input('body'),
34			]);
35			}
36
37			public function destroy(Comment $comment)
38			{
39			$comment->delete();
40			}
41			}
42

academico-sis / academico

CommentController::destroy() A last analyzed 2022-02-16 19:55 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CommentController::destroy() A
last analyzed 2022-02-16 19:55 UTC