App\Http\Controllers\CommentController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	store()	0	10	1
A	destroy()	0	3	1
A	update()	0	4	1
A	__construct()	0	4	1

<?php

namespace App\Http\Controllers;

use App\Http\Requests\CommentRequest as StoreRequest;
use App\Models\Comment;
use Illuminate\Support\Facades\Log;

class CommentController extends Controller
{
    public function __construct()
    {
        parent::__construct();
        $this->middleware('permission:comments.edit', ['only' => 'delete']);
    }

    public function store(StoreRequest $request)
    {
        Log::info('Comment created by '.backpack_user()->firstname);

Accessing firstname on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        return Comment::create([
            'commentable_id' => $request->input('commentable_id'),
            'commentable_type' => $request->input('commentable_type'),
            'action' => $request->input('action') ?? 0,
            'body' => $request->input('body'),
            'author_id' => backpack_user()->id,

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        ]);
    }

    public function update(Comment $comment, StoreRequest $request)
    {
        $comment->update([
            'body' => $request->input('body'),
        ]);
    }

    public function destroy(Comment $comment)
    {
        $comment->delete();
    }
}