abr4xas / php-instapago

Instapago/Api.php

Doc Comments +2 added lines, -2 removed lines

@@ -199,9 +199,9 @@
    * Realiza Transaccion
    * Efectúa y retornar una respuesta a un metodo de pago.
    *
-   * @param $url endpoint a consultar
+   * @param string $url endpoint a consultar
    * @param $fields datos para la consulta
-   * @param $method verbo http de la consulta
+   * @param string $method verbo http de la consulta
    *
    * @return $obj array resultados de la transaccion
    */

Spacing +12 added lines, -12 removed lines

@@ -47,7 +47,7 @@ 
    *                            Requeridas.
    */
   public function __construct($keyId, $publicKeyId) {
-    if ( empty($keyId) || empty($publicKeyId) ) {
+    if (empty($keyId) || empty($publicKeyId)) {
       throw new Exceptions\InstapagoException('Los parámetros "keyId" y "publicKeyId" son requeridos para procesar la petición.');
     }
     $this->publicKeyId = $publicKeyId;
@@ -94,9 +94,9 @@ 
     $type = null;
     if ($paymentType == 'direct') {
       $type = '2';
-    }else if ($paymentType == 'reserve') {
+    } else if ($paymentType == 'reserve') {
       $type = '1';
-    }else{
+    } else {
       throw new Exceptions\InstapagoException("Invalid Payment type");
     }
 
@@ -132,7 +132,7 @@ 
    * @return \ArrayObject<string, string> Respuesta de Instapago
    * @throws Exceptions\InstapagoException
    */
-  public function continuePayment($fields){
+  public function continuePayment($fields) {
     $validator = (new Validator())->release()->validate($fields);
     $fields = [
       'KeyID'        => $this->keyId, //required
@@ -217,11 +217,11 @@ 
       $args = [
         'query' => $fields
       ];
-    }else if ($method == 'POST' || $method == 'DELETE') {
+    } else if ($method == 'POST' || $method == 'DELETE') {
       $args = [
           'form_params' => $fields
       ];
-    }else{
+    } else {
       throw new Exception("Not implemented yet", 1);
     }
     
@@ -250,24 +250,24 @@ 
       throw new Exceptions\InvalidInputException(
         'Error al validar los datos enviados.'
       );
-    }else if ($code == 401) {
+    } else if ($code == 401) {
       throw new Exceptions\AuthException(
         'Error de autenticación, ha ocurrido un error'
         . ' con las llaves utilizadas.');
-    }else if ($code == 403) {
+    } else if ($code == 403) {
       throw new Exceptions\BankRejectException(
         'Pago Rechazado por el banco.'
       );
-    }else if ($code == 500) {
+    } else if ($code == 500) {
       throw new Exceptions\InstapagoException(
         'Ha Ocurrido un error interno dentro del servidor.'
       );
-    }else if ($code == 503) {
+    } else if ($code == 503) {
       throw new Exceptions\InstapagoException(
         'Ha Ocurrido un error al procesar los parámetros de entrada.'
         . ' Revise los datos enviados y vuelva a intentarlo.'
       );
-    }else if ($code == 201) {
+    } else if ($code == 201) {
       return [
         'code'         => $code,
         'msg_banco'    => $obj->message,
@@ -275,7 +275,7 @@ 
         'id_pago'      => $obj->id,
         'reference'    => $obj->reference,
       ];
-    }else {
+    } else {
       throw new \Exception('Not implemented yet');
     }
   }

Braces +10 added lines, -10 removed lines

@@ -94,9 +94,9 @@ 
     $type = null;
     if ($paymentType == 'direct') {
       $type = '2';
-    }else if ($paymentType == 'reserve') {
+    } else if ($paymentType == 'reserve') {
       $type = '1';
-    }else{
+    } else{
       throw new Exceptions\InstapagoException("Invalid Payment type");
     }
 
@@ -217,11 +217,11 @@ 
       $args = [
         'query' => $fields
       ];
-    }else if ($method == 'POST' || $method == 'DELETE') {
+    } else if ($method == 'POST' || $method == 'DELETE') {
       $args = [
           'form_params' => $fields
       ];
-    }else{
+    } else{
       throw new Exception("Not implemented yet", 1);
     }
     
@@ -250,24 +250,24 @@ 
       throw new Exceptions\InvalidInputException(
         'Error al validar los datos enviados.'
       );
-    }else if ($code == 401) {
+    } else if ($code == 401) {
       throw new Exceptions\AuthException(
         'Error de autenticación, ha ocurrido un error'
         . ' con las llaves utilizadas.');
-    }else if ($code == 403) {
+    } else if ($code == 403) {
       throw new Exceptions\BankRejectException(
         'Pago Rechazado por el banco.'
       );
-    }else if ($code == 500) {
+    } else if ($code == 500) {
       throw new Exceptions\InstapagoException(
         'Ha Ocurrido un error interno dentro del servidor.'
       );
-    }else if ($code == 503) {
+    } else if ($code == 503) {
       throw new Exceptions\InstapagoException(
         'Ha Ocurrido un error al procesar los parámetros de entrada.'
         . ' Revise los datos enviados y vuelva a intentarlo.'
       );
-    }else if ($code == 201) {
+    } else if ($code == 201) {
       return [
         'code'         => $code,
         'msg_banco'    => $obj->message,
@@ -275,7 +275,7 @@ 
         'id_pago'      => $obj->id,
         'reference'    => $obj->reference,
       ];
-    }else {
+    } else {
       throw new \Exception('Not implemented yet');
     }
   }

Indentation +120 added lines, -120 removed lines

@@ -47,11 +47,11 @@ 
    *                            Requeridas.
    */
   public function __construct($keyId, $publicKeyId) {
-    if ( empty($keyId) || empty($publicKeyId) ) {
-      throw new Exceptions\InstapagoException('Los parámetros "keyId" y "publicKeyId" son requeridos para procesar la petición.');
-    }
-    $this->publicKeyId = $publicKeyId;
-    $this->keyId = $keyId;
+	if ( empty($keyId) || empty($publicKeyId) ) {
+	  throw new Exceptions\InstapagoException('Los parámetros "keyId" y "publicKeyId" son requeridos para procesar la petición.');
+	}
+	$this->publicKeyId = $publicKeyId;
+	$this->keyId = $keyId;
   }
 
   /**
@@ -64,7 +64,7 @@ 
    */
   public function directPayment($fields)
   {
-    return $this->payment('direct', $fields);
+	return $this->payment('direct', $fields);
   }
 
   /**
@@ -77,7 +77,7 @@ 
    */
   public function reservePayment($fields)
   {
-    return $this->payment('reserve', $fields);
+	return $this->payment('reserve', $fields);
   }
 
   /**
@@ -91,35 +91,35 @@ 
    */
 
   public function payment($paymentType, $fields) {
-    $type = null;
-    if ($paymentType == 'direct') {
-      $type = '2';
-    }else if ($paymentType == 'reserve') {
-      $type = '1';
-    }else{
-      throw new Exceptions\InstapagoException("Invalid Payment type");
-    }
+	$type = null;
+	if ($paymentType == 'direct') {
+	  $type = '2';
+	}else if ($paymentType == 'reserve') {
+	  $type = '1';
+	}else{
+	  throw new Exceptions\InstapagoException("Invalid Payment type");
+	}
 
-    (new Validator())->payment()->validate($fields);
+	(new Validator())->payment()->validate($fields);
 
-    $fields = [
-      'KeyID'          => $this->keyId, 
-      'PublicKeyId'    => $this->publicKeyId, 
-      'amount'         => $fields['amount'], 
-      'description'    => $fields['description'], 
-      'cardHolder'     => $fields['card_holder'], 
-      'cardHolderId'   => $fields['card_holder_id'], 
-      'cardNumber'     => $fields['card_number'], 
-      'cvc'            => $fields['cvc'], 
-      'expirationDate' => $fields['expiration'], 
-      'statusId'       => $type, 
-      'IP'             => $fields['ip'], 
-    ];
+	$fields = [
+	  'KeyID'          => $this->keyId, 
+	  'PublicKeyId'    => $this->publicKeyId, 
+	  'amount'         => $fields['amount'], 
+	  'description'    => $fields['description'], 
+	  'cardHolder'     => $fields['card_holder'], 
+	  'cardHolderId'   => $fields['card_holder_id'], 
+	  'cardNumber'     => $fields['card_number'], 
+	  'cvc'            => $fields['cvc'], 
+	  'expirationDate' => $fields['expiration'], 
+	  'statusId'       => $type, 
+	  'IP'             => $fields['ip'], 
+	];
 
-    $obj = $this->curlTransaccion('payment', $fields, 'POST');
-    $result = $this->checkResponseCode($obj);
+	$obj = $this->curlTransaccion('payment', $fields, 'POST');
+	$result = $this->checkResponseCode($obj);
 
-    return $result;
+	return $result;
   }
 
   /**
@@ -133,17 +133,17 @@ 
    * @throws Exceptions\InstapagoException
    */
   public function continuePayment($fields){
-    (new Validator())->release()->validate($fields);
-    $fields = [
-      'KeyID'        => $this->keyId, //required
-      'PublicKeyId'  => $this->publicKeyId, //required
-      'id'           => $fields['id'], //required
-      'amount'       => $fields['amount'], //required
-    ];
+	(new Validator())->release()->validate($fields);
+	$fields = [
+	  'KeyID'        => $this->keyId, //required
+	  'PublicKeyId'  => $this->publicKeyId, //required
+	  'id'           => $fields['id'], //required
+	  'amount'       => $fields['amount'], //required
+	];
 
-    $obj = $this->curlTransaccion('complete', $fields, 'POST');
-    $result = $this->checkResponseCode($obj);
-    return $result;
+	$obj = $this->curlTransaccion('complete', $fields, 'POST');
+	$result = $this->checkResponseCode($obj);
+	return $result;
   }
 
   /**
@@ -156,19 +156,19 @@ 
    * @throws Exceptions\InstapagoException
    */
   public function query($id_pago) {
-    (new Validator())->query()->validate([
-      'id' => $id_pago
-    ]);
+	(new Validator())->query()->validate([
+	  'id' => $id_pago
+	]);
 
-    $fields = [
-      'KeyID'        => $this->keyId, //required
-      'PublicKeyId'  => $this->publicKeyId, //required
-      'id'           => $id_pago, //required
-    ];
+	$fields = [
+	  'KeyID'        => $this->keyId, //required
+	  'PublicKeyId'  => $this->publicKeyId, //required
+	  'id'           => $id_pago, //required
+	];
 
-    $obj = $this->curlTransaccion('payment', $fields, 'GET');
-    $result = $this->checkResponseCode($obj);
-    return $result;
+	$obj = $this->curlTransaccion('payment', $fields, 'GET');
+	$result = $this->checkResponseCode($obj);
+	return $result;
   }
 
   /**
@@ -180,19 +180,19 @@ 
    * @throws Exceptions\InstapagoException
    */
   public function cancel($id_pago) {
-    (new Validator())->query()->validate([
-      'id' => $id_pago
-    ]);
+	(new Validator())->query()->validate([
+	  'id' => $id_pago
+	]);
 
-    $fields = [
-      'KeyID'        => $this->keyId, //required
-      'PublicKeyId'  => $this->publicKeyId, //required
-      'id'           => $id_pago, //required
-    ];
+	$fields = [
+	  'KeyID'        => $this->keyId, //required
+	  'PublicKeyId'  => $this->publicKeyId, //required
+	  'id'           => $id_pago, //required
+	];
 
-    $obj = $this->curlTransaccion('payment', $fields, 'DELETE');
-    $result = $this->checkResponseCode($obj);
-    return $result;
+	$obj = $this->curlTransaccion('payment', $fields, 'DELETE');
+	$result = $this->checkResponseCode($obj);
+	return $result;
   }
 
   /**
@@ -207,32 +207,32 @@ 
    */
   public function curlTransaccion($url, $fields, $method)
   {
-    $client = new Client([
-       'base_uri' => 'https://api.instapago.com/',
-    ]);
+	$client = new Client([
+	   'base_uri' => 'https://api.instapago.com/',
+	]);
 
-    $args = [];
+	$args = [];
     
-    if ($method == 'GET') {
-      $args = [
-        'query' => $fields
-      ];
-    }else if ($method == 'POST' || $method == 'DELETE') {
-      $args = [
-          'form_params' => $fields
-      ];
-    }else{
-      throw new Exception("Not implemented yet", 1);
-    }
+	if ($method == 'GET') {
+	  $args = [
+		'query' => $fields
+	  ];
+	}else if ($method == 'POST' || $method == 'DELETE') {
+	  $args = [
+		  'form_params' => $fields
+	  ];
+	}else{
+	  throw new Exception("Not implemented yet", 1);
+	}
     
-    try {
-      $request = $client->request($method, $url, $args);
-      $body = $request->getBody()->getContents();
-      $obj = json_decode($body);
-      return $obj;
-    } catch (\GuzzleHttp\Exception\ConnectException $e) {
-      throw new Exceptions\TimeoutException("Cannot connect to api.instapago.com");
-    }
+	try {
+	  $request = $client->request($method, $url, $args);
+	  $body = $request->getBody()->getContents();
+	  $obj = json_decode($body);
+	  return $obj;
+	} catch (\GuzzleHttp\Exception\ConnectException $e) {
+	  throw new Exceptions\TimeoutException("Cannot connect to api.instapago.com");
+	}
   }
 
   /**
@@ -244,40 +244,40 @@ 
    */
   public function checkResponseCode($obj)
   {
-    $code = $obj->code;
+	$code = $obj->code;
 
-    if ($code == 400) {
-      throw new Exceptions\InvalidInputException(
-        'Error al validar los datos enviados.'
-      );
-    }else if ($code == 401) {
-      throw new Exceptions\AuthException(
-        'Error de autenticación, ha ocurrido un error'
-        . ' con las llaves utilizadas.');
-    }else if ($code == 403) {
-      throw new Exceptions\BankRejectException(
-        'Pago Rechazado por el banco.'
-      );
-    }else if ($code == 500) {
-      throw new Exceptions\InstapagoException(
-        'Ha Ocurrido un error interno dentro del servidor.'
-      );
-    }else if ($code == 503) {
-      throw new Exceptions\InstapagoException(
-        'Ha Ocurrido un error al procesar los parámetros de entrada.'
-        . ' Revise los datos enviados y vuelva a intentarlo.'
-      );
-    }else if ($code == 201) {
-      return [
-        'code'         => $code,
-        'msg_banco'    => $obj->message,
-        'voucher'      => html_entity_decode($obj->voucher),
-        'id_pago'      => $obj->id,
-        'reference'    => $obj->reference,
-      ];
-    }else {
-      throw new \Exception('Not implemented yet');
-    }
+	if ($code == 400) {
+	  throw new Exceptions\InvalidInputException(
+		'Error al validar los datos enviados.'
+	  );
+	}else if ($code == 401) {
+	  throw new Exceptions\AuthException(
+		'Error de autenticación, ha ocurrido un error'
+		. ' con las llaves utilizadas.');
+	}else if ($code == 403) {
+	  throw new Exceptions\BankRejectException(
+		'Pago Rechazado por el banco.'
+	  );
+	}else if ($code == 500) {
+	  throw new Exceptions\InstapagoException(
+		'Ha Ocurrido un error interno dentro del servidor.'
+	  );
+	}else if ($code == 503) {
+	  throw new Exceptions\InstapagoException(
+		'Ha Ocurrido un error al procesar los parámetros de entrada.'
+		. ' Revise los datos enviados y vuelva a intentarlo.'
+	  );
+	}else if ($code == 201) {
+	  return [
+		'code'         => $code,
+		'msg_banco'    => $obj->message,
+		'voucher'      => html_entity_decode($obj->voucher),
+		'id_pago'      => $obj->id,
+		'reference'    => $obj->reference,
+	  ];
+	}else {
+	  throw new \Exception('Not implemented yet');
+	}
   }
 
 }

Instapago/Exceptions/InvalidInputException.php

Spacing +1 added lines, -1 removed lines

@@ -31,4 +31,4 @@
 /**
  * Custom InvalidInputException.
  */
-class InvalidInputException extends \Exception{}
+class InvalidInputException extends \Exception {}

Instapago/Exceptions/ValidationException.php

Spacing +1 added lines, -1 removed lines

@@ -31,4 +31,4 @@
 /**
  * Custom ValidationException.
  */
-class ValidationException extends \Exception{}
+class ValidationException extends \Exception {}

Instapago/Exceptions/BankRejectException.php

Spacing +1 added lines, -1 removed lines

@@ -31,4 +31,4 @@
 /**
  * Custom BankRejectException.
  */
-class BankRejectException extends \Exception{}
+class BankRejectException extends \Exception {}

Instapago/Exceptions/AuthException.php

Spacing +1 added lines, -1 removed lines

@@ -31,4 +31,4 @@
 /**
  * Custom AuthException.
  */
-class AuthException extends \Exception{}
+class AuthException extends \Exception {}

Instapago/Exceptions/TimeoutException.php

Spacing +1 added lines, -1 removed lines

@@ -31,4 +31,4 @@
 /**
  * Custom TimeoutException.
  */
-class TimeoutException extends \Exception{}
+class TimeoutException extends \Exception {}

Instapago/Exceptions/InstapagoException.php

Spacing +1 added lines, -1 removed lines

@@ -31,4 +31,4 @@
 /**
  * Custom InstapagoException.
  */
-class InstapagoException extends \Exception{}
+class InstapagoException extends \Exception {}

Instapago/Validator.php

Indentation +35 added lines, -35 removed lines

@@ -38,54 +38,54 @@
   protected $validations = [];
 
   public function payment() {
-    $this->validations = [
-      'amount' => [FILTER_VALIDATE_FLOAT],
-      'description' => [FILTER_VALIDATE_REGEXP, '/^(.{0,140})$/'],
-      'card_holder' => [FILTER_VALIDATE_REGEXP, '/^([a-zA-Z\ ]+)$/'],
-      'card_holder_id' => [FILTER_VALIDATE_REGEXP, '/^(\d{5,8})$/'],
-      'card_number' => [FILTER_VALIDATE_REGEXP, '/^(\d{16})$/'],
-      'cvc' => [FILTER_VALIDATE_INT],
-      'expiration' => [FILTER_VALIDATE_REGEXP, '/^(\d{2})\/(\d{4})$/'],
-      'ip' => [FILTER_VALIDATE_IP],
-    ];
-    return $this;
+	$this->validations = [
+	  'amount' => [FILTER_VALIDATE_FLOAT],
+	  'description' => [FILTER_VALIDATE_REGEXP, '/^(.{0,140})$/'],
+	  'card_holder' => [FILTER_VALIDATE_REGEXP, '/^([a-zA-Z\ ]+)$/'],
+	  'card_holder_id' => [FILTER_VALIDATE_REGEXP, '/^(\d{5,8})$/'],
+	  'card_number' => [FILTER_VALIDATE_REGEXP, '/^(\d{16})$/'],
+	  'cvc' => [FILTER_VALIDATE_INT],
+	  'expiration' => [FILTER_VALIDATE_REGEXP, '/^(\d{2})\/(\d{4})$/'],
+	  'ip' => [FILTER_VALIDATE_IP],
+	];
+	return $this;
   }
 
   public function release(){
-    $this->validations = [
-      'amount' => [FILTER_VALIDATE_FLOAT],
-      'id' => [FILTER_VALIDATE_REGEXP, '/^([0-9a-f]{8})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{12})$/'],
-    ];
-    return $this;
+	$this->validations = [
+	  'amount' => [FILTER_VALIDATE_FLOAT],
+	  'id' => [FILTER_VALIDATE_REGEXP, '/^([0-9a-f]{8})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{12})$/'],
+	];
+	return $this;
   }
 
   public function query(){
-    $this->validations = [
-      'id' => [FILTER_VALIDATE_REGEXP, '/^([0-9a-f]{8})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{12})$/'],
-    ];
-    return $this;
+	$this->validations = [
+	  'id' => [FILTER_VALIDATE_REGEXP, '/^([0-9a-f]{8})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{12})$/'],
+	];
+	return $this;
   }
 
   public function validate($fields){
-    foreach ($this->validations as $key => $filters) {
-      if ( !$this->_validation($fields[$key], $filters) ){
-        throw new Exceptions\ValidationException("Error {$key}: {$fields[$key]}");
-      }
-    }
+	foreach ($this->validations as $key => $filters) {
+	  if ( !$this->_validation($fields[$key], $filters) ){
+		throw new Exceptions\ValidationException("Error {$key}: {$fields[$key]}");
+	  }
+	}
 
   }
 
   private function _validation ($value, $filters)
   {
-    $filter = $filters[0];
-    $flags = [];
-    if ($filter === FILTER_VALIDATE_REGEXP) {
-      $flags = [
-        "options" => [
-          "regexp"=> $filters[1],
-        ],
-      ];
-    }
-    return filter_var($value, $filter, $flags);
+	$filter = $filters[0];
+	$flags = [];
+	if ($filter === FILTER_VALIDATE_REGEXP) {
+	  $flags = [
+		"options" => [
+		  "regexp"=> $filters[1],
+		],
+	  ];
+	}
+	return filter_var($value, $filter, $flags);
   }
 }
\ No newline at end of file

Spacing +5 added lines, -5 removed lines

@@ -51,7 +51,7 @@ 
     return $this;
   }
 
-  public function release(){
+  public function release() {
     $this->validations = [
       'amount' => [FILTER_VALIDATE_FLOAT],
       'id' => [FILTER_VALIDATE_REGEXP, '/^([0-9a-f]{8})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{12})$/'],
@@ -59,23 +59,23 @@ 
     return $this;
   }
 
-  public function query(){
+  public function query() {
     $this->validations = [
       'id' => [FILTER_VALIDATE_REGEXP, '/^([0-9a-f]{8})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{12})$/'],
     ];
     return $this;
   }
 
-  public function validate($fields){
+  public function validate($fields) {
     foreach ($this->validations as $key => $filters) {
-      if ( !$this->_validation($fields[$key], $filters) ){
+      if ( ! $this->_validation($fields[$key], $filters)) {
         throw new Exceptions\ValidationException("Error {$key}: {$fields[$key]}");
       }
     }
 
   }
 
-  private function _validation ($value, $filters)
+  private function _validation($value, $filters)
   {
     $filter = $filters[0];
     $flags = [];