Inspection of "fixed encoding and latex bugs on HDU crawler." - ZsgsDesign/NOJ - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#108)

by Chenyi

created 2019-06-03 07:51 UTC

Status

Spacing +30 added lines, -30 removed lines patch added patch discarded remove patch

@@ -80,53 +80,53 @@
 block discarded – undo
 
     public function crawler($con)
     {
-        if($con == "all") {
-            return ;
+        if ($con=="all") {
+            return;
         }
-        $this->con = $con;
-        $this->imgi = 1;
-        $problemModel = new ProblemModel();
-        $res = Requests::get("http://acm.hdu.edu.cn/showproblem.php?pid={$con}");
-        if (strpos("No such problem",$res->body) !== false) {
+        $this->con=$con;
+        $this->imgi=1;
+        $problemModel=new ProblemModel();
+        $res=Requests::get("http://acm.hdu.edu.cn/showproblem.php?pid={$con}");
+        if (strpos("No such problem", $res->body)!==false) {
             header('HTTP/1.1 404 Not Found');
             die();
         }
-        else if(strpos("Invalid Parameter.",$res->body) !== false) {
+        else if (strpos("Invalid Parameter.", $res->body)!==false) {
             header('HTTP/1.1 404 Not Found');
             die();
         }
         else {
-            $res->body = iconv("gb2312","utf-8//IGNORE",$res->body);
-            $this->pro['pcode'] = "HDU".$con;
-            $this->pro['OJ'] = 8;
-            $this->pro['contest_id'] = null;
-            $this->pro['index_id'] = $con;
-            $this->pro['origin'] = "http://acm.hdu.edu.cn/showproblem.php?pid={$con}";
-            $this->pro['title'] = self::find("/<h1 style='color:#1A5CC8'>([\s\S]*?)<\/h1>/",$res->body);
-            $this->pro['time_limit'] = self::find('/Time Limit:.*\/(.*) MS/',$res->body);
-            $this->pro['memory_limit'] = self::find('/Memory Limit:.*\/(.*) K/',$res->body);
-            $this->pro['solved_count'] = self::find("/Accepted Submission(s): ([\d+]*?)/",$res->body);
+            $res->body=iconv("gb2312", "utf-8//IGNORE", $res->body);
+            $this->pro['pcode']="HDU".$con;
+            $this->pro['OJ']=8;
+            $this->pro['contest_id']=null;
+            $this->pro['index_id']=$con;
+            $this->pro['origin']="http://acm.hdu.edu.cn/showproblem.php?pid={$con}";
+            $this->pro['title']=self::find("/<h1 style='color:#1A5CC8'>([\s\S]*?)<\/h1>/", $res->body);
+            $this->pro['time_limit']=self::find('/Time Limit:.*\/(.*) MS/', $res->body);
+            $this->pro['memory_limit']=self::find('/Memory Limit:.*\/(.*) K/', $res->body);
+            $this->pro['solved_count']=self::find("/Accepted Submission(s): ([\d+]*?)/", $res->body);
             $this->pro['input_type']='standard input';
             $this->pro['output_type']='standard output';
-            $this->pro['description'] = $this->cacheImage(HtmlDomParser::str_get_html(self::find("/Problem Description.*<div class=panel_content>(.*)<\/div><div class=panel_bottom>/sU",$res->body), true, true, DEFAULT_TARGET_CHARSET, false));
+            $this->pro['description']=$this->cacheImage(HtmlDomParser::str_get_html(self::find("/Problem Description.*<div class=panel_content>(.*)<\/div><div class=panel_bottom>/sU", $res->body), true, true, DEFAULT_TARGET_CHARSET, false));
             $this->pro['description']=str_replace("$", "$$", $this->pro['description']);
-            $this->pro['input'] = self::find("/<div class=panel_title align=left>Input.*<div class=panel_content>(.*)<\/div><div class=panel_bottom>/sU",$res->body);
+            $this->pro['input']=self::find("/<div class=panel_title align=left>Input.*<div class=panel_content>(.*)<\/div><div class=panel_bottom>/sU", $res->body);
             $this->pro['input']=str_replace("$", "$$", $this->pro['input']);
-            $this->pro['output'] = self::find("/<div class=panel_title align=left>Output.*<div class=panel_content>(.*)<\/div><div class=panel_bottom>/sU",$res->body);
+            $this->pro['output']=self::find("/<div class=panel_title align=left>Output.*<div class=panel_content>(.*)<\/div><div class=panel_bottom>/sU", $res->body);
             $this->pro['output']=str_replace("$", "$$", $this->pro['output']);
-            $this->pro['sample'] = [];
-            $this->pro['sample'][] = [
-                'sample_input'=>self::find("/<pre><div.*>(.*)<\/div><\/pre>/sU",$res->body),
-                'sample_output'=>self::find("/<div.*>Sample Output<\/div><div.*><pre><div.*>(.*)<\/div><\/pre><\/div>/sU",$res->body)
+            $this->pro['sample']=[];
+            $this->pro['sample'][]=[
+                'sample_input'=>self::find("/<pre><div.*>(.*)<\/div><\/pre>/sU", $res->body),
+                'sample_output'=>self::find("/<div.*>Sample Output<\/div><div.*><pre><div.*>(.*)<\/div><\/pre><\/div>/sU", $res->body)
             ];
             // $this->pro['sample']['sample_input'] = self::find("/<pre><div.*>(.*)<\/div><\/pre>/sU",$res->body);
             // $this->pro['sample']['sample_output'] = self::find("/<div.*>Sample Output<\/div><div.*><pre><div.*>(.*)<\/div><\/pre><\/div>/sU",$res->body);
-            $this->pro['note'] = self::find("/<i>Hint<\/i><\/div>(.*)<\/div><i style='font-size:1px'>/sU",$res->body);
-            $this->pro['source'] = strip_tags(self::find("/<div class=panel_title align=left>Source<\/div> (.*)<div class=panel_bottom>/sU",$res->body));
-            if($this->pro['source'] === "") {
-                $this->pro['source'] = $this->pro['pcode'];
+            $this->pro['note']=self::find("/<i>Hint<\/i><\/div>(.*)<\/div><i style='font-size:1px'>/sU", $res->body);
+            $this->pro['source']=strip_tags(self::find("/<div class=panel_title align=left>Source<\/div> (.*)<div class=panel_bottom>/sU", $res->body));
+            if ($this->pro['source']==="") {
+                $this->pro['source']=$this->pro['pcode'];
             }
-            $this->pro['force_raw'] = 0;
+            $this->pro['force_raw']=0;
             $problem=$problemModel->pid($this->pro['pcode']);
 
             if ($problem) {

Please login to merge, or discard this patch.

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -90,12 +90,10 @@
 block discarded – undo
         if (strpos("No such problem",$res->body) !== false) {
             header('HTTP/1.1 404 Not Found');
             die();
-        }
-        else if(strpos("Invalid Parameter.",$res->body) !== false) {
+        } else if(strpos("Invalid Parameter.",$res->body) !== false) {
             header('HTTP/1.1 404 Not Found');
             die();
-        }
-        else {
+        } else {
             $res->body = iconv("gb2312","utf-8//IGNORE",$res->body);
             $this->pro['pcode'] = "HDU".$con;
             $this->pro['OJ'] = 8;

Please login to merge, or discard this patch.

		@@ -80,53 +80,53 @@
		block discarded – undo
80	80
81	81	public function crawler($con)
82	82	{
83		- if($con == "all") {
84		- return ;
	83	+ if ($con=="all") {
	84	+ return;
85	85	}
86		- $this->con = $con;
87		- $this->imgi = 1;
88		- $problemModel = new ProblemModel();
89		- $res = Requests::get("http://acm.hdu.edu.cn/showproblem.php?pid={$con}");
90		- if (strpos("No such problem",$res->body) !== false) {
	86	+ $this->con=$con;
	87	+ $this->imgi=1;
	88	+ $problemModel=new ProblemModel();
	89	+ $res=Requests::get("http://acm.hdu.edu.cn/showproblem.php?pid={$con}");
	90	+ if (strpos("No such problem", $res->body)!==false) {
91	91	header('HTTP/1.1 404 Not Found');
92	92	die();
93	93	}
94		- else if(strpos("Invalid Parameter.",$res->body) !== false) {
	94	+ else if (strpos("Invalid Parameter.", $res->body)!==false) {
95	95	header('HTTP/1.1 404 Not Found');
96	96	die();
97	97	}
98	98	else {
99		- $res->body = iconv("gb2312","utf-8//IGNORE",$res->body);
100		- $this->pro['pcode'] = "HDU".$con;
101		- $this->pro['OJ'] = 8;
102		- $this->pro['contest_id'] = null;
103		- $this->pro['index_id'] = $con;
104		- $this->pro['origin'] = "http://acm.hdu.edu.cn/showproblem.php?pid={$con}";
105		- $this->pro['title'] = self::find("/<h1 style='color:#1A5CC8'>([\s\S]*?)<\/h1>/",$res->body);
106		- $this->pro['time_limit'] = self::find('/Time Limit:.\/(.) MS/',$res->body);
107		- $this->pro['memory_limit'] = self::find('/Memory Limit:.\/(.) K/',$res->body);
108		- $this->pro['solved_count'] = self::find("/Accepted Submission(s): ([\d+]*?)/",$res->body);
	99	+ $res->body=iconv("gb2312", "utf-8//IGNORE", $res->body);
	100	+ $this->pro['pcode']="HDU".$con;
	101	+ $this->pro['OJ']=8;
	102	+ $this->pro['contest_id']=null;
	103	+ $this->pro['index_id']=$con;
	104	+ $this->pro['origin']="http://acm.hdu.edu.cn/showproblem.php?pid={$con}";
	105	+ $this->pro['title']=self::find("/<h1 style='color:#1A5CC8'>([\s\S]*?)<\/h1>/", $res->body);
	106	+ $this->pro['time_limit']=self::find('/Time Limit:.\/(.) MS/', $res->body);
	107	+ $this->pro['memory_limit']=self::find('/Memory Limit:.\/(.) K/', $res->body);
	108	+ $this->pro['solved_count']=self::find("/Accepted Submission(s): ([\d+]*?)/", $res->body);
109	109	$this->pro['input_type']='standard input';
110	110	$this->pro['output_type']='standard output';
111		- $this->pro['description'] = $this->cacheImage(HtmlDomParser::str_get_html(self::find("/Problem Description.<div class=panel_content>(.)<\/div><div class=panel_bottom>/sU",$res->body), true, true, DEFAULT_TARGET_CHARSET, false));
	111	+ $this->pro['description']=$this->cacheImage(HtmlDomParser::str_get_html(self::find("/Problem Description.<div class=panel_content>(.)<\/div><div class=panel_bottom>/sU", $res->body), true, true, DEFAULT_TARGET_CHARSET, false));
112	112	$this->pro['description']=str_replace("$", "$$", $this->pro['description']);
113		- $this->pro['input'] = self::find("/<div class=panel_title align=left>Input.<div class=panel_content>(.)<\/div><div class=panel_bottom>/sU",$res->body);
	113	+ $this->pro['input']=self::find("/<div class=panel_title align=left>Input.<div class=panel_content>(.)<\/div><div class=panel_bottom>/sU", $res->body);
114	114	$this->pro['input']=str_replace("$", "$$", $this->pro['input']);
115		- $this->pro['output'] = self::find("/<div class=panel_title align=left>Output.<div class=panel_content>(.)<\/div><div class=panel_bottom>/sU",$res->body);
	115	+ $this->pro['output']=self::find("/<div class=panel_title align=left>Output.<div class=panel_content>(.)<\/div><div class=panel_bottom>/sU", $res->body);
116	116	$this->pro['output']=str_replace("$", "$$", $this->pro['output']);
117		- $this->pro['sample'] = [];
118		- $this->pro['sample'][] = [
119		- 'sample_input'=>self::find("/<pre><div.>(.)<\/div><\/pre>/sU",$res->body),
120		- 'sample_output'=>self::find("/<div.>Sample Output<\/div><div.><pre><div.>(.)<\/div><\/pre><\/div>/sU",$res->body)
	117	+ $this->pro['sample']=[];
	118	+ $this->pro['sample'][]=[
	119	+ 'sample_input'=>self::find("/<pre><div.>(.)<\/div><\/pre>/sU", $res->body),
	120	+ 'sample_output'=>self::find("/<div.>Sample Output<\/div><div.><pre><div.>(.)<\/div><\/pre><\/div>/sU", $res->body)
121	121	];
122	122	// $this->pro['sample']['sample_input'] = self::find("/<pre><div.>(.)<\/div><\/pre>/sU",$res->body);
123	123	// $this->pro['sample']['sample_output'] = self::find("/<div.>Sample Output<\/div><div.><pre><div.>(.)<\/div><\/pre><\/div>/sU",$res->body);
124		- $this->pro['note'] = self::find("/<i>Hint<\/i><\/div>(.*)<\/div><i style='font-size:1px'>/sU",$res->body);
125		- $this->pro['source'] = strip_tags(self::find("/<div class=panel_title align=left>Source<\/div> (.*)<div class=panel_bottom>/sU",$res->body));
126		- if($this->pro['source'] === "") {
127		- $this->pro['source'] = $this->pro['pcode'];
	124	+ $this->pro['note']=self::find("/<i>Hint<\/i><\/div>(.*)<\/div><i style='font-size:1px'>/sU", $res->body);
	125	+ $this->pro['source']=strip_tags(self::find("/<div class=panel_title align=left>Source<\/div> (.*)<div class=panel_bottom>/sU", $res->body));
	126	+ if ($this->pro['source']==="") {
	127	+ $this->pro['source']=$this->pro['pcode'];
128	128	}
129		- $this->pro['force_raw'] = 0;
	129	+ $this->pro['force_raw']=0;
130	130	$problem=$problemModel->pid($this->pro['pcode']);
131	131
132	132	if ($problem) {

		@@ -90,12 +90,10 @@
		block discarded – undo
90	90	if (strpos("No such problem",$res->body) !== false) {
91	91	header('HTTP/1.1 404 Not Found');
92	92	die();
93		- }
94		- else if(strpos("Invalid Parameter.",$res->body) !== false) {
	93	+ } else if(strpos("Invalid Parameter.",$res->body) !== false) {
95	94	header('HTTP/1.1 404 Not Found');
96	95	die();
97		- }
98		- else {
	96	+ } else {
99	97	$res->body = iconv("gb2312","utf-8//IGNORE",$res->body);
100	98	$this->pro['pcode'] = "HDU".$con;
101	99	$this->pro['OJ'] = 8;

ZsgsDesign / NOJ

Pull Request — master (#108)

Status

Category

Spacing +30 added lines, -30 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch