Passed
Push — master ( b5b4bb...2b97b9 )
by John
06:29
created
app/Models/ResponseModel.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
             $statusCode=200;
15 15
         }
16 16
         $output=[
17
-             'ret' => $statusCode,
17
+                'ret' => $statusCode,
18 18
             'desc' => is_null($desc) ? self::desc($statusCode) : $desc,
19 19
             'data' => $data
20 20
         ];
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
             $statusCode=1000;
28 28
         }
29 29
         $output=[
30
-             'ret' => $statusCode,
30
+                'ret' => $statusCode,
31 31
             'desc' => is_null($desc) ? self::desc($statusCode) : $desc,
32 32
             'data' => $data
33 33
         ];
@@ -44,9 +44,9 @@  discard block
 block discarded – undo
44 44
             '451'  => "Unavailable For Legal Reasons",
45 45
 
46 46
             '1000' => "Unspecified Response", /** Under normal condictions those errors shouldn't been displayed to end users
47
-                                                 *  unless they attempt to do so, some submissions should be intercepted
48
-                                                 *  by the frontend before the request sended
49
-                                                 */
47
+             *  unless they attempt to do so, some submissions should be intercepted
48
+             *  by the frontend before the request sended
49
+             */
50 50
             '1001' => "Internal Sever Error",
51 51
             '1002' => "Service Currently Unavailable",
52 52
             '1003' => "Missing Params",
Please login to merge, or discard this patch.
app/Babel/Submit/Curl.php 1 patch
Braces   +105 added lines, -21 removed lines patch added patch discarded remove patch
@@ -18,11 +18,31 @@  discard block
 block discarded – undo
18 18
 
19 19
     public function login($all_data)
20 20
     {
21
-        if (isset($all_data["url"]))    $url=$all_data["url"]; else throw new Exception("url is not exist in all_data");
22
-        if (isset($all_data["data"]))   $data=$all_data["data"]; else throw new Exception("data is not exist in all_data");
23
-        if (isset($all_data["oj"]))     $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
24
-        if (isset($all_data["ret"]))    $ret=$all_data["ret"]; else $ret='false';
25
-        if (isset($all_data["handle"])) $handle=$all_data["handle"]; else $handle="default";
21
+        if (isset($all_data["url"])) {
22
+            $url=$all_data["url"];
23
+        } else {
24
+            throw new Exception("url is not exist in all_data");
25
+        }
26
+        if (isset($all_data["data"])) {
27
+            $data=$all_data["data"];
28
+        } else {
29
+            throw new Exception("data is not exist in all_data");
30
+        }
31
+        if (isset($all_data["oj"])) {
32
+            $oj=$all_data["oj"];
33
+        } else {
34
+            throw new Exception("oj is not exist in all_data");
35
+        }
36
+        if (isset($all_data["ret"])) {
37
+            $ret=$all_data["ret"];
38
+        } else {
39
+            $ret='false';
40
+        }
41
+        if (isset($all_data["handle"])) {
42
+            $handle=$all_data["handle"];
43
+        } else {
44
+            $handle="default";
45
+        }
26 46
 
27 47
         $datapost=curl_init();
28 48
         $headers=array("Expect:");
@@ -54,12 +74,36 @@  discard block
 block discarded – undo
54 74
 
55 75
     public function grab_page($all_data)
56 76
     {
57
-        if (isset($all_data["site"]))    $site=$all_data["site"]; else throw new Exception("site is not exist in all_data");
58
-        if (isset($all_data["oj"]))      $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
59
-        if (isset($all_data["headers"])) $headers=$all_data["headers"]; else $headers=[];
60
-        if (isset($all_data["handle"]))  $handle=$all_data["handle"]; else $handle="default";
61
-        if (isset($all_data["follow"]))  $follow=$all_data["follow"]; else $follow=false;
62
-        if (isset($all_data["vcid"]))  $vcid=$all_data["vcid"]."_"; else $vcid="";
77
+        if (isset($all_data["site"])) {
78
+            $site=$all_data["site"];
79
+        } else {
80
+            throw new Exception("site is not exist in all_data");
81
+        }
82
+        if (isset($all_data["oj"])) {
83
+            $oj=$all_data["oj"];
84
+        } else {
85
+            throw new Exception("oj is not exist in all_data");
86
+        }
87
+        if (isset($all_data["headers"])) {
88
+            $headers=$all_data["headers"];
89
+        } else {
90
+            $headers=[];
91
+        }
92
+        if (isset($all_data["handle"])) {
93
+            $handle=$all_data["handle"];
94
+        } else {
95
+            $handle="default";
96
+        }
97
+        if (isset($all_data["follow"])) {
98
+            $follow=$all_data["follow"];
99
+        } else {
100
+            $follow=false;
101
+        }
102
+        if (isset($all_data["vcid"])) {
103
+            $vcid=$all_data["vcid"]."_";
104
+        } else {
105
+            $vcid="";
106
+        }
63 107
 
64 108
         $handle=urlencode($handle);
65 109
 
@@ -86,16 +130,56 @@  discard block
 block discarded – undo
86 130
 
87 131
     public function post_data($all_data)
88 132
     {
89
-        if (isset($all_data["site"]))         $site=$all_data["site"]; else throw new Exception("site is not exist in all_data");
90
-        if (isset($all_data["data"]))         $data=$all_data["data"]; else throw new Exception("data is not exist in all_data");
91
-        if (isset($all_data["oj"]))           $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
92
-        if (isset($all_data["ret"]))          $ret=$all_data["ret"]; else $ret=false;
93
-        if (isset($all_data["follow"]))       $follow=$all_data["follow"]; else $follow=true;
94
-        if (isset($all_data["returnHeader"])) $returnHeader=$all_data["returnHeader"]; else $returnHeader=true;
95
-        if (isset($all_data["postJson"]))     $postJson=$all_data["postJson"]; else $postJson=false;
96
-        if (isset($all_data["extraHeaders"])) $extraHeaders=$all_data["extraHeaders"]; else $extraHeaders=[];
97
-        if (isset($all_data["handle"]))       $handle=$all_data["handle"]; else $handle="default";
98
-        if (isset($all_data["vcid"]))  $vcid=$all_data["vcid"]."_"; else $vcid="";
133
+        if (isset($all_data["site"])) {
134
+            $site=$all_data["site"];
135
+        } else {
136
+            throw new Exception("site is not exist in all_data");
137
+        }
138
+        if (isset($all_data["data"])) {
139
+            $data=$all_data["data"];
140
+        } else {
141
+            throw new Exception("data is not exist in all_data");
142
+        }
143
+        if (isset($all_data["oj"])) {
144
+            $oj=$all_data["oj"];
145
+        } else {
146
+            throw new Exception("oj is not exist in all_data");
147
+        }
148
+        if (isset($all_data["ret"])) {
149
+            $ret=$all_data["ret"];
150
+        } else {
151
+            $ret=false;
152
+        }
153
+        if (isset($all_data["follow"])) {
154
+            $follow=$all_data["follow"];
155
+        } else {
156
+            $follow=true;
157
+        }
158
+        if (isset($all_data["returnHeader"])) {
159
+            $returnHeader=$all_data["returnHeader"];
160
+        } else {
161
+            $returnHeader=true;
162
+        }
163
+        if (isset($all_data["postJson"])) {
164
+            $postJson=$all_data["postJson"];
165
+        } else {
166
+            $postJson=false;
167
+        }
168
+        if (isset($all_data["extraHeaders"])) {
169
+            $extraHeaders=$all_data["extraHeaders"];
170
+        } else {
171
+            $extraHeaders=[];
172
+        }
173
+        if (isset($all_data["handle"])) {
174
+            $handle=$all_data["handle"];
175
+        } else {
176
+            $handle="default";
177
+        }
178
+        if (isset($all_data["vcid"])) {
179
+            $vcid=$all_data["vcid"]."_";
180
+        } else {
181
+            $vcid="";
182
+        }
99 183
 
100 184
         $handle=urlencode($handle);
101 185
 
Please login to merge, or discard this patch.
app/Http/Controllers/Auth/RegisterController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -48,16 +48,16 @@
 block discarded – undo
48 48
      */
49 49
     protected function validator(array $data)
50 50
     {
51
-        $validator = [
51
+        $validator=[
52 52
             'name' => ['required', 'string', 'max:16', 'unique:users'],
53 53
             'email' => ['required', 'string', 'email', 'max:255', 'unique:users', 'allowed_email_domain'],
54 54
             'password' => ['required', 'string', 'min:8', 'confirmed'],
55 55
             'agreement' => ['required'],
56 56
         ];
57
-        $messages = [];
58
-        if(config('function.password.strong')) {
59
-            $validator['password'][] = 'regex:/^(?![A-Za-z0-9]+$)(?![a-z0-9\\W]+$)(?![A-Za-z\\W]+$)(?![A-Z0-9\\W]+$)[a-zA-Z0-9\\W]{8,}$/';
60
-            $messages['password.regex'] = __('validation.password.strong');
57
+        $messages=[];
58
+        if (config('function.password.strong')) {
59
+            $validator['password'][]='regex:/^(?![A-Za-z0-9]+$)(?![a-z0-9\\W]+$)(?![A-Za-z\\W]+$)(?![A-Z0-9\\W]+$)[a-zA-Z0-9\\W]{8,}$/';
60
+            $messages['password.regex']=__('validation.password.strong');
61 61
         }
62 62
         return Validator::make($data, $validator, $messages);
63 63
     }
Please login to merge, or discard this patch.
app/Http/Controllers/Group/IndexController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
         if ($clearance<1) {
180 180
             return Redirect::route('group.detail', ['gcode' => $gcode]);
181 181
         }
182
-        $homeworkInfo = GroupHomework::where(['id' => $homework_id, 'group_id' => $basic_info['gid']])->first();
182
+        $homeworkInfo=GroupHomework::where(['id' => $homework_id, 'group_id' => $basic_info['gid']])->first();
183 183
         if (blank($homeworkInfo)) {
184 184
             return Redirect::route('group.detail', ['gcode' => $gcode]);
185 185
         }
@@ -195,13 +195,13 @@  discard block
 block discarded – undo
195 195
 
196 196
     public function homeworkStatistics($gcode, $homework_id)
197 197
     {
198
-        $groupModel = new GroupModel();
199
-        $basic_info = $groupModel->details($gcode);
200
-        $clearance = $groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
201
-        if ($clearance < 2) {
198
+        $groupModel=new GroupModel();
199
+        $basic_info=$groupModel->details($gcode);
200
+        $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
201
+        if ($clearance<2) {
202 202
             return Redirect::route('group.detail', ['gcode' => $gcode]);
203 203
         }
204
-        $homeworkInfo = GroupHomework::where(['id' => $homework_id, 'group_id' => $basic_info['gid']])->first();
204
+        $homeworkInfo=GroupHomework::where(['id' => $homework_id, 'group_id' => $basic_info['gid']])->first();
205 205
         if (blank($homeworkInfo)) {
206 206
             return Redirect::route('group.detail', ['gcode' => $gcode]);
207 207
         }
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/ProblemController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
     public function problemExists(Request $request)
85 85
     {
86 86
         $request->validate(["pcode" => "required|string|max:100"]);
87
-        $problem = Problem::where('pcode', $request->pcode)->first();
87
+        $problem=Problem::where('pcode', $request->pcode)->first();
88 88
         if (filled($problem)) {
89 89
             return ResponseModel::success(200, null, $problem->only(["pcode", "title"]));
90 90
         } else {
Please login to merge, or discard this patch.
app/Models/Eloquent/GroupHomeworkProblem.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
 {
11 11
     use HasFactory;
12 12
 
13
-    protected $with = ['problem'];
13
+    protected $with=['problem'];
14 14
 
15 15
     public function homework()
16 16
     {
Please login to merge, or discard this patch.
app/Models/Eloquent/Group.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -66,21 +66,21 @@
 block discarded – undo
66 66
 
67 67
             // Create Homework Itself
68 68
 
69
-            $newHomework = new GroupHomework();
69
+            $newHomework=new GroupHomework();
70 70
 
71
-            $newHomework->title = $title;
72
-            $newHomework->description = $description;
73
-            $newHomework->ended_at = $endedAt;
74
-            $newHomework->is_simple = 1;
71
+            $newHomework->title=$title;
72
+            $newHomework->description=$description;
73
+            $newHomework->ended_at=$endedAt;
74
+            $newHomework->is_simple=1;
75 75
             $this->homework()->save($newHomework);
76 76
 
77 77
             // Created Related Problem List
78 78
 
79
-            $problemIndex = 1;
79
+            $problemIndex=1;
80 80
             foreach ($problems as $problem) {
81
-                $newProblem = new GroupHomeworkProblem();
82
-                $newProblem->problem_id = $problem['pid'];
83
-                $newProblem->order_index = $problemIndex++;
81
+                $newProblem=new GroupHomeworkProblem();
82
+                $newProblem->problem_id=$problem['pid'];
83
+                $newProblem->order_index=$problemIndex++;
84 84
                 $newHomework->problems()->save($newProblem);
85 85
             }
86 86
 
Please login to merge, or discard this patch.
app/Exceptions/Handler.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
      *
13 13
      * @var array
14 14
      */
15
-    protected $dontReport = [
15
+    protected $dontReport=[
16 16
         //
17 17
     ];
18 18
 
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      *
22 22
      * @var array
23 23
      */
24
-    protected $dontFlash = [
24
+    protected $dontFlash=[
25 25
         'current_password',
26 26
         'password',
27 27
         'password_confirmation',
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      */
35 35
     public function register()
36 36
     {
37
-        $this->reportable(function (Throwable $e) {
37
+        $this->reportable(function(Throwable $e) {
38 38
             //
39 39
         });
40 40
     }
Please login to merge, or discard this patch.
app/Console/Commands/Install/Install.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -78,10 +78,10 @@  discard block
 block discarded – undo
78 78
         $this->initSystemCheck();
79 79
         return;
80 80
         if ($this->confirm('Do you wish to continue?')) {
81
-            if(!$this->acceptLicense()){
81
+            if (!$this->acceptLicense()) {
82 82
                 return;
83 83
             }
84
-            if($this->createFrontAdminUser()){
84
+            if ($this->createFrontAdminUser()) {
85 85
                 $this->createFrontAdminGroup();
86 86
             }
87 87
             $this->installBabelExtensionNOJ();
@@ -119,19 +119,19 @@  discard block
 block discarded – undo
119 119
     protected function createFrontAdminUser() {
120 120
         $this->line('Creating frontstage admin user...');
121 121
         $this->comment('');
122
-        $shallCreate = true;
122
+        $shallCreate=true;
123 123
         if (User::count()) {
124
-            $shallCreate = $this->confirm('Detected existing frontstage user, do you really want to create frontstage admin?');
124
+            $shallCreate=$this->confirm('Detected existing frontstage user, do you really want to create frontstage admin?');
125 125
             $this->comment('');
126 126
         }
127 127
         if (!$shallCreate) {
128 128
             return false;
129 129
         }
130
-        while(true) {
130
+        while (true) {
131 131
             try {
132
-                $createdUser = $this->createFrontUser();
132
+                $createdUser=$this->createFrontUser();
133 133
                 break;
134
-            } catch(Exception $e) {
134
+            } catch (Exception $e) {
135 135
                 $this->line("\n  <bg=red;fg=white> Exception </> : <fg=yellow>Error occured while creating admin user.</>\n");
136 136
                 continue;
137 137
             }
@@ -140,9 +140,9 @@  discard block
 block discarded – undo
140 140
     }
141 141
 
142 142
     private function createFrontUser() {
143
-        $username = $this->ask('Please choose a username:', 'admin');
144
-        $email = $this->ask('Please choose a email address:', '[email protected]');
145
-        $password = Hash::make(Str::random(8));
143
+        $username=$this->ask('Please choose a username:', 'admin');
144
+        $email=$this->ask('Please choose a email address:', '[email protected]');
145
+        $password=Hash::make(Str::random(8));
146 146
         $createdUser=User::create([
147 147
             'name' => $username,
148 148
             'email' => $email,
Please login to merge, or discard this patch.