Passed
Branch dev (36fa10)
by John
04:08
created
app/Http/Controllers/Ajax/GroupManageController.php 2 patches
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
         $all_data=$request->all();
38 38
 
39
-        if(($all_data['public'] ?? 0) && ($all_data['practice'] ?? 0)){
39
+        if (($all_data['public'] ?? 0) && ($all_data['practice'] ?? 0)) {
40 40
             return ResponseModel::err(4007);
41 41
         }
42 42
 
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
             return ResponseModel::err(1003);
68 68
         }
69 69
 
70
-        $cid = $contestModel->arrangeContest($all_data["gid"], [
70
+        $cid=$contestModel->arrangeContest($all_data["gid"], [
71 71
             "assign_uid"=>Auth::user()->id,
72 72
             "name"=>$all_data["name"],
73 73
             "description"=>$all_data["description"],
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             "public"=>$all_data["public"] ?? 0,
78 78
         ], $problemSet);
79 79
 
80
-        return ResponseModel::success(200,'Successful!',$cid);
80
+        return ResponseModel::success(200, 'Successful!', $cid);
81 81
     }
82 82
 
83 83
     public function changeGroupName(Request $request)
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 
92 92
         $groupModel=new GroupModel();
93 93
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
94
-        if ($clearance < 2){
94
+        if ($clearance<2) {
95 95
             return ResponseModel::err(2001);
96 96
         }
97 97
 
@@ -110,11 +110,11 @@  discard block
 block discarded – undo
110 110
 
111 111
         $groupModel=new GroupModel();
112 112
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
113
-        if ($clearance < 2){
113
+        if ($clearance<2) {
114 114
             return ResponseModel::err(2001);
115 115
         }
116 116
 
117
-        if ($all_data["join_policy"] < 1 || $all_data["join_policy"] > 3){
117
+        if ($all_data["join_policy"]<1 || $all_data["join_policy"]>3) {
118 118
             return ResponseModel::err(1007);
119 119
         }
120 120
 
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
             'gid' => 'required|integer',
129 129
         ]);
130 130
 
131
-        $all_data = $request->all();
131
+        $all_data=$request->all();
132 132
 
133 133
         if (!empty($request->file('img')) && $request->file('img')->isValid()) {
134 134
             $extension=$request->file('img')->extension();
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 
141 141
         $groupModel=new GroupModel();
142 142
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
143
-        if ($clearance < 2){
143
+        if ($clearance<2) {
144 144
             return ResponseModel::err(2001);
145 145
         }
146 146
 
@@ -178,18 +178,18 @@  discard block
 block discarded – undo
178 178
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
179 179
         $target_clearance=$groupModel->judgeClearance($all_data["gid"], $all_data['uid']);
180 180
 
181
-        if($target_clearance == -3){
181
+        if ($target_clearance==-3) {
182 182
             return ResponseModel::err(7004);
183 183
         }
184 184
 
185
-        if($target_clearance >= $clearance || $clearance < 2 || $all_data['permission'] >= $clearance){
185
+        if ($target_clearance>=$clearance || $clearance<2 || $all_data['permission']>=$clearance) {
186 186
             return ResponseModel::err(2001);
187 187
         }
188 188
 
189 189
         $groupModel->changeClearance($all_data['uid'], $all_data["gid"], $all_data['permission']);
190 190
 
191
-        $result_info = $groupModel->userProfile($all_data['uid'],$all_data["gid"]);
192
-        return ResponseModel::success(200,null,$result_info);
191
+        $result_info=$groupModel->userProfile($all_data['uid'], $all_data["gid"]);
192
+        return ResponseModel::success(200, null, $result_info);
193 193
     }
194 194
 
195 195
     public function approveMember(Request $request)
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
206 206
         $targetClearance=$groupModel->judgeClearance($all_data["gid"], $all_data["uid"]);
207 207
         if ($clearance>1) {
208
-            if($targetClearance!=0) {
208
+            if ($targetClearance!=0) {
209 209
                 return ResponseModel::err(7003);
210 210
             }
211 211
             $groupModel->changeClearance($all_data["uid"], $all_data["gid"], 1);
@@ -244,11 +244,11 @@  discard block
 block discarded – undo
244 244
 
245 245
         $groupModel=new GroupModel();
246 246
         $is_user=$groupModel->isUser($all_data["email"]);
247
-        if(!$is_user) return ResponseModel::err(2006);
247
+        if (!$is_user) return ResponseModel::err(2006);
248 248
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
249
-        if($clearance<2) return ResponseModel::err(7002);
249
+        if ($clearance<2) return ResponseModel::err(7002);
250 250
         $targetClearance=$groupModel->judgeEmailClearance($all_data["gid"], $all_data["email"]);
251
-        if($targetClearance!=-3) return ResponseModel::err(7003);
251
+        if ($targetClearance!=-3) return ResponseModel::err(7003);
252 252
         $groupModel->inviteMember($all_data["gid"], $all_data["email"]);
253 253
         return ResponseModel::success(200);
254 254
     }
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
 
286 286
         $groupModel=new GroupModel();
287 287
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
288
-        if ($clearance < 2){
288
+        if ($clearance<2) {
289 289
             return ResponseModel::err(2001);
290 290
         }
291 291
         $groupModel->createNotice($all_data["gid"], Auth::user()->id, $all_data["title"], $all_data["content"]);
Please login to merge, or discard this patch.
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -244,11 +244,17 @@
 block discarded – undo
244 244
 
245 245
         $groupModel=new GroupModel();
246 246
         $is_user=$groupModel->isUser($all_data["email"]);
247
-        if(!$is_user) return ResponseModel::err(2006);
247
+        if(!$is_user) {
248
+            return ResponseModel::err(2006);
249
+        }
248 250
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
249
-        if($clearance<2) return ResponseModel::err(7002);
251
+        if($clearance<2) {
252
+            return ResponseModel::err(7002);
253
+        }
250 254
         $targetClearance=$groupModel->judgeEmailClearance($all_data["gid"], $all_data["email"]);
251
-        if($targetClearance!=-3) return ResponseModel::err(7003);
255
+        if($targetClearance!=-3) {
256
+            return ResponseModel::err(7003);
257
+        }
252 258
         $groupModel->inviteMember($all_data["gid"], $all_data["email"]);
253 259
         return ResponseModel::success(200);
254 260
     }
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/GroupController.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -69,9 +69,9 @@  discard block
 block discarded – undo
69 69
         $all_data=$request->all();
70 70
 
71 71
         $groupModel=new GroupModel();
72
-        if($all_data["gcode"]=="create") return ResponseModel::err(7005);
72
+        if ($all_data["gcode"]=="create") return ResponseModel::err(7005);
73 73
         $is_group=$groupModel->isGroup($all_data["gcode"]);
74
-        if($is_group) return ResponseModel::err(7006);
74
+        if ($is_group) return ResponseModel::err(7006);
75 75
 
76 76
         $allow_extension=['jpg', 'png', 'jpeg', 'gif', 'bmp'];
77 77
         if (!empty($request->file('img')) && $request->file('img')->isValid()) {
@@ -100,20 +100,20 @@  discard block
 block discarded – undo
100 100
 
101 101
         $groupModel=new GroupModel();
102 102
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
103
-        if ($clearance > 0) {
104
-            switch($all_data['mode']){
103
+        if ($clearance>0) {
104
+            switch ($all_data['mode']) {
105 105
                 case 'contest':
106
-                    $ret = $groupModel->groupMemberPracticeContestStat($all_data["gid"]);
106
+                    $ret=$groupModel->groupMemberPracticeContestStat($all_data["gid"]);
107 107
                 break;
108 108
                 case 'tag':
109
-                    $ret = $groupModel->groupMemberPracticeTagStat($all_data["gid"]);
109
+                    $ret=$groupModel->groupMemberPracticeTagStat($all_data["gid"]);
110 110
                 break;
111 111
                 default:
112 112
                     return ResponseModel::err(1007);
113 113
                 break;
114 114
             }
115 115
 
116
-            return ResponseModel::success(200,null,$ret);
116
+            return ResponseModel::success(200, null, $ret);
117 117
         }
118 118
         return ResponseModel::err(7002);
119 119
     }
Please login to merge, or discard this patch.
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,9 +69,13 @@
 block discarded – undo
69 69
         $all_data=$request->all();
70 70
 
71 71
         $groupModel=new GroupModel();
72
-        if($all_data["gcode"]=="create") return ResponseModel::err(7005);
72
+        if($all_data["gcode"]=="create") {
73
+            return ResponseModel::err(7005);
74
+        }
73 75
         $is_group=$groupModel->isGroup($all_data["gcode"]);
74
-        if($is_group) return ResponseModel::err(7006);
76
+        if($is_group) {
77
+            return ResponseModel::err(7006);
78
+        }
75 79
 
76 80
         $allow_extension=['jpg', 'png', 'jpeg', 'gif', 'bmp'];
77 81
         if (!empty($request->file('img')) && $request->file('img')->isValid()) {
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/GroupAdminController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -48,11 +48,11 @@  discard block
 block discarded – undo
48 48
 
49 49
         $groupModel=new GroupModel();
50 50
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
51
-        if ($clearance < 2) {
51
+        if ($clearance<2) {
52 52
             return ResponseModel::err(7002);
53 53
         }
54
-        $tags = $groupModel->problemTags($all_data['gid'],$all_data['pid']);
55
-        if(in_array($all_data['tag'],$tags)){
54
+        $tags=$groupModel->problemTags($all_data['gid'], $all_data['pid']);
55
+        if (in_array($all_data['tag'], $tags)) {
56 56
             return ResponseModel::err(7007);
57 57
         }
58 58
 
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
         $request->validate([
85 85
             'gid' => 'required|string',
86 86
         ]);
87
-        $gid = $request->input('gid');
87
+        $gid=$request->input('gid');
88 88
         $groupModel=new GroupModel();
89
-        if($groupModel->judgeClearance($gid,Auth::user()->id) < 2) {
89
+        if ($groupModel->judgeClearance($gid, Auth::user()->id)<2) {
90 90
             return ResponseModel::err(2001);
91 91
         }
92 92
         $groupModel->refreshElo($gid);
Please login to merge, or discard this patch.