ZsgsDesign / NOJ

app/Models/ResponseModel.php

Indentation +5 added lines, -5 removed lines

@@ -14,7 +14,7 @@ 
             $statusCode=200;
         }
         $output=[
-             'ret' => $statusCode,
+                'ret' => $statusCode,
             'desc' => is_null($desc) ? self::desc($statusCode) : $desc,
             'data' => $data
         ];
@@ -27,7 +27,7 @@ 
             $statusCode=1000;
         }
         $output=[
-             'ret' => $statusCode,
+                'ret' => $statusCode,
             'desc' => is_null($desc) ? self::desc($statusCode) : $desc,
             'data' => $data
         ];
@@ -44,9 +44,9 @@ 
             '451'  => "Unavailable For Legal Reasons",
 
             '1000' => "Unspecified Response", /** Under normal condictions those errors shouldn't been displayed to end users
-                                                 *  unless they attempt to do so, some submissions should be intercepted
-                                                 *  by the frontend before the request sended
-                                                 */
+             *  unless they attempt to do so, some submissions should be intercepted
+             *  by the frontend before the request sended
+             */
             '1001' => "Internal Sever Error",
             '1002' => "Service Currently Unavailable",
             '1003' => "Missing Params",

app/Babel/Submit/Curl.php

Braces +105 added lines, -21 removed lines

@@ -18,11 +18,31 @@ 
 
     public function login($all_data)
     {
-        if (isset($all_data["url"]))    $url=$all_data["url"]; else throw new Exception("url is not exist in all_data");
-        if (isset($all_data["data"]))   $data=$all_data["data"]; else throw new Exception("data is not exist in all_data");
-        if (isset($all_data["oj"]))     $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
-        if (isset($all_data["ret"]))    $ret=$all_data["ret"]; else $ret='false';
-        if (isset($all_data["handle"])) $handle=$all_data["handle"]; else $handle="default";
+        if (isset($all_data["url"])) {
+            $url=$all_data["url"];
+        } else {
+            throw new Exception("url is not exist in all_data");
+        }
+        if (isset($all_data["data"])) {
+            $data=$all_data["data"];
+        } else {
+            throw new Exception("data is not exist in all_data");
+        }
+        if (isset($all_data["oj"])) {
+            $oj=$all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if (isset($all_data["ret"])) {
+            $ret=$all_data["ret"];
+        } else {
+            $ret='false';
+        }
+        if (isset($all_data["handle"])) {
+            $handle=$all_data["handle"];
+        } else {
+            $handle="default";
+        }
 
         $datapost=curl_init();
         $headers=array("Expect:");
@@ -54,12 +74,36 @@ 
 
     public function grab_page($all_data)
     {
-        if (isset($all_data["site"]))    $site=$all_data["site"]; else throw new Exception("site is not exist in all_data");
-        if (isset($all_data["oj"]))      $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
-        if (isset($all_data["headers"])) $headers=$all_data["headers"]; else $headers=[];
-        if (isset($all_data["handle"]))  $handle=$all_data["handle"]; else $handle="default";
-        if (isset($all_data["follow"]))  $follow=$all_data["follow"]; else $follow=false;
-        if (isset($all_data["vcid"]))  $vcid=$all_data["vcid"]."_"; else $vcid="";
+        if (isset($all_data["site"])) {
+            $site=$all_data["site"];
+        } else {
+            throw new Exception("site is not exist in all_data");
+        }
+        if (isset($all_data["oj"])) {
+            $oj=$all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if (isset($all_data["headers"])) {
+            $headers=$all_data["headers"];
+        } else {
+            $headers=[];
+        }
+        if (isset($all_data["handle"])) {
+            $handle=$all_data["handle"];
+        } else {
+            $handle="default";
+        }
+        if (isset($all_data["follow"])) {
+            $follow=$all_data["follow"];
+        } else {
+            $follow=false;
+        }
+        if (isset($all_data["vcid"])) {
+            $vcid=$all_data["vcid"]."_";
+        } else {
+            $vcid="";
+        }
 
         $handle=urlencode($handle);
 
@@ -86,16 +130,56 @@ 
 
     public function post_data($all_data)
     {
-        if (isset($all_data["site"]))         $site=$all_data["site"]; else throw new Exception("site is not exist in all_data");
-        if (isset($all_data["data"]))         $data=$all_data["data"]; else throw new Exception("data is not exist in all_data");
-        if (isset($all_data["oj"]))           $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
-        if (isset($all_data["ret"]))          $ret=$all_data["ret"]; else $ret=false;
-        if (isset($all_data["follow"]))       $follow=$all_data["follow"]; else $follow=true;
-        if (isset($all_data["returnHeader"])) $returnHeader=$all_data["returnHeader"]; else $returnHeader=true;
-        if (isset($all_data["postJson"]))     $postJson=$all_data["postJson"]; else $postJson=false;
-        if (isset($all_data["extraHeaders"])) $extraHeaders=$all_data["extraHeaders"]; else $extraHeaders=[];
-        if (isset($all_data["handle"]))       $handle=$all_data["handle"]; else $handle="default";
-        if (isset($all_data["vcid"]))  $vcid=$all_data["vcid"]."_"; else $vcid="";
+        if (isset($all_data["site"])) {
+            $site=$all_data["site"];
+        } else {
+            throw new Exception("site is not exist in all_data");
+        }
+        if (isset($all_data["data"])) {
+            $data=$all_data["data"];
+        } else {
+            throw new Exception("data is not exist in all_data");
+        }
+        if (isset($all_data["oj"])) {
+            $oj=$all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if (isset($all_data["ret"])) {
+            $ret=$all_data["ret"];
+        } else {
+            $ret=false;
+        }
+        if (isset($all_data["follow"])) {
+            $follow=$all_data["follow"];
+        } else {
+            $follow=true;
+        }
+        if (isset($all_data["returnHeader"])) {
+            $returnHeader=$all_data["returnHeader"];
+        } else {
+            $returnHeader=true;
+        }
+        if (isset($all_data["postJson"])) {
+            $postJson=$all_data["postJson"];
+        } else {
+            $postJson=false;
+        }
+        if (isset($all_data["extraHeaders"])) {
+            $extraHeaders=$all_data["extraHeaders"];
+        } else {
+            $extraHeaders=[];
+        }
+        if (isset($all_data["handle"])) {
+            $handle=$all_data["handle"];
+        } else {
+            $handle="default";
+        }
+        if (isset($all_data["vcid"])) {
+            $vcid=$all_data["vcid"]."_";
+        } else {
+            $vcid="";
+        }
 
         $handle=urlencode($handle);
 

app/Http/Controllers/Auth/RegisterController.php

Spacing +5 added lines, -5 removed lines

@@ -48,16 +48,16 @@
      */
     protected function validator(array $data)
     {
-        $validator = [
+        $validator=[
             'name' => ['required', 'string', 'max:16', 'unique:users'],
             'email' => ['required', 'string', 'email', 'max:255', 'unique:users', 'allowed_email_domain'],
             'password' => ['required', 'string', 'min:8', 'confirmed'],
             'agreement' => ['required'],
         ];
-        $messages = [];
-        if(config('function.password.strong')) {
-            $validator['password'][] = 'regex:/^(?![A-Za-z0-9]+$)(?![a-z0-9\\W]+$)(?![A-Za-z\\W]+$)(?![A-Z0-9\\W]+$)[a-zA-Z0-9\\W]{8,}$/';
-            $messages['password.regex'] = __('validation.password.strong');
+        $messages=[];
+        if (config('function.password.strong')) {
+            $validator['password'][]='regex:/^(?![A-Za-z0-9]+$)(?![a-z0-9\\W]+$)(?![A-Za-z\\W]+$)(?![A-Z0-9\\W]+$)[a-zA-Z0-9\\W]{8,}$/';
+            $messages['password.regex']=__('validation.password.strong');
         }
         return Validator::make($data, $validator, $messages);
     }

app/Http/Controllers/Group/IndexController.php

Spacing +6 added lines, -6 removed lines

@@ -179,7 +179,7 @@ 
         if ($clearance<1) {
             return Redirect::route('group.detail', ['gcode' => $gcode]);
         }
-        $homeworkInfo = GroupHomework::where(['id' => $homework_id, 'group_id' => $basic_info['gid']])->first();
+        $homeworkInfo=GroupHomework::where(['id' => $homework_id, 'group_id' => $basic_info['gid']])->first();
         if (blank($homeworkInfo)) {
             return Redirect::route('group.detail', ['gcode' => $gcode]);
         }
@@ -195,13 +195,13 @@ 
 
     public function homeworkStatistics($gcode, $homework_id)
     {
-        $groupModel = new GroupModel();
-        $basic_info = $groupModel->details($gcode);
-        $clearance = $groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
-        if ($clearance < 2) {
+        $groupModel=new GroupModel();
+        $basic_info=$groupModel->details($gcode);
+        $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
+        if ($clearance<2) {
             return Redirect::route('group.detail', ['gcode' => $gcode]);
         }
-        $homeworkInfo = GroupHomework::where(['id' => $homework_id, 'group_id' => $basic_info['gid']])->first();
+        $homeworkInfo=GroupHomework::where(['id' => $homework_id, 'group_id' => $basic_info['gid']])->first();
         if (blank($homeworkInfo)) {
             return Redirect::route('group.detail', ['gcode' => $gcode]);
         }

app/Http/Controllers/Ajax/ProblemController.php

Spacing +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
     public function problemExists(Request $request)
     {
         $request->validate(["pcode" => "required|string|max:100"]);
-        $problem = Problem::where('pcode', $request->pcode)->first();
+        $problem=Problem::where('pcode', $request->pcode)->first();
         if (filled($problem)) {
             return ResponseModel::success(200, null, $problem->only(["pcode", "title"]));
         } else {

app/Http/Controllers/Ajax/GroupManageController.php

Spacing +19 added lines, -19 removed lines

@@ -319,9 +319,9 @@ 
     public function createHomework(Request $request)
     {
         try {
-            $all = $request->all();
-            $all['currently_at'] = strtotime('now');
-            $validator = Validator::make($all, [
+            $all=$request->all();
+            $all['currently_at']=strtotime('now');
+            $validator=Validator::make($all, [
                 'title'         => 'required|string|min:1|max:100',
                 'description'   => 'required|string|min:1|max:65535',
                 'ended_at'      => 'required|date|after:currently_at',
@@ -340,29 +340,29 @@ 
                 throw new Exception($validator->errors()->first());
             }
 
-            if (count($request->problems) > 26) {
+            if (count($request->problems)>26) {
                 throw new Exception('Please include no more than 26 problems.');
             }
 
-            if (count($request->problems) < 1) {
+            if (count($request->problems)<1) {
                 throw new Exception('Please include at least one problem.');
             }
 
-            $proceedProblems = $request->problems;
-            $proceedProblemCodes = [];
+            $proceedProblems=$request->problems;
+            $proceedProblemCodes=[];
 
             foreach ($proceedProblems as &$problem) {
                 if (!is_array($problem)) {
                     throw new Exception('Each problem object must be an array.');
                 }
 
-                $problem['pcode'] = mb_strtoupper(trim($problem['pcode']));
+                $problem['pcode']=mb_strtoupper(trim($problem['pcode']));
 
-                if(array_search($problem['pcode'], $proceedProblemCodes) !== false) {
+                if (array_search($problem['pcode'], $proceedProblemCodes)!==false) {
                     throw new Exception("Duplicate Problem");
                 }
 
-                $validator = Validator::make($problem, [
+                $validator=Validator::make($problem, [
                     'pcode'         => 'required|string|min:1|max:100',
                     // 'alias'         => 'required|string|min:0|max:100|nullable',
                     // 'points'        => 'required|integer|gte:1',
@@ -376,17 +376,17 @@ 
                     throw new Exception($validator->errors()->first());
                 }
 
-                $proceedProblemCodes[] = $problem['pcode'];
+                $proceedProblemCodes[]=$problem['pcode'];
             }
 
             unset($problem);
 
-            $problemsDict = Problem::whereIn('pcode', $proceedProblemCodes)->select('pid', 'pcode')->get()->pluck('pid', 'pcode');
+            $problemsDict=Problem::whereIn('pcode', $proceedProblemCodes)->select('pid', 'pcode')->get()->pluck('pid', 'pcode');
 
             try {
-                foreach($proceedProblems as &$proceedProblem) {
-                    $proceedProblem['pid'] = $problemsDict[$proceedProblem['pcode']];
-                    if(blank($proceedProblem['pid'])) {
+                foreach ($proceedProblems as &$proceedProblem) {
+                    $proceedProblem['pid']=$problemsDict[$proceedProblem['pcode']];
+                    if (blank($proceedProblem['pid'])) {
                         throw new Exception();
                     }
                 }
@@ -405,14 +405,14 @@ 
             ], 422);
         }
 
-        $groupModel = new GroupModel();
-        $clearance = $groupModel->judgeClearance($request->gid, Auth::user()->id);
-        if ($clearance < 2) {
+        $groupModel=new GroupModel();
+        $clearance=$groupModel->judgeClearance($request->gid, Auth::user()->id);
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
         try {
-            $homeworkID = Group::find($request->gid)->addHomework($request->title, $request->description, Carbon::parse($request->ended_at), $proceedProblems);
+            $homeworkID=Group::find($request->gid)->addHomework($request->title, $request->description, Carbon::parse($request->ended_at), $proceedProblems);
         } catch (Exception $e) {
             return ResponseModel::err(7009);
         }

app/Models/Eloquent/GroupHomeworkProblem.php

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
 {
     use HasFactory;
 
-    protected $with = ['problem'];
+    protected $with=['problem'];
 
     public function homework()
     {

app/Models/Eloquent/GroupHomework.php

Spacing +23 added lines, -23 removed lines

@@ -30,17 +30,17 @@ 
 
     public function getStatisticsAttribute()
     {
-        $cachedStatistics = Cache::tags(['homework', 'statistics'])->get($this->id);
+        $cachedStatistics=Cache::tags(['homework', 'statistics'])->get($this->id);
 
         if (blank($cachedStatistics)) {
-            $cachedStatistics = $this->cacheStatistics();
+            $cachedStatistics=$this->cacheStatistics();
         }
 
-        if ($cachedStatistics === false) {
+        if ($cachedStatistics===false) {
             return null;
         }
 
-        $cachedStatistics['timestamp'] = Carbon::createFromTimestamp($cachedStatistics['timestamp']);
+        $cachedStatistics['timestamp']=Carbon::createFromTimestamp($cachedStatistics['timestamp']);
 
         return $cachedStatistics;
     }
@@ -48,25 +48,25 @@ 
     public function cacheStatistics()
     {
         try {
-            $statistics = [];
-            $homeworkProblems = $this->problems->sortBy('order_index');
-            $users = $this->group->members()->where('role', '>=', 1)->get();
-            $userIDArr = $users->pluck('uid');
-            $defaultVerdict = [];
+            $statistics=[];
+            $homeworkProblems=$this->problems->sortBy('order_index');
+            $users=$this->group->members()->where('role', '>=', 1)->get();
+            $userIDArr=$users->pluck('uid');
+            $defaultVerdict=[];
 
             foreach ($homeworkProblems as $homeworkProblem) {
-                $statistics['problems'][] = [
+                $statistics['problems'][]=[
                     'pid' => $homeworkProblem->problem_id,
                     'readable_name' => $homeworkProblem->problem->readable_name,
                 ];
-                $defaultVerdict[$homeworkProblem->problem_id] = [
+                $defaultVerdict[$homeworkProblem->problem_id]=[
                     "icon" => "checkbox-blank-circle-outline",
                     "color" => "wemd-grey-text"
                 ];
             }
 
             foreach ($users as $user) {
-                $statistics['data'][$user->uid] = [
+                $statistics['data'][$user->uid]=[
                     'name' => $user->user->name,
                     'nick_name' => blank($user->nick_name) ? null : $user->nick_name,
                     'solved' => 0,
@@ -75,44 +75,44 @@ 
                 ];
             }
 
-            $endedAt = Carbon::parse($this->ended_at);
+            $endedAt=Carbon::parse($this->ended_at);
 
             foreach ($homeworkProblems as $homeworkProblem) {
-                $userProbIDArr = [];
+                $userProbIDArr=[];
 
                 foreach ($homeworkProblem->problem->users_latest_submission($userIDArr->diff($userProbIDArr), null, $endedAt, ['Accepted'])->get() as $acceptedRecord) {
-                    $statistics['data'][$acceptedRecord['uid']]['verdict'][$homeworkProblem->problem_id] = [
+                    $statistics['data'][$acceptedRecord['uid']]['verdict'][$homeworkProblem->problem_id]=[
                         "icon" => "checkbox-blank-circle",
                         "color" => $acceptedRecord['color']
                     ];
                     $statistics['data'][$acceptedRecord['uid']]['solved']++;
-                    $userProbIDArr[] = $acceptedRecord['uid'];
+                    $userProbIDArr[]=$acceptedRecord['uid'];
                 }
 
                 foreach ($homeworkProblem->problem->users_latest_submission($userIDArr->diff($userProbIDArr), null, $endedAt, ['Partially Accepted'])->get() as $acceptedRecord) {
-                    $statistics['data'][$acceptedRecord['uid']]['verdict'][$homeworkProblem->problem_id] = [
+                    $statistics['data'][$acceptedRecord['uid']]['verdict'][$homeworkProblem->problem_id]=[
                         "icon" => "cisco-webex",
                         "color" => $acceptedRecord['color']
                     ];
                     $statistics['data'][$acceptedRecord['uid']]['attempted']++;
-                    $userProbIDArr[] = $acceptedRecord['uid'];
+                    $userProbIDArr[]=$acceptedRecord['uid'];
                 }
 
                 foreach ($homeworkProblem->problem->users_latest_submission($userIDArr->diff($userProbIDArr), null, $endedAt)->get() as $acceptedRecord) {
-                    $statistics['data'][$acceptedRecord['uid']]['verdict'][$homeworkProblem->problem_id] = [
+                    $statistics['data'][$acceptedRecord['uid']]['verdict'][$homeworkProblem->problem_id]=[
                         "icon" => "cisco-webex",
                         "color" => $acceptedRecord['color']
                     ];
                     $statistics['data'][$acceptedRecord['uid']]['attempted']++;
-                    $userProbIDArr[] = $acceptedRecord['uid'];
+                    $userProbIDArr[]=$acceptedRecord['uid'];
                 }
             }
 
-            usort($statistics['data'], function ($a, $b) {
-                return $b["solved"] == $a["solved"] ? $b["attempted"] <=> $a["attempted"] : $b["solved"] <=> $a["solved"];
+            usort($statistics['data'], function($a, $b) {
+                return $b["solved"]==$a["solved"] ? $b["attempted"] <=> $a["attempted"] : $b["solved"] <=> $a["solved"];
             });
 
-            $statistics['timestamp'] = time();
+            $statistics['timestamp']=time();
             Cache::tags(['homework', 'statistics'])->put($this->id, $statistics, 360);
             return $statistics;
         } catch (Exception $e) {

app/Models/Eloquent/Group.php

Spacing +9 added lines, -9 removed lines

@@ -66,21 +66,21 @@
 
             // Create Homework Itself
 
-            $newHomework = new GroupHomework();
+            $newHomework=new GroupHomework();
 
-            $newHomework->title = $title;
-            $newHomework->description = $description;
-            $newHomework->ended_at = $endedAt;
-            $newHomework->is_simple = 1;
+            $newHomework->title=$title;
+            $newHomework->description=$description;
+            $newHomework->ended_at=$endedAt;
+            $newHomework->is_simple=1;
             $this->homework()->save($newHomework);
 
             // Created Related Problem List
 
-            $problemIndex = 1;
+            $problemIndex=1;
             foreach ($problems as $problem) {
-                $newProblem = new GroupHomeworkProblem();
-                $newProblem->problem_id = $problem['pid'];
-                $newProblem->order_index = $problemIndex++;
+                $newProblem=new GroupHomeworkProblem();
+                $newProblem->problem_id=$problem['pid'];
+                $newProblem->order_index=$problemIndex++;
                 $newHomework->problems()->save($newProblem);
             }