Passed
Push — master ( 3dac84...29c427 )
by John
13:35 queued 04:51
created
app/Http/Controllers/Auth/RegisterController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -48,16 +48,16 @@
 block discarded – undo
48 48
      */
49 49
     protected function validator(array $data)
50 50
     {
51
-        $validator = [
51
+        $validator=[
52 52
             'name' => ['required', 'string', 'max:16', 'unique:users'],
53 53
             'email' => ['required', 'string', 'email', 'max:255', 'unique:users', 'allowed_email_domain'],
54 54
             'password' => ['required', 'string', 'min:8', 'confirmed'],
55 55
             'agreement' => ['required'],
56 56
         ];
57
-        $messages = [];
58
-        if(config('function.password.strong')) {
59
-            $validator['password'][] = 'regex:/^(?![A-Za-z0-9]+$)(?![a-z0-9\\W]+$)(?![A-Za-z\\W]+$)(?![A-Z0-9\\W]+$)[a-zA-Z0-9\\W]{8,}$/';
60
-            $messages['password.regex'] = __('validation.password.strong');
57
+        $messages=[];
58
+        if (config('function.password.strong')) {
59
+            $validator['password'][]='regex:/^(?![A-Za-z0-9]+$)(?![a-z0-9\\W]+$)(?![A-Za-z\\W]+$)(?![A-Z0-9\\W]+$)[a-zA-Z0-9\\W]{8,}$/';
60
+            $messages['password.regex']=__('validation.password.strong');
61 61
         }
62 62
         return Validator::make($data, $validator, $messages);
63 63
     }
Please login to merge, or discard this patch.
app/Http/Controllers/Group/IndexController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
         if ($clearance<1) {
180 180
             return Redirect::route('group.detail', ['gcode' => $gcode]);
181 181
         }
182
-        $homeworkInfo = GroupHomework::where(['id' => $homework_id, 'group_id' => $basic_info['gid']])->first();
182
+        $homeworkInfo=GroupHomework::where(['id' => $homework_id, 'group_id' => $basic_info['gid']])->first();
183 183
         if (blank($homeworkInfo)) {
184 184
             return Redirect::route('group.detail', ['gcode' => $gcode]);
185 185
         }
@@ -195,13 +195,13 @@  discard block
 block discarded – undo
195 195
 
196 196
     public function homeworkStatistics($gcode, $homework_id)
197 197
     {
198
-        $groupModel = new GroupModel();
199
-        $basic_info = $groupModel->details($gcode);
200
-        $clearance = $groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
201
-        if ($clearance < 2) {
198
+        $groupModel=new GroupModel();
199
+        $basic_info=$groupModel->details($gcode);
200
+        $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
201
+        if ($clearance<2) {
202 202
             return Redirect::route('group.detail', ['gcode' => $gcode]);
203 203
         }
204
-        $homeworkInfo = GroupHomework::where(['id' => $homework_id, 'group_id' => $basic_info['gid']])->first();
204
+        $homeworkInfo=GroupHomework::where(['id' => $homework_id, 'group_id' => $basic_info['gid']])->first();
205 205
         if (blank($homeworkInfo)) {
206 206
             return Redirect::route('group.detail', ['gcode' => $gcode]);
207 207
         }
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/ProblemController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
     public function problemExists(Request $request)
85 85
     {
86 86
         $request->validate(["pcode" => "required|string|max:100"]);
87
-        $problem = Problem::where('pcode', $request->pcode)->first();
87
+        $problem=Problem::where('pcode', $request->pcode)->first();
88 88
         if (filled($problem)) {
89 89
             return ResponseModel::success(200, null, $problem->only(["pcode", "title"]));
90 90
         } else {
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/GroupManageController.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -319,9 +319,9 @@  discard block
 block discarded – undo
319 319
     public function createHomework(Request $request)
320 320
     {
321 321
         try {
322
-            $all = $request->all();
323
-            $all['currently_at'] = strtotime('now');
324
-            $validator = Validator::make($all, [
322
+            $all=$request->all();
323
+            $all['currently_at']=strtotime('now');
324
+            $validator=Validator::make($all, [
325 325
                 'title'         => 'required|string|min:1|max:100',
326 326
                 'description'   => 'required|string|min:1|max:65535',
327 327
                 'ended_at'      => 'required|date|after:currently_at',
@@ -340,29 +340,29 @@  discard block
 block discarded – undo
340 340
                 throw new Exception($validator->errors()->first());
341 341
             }
342 342
 
343
-            if (count($request->problems) > 26) {
343
+            if (count($request->problems)>26) {
344 344
                 throw new Exception('Please include no more than 26 problems.');
345 345
             }
346 346
 
347
-            if (count($request->problems) < 1) {
347
+            if (count($request->problems)<1) {
348 348
                 throw new Exception('Please include at least one problem.');
349 349
             }
350 350
 
351
-            $proceedProblems = $request->problems;
352
-            $proceedProblemCodes = [];
351
+            $proceedProblems=$request->problems;
352
+            $proceedProblemCodes=[];
353 353
 
354 354
             foreach ($proceedProblems as &$problem) {
355 355
                 if (!is_array($problem)) {
356 356
                     throw new Exception('Each problem object must be an array.');
357 357
                 }
358 358
 
359
-                $problem['pcode'] = mb_strtoupper(trim($problem['pcode']));
359
+                $problem['pcode']=mb_strtoupper(trim($problem['pcode']));
360 360
 
361
-                if(array_search($problem['pcode'], $proceedProblemCodes) !== false) {
361
+                if (array_search($problem['pcode'], $proceedProblemCodes)!==false) {
362 362
                     throw new Exception("Duplicate Problem");
363 363
                 }
364 364
 
365
-                $validator = Validator::make($problem, [
365
+                $validator=Validator::make($problem, [
366 366
                     'pcode'         => 'required|string|min:1|max:100',
367 367
                     // 'alias'         => 'required|string|min:0|max:100|nullable',
368 368
                     // 'points'        => 'required|integer|gte:1',
@@ -376,17 +376,17 @@  discard block
 block discarded – undo
376 376
                     throw new Exception($validator->errors()->first());
377 377
                 }
378 378
 
379
-                $proceedProblemCodes[] = $problem['pcode'];
379
+                $proceedProblemCodes[]=$problem['pcode'];
380 380
             }
381 381
 
382 382
             unset($problem);
383 383
 
384
-            $problemsDict = Problem::whereIn('pcode', $proceedProblemCodes)->select('pid', 'pcode')->get()->pluck('pid', 'pcode');
384
+            $problemsDict=Problem::whereIn('pcode', $proceedProblemCodes)->select('pid', 'pcode')->get()->pluck('pid', 'pcode');
385 385
 
386 386
             try {
387
-                foreach($proceedProblems as &$proceedProblem) {
388
-                    $proceedProblem['pid'] = $problemsDict[$proceedProblem['pcode']];
389
-                    if(blank($proceedProblem['pid'])) {
387
+                foreach ($proceedProblems as &$proceedProblem) {
388
+                    $proceedProblem['pid']=$problemsDict[$proceedProblem['pcode']];
389
+                    if (blank($proceedProblem['pid'])) {
390 390
                         throw new Exception();
391 391
                     }
392 392
                 }
@@ -405,14 +405,14 @@  discard block
 block discarded – undo
405 405
             ], 422);
406 406
         }
407 407
 
408
-        $groupModel = new GroupModel();
409
-        $clearance = $groupModel->judgeClearance($request->gid, Auth::user()->id);
410
-        if ($clearance < 2) {
408
+        $groupModel=new GroupModel();
409
+        $clearance=$groupModel->judgeClearance($request->gid, Auth::user()->id);
410
+        if ($clearance<2) {
411 411
             return ResponseModel::err(2001);
412 412
         }
413 413
 
414 414
         try {
415
-            $homeworkID = Group::find($request->gid)->addHomework($request->title, $request->description, Carbon::parse($request->ended_at), $proceedProblems);
415
+            $homeworkID=Group::find($request->gid)->addHomework($request->title, $request->description, Carbon::parse($request->ended_at), $proceedProblems);
416 416
         } catch (Exception $e) {
417 417
             return ResponseModel::err(7009);
418 418
         }
Please login to merge, or discard this patch.
app/Models/Eloquent/GroupHomeworkProblem.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
 {
11 11
     use HasFactory;
12 12
 
13
-    protected $with = ['problem'];
13
+    protected $with=['problem'];
14 14
 
15 15
     public function homework()
16 16
     {
Please login to merge, or discard this patch.
app/Models/Eloquent/GroupHomework.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -30,17 +30,17 @@  discard block
 block discarded – undo
30 30
 
31 31
     public function getStatisticsAttribute()
32 32
     {
33
-        $cachedStatistics = Cache::tags(['homework', 'statistics'])->get($this->id);
33
+        $cachedStatistics=Cache::tags(['homework', 'statistics'])->get($this->id);
34 34
 
35 35
         if (blank($cachedStatistics)) {
36
-            $cachedStatistics = $this->cacheStatistics();
36
+            $cachedStatistics=$this->cacheStatistics();
37 37
         }
38 38
 
39
-        if ($cachedStatistics === false) {
39
+        if ($cachedStatistics===false) {
40 40
             return null;
41 41
         }
42 42
 
43
-        $cachedStatistics['timestamp'] = Carbon::createFromTimestamp($cachedStatistics['timestamp']);
43
+        $cachedStatistics['timestamp']=Carbon::createFromTimestamp($cachedStatistics['timestamp']);
44 44
 
45 45
         return $cachedStatistics;
46 46
     }
@@ -48,25 +48,25 @@  discard block
 block discarded – undo
48 48
     public function cacheStatistics()
49 49
     {
50 50
         try {
51
-            $statistics = [];
52
-            $homeworkProblems = $this->problems->sortBy('order_index');
53
-            $users = $this->group->members()->where('role', '>=', 1)->get();
54
-            $userIDArr = $users->pluck('uid');
55
-            $defaultVerdict = [];
51
+            $statistics=[];
52
+            $homeworkProblems=$this->problems->sortBy('order_index');
53
+            $users=$this->group->members()->where('role', '>=', 1)->get();
54
+            $userIDArr=$users->pluck('uid');
55
+            $defaultVerdict=[];
56 56
 
57 57
             foreach ($homeworkProblems as $homeworkProblem) {
58
-                $statistics['problems'][] = [
58
+                $statistics['problems'][]=[
59 59
                     'pid' => $homeworkProblem->problem_id,
60 60
                     'readable_name' => $homeworkProblem->problem->readable_name,
61 61
                 ];
62
-                $defaultVerdict[$homeworkProblem->problem_id] = [
62
+                $defaultVerdict[$homeworkProblem->problem_id]=[
63 63
                     "icon" => "checkbox-blank-circle-outline",
64 64
                     "color" => "wemd-grey-text"
65 65
                 ];
66 66
             }
67 67
 
68 68
             foreach ($users as $user) {
69
-                $statistics['data'][$user->uid] = [
69
+                $statistics['data'][$user->uid]=[
70 70
                     'name' => $user->user->name,
71 71
                     'nick_name' => blank($user->nick_name) ? null : $user->nick_name,
72 72
                     'solved' => 0,
@@ -75,44 +75,44 @@  discard block
 block discarded – undo
75 75
                 ];
76 76
             }
77 77
 
78
-            $endedAt = Carbon::parse($this->ended_at);
78
+            $endedAt=Carbon::parse($this->ended_at);
79 79
 
80 80
             foreach ($homeworkProblems as $homeworkProblem) {
81
-                $userProbIDArr = [];
81
+                $userProbIDArr=[];
82 82
 
83 83
                 foreach ($homeworkProblem->problem->users_latest_submission($userIDArr->diff($userProbIDArr), null, $endedAt, ['Accepted'])->get() as $acceptedRecord) {
84
-                    $statistics['data'][$acceptedRecord['uid']]['verdict'][$homeworkProblem->problem_id] = [
84
+                    $statistics['data'][$acceptedRecord['uid']]['verdict'][$homeworkProblem->problem_id]=[
85 85
                         "icon" => "checkbox-blank-circle",
86 86
                         "color" => $acceptedRecord['color']
87 87
                     ];
88 88
                     $statistics['data'][$acceptedRecord['uid']]['solved']++;
89
-                    $userProbIDArr[] = $acceptedRecord['uid'];
89
+                    $userProbIDArr[]=$acceptedRecord['uid'];
90 90
                 }
91 91
 
92 92
                 foreach ($homeworkProblem->problem->users_latest_submission($userIDArr->diff($userProbIDArr), null, $endedAt, ['Partially Accepted'])->get() as $acceptedRecord) {
93
-                    $statistics['data'][$acceptedRecord['uid']]['verdict'][$homeworkProblem->problem_id] = [
93
+                    $statistics['data'][$acceptedRecord['uid']]['verdict'][$homeworkProblem->problem_id]=[
94 94
                         "icon" => "cisco-webex",
95 95
                         "color" => $acceptedRecord['color']
96 96
                     ];
97 97
                     $statistics['data'][$acceptedRecord['uid']]['attempted']++;
98
-                    $userProbIDArr[] = $acceptedRecord['uid'];
98
+                    $userProbIDArr[]=$acceptedRecord['uid'];
99 99
                 }
100 100
 
101 101
                 foreach ($homeworkProblem->problem->users_latest_submission($userIDArr->diff($userProbIDArr), null, $endedAt)->get() as $acceptedRecord) {
102
-                    $statistics['data'][$acceptedRecord['uid']]['verdict'][$homeworkProblem->problem_id] = [
102
+                    $statistics['data'][$acceptedRecord['uid']]['verdict'][$homeworkProblem->problem_id]=[
103 103
                         "icon" => "cisco-webex",
104 104
                         "color" => $acceptedRecord['color']
105 105
                     ];
106 106
                     $statistics['data'][$acceptedRecord['uid']]['attempted']++;
107
-                    $userProbIDArr[] = $acceptedRecord['uid'];
107
+                    $userProbIDArr[]=$acceptedRecord['uid'];
108 108
                 }
109 109
             }
110 110
 
111
-            usort($statistics['data'], function ($a, $b) {
112
-                return $b["solved"] == $a["solved"] ? $b["attempted"] <=> $a["attempted"] : $b["solved"] <=> $a["solved"];
111
+            usort($statistics['data'], function($a, $b) {
112
+                return $b["solved"]==$a["solved"] ? $b["attempted"] <=> $a["attempted"] : $b["solved"] <=> $a["solved"];
113 113
             });
114 114
 
115
-            $statistics['timestamp'] = time();
115
+            $statistics['timestamp']=time();
116 116
             Cache::tags(['homework', 'statistics'])->put($this->id, $statistics, 360);
117 117
             return $statistics;
118 118
         } catch (Exception $e) {
Please login to merge, or discard this patch.
app/Models/Eloquent/Group.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -66,21 +66,21 @@
 block discarded – undo
66 66
 
67 67
             // Create Homework Itself
68 68
 
69
-            $newHomework = new GroupHomework();
69
+            $newHomework=new GroupHomework();
70 70
 
71
-            $newHomework->title = $title;
72
-            $newHomework->description = $description;
73
-            $newHomework->ended_at = $endedAt;
74
-            $newHomework->is_simple = 1;
71
+            $newHomework->title=$title;
72
+            $newHomework->description=$description;
73
+            $newHomework->ended_at=$endedAt;
74
+            $newHomework->is_simple=1;
75 75
             $this->homework()->save($newHomework);
76 76
 
77 77
             // Created Related Problem List
78 78
 
79
-            $problemIndex = 1;
79
+            $problemIndex=1;
80 80
             foreach ($problems as $problem) {
81
-                $newProblem = new GroupHomeworkProblem();
82
-                $newProblem->problem_id = $problem['pid'];
83
-                $newProblem->order_index = $problemIndex++;
81
+                $newProblem=new GroupHomeworkProblem();
82
+                $newProblem->problem_id=$problem['pid'];
83
+                $newProblem->order_index=$problemIndex++;
84 84
                 $newHomework->problems()->save($newProblem);
85 85
             }
86 86
 
Please login to merge, or discard this patch.
app/Exceptions/Handler.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
      *
13 13
      * @var array
14 14
      */
15
-    protected $dontReport = [
15
+    protected $dontReport=[
16 16
         //
17 17
     ];
18 18
 
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      *
22 22
      * @var array
23 23
      */
24
-    protected $dontFlash = [
24
+    protected $dontFlash=[
25 25
         'current_password',
26 26
         'password',
27 27
         'password_confirmation',
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      */
35 35
     public function register()
36 36
     {
37
-        $this->reportable(function (Throwable $e) {
37
+        $this->reportable(function(Throwable $e) {
38 38
             //
39 39
         });
40 40
     }
Please login to merge, or discard this patch.
app/Console/Commands/Install/Install.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -78,10 +78,10 @@  discard block
 block discarded – undo
78 78
         $this->initSystemCheck();
79 79
         return;
80 80
         if ($this->confirm('Do you wish to continue?')) {
81
-            if(!$this->acceptLicense()){
81
+            if (!$this->acceptLicense()) {
82 82
                 return;
83 83
             }
84
-            if($this->createFrontAdminUser()){
84
+            if ($this->createFrontAdminUser()) {
85 85
                 $this->createFrontAdminGroup();
86 86
             }
87 87
             $this->installBabelExtensionNOJ();
@@ -119,19 +119,19 @@  discard block
 block discarded – undo
119 119
     protected function createFrontAdminUser() {
120 120
         $this->line('Creating frontstage admin user...');
121 121
         $this->comment('');
122
-        $shallCreate = true;
122
+        $shallCreate=true;
123 123
         if (User::count()) {
124
-            $shallCreate = $this->confirm('Detected existing frontstage user, do you really want to create frontstage admin?');
124
+            $shallCreate=$this->confirm('Detected existing frontstage user, do you really want to create frontstage admin?');
125 125
             $this->comment('');
126 126
         }
127 127
         if (!$shallCreate) {
128 128
             return false;
129 129
         }
130
-        while(true) {
130
+        while (true) {
131 131
             try {
132
-                $createdUser = $this->createFrontUser();
132
+                $createdUser=$this->createFrontUser();
133 133
                 break;
134
-            } catch(Exception $e) {
134
+            } catch (Exception $e) {
135 135
                 $this->line("\n  <bg=red;fg=white> Exception </> : <fg=yellow>Error occured while creating admin user.</>\n");
136 136
                 continue;
137 137
             }
@@ -140,9 +140,9 @@  discard block
 block discarded – undo
140 140
     }
141 141
 
142 142
     private function createFrontUser() {
143
-        $username = $this->ask('Please choose a username:', 'admin');
144
-        $email = $this->ask('Please choose a email address:', '[email protected]');
145
-        $password = Hash::make(Str::random(8));
143
+        $username=$this->ask('Please choose a username:', 'admin');
144
+        $email=$this->ask('Please choose a email address:', '[email protected]');
145
+        $password=Hash::make(Str::random(8));
146 146
         $createdUser=User::create([
147 147
             'name' => $username,
148 148
             'email' => $email,
Please login to merge, or discard this patch.