Passed
Pull Request — master (#184)
by Chenyi
03:56
created
app/Babel/Submit/Curl.php 1 patch
Braces   +90 added lines, -18 removed lines patch added patch discarded remove patch
@@ -18,11 +18,31 @@  discard block
 block discarded – undo
18 18
 
19 19
     public function login($all_data)
20 20
     {
21
-        if(isset($all_data["url"]))    $url = $all_data["url"];       else throw new Exception("url is not exist in all_data");
22
-        if(isset($all_data["data"]))   $data = $all_data["data"];     else throw new Exception("data is not exist in all_data");
23
-        if(isset($all_data["oj"]))     $oj = $all_data["oj"];         else throw new Exception("oj is not exist in all_data");
24
-        if(isset($all_data["ret"]))    $ret = $all_data["ret"];       else $ret = 'false';
25
-        if(isset($all_data["handle"])) $handle = $all_data["handle"]; else $handle = "default";
21
+        if(isset($all_data["url"])) {
22
+            $url = $all_data["url"];
23
+        } else {
24
+            throw new Exception("url is not exist in all_data");
25
+        }
26
+        if(isset($all_data["data"])) {
27
+            $data = $all_data["data"];
28
+        } else {
29
+            throw new Exception("data is not exist in all_data");
30
+        }
31
+        if(isset($all_data["oj"])) {
32
+            $oj = $all_data["oj"];
33
+        } else {
34
+            throw new Exception("oj is not exist in all_data");
35
+        }
36
+        if(isset($all_data["ret"])) {
37
+            $ret = $all_data["ret"];
38
+        } else {
39
+            $ret = 'false';
40
+        }
41
+        if(isset($all_data["handle"])) {
42
+            $handle = $all_data["handle"];
43
+        } else {
44
+            $handle = "default";
45
+        }
26 46
 
27 47
         $datapost=curl_init();
28 48
         $headers=array("Expect:");
@@ -54,10 +74,26 @@  discard block
 block discarded – undo
54 74
 
55 75
     public function grab_page($all_data)
56 76
     {
57
-        if(isset($all_data["site"]))    $site = $all_data["site"];          else throw new Exception("site is not exist in all_data");
58
-        if(isset($all_data["oj"]))      $oj = $all_data["oj"];              else throw new Exception("oj is not exist in all_data");
59
-        if(isset($all_data["headers"])) $headers = $all_data["headers"];    else $headers = [];
60
-        if(isset($all_data["handle"]))  $handle = $all_data["handle"];      else $handle = "default";
77
+        if(isset($all_data["site"])) {
78
+            $site = $all_data["site"];
79
+        } else {
80
+            throw new Exception("site is not exist in all_data");
81
+        }
82
+        if(isset($all_data["oj"])) {
83
+            $oj = $all_data["oj"];
84
+        } else {
85
+            throw new Exception("oj is not exist in all_data");
86
+        }
87
+        if(isset($all_data["headers"])) {
88
+            $headers = $all_data["headers"];
89
+        } else {
90
+            $headers = [];
91
+        }
92
+        if(isset($all_data["handle"])) {
93
+            $handle = $all_data["handle"];
94
+        } else {
95
+            $handle = "default";
96
+        }
61 97
 
62 98
         $handle=urlencode($handle);
63 99
 
@@ -83,15 +119,51 @@  discard block
 block discarded – undo
83 119
 
84 120
     public function post_data($all_data)
85 121
     {
86
-        if(isset($all_data["site"]))         $site = $all_data["site"];                 else throw new Exception("site is not exist in all_data");
87
-        if(isset($all_data["data"]))         $data = $all_data["data"];                 else throw new Exception("data is not exist in all_data");
88
-        if(isset($all_data["oj"]))           $oj = $all_data["oj"];                     else throw new Exception("oj is not exist in all_data");
89
-        if(isset($all_data["ret"]))          $ret = $all_data["ret"];                   else $ret = false;
90
-        if(isset($all_data["follow"]))       $follow = $all_data["follow"];             else $follow = true;
91
-        if(isset($all_data["returnHeader"])) $returnHeader = $all_data["returnHeader"]; else $returnHeader = true;
92
-        if(isset($all_data["postJson"]))     $postJson = $all_data["postJson"];         else $postJson = false;
93
-        if(isset($all_data["extraHeaders"])) $extraHeaders = $all_data["extraHeaders"]; else $extraHeaders = [];
94
-        if(isset($all_data["handle"]))       $handle = $all_data["handle"];             else $handle = "default";
122
+        if(isset($all_data["site"])) {
123
+            $site = $all_data["site"];
124
+        } else {
125
+            throw new Exception("site is not exist in all_data");
126
+        }
127
+        if(isset($all_data["data"])) {
128
+            $data = $all_data["data"];
129
+        } else {
130
+            throw new Exception("data is not exist in all_data");
131
+        }
132
+        if(isset($all_data["oj"])) {
133
+            $oj = $all_data["oj"];
134
+        } else {
135
+            throw new Exception("oj is not exist in all_data");
136
+        }
137
+        if(isset($all_data["ret"])) {
138
+            $ret = $all_data["ret"];
139
+        } else {
140
+            $ret = false;
141
+        }
142
+        if(isset($all_data["follow"])) {
143
+            $follow = $all_data["follow"];
144
+        } else {
145
+            $follow = true;
146
+        }
147
+        if(isset($all_data["returnHeader"])) {
148
+            $returnHeader = $all_data["returnHeader"];
149
+        } else {
150
+            $returnHeader = true;
151
+        }
152
+        if(isset($all_data["postJson"])) {
153
+            $postJson = $all_data["postJson"];
154
+        } else {
155
+            $postJson = false;
156
+        }
157
+        if(isset($all_data["extraHeaders"])) {
158
+            $extraHeaders = $all_data["extraHeaders"];
159
+        } else {
160
+            $extraHeaders = [];
161
+        }
162
+        if(isset($all_data["handle"])) {
163
+            $handle = $all_data["handle"];
164
+        } else {
165
+            $handle = "default";
166
+        }
95 167
 
96 168
         $handle=urlencode($handle);
97 169
 
Please login to merge, or discard this patch.
app/Http/Controllers/GroupController.php 1 patch
Braces   +16 added lines, -6 removed lines patch added patch discarded remove patch
@@ -43,7 +43,9 @@  discard block
 block discarded – undo
43 43
         $groupModel=new GroupModel();
44 44
         $contestModel=new ContestModel();
45 45
         $basic_info=$groupModel->details($gcode);
46
-        if(empty($basic_info)) return Redirect::route('group.index');
46
+        if(empty($basic_info)) {
47
+            return Redirect::route('group.index');
48
+        }
47 49
         $my_profile=$groupModel->userProfile(Auth::user()->id, $basic_info["gid"]);
48 50
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
49 51
         $member_list=$groupModel->userList($basic_info["gid"]);
@@ -110,7 +112,9 @@  discard block
 block discarded – undo
110 112
     {
111 113
         $groupModel=new GroupModel();
112 114
         $basic_info=$groupModel->details($gcode);
113
-        if(empty($basic_info)) return Redirect::route('group.index');
115
+        if(empty($basic_info)) {
116
+            return Redirect::route('group.index');
117
+        }
114 118
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
115 119
         $member_list=$groupModel->userList($basic_info["gid"]);
116 120
         return view('group.settings.general', [
@@ -155,7 +159,9 @@  discard block
 block discarded – undo
155 159
         $groupModel=new GroupModel();
156 160
         $contestModel=new ContestModel();
157 161
         $basic_info=$groupModel->details($gcode);
158
-        if(empty($basic_info)) return Redirect::route('group.index');
162
+        if(empty($basic_info)) {
163
+            return Redirect::route('group.index');
164
+        }
159 165
         return view('group.settings.danger', [
160 166
             'page_title'=>"Group Setting danger",
161 167
             'site_title'=>config("app.name"),
@@ -191,7 +197,9 @@  discard block
 block discarded – undo
191 197
         $groupModel=new GroupModel();
192 198
         $contestModel=new ContestModel();
193 199
         $basic_info=$groupModel->details($gcode);
194
-        if(empty($basic_info)) return Redirect::route('group.index');
200
+        if(empty($basic_info)) {
201
+            return Redirect::route('group.index');
202
+        }
195 203
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
196 204
         $member_list=$groupModel->userList($basic_info["gid"]);
197 205
         $group_notice=$groupModel->detailNotice($gcode);
@@ -211,7 +219,9 @@  discard block
 block discarded – undo
211 219
         $groupModel=new GroupModel();
212 220
         $contestModel=new ContestModel();
213 221
         $basic_info=$groupModel->details($gcode);
214
-        if(empty($basic_info)) return Redirect::route('group.index');
222
+        if(empty($basic_info)) {
223
+            return Redirect::route('group.index');
224
+        }
215 225
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
216 226
         $contest_list=$contestModel->listForSetting($basic_info["gid"]);
217 227
         $member_list=$groupModel->userList($basic_info["gid"]);
@@ -252,7 +262,7 @@  discard block
 block discarded – undo
252 262
                 ),
253 263
                 $gcode . '_Group_Contest_Analysis.xlsx'
254 264
             );
255
-        }else{
265
+        } else{
256 266
             $data = $groupModel->groupMemberPracticeTagStat($group_info['gid']);
257 267
             return Excel::download(
258 268
                 new GroupAnalysisExport(
Please login to merge, or discard this patch.