ZsgsDesign / NOJ

app/Console/Kernel.php

Spacing +17 added lines, -17 removed lines

@@ -31,48 +31,48 @@ 
      */
     protected function schedule(Schedule $schedule)
     {
-        $schedule->call(function () {
+        $schedule->call(function() {
             $babel=new Babel();
             for ($i=1; $i<=12; $i++) {
                 $babel->judge();
                 sleep(5);
             }
-            file_put_contents(storage_path('app/task-schedule.output'),"Successfully Synced Judger");
+            file_put_contents(storage_path('app/task-schedule.output'), "Successfully Synced Judger");
         })->everyMinute()->description("Sync Judger");
 
-        $schedule->call(function () {
+        $schedule->call(function() {
             $rankModel=new RankModel();
             $rankModel->rankList();
-            file_put_contents(storage_path('app/task-schedule.output'),"Successfully Updated Rank");
+            file_put_contents(storage_path('app/task-schedule.output'), "Successfully Updated Rank");
         })->dailyAt('02:00')->description("Update Rank");
 
-        $schedule->call(function () {
+        $schedule->call(function() {
             $siteMapModel=new SiteMapModel();
-            file_put_contents(storage_path('app/task-schedule.output'),"Successfully Updated SiteMap");
+            file_put_contents(storage_path('app/task-schedule.output'), "Successfully Updated SiteMap");
         })->dailyAt('02:00')->description("Update SiteMap");
 
-        $schedule->call(function () {
+        $schedule->call(function() {
             $groupModel=new GroupModel();
             $groupModel->cacheTrendingGroups();
-            file_put_contents(storage_path('app/task-schedule.output'),"Successfully Cached Trending Groups");
+            file_put_contents(storage_path('app/task-schedule.output'), "Successfully Cached Trending Groups");
         })->dailyAt('03:00')->description("Update Trending Groups");
 
         $schedule->call(function() {
-            $contestModel = new ContestModel();
-            $syncList = $contestModel->runningContest();
-            foreach($syncList as $syncContest) {
-                $className = "App\\Babel\\Extension\\hdu\\Synchronizer";  // TODO Add OJ judgement.
-                $all_data = [
+            $contestModel=new ContestModel();
+            $syncList=$contestModel->runningContest();
+            foreach ($syncList as $syncContest) {
+                $className="App\\Babel\\Extension\\hdu\\Synchronizer"; // TODO Add OJ judgement.
+                $all_data=[
                     'oj'=>"hdu",
                     'vcid'=>$syncContest['vcid'],
                     'gid'=>$syncContest['gid'],
                     'cid'=>$syncContest['cid'],
                 ];
-                $hduSync = new $className($all_data);
+                $hduSync=new $className($all_data);
                 $hduSync->crawlRank();
                 $hduSync->crawlClarification();
             }
-            file_put_contents(storage_path('app/task-schedule.output'),"Successfully Synced Remote Rank and Clarification");
+            file_put_contents(storage_path('app/task-schedule.output'), "Successfully Synced Remote Rank and Clarification");
         })->everyMinute()->description("Sync Remote Rank and Clarification");
 
         // TODO it depends on the front interface.
@@ -80,10 +80,10 @@ 
 
         // })->everyMinute()->description("Sync Remote Problem");
 
-        $schedule->call(function () {
+        $schedule->call(function() {
             $judgerModel=new JudgerModel();
             $judgerModel->updateServerStatus(1);
-            file_put_contents(storage_path('app/task-schedule.output'),"Successfully Updated Judge Server Status");
+            file_put_contents(storage_path('app/task-schedule.output'), "Successfully Updated Judge Server Status");
         })->everyMinute()->description("Update Judge Server Status");
 
         if (!env("APP_DEBUG")) {

app/Console/Commands/Babel/SyncContest.php

Spacing +8 added lines, -8 removed lines

@@ -14,14 +14,14 @@ 
      *
      * @var string
      */
-    protected $signature = 'babel:sync {extension : The package name of the extension} {--vcid= : The target contest of the Crawler} {--gid=1 : The holding group}';
+    protected $signature='babel:sync {extension : The package name of the extension} {--vcid= : The target contest of the Crawler} {--gid=1 : The holding group}';
 
     /**
      * The console command description.
      *
      * @var string
      */
-    protected $description = 'Crawl contests for a given Babel Extension to NOJ';
+    protected $description='Crawl contests for a given Babel Extension to NOJ';
 
     /**
      * Create a new command instance.
@@ -40,16 +40,16 @@ 
      */
     public function handle()
     {
-        $extension = $this->argument('extension');
-        $vcid = $this->option('vcid');
-        $gid = $this->option('gid');
-        $className = "App\\Babel\\Extension\\$extension\\Synchronizer";
-        $all_data = [
+        $extension=$this->argument('extension');
+        $vcid=$this->option('vcid');
+        $gid=$this->option('gid');
+        $className="App\\Babel\\Extension\\$extension\\Synchronizer";
+        $all_data=[
             'oj'=>$extension,
             'vcid'=>$vcid,
             'gid'=>$gid,
         ];
-        $Sync = new $className($all_data);
+        $Sync=new $className($all_data);
         $Sync->crawlContest();
     }
 }

app/Babel/Submit/Curl.php

Spacing +18 added lines, -18 removed lines

@@ -18,11 +18,11 @@ 
 
     public function login($all_data)
     {
-        if(isset($all_data["url"]))    $url = $all_data["url"];       else throw new Exception("url is not exist in all_data");
-        if(isset($all_data["data"]))   $data = $all_data["data"];     else throw new Exception("data is not exist in all_data");
-        if(isset($all_data["oj"]))     $oj = $all_data["oj"];         else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["ret"]))    $ret = $all_data["ret"];       else $ret = 'false';
-        if(isset($all_data["handle"])) $handle = $all_data["handle"]; else $handle = "default";
+        if (isset($all_data["url"]))    $url=$all_data["url"]; else throw new Exception("url is not exist in all_data");
+        if (isset($all_data["data"]))   $data=$all_data["data"]; else throw new Exception("data is not exist in all_data");
+        if (isset($all_data["oj"]))     $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
+        if (isset($all_data["ret"]))    $ret=$all_data["ret"]; else $ret='false';
+        if (isset($all_data["handle"])) $handle=$all_data["handle"]; else $handle="default";
 
         $datapost=curl_init();
         $headers=array("Expect:");
@@ -54,10 +54,10 @@ 
 
     public function grab_page($all_data)
     {
-        if(isset($all_data["site"]))    $site = $all_data["site"];          else throw new Exception("site is not exist in all_data");
-        if(isset($all_data["oj"]))      $oj = $all_data["oj"];              else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["headers"])) $headers = $all_data["headers"];    else $headers = [];
-        if(isset($all_data["handle"]))  $handle = $all_data["handle"];      else $handle = "default";
+        if (isset($all_data["site"]))    $site=$all_data["site"]; else throw new Exception("site is not exist in all_data");
+        if (isset($all_data["oj"]))      $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
+        if (isset($all_data["headers"])) $headers=$all_data["headers"]; else $headers=[];
+        if (isset($all_data["handle"]))  $handle=$all_data["handle"]; else $handle="default";
 
         $handle=urlencode($handle);
 
@@ -83,15 +83,15 @@ 
 
     public function post_data($all_data)
     {
-        if(isset($all_data["site"]))         $site = $all_data["site"];                 else throw new Exception("site is not exist in all_data");
-        if(isset($all_data["data"]))         $data = $all_data["data"];                 else throw new Exception("data is not exist in all_data");
-        if(isset($all_data["oj"]))           $oj = $all_data["oj"];                     else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["ret"]))          $ret = $all_data["ret"];                   else $ret = false;
-        if(isset($all_data["follow"]))       $follow = $all_data["follow"];             else $follow = true;
-        if(isset($all_data["returnHeader"])) $returnHeader = $all_data["returnHeader"]; else $returnHeader = true;
-        if(isset($all_data["postJson"]))     $postJson = $all_data["postJson"];         else $postJson = false;
-        if(isset($all_data["extraHeaders"])) $extraHeaders = $all_data["extraHeaders"]; else $extraHeaders = [];
-        if(isset($all_data["handle"]))       $handle = $all_data["handle"];             else $handle = "default";
+        if (isset($all_data["site"]))         $site=$all_data["site"]; else throw new Exception("site is not exist in all_data");
+        if (isset($all_data["data"]))         $data=$all_data["data"]; else throw new Exception("data is not exist in all_data");
+        if (isset($all_data["oj"]))           $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
+        if (isset($all_data["ret"]))          $ret=$all_data["ret"]; else $ret=false;
+        if (isset($all_data["follow"]))       $follow=$all_data["follow"]; else $follow=true;
+        if (isset($all_data["returnHeader"])) $returnHeader=$all_data["returnHeader"]; else $returnHeader=true;
+        if (isset($all_data["postJson"]))     $postJson=$all_data["postJson"]; else $postJson=false;
+        if (isset($all_data["extraHeaders"])) $extraHeaders=$all_data["extraHeaders"]; else $extraHeaders=[];
+        if (isset($all_data["handle"]))       $handle=$all_data["handle"]; else $handle="default";
 
         $handle=urlencode($handle);
 

Braces +90 added lines, -18 removed lines

@@ -18,11 +18,31 @@ 
 
     public function login($all_data)
     {
-        if(isset($all_data["url"]))    $url = $all_data["url"];       else throw new Exception("url is not exist in all_data");
-        if(isset($all_data["data"]))   $data = $all_data["data"];     else throw new Exception("data is not exist in all_data");
-        if(isset($all_data["oj"]))     $oj = $all_data["oj"];         else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["ret"]))    $ret = $all_data["ret"];       else $ret = 'false';
-        if(isset($all_data["handle"])) $handle = $all_data["handle"]; else $handle = "default";
+        if(isset($all_data["url"])) {
+            $url = $all_data["url"];
+        } else {
+            throw new Exception("url is not exist in all_data");
+        }
+        if(isset($all_data["data"])) {
+            $data = $all_data["data"];
+        } else {
+            throw new Exception("data is not exist in all_data");
+        }
+        if(isset($all_data["oj"])) {
+            $oj = $all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if(isset($all_data["ret"])) {
+            $ret = $all_data["ret"];
+        } else {
+            $ret = 'false';
+        }
+        if(isset($all_data["handle"])) {
+            $handle = $all_data["handle"];
+        } else {
+            $handle = "default";
+        }
 
         $datapost=curl_init();
         $headers=array("Expect:");
@@ -54,10 +74,26 @@ 
 
     public function grab_page($all_data)
     {
-        if(isset($all_data["site"]))    $site = $all_data["site"];          else throw new Exception("site is not exist in all_data");
-        if(isset($all_data["oj"]))      $oj = $all_data["oj"];              else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["headers"])) $headers = $all_data["headers"];    else $headers = [];
-        if(isset($all_data["handle"]))  $handle = $all_data["handle"];      else $handle = "default";
+        if(isset($all_data["site"])) {
+            $site = $all_data["site"];
+        } else {
+            throw new Exception("site is not exist in all_data");
+        }
+        if(isset($all_data["oj"])) {
+            $oj = $all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if(isset($all_data["headers"])) {
+            $headers = $all_data["headers"];
+        } else {
+            $headers = [];
+        }
+        if(isset($all_data["handle"])) {
+            $handle = $all_data["handle"];
+        } else {
+            $handle = "default";
+        }
 
         $handle=urlencode($handle);
 
@@ -83,15 +119,51 @@ 
 
     public function post_data($all_data)
     {
-        if(isset($all_data["site"]))         $site = $all_data["site"];                 else throw new Exception("site is not exist in all_data");
-        if(isset($all_data["data"]))         $data = $all_data["data"];                 else throw new Exception("data is not exist in all_data");
-        if(isset($all_data["oj"]))           $oj = $all_data["oj"];                     else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["ret"]))          $ret = $all_data["ret"];                   else $ret = false;
-        if(isset($all_data["follow"]))       $follow = $all_data["follow"];             else $follow = true;
-        if(isset($all_data["returnHeader"])) $returnHeader = $all_data["returnHeader"]; else $returnHeader = true;
-        if(isset($all_data["postJson"]))     $postJson = $all_data["postJson"];         else $postJson = false;
-        if(isset($all_data["extraHeaders"])) $extraHeaders = $all_data["extraHeaders"]; else $extraHeaders = [];
-        if(isset($all_data["handle"]))       $handle = $all_data["handle"];             else $handle = "default";
+        if(isset($all_data["site"])) {
+            $site = $all_data["site"];
+        } else {
+            throw new Exception("site is not exist in all_data");
+        }
+        if(isset($all_data["data"])) {
+            $data = $all_data["data"];
+        } else {
+            throw new Exception("data is not exist in all_data");
+        }
+        if(isset($all_data["oj"])) {
+            $oj = $all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if(isset($all_data["ret"])) {
+            $ret = $all_data["ret"];
+        } else {
+            $ret = false;
+        }
+        if(isset($all_data["follow"])) {
+            $follow = $all_data["follow"];
+        } else {
+            $follow = true;
+        }
+        if(isset($all_data["returnHeader"])) {
+            $returnHeader = $all_data["returnHeader"];
+        } else {
+            $returnHeader = true;
+        }
+        if(isset($all_data["postJson"])) {
+            $postJson = $all_data["postJson"];
+        } else {
+            $postJson = false;
+        }
+        if(isset($all_data["extraHeaders"])) {
+            $extraHeaders = $all_data["extraHeaders"];
+        } else {
+            $extraHeaders = [];
+        }
+        if(isset($all_data["handle"])) {
+            $handle = $all_data["handle"];
+        } else {
+            $handle = "default";
+        }
 
         $handle=urlencode($handle);
 

app/Http/Controllers/Ajax/GroupController.php

Spacing +24 added lines, -24 removed lines

@@ -84,7 +84,7 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
@@ -103,11 +103,11 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
-        if ($all_data["join_policy"] < 1 || $all_data["join_policy"] > 3){
+        if ($all_data["join_policy"]<1 || $all_data["join_policy"]>3) {
             return ResponseModel::err(1007);
         }
 
@@ -121,7 +121,7 @@ 
             'gid' => 'required|integer',
         ]);
 
-        $all_data = $request->all();
+        $all_data=$request->all();
 
         if (!empty($request->file('img')) && $request->file('img')->isValid()) {
             $extension=$request->file('img')->extension();
@@ -133,7 +133,7 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
@@ -171,18 +171,18 @@ 
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
         $target_clearance=$groupModel->judgeClearance($all_data["gid"], $all_data['uid']);
 
-        if($target_clearance == -3){
+        if ($target_clearance==-3) {
             return ResponseModel::err(7004);
         }
 
-        if($target_clearance >= $clearance || $clearance < 2 || $all_data['permission'] >= $clearance){
+        if ($target_clearance>=$clearance || $clearance<2 || $all_data['permission']>=$clearance) {
             return ResponseModel::err(2001);
         }
 
         $groupModel->changeClearance($all_data['uid'], $all_data["gid"], $all_data['permission']);
 
-        $result_info = $groupModel->userProfile($all_data['uid'],$all_data["gid"]);
-        return ResponseModel::success(200,null,$result_info);
+        $result_info=$groupModel->userProfile($all_data['uid'], $all_data["gid"]);
+        return ResponseModel::success(200, null, $result_info);
     }
 
     public function generateContestAccount(Request $request)
@@ -262,7 +262,7 @@ 
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
         $targetClearance=$groupModel->judgeClearance($all_data["gid"], $all_data["uid"]);
         if ($clearance>1) {
-            if($targetClearance!=0) {
+            if ($targetClearance!=0) {
                 return ResponseModel::err(7003);
             }
             $groupModel->changeClearance($all_data["uid"], $all_data["gid"], 1);
@@ -301,11 +301,11 @@ 
 
         $groupModel=new GroupModel();
         $is_user=$groupModel->isUser($all_data["email"]);
-        if(!$is_user) return ResponseModel::err(2006);
+        if (!$is_user) return ResponseModel::err(2006);
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if($clearance<2) return ResponseModel::err(7002);
+        if ($clearance<2) return ResponseModel::err(7002);
         $targetClearance=$groupModel->judgeEmailClearance($all_data["gid"], $all_data["email"]);
-        if($targetClearance!=-3) return ResponseModel::err(7003);
+        if ($targetClearance!=-3) return ResponseModel::err(7003);
         $groupModel->inviteMember($all_data["gid"], $all_data["email"]);
         return ResponseModel::success(200);
     }
@@ -323,9 +323,9 @@ 
         $all_data=$request->all();
 
         $groupModel=new GroupModel();
-        if($all_data["gcode"]=="create") return ResponseModel::err(7005);
+        if ($all_data["gcode"]=="create") return ResponseModel::err(7005);
         $is_group=$groupModel->isGroup($all_data["gcode"]);
-        if($is_group) return ResponseModel::err(7006);
+        if ($is_group) return ResponseModel::err(7006);
 
         $allow_extension=['jpg', 'png', 'jpeg', 'gif', 'bmp'];
         if (!empty($request->file('img')) && $request->file('img')->isValid()) {
@@ -355,7 +355,7 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
         $groupModel->createNotice($all_data["gid"], Auth::user()->id, $all_data["title"], $all_data["content"]);
@@ -374,11 +374,11 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2) {
+        if ($clearance<2) {
             return ResponseModel::err(7002);
         }
-        $tags = $groupModel->problemTags($all_data['gid'],$all_data['pid']);
-        if(in_array($all_data['tag'],$tags)){
+        $tags=$groupModel->problemTags($all_data['gid'], $all_data['pid']);
+        if (in_array($all_data['tag'], $tags)) {
             return ResponseModel::err(7007);
         }
 
@@ -416,20 +416,20 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance > 0) {
-            switch($all_data['mode']){
+        if ($clearance>0) {
+            switch ($all_data['mode']) {
                 case 'contest':
-                    $ret = $groupModel->groupMemberPracticeContestStat($all_data["gid"]);
+                    $ret=$groupModel->groupMemberPracticeContestStat($all_data["gid"]);
                 break;
                 case 'tag':
-                    $ret = $groupModel->groupMemberPracticeTagStat($all_data["gid"]);
+                    $ret=$groupModel->groupMemberPracticeTagStat($all_data["gid"]);
                 break;
                 default:
                     return ResponseModel::err(1007);
                 break;
             }
 
-            return ResponseModel::success(200,null,$ret);
+            return ResponseModel::success(200, null, $ret);
         }
         return ResponseModel::err(7002);
     }

app/Http/Controllers/GroupController.php

Spacing +26 added lines, -26 removed lines

@@ -43,7 +43,7 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if (empty($basic_info)) return Redirect::route('group.index');
         $my_profile=$groupModel->userProfile(Auth::user()->id, $basic_info["gid"]);
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $member_list=$groupModel->userList($basic_info["gid"]);
@@ -88,7 +88,7 @@ 
      */
     public function settings($gcode)
     {
-        return Redirect::route('group.settings.general', ['gcode' => $gcode]);;
+        return Redirect::route('group.settings.general', ['gcode' => $gcode]); ;
     }
 
     /**
@@ -98,7 +98,7 @@ 
      */
     public function settingsReturn($gcode)
     {
-        return Redirect::route('group.detail', ['gcode' => $gcode]);;
+        return Redirect::route('group.detail', ['gcode' => $gcode]); ;
     }
 
     /**
@@ -110,7 +110,7 @@ 
     {
         $groupModel=new GroupModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if (empty($basic_info)) return Redirect::route('group.index');
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $member_list=$groupModel->userList($basic_info["gid"]);
         return view('group.settings.general', [
@@ -128,11 +128,11 @@ 
      *
      * @return Response
      */
-    public function problems($gcode){
-        $groupModel = new GroupModel();
-        $group_info = $groupModel->details($gcode);
-        $problems = $groupModel->problems($group_info['gid']);
-        $allTags = $groupModel->problemTags($group_info['gid'],-1);
+    public function problems($gcode) {
+        $groupModel=new GroupModel();
+        $group_info=$groupModel->details($gcode);
+        $problems=$groupModel->problems($group_info['gid']);
+        $allTags=$groupModel->problemTags($group_info['gid'], -1);
         $basic_info=$groupModel->details($gcode);
         return view('group.settings.problems', [
             'page_title'=>"Group Problems",
@@ -155,7 +155,7 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if (empty($basic_info)) return Redirect::route('group.index');
         return view('group.settings.danger', [
             'page_title'=>"Group Setting danger",
             'site_title'=>config("app.name"),
@@ -169,9 +169,9 @@ 
      *
      * @return Response
      */
-    public function analysis($gcode){
-        $groupModel = new GroupModel();
-        $group_info = $groupModel->details($gcode);
+    public function analysis($gcode) {
+        $groupModel=new GroupModel();
+        $group_info=$groupModel->details($gcode);
         return view('group.settings.analysis', [
             'page_title'=>"Group Analysis",
             'site_title'=>"NOJ",
@@ -191,7 +191,7 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if (empty($basic_info)) return Redirect::route('group.index');
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $member_list=$groupModel->userList($basic_info["gid"]);
         $group_notice=$groupModel->detailNotice($gcode);
@@ -211,7 +211,7 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if (empty($basic_info)) return Redirect::route('group.index');
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $contest_list=$contestModel->listForSetting($basic_info["gid"]);
         $member_list=$groupModel->userList($basic_info["gid"]);
@@ -231,13 +231,13 @@ 
      *
      * @return Response
      */
-    public function analysisDownload($gcode,Request $request){
-        $all_data = $request->all();
-        $groupModel = new GroupModel();
-        $group_info = $groupModel->details($gcode);
-        $mode = $all_data['mode'] ?? 'contest';
-        if($mode == 'contest'){
-            $data = $groupModel->groupMemberPracticeContestStat($group_info['gid']);
+    public function analysisDownload($gcode, Request $request) {
+        $all_data=$request->all();
+        $groupModel=new GroupModel();
+        $group_info=$groupModel->details($gcode);
+        $mode=$all_data['mode'] ?? 'contest';
+        if ($mode=='contest') {
+            $data=$groupModel->groupMemberPracticeContestStat($group_info['gid']);
             return Excel::download(
                 new GroupAnalysisExport(
                     [
@@ -250,10 +250,10 @@ 
                         'percent' => $all_data['percent'] ?? false,
                     ]
                 ),
-                $gcode . '_Group_Contest_Analysis.xlsx'
+                $gcode.'_Group_Contest_Analysis.xlsx'
             );
-        }else{
-            $data = $groupModel->groupMemberPracticeTagStat($group_info['gid']);
+        } else {
+            $data=$groupModel->groupMemberPracticeTagStat($group_info['gid']);
             return Excel::download(
                 new GroupAnalysisExport(
                     [
@@ -266,7 +266,7 @@ 
                         'percent' => $all_data['percent'] ?? false,
                     ]
                 ),
-                $gcode . '_Group_Tag_Analysis.xlsx'
+                $gcode.'_Group_Tag_Analysis.xlsx'
             );
         }
     }

Braces +16 added lines, -6 removed lines

@@ -43,7 +43,9 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if(empty($basic_info)) {
+            return Redirect::route('group.index');
+        }
         $my_profile=$groupModel->userProfile(Auth::user()->id, $basic_info["gid"]);
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $member_list=$groupModel->userList($basic_info["gid"]);
@@ -110,7 +112,9 @@ 
     {
         $groupModel=new GroupModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if(empty($basic_info)) {
+            return Redirect::route('group.index');
+        }
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $member_list=$groupModel->userList($basic_info["gid"]);
         return view('group.settings.general', [
@@ -155,7 +159,9 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if(empty($basic_info)) {
+            return Redirect::route('group.index');
+        }
         return view('group.settings.danger', [
             'page_title'=>"Group Setting danger",
             'site_title'=>config("app.name"),
@@ -191,7 +197,9 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if(empty($basic_info)) {
+            return Redirect::route('group.index');
+        }
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $member_list=$groupModel->userList($basic_info["gid"]);
         $group_notice=$groupModel->detailNotice($gcode);
@@ -211,7 +219,9 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if(empty($basic_info)) {
+            return Redirect::route('group.index');
+        }
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $contest_list=$contestModel->listForSetting($basic_info["gid"]);
         $member_list=$groupModel->userList($basic_info["gid"]);
@@ -252,7 +262,7 @@ 
                 ),
                 $gcode . '_Group_Contest_Analysis.xlsx'
             );
-        }else{
+        } else{
             $data = $groupModel->groupMemberPracticeTagStat($group_info['gid']);
             return Excel::download(
                 new GroupAnalysisExport(