Passed
Pull Request — master (#610)
by John
09:24 queued 03:16
created
app/Http/Controllers/Group/IndexController.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,9 @@
 block discarded – undo
96 96
         $groupModel=new GroupModel();
97 97
         $basic_info=$groupModel->details($gcode);
98 98
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
99
-        if ($clearance<1) return Redirect::route('group.detail', ['gcode' => $gcode]);
99
+        if ($clearance<1) {
100
+            return Redirect::route('group.detail', ['gcode' => $gcode]);
101
+        }
100 102
         $group_info=$groupModel->details($gcode);
101 103
         return view('group.settings.analysis', [
102 104
             'page_title'=>"Group Analysis",
Please login to merge, or discard this patch.
app/Models/GroupModel.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -121,7 +121,9 @@  discard block
 block discarded – undo
121 121
     public function details($gcode)
122 122
     {
123 123
         $basic_info=DB::table($this->tableName)->where(["gcode"=>$gcode])->first();
124
-        if (empty($basic_info)) return [];
124
+        if (empty($basic_info)) {
125
+            return [];
126
+        }
125 127
         $basic_info["members"]=$this->countGroupMembers($basic_info["gid"]);
126 128
         $basic_info["tags"]=$this->getGroupTags($basic_info["gid"]);
127 129
         $basic_info["create_time_foramt"]=date_format(date_create($basic_info["created_at"]), 'M jS, Y');
@@ -169,7 +171,9 @@  discard block
 block discarded – undo
169 171
         foreach ($user_list as &$u) {
170 172
             $u["role_parsed"]=$this->role[$u["role"]];
171 173
             $u["role_color"]=$this->role_color[$u["role"]];
172
-            if (is_null($u["sub_group"])) $u["sub_group"]="None";
174
+            if (is_null($u["sub_group"])) {
175
+                $u["sub_group"]="None";
176
+            }
173 177
         }
174 178
         return $user_list;
175 179
     }
@@ -300,7 +304,9 @@  discard block
 block discarded – undo
300 304
     public function judgeEmailClearance($gid, $email)
301 305
     {
302 306
         $user=DB::table("users")->where(["email"=>$email])->first();
303
-        if (empty($user)) return -4;
307
+        if (empty($user)) {
308
+            return -4;
309
+        }
304 310
         $ret=DB::table("group_member")->where([
305 311
             "gid"=>$gid,
306 312
             "uid"=>$user["id"],
Please login to merge, or discard this patch.
app/Babel/Submit/Curl.php 1 patch
Braces   +105 added lines, -21 removed lines patch added patch discarded remove patch
@@ -18,11 +18,31 @@  discard block
 block discarded – undo
18 18
 
19 19
     public function login($all_data)
20 20
     {
21
-        if (isset($all_data["url"]))    $url=$all_data["url"]; else throw new Exception("url is not exist in all_data");
22
-        if (isset($all_data["data"]))   $data=$all_data["data"]; else throw new Exception("data is not exist in all_data");
23
-        if (isset($all_data["oj"]))     $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
24
-        if (isset($all_data["ret"]))    $ret=$all_data["ret"]; else $ret='false';
25
-        if (isset($all_data["handle"])) $handle=$all_data["handle"]; else $handle="default";
21
+        if (isset($all_data["url"])) {
22
+            $url=$all_data["url"];
23
+        } else {
24
+            throw new Exception("url is not exist in all_data");
25
+        }
26
+        if (isset($all_data["data"])) {
27
+            $data=$all_data["data"];
28
+        } else {
29
+            throw new Exception("data is not exist in all_data");
30
+        }
31
+        if (isset($all_data["oj"])) {
32
+            $oj=$all_data["oj"];
33
+        } else {
34
+            throw new Exception("oj is not exist in all_data");
35
+        }
36
+        if (isset($all_data["ret"])) {
37
+            $ret=$all_data["ret"];
38
+        } else {
39
+            $ret='false';
40
+        }
41
+        if (isset($all_data["handle"])) {
42
+            $handle=$all_data["handle"];
43
+        } else {
44
+            $handle="default";
45
+        }
26 46
 
27 47
         $datapost=curl_init();
28 48
         $headers=array("Expect:");
@@ -54,12 +74,36 @@  discard block
 block discarded – undo
54 74
 
55 75
     public function grab_page($all_data)
56 76
     {
57
-        if (isset($all_data["site"]))    $site=$all_data["site"]; else throw new Exception("site is not exist in all_data");
58
-        if (isset($all_data["oj"]))      $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
59
-        if (isset($all_data["headers"])) $headers=$all_data["headers"]; else $headers=[];
60
-        if (isset($all_data["handle"]))  $handle=$all_data["handle"]; else $handle="default";
61
-        if (isset($all_data["follow"]))  $follow=$all_data["follow"]; else $follow=false;
62
-        if (isset($all_data["vcid"]))  $vcid=$all_data["vcid"]."_"; else $vcid="";
77
+        if (isset($all_data["site"])) {
78
+            $site=$all_data["site"];
79
+        } else {
80
+            throw new Exception("site is not exist in all_data");
81
+        }
82
+        if (isset($all_data["oj"])) {
83
+            $oj=$all_data["oj"];
84
+        } else {
85
+            throw new Exception("oj is not exist in all_data");
86
+        }
87
+        if (isset($all_data["headers"])) {
88
+            $headers=$all_data["headers"];
89
+        } else {
90
+            $headers=[];
91
+        }
92
+        if (isset($all_data["handle"])) {
93
+            $handle=$all_data["handle"];
94
+        } else {
95
+            $handle="default";
96
+        }
97
+        if (isset($all_data["follow"])) {
98
+            $follow=$all_data["follow"];
99
+        } else {
100
+            $follow=false;
101
+        }
102
+        if (isset($all_data["vcid"])) {
103
+            $vcid=$all_data["vcid"]."_";
104
+        } else {
105
+            $vcid="";
106
+        }
63 107
 
64 108
         $handle=urlencode($handle);
65 109
 
@@ -86,16 +130,56 @@  discard block
 block discarded – undo
86 130
 
87 131
     public function post_data($all_data)
88 132
     {
89
-        if (isset($all_data["site"]))         $site=$all_data["site"]; else throw new Exception("site is not exist in all_data");
90
-        if (isset($all_data["data"]))         $data=$all_data["data"]; else throw new Exception("data is not exist in all_data");
91
-        if (isset($all_data["oj"]))           $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
92
-        if (isset($all_data["ret"]))          $ret=$all_data["ret"]; else $ret=false;
93
-        if (isset($all_data["follow"]))       $follow=$all_data["follow"]; else $follow=true;
94
-        if (isset($all_data["returnHeader"])) $returnHeader=$all_data["returnHeader"]; else $returnHeader=true;
95
-        if (isset($all_data["postJson"]))     $postJson=$all_data["postJson"]; else $postJson=false;
96
-        if (isset($all_data["extraHeaders"])) $extraHeaders=$all_data["extraHeaders"]; else $extraHeaders=[];
97
-        if (isset($all_data["handle"]))       $handle=$all_data["handle"]; else $handle="default";
98
-        if (isset($all_data["vcid"]))  $vcid=$all_data["vcid"]."_"; else $vcid="";
133
+        if (isset($all_data["site"])) {
134
+            $site=$all_data["site"];
135
+        } else {
136
+            throw new Exception("site is not exist in all_data");
137
+        }
138
+        if (isset($all_data["data"])) {
139
+            $data=$all_data["data"];
140
+        } else {
141
+            throw new Exception("data is not exist in all_data");
142
+        }
143
+        if (isset($all_data["oj"])) {
144
+            $oj=$all_data["oj"];
145
+        } else {
146
+            throw new Exception("oj is not exist in all_data");
147
+        }
148
+        if (isset($all_data["ret"])) {
149
+            $ret=$all_data["ret"];
150
+        } else {
151
+            $ret=false;
152
+        }
153
+        if (isset($all_data["follow"])) {
154
+            $follow=$all_data["follow"];
155
+        } else {
156
+            $follow=true;
157
+        }
158
+        if (isset($all_data["returnHeader"])) {
159
+            $returnHeader=$all_data["returnHeader"];
160
+        } else {
161
+            $returnHeader=true;
162
+        }
163
+        if (isset($all_data["postJson"])) {
164
+            $postJson=$all_data["postJson"];
165
+        } else {
166
+            $postJson=false;
167
+        }
168
+        if (isset($all_data["extraHeaders"])) {
169
+            $extraHeaders=$all_data["extraHeaders"];
170
+        } else {
171
+            $extraHeaders=[];
172
+        }
173
+        if (isset($all_data["handle"])) {
174
+            $handle=$all_data["handle"];
175
+        } else {
176
+            $handle="default";
177
+        }
178
+        if (isset($all_data["vcid"])) {
179
+            $vcid=$all_data["vcid"]."_";
180
+        } else {
181
+            $vcid="";
182
+        }
99 183
 
100 184
         $handle=urlencode($handle);
101 185
 
Please login to merge, or discard this patch.