App\Http\Controllers\Tool\ImageHostingController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	7	1
A	list()	0	8	1
A	detail()	0	14	3

<?php

namespace App\Http\Controllers\Tool;

use App\Models\Eloquent\Tool\ImageHosting;
use App\Models\Eloquent\User;
use App\Http\Controllers\Controller;
use Auth;

class ImageHostingController extends Controller
{
    /**
     * Show the Image Hosting Create Page.
     *
     * @return Response

The type App\Http\Controllers\Tool\Response was not found. Did you mean Response? If so, make sure to prefix the type with \.

     */
    public function create()
    {
        return view('tool.imagehosting.create', [

The expression return view('tool.imagehosting.create', array('page_title' => 'Create', 'site_title' => 'Image Hosting', 'navigation' => 'Image Hosting', 'permission' => Auth::user()->hasPermission(26))) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Tool\Response.

            'page_title' => "Create",
            'site_title' => "Image Hosting",
            'navigation' => "Image Hosting",
            'permission' => Auth::user()->hasPermission(26)

The method hasPermission() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of said class. However, the method does not exist in Illuminate\Auth\GenericUser. Are you sure you never get one of those?

        ]);
    }

    /**
     * Show the Image Hosting Detail Page.
     *
     * @return Response
     */
    public function detail($id)
    {
        $image=ImageHosting::find($id);
        if (is_null($image)) {
            return abort('404');

The expression return abort('404') returns the type void which is incompatible with the documented return type App\Http\Controllers\Tool\Response.

Are you sure the usage of abort('404') is correct as it seems to always return null.

        }
        if (Auth::user()->id!=$image->user_id) {

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            return abort('403');

Are you sure the usage of abort('403') is correct as it seems to always return null.

The expression return abort('403') returns the type void which is incompatible with the documented return type App\Http\Controllers\Tool\Response.

        }
        return view('tool.imagehosting.detail', [

The expression return view('tool.imagehosting.detail', array('page_title' => 'Detail', 'site_title' => 'Image Hosting', 'navigation' => 'Image Hosting', 'image' => $image)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Tool\Response.

            'page_title' => "Detail",
            'site_title' => "Image Hosting",
            'navigation' => "Image Hosting",
            'image' => $image,
        ]);
    }

    /**
     * Show the Image Hosting List Page.
     *
     * @return Response
     */
    public function list()
    {
        $images=Auth::user()->imagehostings()->orderBy('created_at', 'desc')->get();

The method imagehostings() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of said class. However, the method does not exist in Illuminate\Auth\GenericUser. Are you sure you never get one of those?

        return view('tool.imagehosting.list', [

The expression return view('tool.imagehosting.list', array('page_title' => 'List', 'site_title' => 'Image Hosting', 'navigation' => 'Image Hosting', 'images' => $images)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Tool\Response.

            'page_title' => "List",
            'site_title' => "Image Hosting",
            'navigation' => "Image Hosting",
            'images' => $images,
        ]);
    }
}