ZsgsDesign / NOJ

app/Http/Controllers/Contest/BoardController.php

Spacing +10 added lines, -10 removed lines

@@ -106,8 +106,8 @@ 
             ];
         }
 
-        $editor_left_width = $accountModel->getExtra(Auth::user()->id, 'editor_left_width');
-        if(empty($editor_left_width)) $editor_left_width='40';
+        $editor_left_width=$accountModel->getExtra(Auth::user()->id, 'editor_left_width');
+        if (empty($editor_left_width)) $editor_left_width='40';
 
         return view('contest.board.editor', [
             'page_title'=>"Problem Detail",
@@ -151,14 +151,14 @@ 
 
         // To determine the ranking
         foreach ($contestRank as $i => &$r) {
-            if($i != 0) {
-                if($r['score'] == $contestRank[$i-1]['score'] && $r['penalty'] == $contestRank[$i-1]['penalty']){
-                    $r['rank'] = $contestRank[$i-1]['rank'];
-                }else{
-                    $r['rank'] = $i + 1;
+            if ($i!=0) {
+                if ($r['score']==$contestRank[$i-1]['score'] && $r['penalty']==$contestRank[$i-1]['penalty']) {
+                    $r['rank']=$contestRank[$i-1]['rank'];
+                } else {
+                    $r['rank']=$i+1;
                 }
-            }else{
-                $r['rank'] = 1;
+            } else {
+                $r['rank']=1;
             }
         }
         $rankFrozen=$contestModel->isFrozen($cid);
@@ -278,7 +278,7 @@ 
         ]);
     }
 
-    public function analysis($cid){
+    public function analysis($cid) {
         $contestModel=new ContestModel();
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
         if (!$clearance) {

Braces +5 added lines, -3 removed lines

@@ -107,7 +107,9 @@ 
         }
 
         $editor_left_width = $accountModel->getExtra(Auth::user()->id, 'editor_left_width');
-        if(empty($editor_left_width)) $editor_left_width='40';
+        if(empty($editor_left_width)) {
+            $editor_left_width='40';
+        }
 
         return view('contest.board.editor', [
             'page_title'=>"Problem Detail",
@@ -154,10 +156,10 @@ 
             if($i != 0) {
                 if($r['score'] == $contestRank[$i-1]['score'] && $r['penalty'] == $contestRank[$i-1]['penalty']){
                     $r['rank'] = $contestRank[$i-1]['rank'];
-                }else{
+                } else{
                     $r['rank'] = $i + 1;
                 }
-            }else{
+            } else{
                 $r['rank'] = 1;
             }
         }

app/Http/Controllers/Ajax/GroupManageController.php

Spacing +18 added lines, -18 removed lines

@@ -36,7 +36,7 @@ 
 
         $all_data=$request->all();
 
-        if(($all_data['public'] ?? 0) && ($all_data['practice'] ?? 0)){
+        if (($all_data['public'] ?? 0) && ($all_data['practice'] ?? 0)) {
             return ResponseModel::err(4007);
         }
 
@@ -67,7 +67,7 @@ 
             return ResponseModel::err(1003);
         }
 
-        $cid = $contestModel->arrangeContest($all_data["gid"], [
+        $cid=$contestModel->arrangeContest($all_data["gid"], [
             "assign_uid"=>Auth::user()->id,
             "name"=>$all_data["name"],
             "description"=>$all_data["description"],
@@ -77,7 +77,7 @@ 
             "public"=>$all_data["public"] ?? 0,
         ], $problemSet);
 
-        return ResponseModel::success(200,'Successful!',$cid);
+        return ResponseModel::success(200, 'Successful!', $cid);
     }
 
     public function changeGroupName(Request $request)
@@ -91,7 +91,7 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
@@ -110,11 +110,11 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
-        if ($all_data["join_policy"] < 1 || $all_data["join_policy"] > 3){
+        if ($all_data["join_policy"]<1 || $all_data["join_policy"]>3) {
             return ResponseModel::err(1007);
         }
 
@@ -128,7 +128,7 @@ 
             'gid' => 'required|integer',
         ]);
 
-        $all_data = $request->all();
+        $all_data=$request->all();
 
         if (!empty($request->file('img')) && $request->file('img')->isValid()) {
             $extension=$request->file('img')->extension();
@@ -140,7 +140,7 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
@@ -178,18 +178,18 @@ 
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
         $target_clearance=$groupModel->judgeClearance($all_data["gid"], $all_data['uid']);
 
-        if($target_clearance == -3){
+        if ($target_clearance==-3) {
             return ResponseModel::err(7004);
         }
 
-        if($target_clearance >= $clearance || $clearance < 2 || $all_data['permission'] >= $clearance){
+        if ($target_clearance>=$clearance || $clearance<2 || $all_data['permission']>=$clearance) {
             return ResponseModel::err(2001);
         }
 
         $groupModel->changeClearance($all_data['uid'], $all_data["gid"], $all_data['permission']);
 
-        $result_info = $groupModel->userProfile($all_data['uid'],$all_data["gid"]);
-        return ResponseModel::success(200,null,$result_info);
+        $result_info=$groupModel->userProfile($all_data['uid'], $all_data["gid"]);
+        return ResponseModel::success(200, null, $result_info);
     }
 
     public function approveMember(Request $request)
@@ -205,7 +205,7 @@ 
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
         $targetClearance=$groupModel->judgeClearance($all_data["gid"], $all_data["uid"]);
         if ($clearance>1) {
-            if($targetClearance!=0) {
+            if ($targetClearance!=0) {
                 return ResponseModel::err(7003);
             }
             $groupModel->changeClearance($all_data["uid"], $all_data["gid"], 1);
@@ -226,7 +226,7 @@ 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
         $targetClearance=$groupModel->judgeClearance($all_data["gid"], $all_data["uid"]);
-        if ($clearance <= 1 || $clearance <= $targetClearance){
+        if ($clearance<=1 || $clearance<=$targetClearance) {
             return ResponseModel::err(7002);
         }
 
@@ -246,11 +246,11 @@ 
 
         $groupModel=new GroupModel();
         $is_user=$groupModel->isUser($all_data["email"]);
-        if(!$is_user) return ResponseModel::err(2006);
+        if (!$is_user) return ResponseModel::err(2006);
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if($clearance<2) return ResponseModel::err(7002);
+        if ($clearance<2) return ResponseModel::err(7002);
         $targetClearance=$groupModel->judgeEmailClearance($all_data["gid"], $all_data["email"]);
-        if($targetClearance!=-3) return ResponseModel::err(7003);
+        if ($targetClearance!=-3) return ResponseModel::err(7003);
         $groupModel->inviteMember($all_data["gid"], $all_data["email"]);
         return ResponseModel::success(200);
     }
@@ -287,7 +287,7 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
         $groupModel->createNotice($all_data["gid"], Auth::user()->id, $all_data["title"], $all_data["content"]);

app/Models/GroupModel.php

Spacing +102 added lines, -102 removed lines

@@ -58,10 +58,10 @@ 
         foreach ($trending_groups as &$t) {
             $t["members"]=$this->countGroupMembers($t["gid"]);
         }
-        usort($trending_groups, function ($a, $b) {
+        usort($trending_groups, function($a, $b) {
             return $b["members"]<=>$a["members"];
         });
-        Cache::tags(['group'])->put('trending', array_slice($trending_groups,0,12), 3600*24);
+        Cache::tags(['group'])->put('trending', array_slice($trending_groups, 0, 12), 3600 * 24);
     }
 
     public function userGroups($uid)
@@ -101,13 +101,13 @@ 
 
     public function changeGroupName($gid, $GroupName)
     {
-        return DB::table("group")->where('gid',$gid)->update([
+        return DB::table("group")->where('gid', $gid)->update([
             "name"=>$GroupName
         ]);
     }
 
-    public function changeJoinPolicy($gid, $JoinPolicy){
-        return DB::table("group")->where('gid',$gid)->update([
+    public function changeJoinPolicy($gid, $JoinPolicy) {
+        return DB::table("group")->where('gid', $gid)->update([
             "join_policy"=>$JoinPolicy
         ]);
     }
@@ -115,7 +115,7 @@ 
     public function details($gcode)
     {
         $basic_info=DB::table($this->tableName)->where(["gcode"=>$gcode])->first();
-        if(empty($basic_info)) return [];
+        if (empty($basic_info)) return [];
         $basic_info["members"]=$this->countGroupMembers($basic_info["gid"]);
         $basic_info["tags"]=$this->getGroupTags($basic_info["gid"]);
         $basic_info["create_time_foramt"]=date_format(date_create($basic_info["create_time"]), 'M jS, Y');
@@ -132,10 +132,10 @@ 
     public function userProfile($uid, $gid)
     {
         $info=DB::table("group_member")
-        ->join('users','users.id','=','group_member.uid')
+        ->join('users', 'users.id', '=', 'group_member.uid')
         ->where(["gid"=>$gid, "uid"=>$uid])
         ->where("role", ">", 0)
-        ->select('avatar','describes','email','gid','uid','name','nick_name','professional_rate','role','sub_group')
+        ->select('avatar', 'describes', 'email', 'gid', 'uid', 'name', 'nick_name', 'professional_rate', 'role', 'sub_group')
         ->first();
         if (!empty($info)) {
             $info["role_parsed"]=$this->role[$info["role"]];
@@ -163,7 +163,7 @@ 
         foreach ($user_list as &$u) {
             $u["role_parsed"]=$this->role[$u["role"]];
             $u["role_color"]=$this->role_color[$u["role"]];
-            if(is_null($u["sub_group"])) $u["sub_group"]="None";
+            if (is_null($u["sub_group"])) $u["sub_group"]="None";
         }
         return $user_list;
     }
@@ -224,16 +224,16 @@ 
         ])->where("role", ">", 0)->count();
     }
 
-    public function problemTags($gid,$pid = -1)
+    public function problemTags($gid, $pid=-1)
     {
-        if($pid == -1){
-            $tags =  DB::table('group_problem_tag')
+        if ($pid==-1) {
+            $tags=DB::table('group_problem_tag')
             ->select('tag')
-            ->where('gid',$gid)
+            ->where('gid', $gid)
             ->distinct()
             ->get()->all();
-        }else{
-            $tags =  DB::table('group_problem_tag')
+        } else {
+            $tags=DB::table('group_problem_tag')
             ->select('tag')
             ->where('gid', $gid)
             ->where('pid', $pid)
@@ -241,10 +241,10 @@ 
             ->get()->all();
         }
 
-        $tags_arr = [];
-        if(!empty($tags)){
+        $tags_arr=[];
+        if (!empty($tags)) {
             foreach ($tags as $value) {
-                array_push($tags_arr,$value['tag']);
+                array_push($tags_arr, $value['tag']);
             }
         }
         return $tags_arr;
@@ -252,28 +252,28 @@ 
 
     public function problems($gid)
     {
-        $contestModel = new ContestModel();
-        $problems = DB::table('contest_problem')
-        ->join('contest','contest_problem.cid', '=', 'contest.cid')
-        ->join('problem','contest_problem.pid', '=', 'problem.pid' )
+        $contestModel=new ContestModel();
+        $problems=DB::table('contest_problem')
+        ->join('contest', 'contest_problem.cid', '=', 'contest.cid')
+        ->join('problem', 'contest_problem.pid', '=', 'problem.pid')
         ->select('contest_problem.cid as cid', 'problem.pid as pid', 'pcode', 'title')
-        ->where('contest.gid',$gid)
-        ->where('contest.practice',1)
-        ->orderBy('contest.create_time','desc')
+        ->where('contest.gid', $gid)
+        ->where('contest.practice', 1)
+        ->orderBy('contest.create_time', 'desc')
         ->distinct()
         ->get()->all();
-        $user_id = Auth::user()->id;
-        foreach($problems as $key => $value){
-            if($contestModel->judgeClearance($value['cid'],$user_id) != 3){
+        $user_id=Auth::user()->id;
+        foreach ($problems as $key => $value) {
+            if ($contestModel->judgeClearance($value['cid'], $user_id)!=3) {
                 unset($problems[$key]);
-            }else{
-                $problems[$key]['tags'] = $this->problemTags($gid,$value['pid']);
+            } else {
+                $problems[$key]['tags']=$this->problemTags($gid, $value['pid']);
             }
         }
         return $problems;
     }
 
-    public function problemAddTag($gid,$pid,$tag)
+    public function problemAddTag($gid, $pid, $tag)
     {
         return DB::table("group_problem_tag")->insert([
             "gid"=>$gid,
@@ -282,7 +282,7 @@ 
         ]);
     }
 
-    public function problemRemoveTag($gid,$pid,$tag)
+    public function problemRemoveTag($gid, $pid, $tag)
     {
         return DB::table("group_problem_tag")->where([
             "gid"=>$gid,
@@ -327,7 +327,7 @@ 
     public function judgeEmailClearance($gid, $email)
     {
         $user=DB::table("users")->where(["email"=>$email])->first();
-        if(empty($user)) return -4;
+        if (empty($user)) return -4;
         $ret=DB::table("group_member")->where([
             "gid"=>$gid,
             "uid"=>$user["id"],
@@ -418,20 +418,20 @@ 
 
     public function groupMemberPracticeContestStat($gid)
     {
-        $contestModel = new ContestModel();
+        $contestModel=new ContestModel();
 
-        $allPracticeContest = DB::table('contest')
+        $allPracticeContest=DB::table('contest')
             ->where([
                 'gid' => $gid,
                 'practice' => 1,
             ])
-            ->select('cid','name')
+            ->select('cid', 'name')
             ->get()->all();
-        $user_list = $this->userList($gid);
+        $user_list=$this->userList($gid);
 
-        $memberData = [];
+        $memberData=[];
         foreach ($user_list as $u) {
-            $memberData[$u['uid']] = [
+            $memberData[$u['uid']]=[
                 'name' => $u['name'],
                 'nick_name' => $u['nick_name'],
                 'elo' => $u['ranking'],
@@ -442,60 +442,60 @@ 
             ];
         }
         foreach ($allPracticeContest as $c) {
-            $contestRankRaw = $contestModel->contestRank($c['cid']);
-            foreach($contestRankRaw as $key => $contestRank){
-                if(isset($contestRank['remote']) && $contestRank['remote']){
+            $contestRankRaw=$contestModel->contestRank($c['cid']);
+            foreach ($contestRankRaw as $key => $contestRank) {
+                if (isset($contestRank['remote']) && $contestRank['remote']) {
                     unset($contestRankRaw[$key]);
                 }
             }
-            $contestRank = array_values($contestRankRaw);
-            $problemsCount = DB::table('contest_problem')
-                ->where('cid',$c['cid'])
+            $contestRank=array_values($contestRankRaw);
+            $problemsCount=DB::table('contest_problem')
+                ->where('cid', $c['cid'])
                 ->count();
-            $index = 1;
-            $last_cr = [];
-            $last_rank = 1;
+            $index=1;
+            $last_cr=[];
+            $last_rank=1;
             foreach ($contestRank as $cr) {
-                $last_rank = $index;
-                if(!empty($last_cr)){
-                    if($cr['solved'] == $last_cr['solved'] && $cr['penalty'] == $last_cr['penalty'] ){
-                        $rank = $last_rank;
-                    }else{
-                        $rank = $index;
-                        $last_rank = $rank;
+                $last_rank=$index;
+                if (!empty($last_cr)) {
+                    if ($cr['solved']==$last_cr['solved'] && $cr['penalty']==$last_cr['penalty']) {
+                        $rank=$last_rank;
+                    } else {
+                        $rank=$index;
+                        $last_rank=$rank;
                     }
                 }
-                if(in_array($cr['uid'],array_keys($memberData))) {
-                    $memberData[$cr['uid']]['solved_all'] += $cr['solved'];
-                    $memberData[$cr['uid']]['problem_all'] += $problemsCount;
-                    $memberData[$cr['uid']]['penalty'] += $cr['penalty'];
-                    $memberData[$cr['uid']]['contest_detial'][$c['cid']] = [
+                if (in_array($cr['uid'], array_keys($memberData))) {
+                    $memberData[$cr['uid']]['solved_all']+=$cr['solved'];
+                    $memberData[$cr['uid']]['problem_all']+=$problemsCount;
+                    $memberData[$cr['uid']]['penalty']+=$cr['penalty'];
+                    $memberData[$cr['uid']]['contest_detial'][$c['cid']]=[
                         'rank' => $rank ?? 1,
                         'solved' => $cr['solved'],
                         'problems' => $problemsCount,
                         'penalty' => $cr['penalty']
                     ];
                 }
-                $last_cr = $cr;
+                $last_cr=$cr;
                 $index++;
             }
         }
-        $new_memberData = [];
+        $new_memberData=[];
         foreach ($memberData as $uid => $data) {
-            $contest_count = 0;
-            $rank_sum = 0;
+            $contest_count=0;
+            $rank_sum=0;
             foreach ($data['contest_detial'] as $cid => $c) {
-                $rank_sum += $c['rank'];
-                $contest_count += 1;
+                $rank_sum+=$c['rank'];
+                $contest_count+=1;
             }
-            $temp = $data;
-            $temp['uid'] = $uid;
-            if($contest_count != 0){
-                $temp['rank_ave'] = $rank_sum/$contest_count;
+            $temp=$data;
+            $temp['uid']=$uid;
+            if ($contest_count!=0) {
+                $temp['rank_ave']=$rank_sum / $contest_count;
             }
-            array_push($new_memberData,$temp);
+            array_push($new_memberData, $temp);
         }
-        $ret = [
+        $ret=[
             'contest_list' => $allPracticeContest,
             'member_data' => $new_memberData
         ];
@@ -504,58 +504,58 @@ 
 
     public function groupMemberPracticeTagStat($gid)
     {
-        $tags = $this->problemTags($gid);
-        $tag_problems = [];
+        $tags=$this->problemTags($gid);
+        $tag_problems=[];
 
-        $user_list = $this->userList($gid);
+        $user_list=$this->userList($gid);
         foreach ($tags as $tag) {
-            $tag_problems[$tag] = DB::table('problem')
-                ->join('group_problem_tag','problem.pid','=','group_problem_tag.pid')
+            $tag_problems[$tag]=DB::table('problem')
+                ->join('group_problem_tag', 'problem.pid', '=', 'group_problem_tag.pid')
                 ->where([
                     'group_problem_tag.gid' => $gid,
                     'tag' => $tag
                 ])
-                ->select('group_problem_tag.pid as pid','pcode','title')
+                ->select('group_problem_tag.pid as pid', 'pcode', 'title')
                 ->get()->all();
         }
-        $all_problems = [];
+        $all_problems=[];
         foreach ($tag_problems as &$tag_problem_set) {
             foreach ($tag_problem_set as $problem) {
-                $all_problems[$problem['pid']] = $problem;
+                $all_problems[$problem['pid']]=$problem;
             }
-            $tag_problem_set = array_column($tag_problem_set,'pid');
+            $tag_problem_set=array_column($tag_problem_set, 'pid');
         }
-        $submission_data =  DB::table('submission')
-            ->whereIn('pid',array_keys($all_problems))
-            ->whereIn('uid',array_column($user_list,'uid'))
-            ->where('verdict','Accepted')
-            ->select('pid','uid')
+        $submission_data=DB::table('submission')
+            ->whereIn('pid', array_keys($all_problems))
+            ->whereIn('uid', array_column($user_list, 'uid'))
+            ->where('verdict', 'Accepted')
+            ->select('pid', 'uid')
             ->get()->all();
 
-        $memberData = [];
+        $memberData=[];
         foreach ($user_list as $member) {
-            $completion = [];
-            foreach($tag_problems as $tag => $problems) {
-                $completion[$tag] = [];
+            $completion=[];
+            foreach ($tag_problems as $tag => $problems) {
+                $completion[$tag]=[];
                 foreach ($problems as $problem) {
-                    $is_accepted = 0;
+                    $is_accepted=0;
                     foreach ($submission_data as $sd) {
-                        if($sd['pid'] == $problem && $sd['uid'] == $member['uid']){
-                            $is_accepted = 1;
+                        if ($sd['pid']==$problem && $sd['uid']==$member['uid']) {
+                            $is_accepted=1;
                             break;
                         }
                     }
-                    $completion[$tag][$problem] = $is_accepted;
+                    $completion[$tag][$problem]=$is_accepted;
                 }
             }
-            array_push($memberData,[
+            array_push($memberData, [
                 'uid' => $member['uid'],
                 'name' => $member['name'],
                 'nick_name' => $member['nick_name'],
                 'completion' => $completion,
             ]);
         }
-        $ret = [
+        $ret=[
             'all_problems' => $all_problems,
             'tag_problems' => $tag_problems,
             'member_data' => $memberData
@@ -566,29 +566,29 @@ 
     public function refreshElo($gid)
     {
         DB::table('group_rated_change_log')
-            ->where('gid',$gid)
+            ->where('gid', $gid)
             ->delete();
         DB::table('group_member')
-            ->where('gid',$gid)
+            ->where('gid', $gid)
             ->update([
                 'ranking' => 1500
             ]);
-        $contests = DB::table('contest')
+        $contests=DB::table('contest')
             ->where([
                 'gid' => $gid,
                 'practice' => 1
             ])
-            ->where('end_time','<',date("Y-m-d H:i:s"))
+            ->where('end_time', '<', date("Y-m-d H:i:s"))
             ->select('cid')
             ->orderBy('end_time')
             ->get()->all();
 
-        if(empty($contests)) {
+        if (empty($contests)) {
             return true;
         }
 
         foreach ($contests as $contest) {
-            $calc = new GroupRatingCalculator($contest['cid']);
+            $calc=new GroupRatingCalculator($contest['cid']);
             $calc->calculate();
             $calc->storage();
         }

Braces +12 added lines, -6 removed lines

@@ -115,7 +115,9 @@ 
     public function details($gcode)
     {
         $basic_info=DB::table($this->tableName)->where(["gcode"=>$gcode])->first();
-        if(empty($basic_info)) return [];
+        if(empty($basic_info)) {
+            return [];
+        }
         $basic_info["members"]=$this->countGroupMembers($basic_info["gid"]);
         $basic_info["tags"]=$this->getGroupTags($basic_info["gid"]);
         $basic_info["create_time_foramt"]=date_format(date_create($basic_info["create_time"]), 'M jS, Y');
@@ -163,7 +165,9 @@ 
         foreach ($user_list as &$u) {
             $u["role_parsed"]=$this->role[$u["role"]];
             $u["role_color"]=$this->role_color[$u["role"]];
-            if(is_null($u["sub_group"])) $u["sub_group"]="None";
+            if(is_null($u["sub_group"])) {
+                $u["sub_group"]="None";
+            }
         }
         return $user_list;
     }
@@ -232,7 +236,7 @@ 
             ->where('gid',$gid)
             ->distinct()
             ->get()->all();
-        }else{
+        } else{
             $tags =  DB::table('group_problem_tag')
             ->select('tag')
             ->where('gid', $gid)
@@ -266,7 +270,7 @@ 
         foreach($problems as $key => $value){
             if($contestModel->judgeClearance($value['cid'],$user_id) != 3){
                 unset($problems[$key]);
-            }else{
+            } else{
                 $problems[$key]['tags'] = $this->problemTags($gid,$value['pid']);
             }
         }
@@ -327,7 +331,9 @@ 
     public function judgeEmailClearance($gid, $email)
     {
         $user=DB::table("users")->where(["email"=>$email])->first();
-        if(empty($user)) return -4;
+        if(empty($user)) {
+            return -4;
+        }
         $ret=DB::table("group_member")->where([
             "gid"=>$gid,
             "uid"=>$user["id"],
@@ -460,7 +466,7 @@ 
                 if(!empty($last_cr)){
                     if($cr['solved'] == $last_cr['solved'] && $cr['penalty'] == $last_cr['penalty'] ){
                         $rank = $last_rank;
-                    }else{
+                    } else{
                         $rank = $index;
                         $last_rank = $rank;
                     }

app/Models/Rating/GroupRatingCalculator.php

Spacing +85 added lines, -85 removed lines

@@ -14,37 +14,37 @@ 
     public $totParticipants=0;
     public $INITIAL_RATING=1500;
 
-    public function __construct($cid){
-        $contestModel = new ContestModel();
-        $this->cid = $cid;
-        $this->gid = $contestModel->gid($cid);
+    public function __construct($cid) {
+        $contestModel=new ContestModel();
+        $this->cid=$cid;
+        $this->gid=$contestModel->gid($cid);
         // get rank
         $this->getRecord();
     }
 
-    private function getRecord(){
-        $contestModel = new ContestModel();
-        $contestRankRaw = $contestModel->contestRank($this->cid);
-        foreach($contestRankRaw as $key => $contestRank){
-            if(isset($contestRank['remote']) && $contestRank['remote']){
+    private function getRecord() {
+        $contestModel=new ContestModel();
+        $contestRankRaw=$contestModel->contestRank($this->cid);
+        foreach ($contestRankRaw as $key => $contestRank) {
+            if (isset($contestRank['remote']) && $contestRank['remote']) {
                 unset($contestRankRaw[$key]);
             }
         }
-        $contestRankRaw = array_values($contestRankRaw);
-        $this->totParticipants = count($contestRankRaw);
-        $members = array_column($contestRankRaw,'uid');
-        $ratings_temp = DB::table('group_member')
+        $contestRankRaw=array_values($contestRankRaw);
+        $this->totParticipants=count($contestRankRaw);
+        $members=array_column($contestRankRaw, 'uid');
+        $ratings_temp=DB::table('group_member')
             ->where([
                 'gid' => $this->gid,
-            ])->whereIn('uid',$members)
-            ->select('uid','ranking')
+            ])->whereIn('uid', $members)
+            ->select('uid', 'ranking')
             ->get()->all();
-        $ratings = [];
+        $ratings=[];
         foreach ($ratings_temp as $rating) {
-            $ratings[$rating['uid']] = $rating['ranking'];
+            $ratings[$rating['uid']]=$rating['ranking'];
         }
-        foreach($contestRankRaw as $c){
-            if(!isset($ratings[$c['uid']])){
+        foreach ($contestRankRaw as $c) {
+            if (!isset($ratings[$c['uid']])) {
                 continue;
             }
             $this->contestants[]=[
@@ -55,84 +55,84 @@ 
         }
     }
 
-    private function reassignRank(){
+    private function reassignRank() {
         $this->sort("points");
-        $idx = 0;
-        $points = $this->contestants[0]["points"];
-        $i = 1;
-        while($i < $this->totParticipants){
-            if($this->contestants[$i]["points"] < $points){
-                $j = $idx;
-                while($j < $i){
-                    $this->contestants[$j]["rank"] = $i;
-                    $j += 1;
+        $idx=0;
+        $points=$this->contestants[0]["points"];
+        $i=1;
+        while ($i<$this->totParticipants) {
+            if ($this->contestants[$i]["points"]<$points) {
+                $j=$idx;
+                while ($j<$i) {
+                    $this->contestants[$j]["rank"]=$i;
+                    $j+=1;
                 }
-                $idx = $i;
-                $points = $this->contestants[$i]["points"];
+                $idx=$i;
+                $points=$this->contestants[$i]["points"];
             }
-            $i += 1;
+            $i+=1;
         }
-        $j = $idx;
-        while($j < $this->totParticipants){
-            $this->contestants[$j]["rank"] = $this->totParticipants;
-            $j += 1;
+        $j=$idx;
+        while ($j<$this->totParticipants) {
+            $this->contestants[$j]["rank"]=$this->totParticipants;
+            $j+=1;
         }
     }
 
-    private function getEloWinProbability($Ra, $Rb){
-        return 1.0 / (1 + pow(10, ($Rb-$Ra)/400.0));
+    private function getEloWinProbability($Ra, $Rb) {
+        return 1.0 / (1+pow(10, ($Rb-$Ra) / 400.0));
     }
 
-    private function getSeed($rating){
-        $result = 1.0;
-        foreach($this->contestants as $other){
-            $result += $this->getEloWinProbability($other["rating"], $rating);
+    private function getSeed($rating) {
+        $result=1.0;
+        foreach ($this->contestants as $other) {
+            $result+=$this->getEloWinProbability($other["rating"], $rating);
         }
         return $result;
     }
 
-    private function getRatingToRank($rank){
+    private function getRatingToRank($rank) {
         $left=1;
         $right=8000;
-        while($right - $left > 1){
-            $mid = floor(($right + $left)/2);
-            if($this->getSeed($mid) < $rank){
-                $right = $mid;
-            }else{
-                $left = $mid;
+        while ($right-$left>1) {
+            $mid=floor(($right+$left) / 2);
+            if ($this->getSeed($mid)<$rank) {
+                $right=$mid;
+            } else {
+                $left=$mid;
             }
         }
         return $left;
     }
 
-    private function sort($key){
-        usort($this->contestants, function ($a, $b) use ($key) {
+    private function sort($key) {
+        usort($this->contestants, function($a, $b) use ($key) {
             return $b[$key] <=> $a[$key];
         });
     }
 
-    public function calculate(){
-        if(empty($this->contestants)){
+    public function calculate() {
+        if (empty($this->contestants)) {
             return;
         }
 
         // recalc rank
         $this->reassignRank();
 
-        foreach($this->contestants as &$member){
-            $member["seed"] = 1.0;
-            foreach($this->contestants as $other){
-                if($member["uid"] != $other["uid"]){
-                    $member["seed"] += $this->getEloWinProbability($other["rating"], $member["rating"]);
+        foreach ($this->contestants as &$member) {
+            $member["seed"]=1.0;
+            foreach ($this->contestants as $other) {
+                if ($member["uid"]!=$other["uid"]) {
+                    $member["seed"]+=$this->getEloWinProbability($other["rating"], $member["rating"]);
                 }
             }
         }
         unset($member);
 
-        foreach($this->contestants as &$contestant){
-            $midRank = sqrt($contestant["rank"] * $contestant["seed"]);
-            $contestant["needRating"] = $this->getRatingToRank($midRank);
-            $contestant["delta"] = floor(($contestant["needRating"] - $contestant["rating"])/2);
+        foreach ($this->contestants as &$contestant) {
+            $midRank=sqrt($contestant["rank"] * $contestant["seed"]);
+            $contestant["needRating"]=$this->getRatingToRank($midRank);
+            $contestant["delta"]=floor(($contestant["needRating"]-$contestant["rating"]) / 2);
         }
         unset($contestant);
 
@@ -140,39 +140,39 @@ 
 
         // DO some adjuct
         // Total sum should not be more than ZERO.
-        $sum = 0;
+        $sum=0;
 
-        foreach($this->contestants as $contestant){
-            $sum += $contestant["delta"];
+        foreach ($this->contestants as $contestant) {
+            $sum+=$contestant["delta"];
         }
-        $inc = -floor($sum / $this->totParticipants) - 1;
-        foreach($this->contestants as &$contestant){
-            $contestant["delta"] += $inc;
+        $inc=-floor($sum / $this->totParticipants)-1;
+        foreach ($this->contestants as &$contestant) {
+            $contestant["delta"]+=$inc;
         }
         unset($contestant);
 
         // Sum of top-4*sqrt should be adjusted to ZERO.
 
-        $sum = 0;
-        $zeroSumCount = min(intval(4*round(sqrt($this->totParticipants))), $this->totParticipants);
+        $sum=0;
+        $zeroSumCount=min(intval(4 * round(sqrt($this->totParticipants))), $this->totParticipants);
 
-        for($i=0;$i<$zeroSumCount;$i++){
-            $sum += $this->contestants[$i]["delta"];
+        for ($i=0; $i<$zeroSumCount; $i++) {
+            $sum+=$this->contestants[$i]["delta"];
         }
 
-        $inc = min(max(-floor($sum / $zeroSumCount), -10), 0);
+        $inc=min(max(-floor($sum / $zeroSumCount), -10), 0);
 
-        for($i=0;$i<$zeroSumCount;$i++){
-            $this->contestants[$i]["delta"] += $inc;
+        for ($i=0; $i<$zeroSumCount; $i++) {
+            $this->contestants[$i]["delta"]+=$inc;
         }
 
         return $this->validateDeltas();
     }
 
-    public function storage(){
+    public function storage() {
         $contestants=$this->contestants;
-        DB::transaction(function () use ($contestants) {
-            foreach($contestants as $contestant){
+        DB::transaction(function() use ($contestants) {
+            foreach ($contestants as $contestant) {
                 $newRating=$contestant["rating"]+$contestant["delta"];
                 DB::table("group_member")->where([
                     'gid' => $this->gid,
@@ -190,20 +190,20 @@ 
         }, 5);
     }
 
-    private function validateDeltas(){
+    private function validateDeltas() {
         $this->sort("points");
 
-        for($i=0;$i<$this->totParticipants;$i++){
-            for($j=$i+1;$j<$this->totParticipants;$j++){
-                if($this->contestants[$i]["rating"] > $this->contestants[$j]["rating"]){
-                    if($this->contestants[$i]["rating"] + $this->contestants[$i]["delta"] < $this->contestants[$j]["rating"] + $this->contestants[$j]["delta"]){
+        for ($i=0; $i<$this->totParticipants; $i++) {
+            for ($j=$i+1; $j<$this->totParticipants; $j++) {
+                if ($this->contestants[$i]["rating"]>$this->contestants[$j]["rating"]) {
+                    if ($this->contestants[$i]["rating"]+$this->contestants[$i]["delta"]<$this->contestants[$j]["rating"]+$this->contestants[$j]["delta"]) {
                         Log::warning("First rating invariant failed: {$this->contestants[$i]["uid"]} vs. {$this->contestants[$j]["uid"]}.");
                         return false;
                     }
                 }
 
-                if($this->contestants[$i]["rating"] < $this->contestants[$j]["rating"]){
-                    if($this->contestants[$i]["delta"] < $this->contestants[$j]["delta"]){
+                if ($this->contestants[$i]["rating"]<$this->contestants[$j]["rating"]) {
+                    if ($this->contestants[$i]["delta"]<$this->contestants[$j]["delta"]) {
                         Log::warning("Second rating invariant failed: {$this->contestants[$i]["uid"]} vs.  {$this->contestants[$j]["uid"]}.");
                         return false;
                     }