View GitHub Repository NOJ

Schedule Inspection
Subscribe
Passed
Branch — dev (6ac00b)
by John
04:53
created
Status
Category
Toggle Patches
app/Http/Controllers/Group/IndexController.php 2 patches
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch 
@@ -43,7 +43,7 @@  discard block
 
 block discarded – undo
43 43 
         $groupModel=new GroupModel();
44 44 
         $contestModel=new ContestModel();
45 45 
         $basic_info=$groupModel->details($gcode);
46 
-        if(empty($basic_info)) return Redirect::route('group.index');
46 
+        if (empty($basic_info)) return Redirect::route('group.index');
47 47 
         $my_profile=$groupModel->userProfile(Auth::user()->id, $basic_info["gid"]);
48 48 
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
49 49 
         $member_list=$groupModel->userList($basic_info["gid"]);
 
@@ -86,9 +86,9 @@  discard block
 
 block discarded – undo
86 86 
      *
87 87 
      * @return Response
88 88 
      */
89 
-    public function analysis($gcode){
90 
-        $groupModel = new GroupModel();
91 
-        $group_info = $groupModel->details($gcode);
89 
+    public function analysis($gcode) {
90 
+        $groupModel=new GroupModel();
91 
+        $group_info=$groupModel->details($gcode);
92 92 
         return view('group.settings.analysis', [
93 93 
             'page_title'=>"Group Analysis",
94 94 
             'site_title'=>"NOJ",
 
@@ -98,13 +98,13 @@  discard block
 
 block discarded – undo
98 98 
         ]);
99 99 
     }
100 100
101 
-    public function analysisDownload($gcode,Request $request){
102 
-        $all_data = $request->all();
103 
-        $groupModel = new GroupModel();
104 
-        $group_info = $groupModel->details($gcode);
105 
-        $mode = $all_data['mode'] ?? 'contest';
106 
-        if($mode == 'contest'){
107 
-            $data = $groupModel->groupMemberPracticeContestStat($group_info['gid']);
101 
+    public function analysisDownload($gcode, Request $request) {
102 
+        $all_data=$request->all();
103 
+        $groupModel=new GroupModel();
104 
+        $group_info=$groupModel->details($gcode);
105 
+        $mode=$all_data['mode'] ?? 'contest';
106 
+        if ($mode=='contest') {
107 
+            $data=$groupModel->groupMemberPracticeContestStat($group_info['gid']);
108 108 
             return Excel::download(
109 109 
                 new GroupAnalysisExport(
110 110 
                     [
 
@@ -117,10 +117,10 @@  discard block
 
 block discarded – undo
117 117 
                         'percent' => $all_data['percent'] ?? false,
118 118 
                     ]
119 119 
                 ),
120 
-                $gcode . '_Group_Contest_Analysis.xlsx'
120 
+                $gcode.'_Group_Contest_Analysis.xlsx'
121 121 
             );
122 
-        }else{
123 
-            $data = $groupModel->groupMemberPracticeTagStat($group_info['gid']);
122 
+        } else {
123 
+            $data=$groupModel->groupMemberPracticeTagStat($group_info['gid']);
124 124 
             return Excel::download(
125 125 
                 new GroupAnalysisExport(
126 126 
                     [
 
@@ -133,7 +133,7 @@  discard block
 
 block discarded – undo
133 133 
                         'percent' => $all_data['percent'] ?? false,
134 134 
                     ]
135 135 
                 ),
136 
-                $gcode . '_Group_Tag_Analysis.xlsx'
136 
+                $gcode.'_Group_Tag_Analysis.xlsx'
137 137 
             );
138 138 
         }
139 139 
     }
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -43,7 +43,9 @@  discard block
 
 block discarded – undo
43 43 
         $groupModel=new GroupModel();
44 44 
         $contestModel=new ContestModel();
45 45 
         $basic_info=$groupModel->details($gcode);
46 
-        if(empty($basic_info)) return Redirect::route('group.index');
46 
+        if(empty($basic_info)) {
47 
+            return Redirect::route('group.index');
48 
+        }
47 49 
         $my_profile=$groupModel->userProfile(Auth::user()->id, $basic_info["gid"]);
48 50 
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
49 51 
         $member_list=$groupModel->userList($basic_info["gid"]);
 
@@ -119,7 +121,7 @@  discard block
 
 block discarded – undo
119 121 
                 ),
120 122 
                 $gcode . '_Group_Contest_Analysis.xlsx'
121 123 
             );
122 
-        }else{
124 
+        } else{
123 125 
             $data = $groupModel->groupMemberPracticeTagStat($group_info['gid']);
124 126 
             return Excel::download(
125 127 
                 new GroupAnalysisExport(
Please login to merge, or discard this patch.
app/Http/Controllers/Group/AdminController.php 2 patches
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -21,7 +21,7 @@  discard block
 
 block discarded – undo
21 21 
      */
22 22 
     public function settings($gcode)
23 23 
     {
24 
-        return Redirect::route('group.settings.general', ['gcode' => $gcode]);;
24 
+        return Redirect::route('group.settings.general', ['gcode' => $gcode]); ;
25 25 
     }
26 26
27 27 
     /**
 
@@ -31,7 +31,7 @@  discard block
 
 block discarded – undo
31 31 
      */
32 32 
     public function settingsReturn($gcode)
33 33 
     {
34 
-        return Redirect::route('group.detail', ['gcode' => $gcode]);;
34 
+        return Redirect::route('group.detail', ['gcode' => $gcode]); ;
35 35 
     }
36 36
37 37 
     /**
 
@@ -43,7 +43,7 @@  discard block
 
 block discarded – undo
43 43 
     {
44 44 
         $groupModel=new GroupModel();
45 45 
         $basic_info=$groupModel->details($gcode);
46 
-        if(empty($basic_info)) return Redirect::route('group.index');
46 
+        if (empty($basic_info)) return Redirect::route('group.index');
47 47 
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
48 48 
         $member_list=$groupModel->userList($basic_info["gid"]);
49 49 
         return view('group.settings.general', [
 
@@ -61,10 +61,10 @@  discard block
 
 block discarded – undo
61 61 
      *
62 62 
      * @return Response
63 63 
      */
64 
-    public function problems($gcode){
65 
-        $groupModel = new GroupModel();
66 
-        $group_info = $groupModel->details($gcode);
67 
-        $problems = $groupModel->problems($group_info['gid']);
64 
+    public function problems($gcode) {
65 
+        $groupModel=new GroupModel();
66 
+        $group_info=$groupModel->details($gcode);
67 
+        $problems=$groupModel->problems($group_info['gid']);
68 68 
         $basic_info=$groupModel->details($gcode);
69 69 
         return view('group.settings.problems', [
70 70 
             'page_title'=>"Group Problems",
 
@@ -85,7 +85,7 @@  discard block
 
 block discarded – undo
85 85 
     {
86 86 
         $groupModel=new GroupModel();
87 87 
         $basic_info=$groupModel->details($gcode);
88 
-        if(empty($basic_info)) return Redirect::route('group.index');
88 
+        if (empty($basic_info)) return Redirect::route('group.index');
89 89 
         return view('group.settings.danger', [
90 90 
             'page_title'=>"Group Setting danger",
91 91 
             'site_title'=>config("app.name"),
 
@@ -104,7 +104,7 @@  discard block
 
 block discarded – undo
104 104 
         $groupModel=new GroupModel();
105 105 
         $contestModel=new ContestModel();
106 106 
         $basic_info=$groupModel->details($gcode);
107 
-        if(empty($basic_info)) return Redirect::route('group.index');
107 
+        if (empty($basic_info)) return Redirect::route('group.index');
108 108 
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
109 109 
         $member_list=$groupModel->userList($basic_info["gid"]);
110 110 
         $group_notice=$groupModel->detailNotice($gcode);
 
@@ -124,7 +124,7 @@  discard block
 
 block discarded – undo
124 124 
         $groupModel=new GroupModel();
125 125 
         $contestModel=new ContestModel();
126 126 
         $basic_info=$groupModel->details($gcode);
127 
-        if(empty($basic_info)) return Redirect::route('group.index');
127 
+        if (empty($basic_info)) return Redirect::route('group.index');
128 128 
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
129 129 
         $contest_list=$contestModel->listForSetting($basic_info["gid"]);
130 130 
         $member_list=$groupModel->userList($basic_info["gid"]);
Please login to merge, or discard this patch.
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -43,7 +43,9 @@  discard block
 
 block discarded – undo
43 43 
     {
44 44 
         $groupModel=new GroupModel();
45 45 
         $basic_info=$groupModel->details($gcode);
46 
-        if(empty($basic_info)) return Redirect::route('group.index');
46 
+        if(empty($basic_info)) {
47 
+            return Redirect::route('group.index');
48 
+        }
47 49 
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
48 50 
         $member_list=$groupModel->userList($basic_info["gid"]);
49 51 
         return view('group.settings.general', [
 
@@ -85,7 +87,9 @@  discard block
 
 block discarded – undo
85 87 
     {
86 88 
         $groupModel=new GroupModel();
87 89 
         $basic_info=$groupModel->details($gcode);
88 
-        if(empty($basic_info)) return Redirect::route('group.index');
90 
+        if(empty($basic_info)) {
91 
+            return Redirect::route('group.index');
92 
+        }
89 93 
         return view('group.settings.danger', [
90 94 
             'page_title'=>"Group Setting danger",
91 95 
             'site_title'=>config("app.name"),
 
@@ -104,7 +108,9 @@  discard block
 
 block discarded – undo
104 108 
         $groupModel=new GroupModel();
105 109 
         $contestModel=new ContestModel();
106 110 
         $basic_info=$groupModel->details($gcode);
107 
-        if(empty($basic_info)) return Redirect::route('group.index');
111 
+        if(empty($basic_info)) {
112 
+            return Redirect::route('group.index');
113 
+        }
108 114 
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
109 115 
         $member_list=$groupModel->userList($basic_info["gid"]);
110 116 
         $group_notice=$groupModel->detailNotice($gcode);
 
@@ -124,7 +130,9 @@  discard block
 
 block discarded – undo
124 130 
         $groupModel=new GroupModel();
125 131 
         $contestModel=new ContestModel();
126 132 
         $basic_info=$groupModel->details($gcode);
127 
-        if(empty($basic_info)) return Redirect::route('group.index');
133 
+        if(empty($basic_info)) {
134 
+            return Redirect::route('group.index');
135 
+        }
128 136 
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
129 137 
         $contest_list=$contestModel->listForSetting($basic_info["gid"]);
130 138 
         $member_list=$groupModel->userList($basic_info["gid"]);
Please login to merge, or discard this patch.