App\Http\Middleware\Privileged::handle()

Complexity

Conditions	6
Paths	6

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function handle($request, Closure $next)
    {
        if (Auth::check()) {
            if (isset($request->gcode)) {
                //group privilege
                $groupModel=new GroupModel();
                if ($groupModel->judgeClearance($groupModel->gid($request->gcode), Auth::user()->id)>=2) {

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                    return $next($request);
                }
            } elseif (isset($request->cid)) {
                //contest privilege
                $contestModel=new ContestModel();
                if ($contestModel->judgeClearance($request->cid, Auth::user()->id)==3) {
                    return $next($request);
                }
            }
        }
        return Redirect::back();
    }