App\Http\Middleware\Privileged

Complexity

Total Complexity

6

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	0	18	6

<?php

namespace App\Http\Middleware;

use App\Models\GroupModel;
use App\Models\ContestModel;
use Closure, Auth, Redirect;

class Privileged
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        if (Auth::check()) {
            if (isset($request->gcode)) {
                //group privilege
                $groupModel=new GroupModel();
                if ($groupModel->judgeClearance($groupModel->gid($request->gcode), Auth::user()->id)>=2) {

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                    return $next($request);
                }
            } elseif (isset($request->cid)) {
                //contest privilege
                $contestModel=new ContestModel();
                if ($contestModel->judgeClearance($request->cid, Auth::user()->id)==3) {
                    return $next($request);
                }
            }
        }
        return Redirect::back();
    }
}