App\Http\Middleware\ContestAccount::handle()

Complexity

Conditions	4
Paths	4

Size

Total Lines	10
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function handle($request, Closure $next)
    {
        if (!Auth::check()) {
            return $next($request);
        } elseif (is_null(Auth::user()->contest_account)) {

Accessing contest_account on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            return $next($request);
        } elseif ($request->cid==Auth::user()->contest_account) {
            return $next($request);
        } else {
            return Redirect::route('contest.detail', ['cid' => Auth::user()->contest_account]);
        }