App\Http\Middleware\ContestAccount

Complexity

Total Complexity

4

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	0	10	4

<?php

namespace App\Http\Middleware;

use Closure, Auth, Redirect;

class ContestAccount
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        if (!Auth::check()) {
            return $next($request);
        } elseif (is_null(Auth::user()->contest_account)) {

Accessing contest_account on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            return $next($request);
        } elseif ($request->cid==Auth::user()->contest_account) {
            return $next($request);
        } else {
            return Redirect::route('contest.detail', ['cid' => Auth::user()->contest_account]);
        }

    }
}