Inspection of "Provide a link to LiveATC for airports" - Ysurac/FlightAirMap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b4996d...b86720 )

by Yannick

created 2016-08-22 17:48 UTC

Status

Indentation +48 added lines, -48 removed lines patch added patch discarded remove patch

@@ -47,79 +47,79 @@
 block discarded – undo
 print '</div>';
 print '<div><span>'._("Altitude").'</span>';
 if ((!isset($_COOKIE['unitaltitude']) && isset($globalUnitAltitude) && $globalUnitAltitude == 'feet') || (isset($_COOKIE['unitaltitude']) && $_COOKIE['unitaltitude'] == 'feet')) {
-        print $spotter_item['altitude'].'feet';
+		print $spotter_item['altitude'].'feet';
 } else {
-        print round($spotter_item['altitude']*0.3048).' m';
+		print round($spotter_item['altitude']*0.3048).' m';
 }
 print '</div>';
 print '<div><span>'._("Country").'</span>'.$spotter_item['country'].'</div>';
 print '<div><span>'._("Coordinates").'</span>'.round($spotter_item['latitude'],3).', '.round($spotter_item['longitude'],3).'</div>';
 if (isset($spotter_item['home_link']) && $spotter_item['home_link'] != '' && isset($spotter_item['wikipedia_link']) && $spotter_item['wikipedia_link'] != '') {
-    print '<div><span>'._("Links").'</span>';
-    print '<a href="'.$spotter_item['home_link'].'">'._("Homepage").'</a>';
-    print ' - ';
-    print '<a href="'.$spotter_item['wikipedia_link'].'">Wikipedia</a>';
-    print '</div>';
+	print '<div><span>'._("Links").'</span>';
+	print '<a href="'.$spotter_item['home_link'].'">'._("Homepage").'</a>';
+	print ' - ';
+	print '<a href="'.$spotter_item['wikipedia_link'].'">Wikipedia</a>';
+	print '</div>';
 } elseif (isset($spotter_item['home_link']) && $spotter_item['home_link'] != '') {
-    print '<div><span>'._("Links").'</span>';
-    print '<a href="'.$spotter_item['home_link'].'">'._("Homepage").'</a>';
-    print '</div>';
+	print '<div><span>'._("Links").'</span>';
+	print '<a href="'.$spotter_item['home_link'].'">'._("Homepage").'</a>';
+	print '</div>';
 } elseif (isset($spotter_item['wikipedia_link']) && $spotter_item['wikipedia_link'] != '') {
-    print '<div><span>'._("Links").'</span>';
-    print '<a href="'.$spotter_item['wikipedia_link'].'">Wikipedia</a>';
-    print '</div>';
+	print '<div><span>'._("Links").'</span>';
+	print '<a href="'.$spotter_item['wikipedia_link'].'">Wikipedia</a>';
+	print '</div>';
 }
 if ($spotter_item['type'] == 'medium_airport' || $spotter_item['type'] == 'large_airport') {
-    print '<div><span>'._("Live Air Traffic").'</span>';
-    print '<a href="http://www.liveatc.net/search/?icao='.$spotter_item['icao'].'">LiveATC</a>';
-    print '</div>';
+	print '<div><span>'._("Live Air Traffic").'</span>';
+	print '<a href="http://www.liveatc.net/search/?icao='.$spotter_item['icao'].'">LiveATC</a>';
+	print '</div>';
 }
 
 print '</div>';
 
 if (isset($metar_parse)) {
-    print '<div class="waypoints">';
-    print '<div><span>METAR</span>';
-    print '<i>'.$metar_info[0]['metar'].'</i><br />';
-    print '<b>'.$metar_info[0]['metar_date'].'</b><br />';
+	print '<div class="waypoints">';
+	print '<div><span>METAR</span>';
+	print '<i>'.$metar_info[0]['metar'].'</i><br />';
+	print '<b>'.$metar_info[0]['metar_date'].'</b><br />';
 //    print_r($metar_parse);
-    if (isset($metar_parse['wind'])) {
-        print _("Wind:").' ';
+	if (isset($metar_parse['wind'])) {
+		print _("Wind:").' ';
 	if (isset($metar_parse['wind']['direction'])) {
-	    $direction = $Spotter->parseDirection($metar_parse['wind']['direction']);
-	    print $direction[0]['direction_fullname'];
-	    print ' ('.$metar_parse['wind']['direction'].'°) ';
-        }
-        if (isset($metar_parse['wind']['speed'])) {
-	    print $metar_parse['wind']['speed'].' m/s';
-        }
+		$direction = $Spotter->parseDirection($metar_parse['wind']['direction']);
+		print $direction[0]['direction_fullname'];
+		print ' ('.$metar_parse['wind']['direction'].'°) ';
+		}
+		if (isset($metar_parse['wind']['speed'])) {
+		print $metar_parse['wind']['speed'].' m/s';
+		}
 	print '<br/>';
-    }
-    if (isset($metar_parse['visibility'])) {
-        print _("Visibility:").' '.$metar_parse['visibility'].' m'."<br/>";
-    }
-    if (isset($metar_parse['weather'])) {
-        print _("Weather:").' '.$metar_parse['weather']."<br/>";
-    }
-    if (isset($metar_parse['temperature'])) {
-        print _("Temperature:").' '.$metar_parse['temperature'].' °C'."<br/>";
-    }
-    if (isset($metar_parse['dew'])) {
-        print _("Dew point:").' '.$metar_parse['dew'].' °C'."<br/>";
-    }
-    if (isset($metar_parse['temperature']) && isset($metar_parse['dew'])) {
+	}
+	if (isset($metar_parse['visibility'])) {
+		print _("Visibility:").' '.$metar_parse['visibility'].' m'."<br/>";
+	}
+	if (isset($metar_parse['weather'])) {
+		print _("Weather:").' '.$metar_parse['weather']."<br/>";
+	}
+	if (isset($metar_parse['temperature'])) {
+		print _("Temperature:").' '.$metar_parse['temperature'].' °C'."<br/>";
+	}
+	if (isset($metar_parse['dew'])) {
+		print _("Dew point:").' '.$metar_parse['dew'].' °C'."<br/>";
+	}
+	if (isset($metar_parse['temperature']) && isset($metar_parse['dew'])) {
 	$humidity = round(100 * pow((112 - (0.1 * $metar_parse['temperature']) + $metar_parse['dew']) / (112 + (0.9 * $metar_parse['temperature'])), 8),1);
 	print _("Humidity:").' '.$humidity.'%'."<br/>";
-    }
-    if (isset($metar_parse['QNH'])) {
-        print _("Pressure:").' '.$metar_parse['QNH'].' hPa'."<br/>";
-    }
+	}
+	if (isset($metar_parse['QNH'])) {
+		print _("Pressure:").' '.$metar_parse['QNH'].' hPa'."<br/>";
+	}
 /*
 if (isset($metar_parse['QNH'])) {
     print 'Pressure : '.$metar_parse['QNH'].' hPa'."<br/>";
 }
 */
-    print '</div>';
+	print '</div>';
 /*
 Wind: from the NNE (020 degrees) at 5 MPH (4 KT) (direction variable):0
 Visibility: greater than 7 mile(s):0

Please login to merge, or discard this patch.

		@@ -47,79 +47,79 @@
		block discarded – undo
47	47	print '</div>';
48	48	print '<div><span>'._("Altitude").'</span>';
49	49	if ((!isset($_COOKIE['unitaltitude']) && isset($globalUnitAltitude) && $globalUnitAltitude == 'feet') \|\| (isset($_COOKIE['unitaltitude']) && $_COOKIE['unitaltitude'] == 'feet')) {
50		- print $spotter_item['altitude'].'feet';
	50	+ print $spotter_item['altitude'].'feet';
51	51	} else {
52		- print round($spotter_item['altitude']*0.3048).' m';
	52	+ print round($spotter_item['altitude']*0.3048).' m';
53	53	}
54	54	print '</div>';
55	55	print '<div><span>'._("Country").'</span>'.$spotter_item['country'].'</div>';
56	56	print '<div><span>'._("Coordinates").'</span>'.round($spotter_item['latitude'],3).', '.round($spotter_item['longitude'],3).'</div>';
57	57	if (isset($spotter_item['home_link']) && $spotter_item['home_link'] != '' && isset($spotter_item['wikipedia_link']) && $spotter_item['wikipedia_link'] != '') {
58		- print '<div><span>'._("Links").'</span>';
59		- print '<a href="'.$spotter_item['home_link'].'">'._("Homepage").'</a>';
60		- print ' - ';
61		- print '<a href="'.$spotter_item['wikipedia_link'].'">Wikipedia</a>';
62		- print '</div>';
	58	+ print '<div><span>'._("Links").'</span>';
	59	+ print '<a href="'.$spotter_item['home_link'].'">'._("Homepage").'</a>';
	60	+ print ' - ';
	61	+ print '<a href="'.$spotter_item['wikipedia_link'].'">Wikipedia</a>';
	62	+ print '</div>';
63	63	} elseif (isset($spotter_item['home_link']) && $spotter_item['home_link'] != '') {
64		- print '<div><span>'._("Links").'</span>';
65		- print '<a href="'.$spotter_item['home_link'].'">'._("Homepage").'</a>';
66		- print '</div>';
	64	+ print '<div><span>'._("Links").'</span>';
	65	+ print '<a href="'.$spotter_item['home_link'].'">'._("Homepage").'</a>';
	66	+ print '</div>';
67	67	} elseif (isset($spotter_item['wikipedia_link']) && $spotter_item['wikipedia_link'] != '') {
68		- print '<div><span>'._("Links").'</span>';
69		- print '<a href="'.$spotter_item['wikipedia_link'].'">Wikipedia</a>';
70		- print '</div>';
	68	+ print '<div><span>'._("Links").'</span>';
	69	+ print '<a href="'.$spotter_item['wikipedia_link'].'">Wikipedia</a>';
	70	+ print '</div>';
71	71	}
72	72	if ($spotter_item['type'] == 'medium_airport' \|\| $spotter_item['type'] == 'large_airport') {
73		- print '<div><span>'._("Live Air Traffic").'</span>';
74		- print '<a href="http://www.liveatc.net/search/?icao='.$spotter_item['icao'].'">LiveATC</a>';
75		- print '</div>';
	73	+ print '<div><span>'._("Live Air Traffic").'</span>';
	74	+ print '<a href="http://www.liveatc.net/search/?icao='.$spotter_item['icao'].'">LiveATC</a>';
	75	+ print '</div>';
76	76	}
77	77
78	78	print '</div>';
79	79
80	80	if (isset($metar_parse)) {
81		- print '<div class="waypoints">';
82		- print '<div><span>METAR</span>';
83		- print '<i>'.$metar_info[0]['metar'].'</i><br />';
84		- print '<b>'.$metar_info[0]['metar_date'].'</b><br />';
	81	+ print '<div class="waypoints">';
	82	+ print '<div><span>METAR</span>';
	83	+ print '<i>'.$metar_info[0]['metar'].'</i><br />';
	84	+ print '<b>'.$metar_info[0]['metar_date'].'</b><br />';
85	85	// print_r($metar_parse);
86		- if (isset($metar_parse['wind'])) {
87		- print _("Wind:").' ';
	86	+ if (isset($metar_parse['wind'])) {
	87	+ print _("Wind:").' ';
88	88	if (isset($metar_parse['wind']['direction'])) {
89		- $direction = $Spotter->parseDirection($metar_parse['wind']['direction']);
90		- print $direction[0]['direction_fullname'];
91		- print ' ('.$metar_parse['wind']['direction'].'°) ';
92		- }
93		- if (isset($metar_parse['wind']['speed'])) {
94		- print $metar_parse['wind']['speed'].' m/s';
95		- }
	89	+ $direction = $Spotter->parseDirection($metar_parse['wind']['direction']);
	90	+ print $direction[0]['direction_fullname'];
	91	+ print ' ('.$metar_parse['wind']['direction'].'°) ';
	92	+ }
	93	+ if (isset($metar_parse['wind']['speed'])) {
	94	+ print $metar_parse['wind']['speed'].' m/s';
	95	+ }
96	96	print '<br/>';
97		- }
98		- if (isset($metar_parse['visibility'])) {
99		- print _("Visibility:").' '.$metar_parse['visibility'].' m'."<br/>";
100		- }
101		- if (isset($metar_parse['weather'])) {
102		- print _("Weather:").' '.$metar_parse['weather']."<br/>";
103		- }
104		- if (isset($metar_parse['temperature'])) {
105		- print _("Temperature:").' '.$metar_parse['temperature'].' °C'."<br/>";
106		- }
107		- if (isset($metar_parse['dew'])) {
108		- print _("Dew point:").' '.$metar_parse['dew'].' °C'."<br/>";
109		- }
110		- if (isset($metar_parse['temperature']) && isset($metar_parse['dew'])) {
	97	+ }
	98	+ if (isset($metar_parse['visibility'])) {
	99	+ print _("Visibility:").' '.$metar_parse['visibility'].' m'."<br/>";
	100	+ }
	101	+ if (isset($metar_parse['weather'])) {
	102	+ print _("Weather:").' '.$metar_parse['weather']."<br/>";
	103	+ }
	104	+ if (isset($metar_parse['temperature'])) {
	105	+ print _("Temperature:").' '.$metar_parse['temperature'].' °C'."<br/>";
	106	+ }
	107	+ if (isset($metar_parse['dew'])) {
	108	+ print _("Dew point:").' '.$metar_parse['dew'].' °C'."<br/>";
	109	+ }
	110	+ if (isset($metar_parse['temperature']) && isset($metar_parse['dew'])) {
111	111	$humidity = round(100 * pow((112 - (0.1 * $metar_parse['temperature']) + $metar_parse['dew']) / (112 + (0.9 * $metar_parse['temperature'])), 8),1);
112	112	print _("Humidity:").' '.$humidity.'%'."<br/>";
113		- }
114		- if (isset($metar_parse['QNH'])) {
115		- print _("Pressure:").' '.$metar_parse['QNH'].' hPa'."<br/>";
116		- }
	113	+ }
	114	+ if (isset($metar_parse['QNH'])) {
	115	+ print _("Pressure:").' '.$metar_parse['QNH'].' hPa'."<br/>";
	116	+ }
117	117	/*
118	118	if (isset($metar_parse['QNH'])) {
119	119	print 'Pressure : '.$metar_parse['QNH'].' hPa'."<br/>";
120	120	}
121	121	*/
122		- print '</div>';
	122	+ print '</div>';
123	123	/*
124	124	Wind: from the NNE (020 degrees) at 5 MPH (4 KT) (direction variable):0
125	125	Visibility: greater than 7 mile(s):0

Ysurac / FlightAirMap

Push — master ( b4996d...b86720 )

Status

Category

Indentation +48 added lines, -48 removed lines patch added patch discarded remove patch