Inspection of "fixed parse argument value for non null type" - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 48a1e6...3c3b08 )

by Portey

created 2016-09-07 19:03 UTC

Status

Spacing +34 added lines, -34 removed lines patch added patch discarded remove patch

@@ -95,14 +95,14 @@  discard block
 block discarded – undo
                 'fields' => [
                     'list' => [
                         'type'    => new ListType(new StringType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
                 ]
             ])
         ]));
-        $data      = $processor->processPayload(' { list }')->getResponseData();
+        $data = $processor->processPayload(' { list }')->getResponseData();
         $this->assertEquals(['data' => ['list' => null]], $data);
     }
 
@@ -115,20 +115,20 @@  discard block
 block discarded – undo
                 'fields' => [
                     'list' => [
                         'type'    => new ListType(new StringType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
                 ]
             ])
         ]));
-        $data      = $processor->processPayload(' { __schema { subscriptionType { name } } }')->getResponseData();
+        $data = $processor->processPayload(' { __schema { subscriptionType { name } } }')->getResponseData();
         $this->assertEquals(['data' => ['__schema' => ['subscriptionType' => null]]], $data);
     }
 
     public function testSchemaOperations()
     {
-        $schema    = new Schema([
+        $schema = new Schema([
             'query' => new ObjectType([
                 'name'   => 'RootQuery',
                 'fields' => [
@@ -141,13 +141,13 @@  discard block
 block discarded – undo
                                     'args'    => [
                                         'shorten' => new BooleanType()
                                     ],
-                                    'resolve' => function ($value, $args) {
+                                    'resolve' => function($value, $args) {
                                         return empty($args['shorten']) ? $value['firstName'] : $value['firstName'];
                                     }
                                 ],
                                 'id_alias'  => [
                                     'type'    => new IdType(),
-                                    'resolve' => function ($value) {
+                                    'resolve' => function($value) {
                                         return $value['id'];
                                     }
                                 ],
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
                                 'code'      => new StringType(),
                             ]
                         ]),
-                        'resolve' => function ($value, $args) {
+                        'resolve' => function($value, $args) {
                             $data = ['id' => '123', 'firstName' => 'John', 'code' => '007'];
                             if (!empty($args['upper'])) {
                                 foreach ($data as $key => $value) {
@@ -174,19 +174,19 @@  discard block
 block discarded – undo
                     ],
                     'randomUser'        => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['invalidField' => 'John'];
                         }
                     ],
                     'invalidValueQuery' => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'stringValue';
                         }
                     ],
                     'labels'            => [
                         'type'    => new ListType(new StringType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['one', 'two'];
                         }
                     ]
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
             ->addField(new Field([
                 'name'    => 'increaseCounter',
                 'type'    => new IntType(),
-                'resolve' => function ($value, $args, ResolveInfo $info) {
+                'resolve' => function($value, $args, ResolveInfo $info) {
                     return $this->_counter += $args['amount'];
                 },
                 'args'    => [
@@ -229,13 +229,13 @@  discard block
 block discarded – undo
             ]))->addField(new Field([
                 'name'    => 'invalidResolveTypeMutation',
                 'type'    => new NonNullType(new IntType()),
-                'resolve' => function () {
+                'resolve' => function() {
                     return null;
                 }
             ]))->addField(new Field([
                 'name'    => 'interfacedMutation',
                 'type'    => new TestInterfaceType(),
-                'resolve' => function () {
+                'resolve' => function() {
                     return ['name' => 'John'];
                 }
             ]));
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
                             ]))
                         ],
                         'type'    => new StringType(),
-                        'resolve' => function ($value, $args) {
+                        'resolve' => function($value, $args) {
                             return $args['argument1'];
                         }
                     ]
@@ -329,43 +329,43 @@  discard block
 block discarded – undo
                 'fields' => [
                     'listQuery'                 => [
                         'type'    => new ListType(new TestEnumType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'invalid list';
                         }
                     ],
                     'listEnumQuery'             => [
                         'type'    => new ListType(new TestEnumType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['invalid enum'];
                         }
                     ],
                     'invalidEnumQuery'          => [
                         'type'    => new TestEnumType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'invalid enum';
                         }
                     ],
                     'enumQuery'                 => [
                         'type'    => new TestEnumType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 1;
                         }
                     ],
                     'invalidNonNullQuery'       => [
                         'type'    => new NonNullType(new IntType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ],
                     'invalidNonNullInsideQuery' => [
                         'type'    => new NonNullType(new IntType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'hello';
                         }
                     ],
                     'objectQuery'               => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['name' => 'John'];
                         }
                     ],
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
                                 'enum'   => new TestEnumType(),
                             ],
                         ]),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return [
                                 'object' => [
                                     'name' => 'John'
@@ -446,10 +446,10 @@  discard block
 block discarded – undo
             ]
         ]);
 
-        $union        = new UnionType([
+        $union = new UnionType([
             'name'        => 'TestUnion',
             'types'       => [$object1, $object2],
-            'resolveType' => function ($object) use ($object1, $object2) {
+            'resolveType' => function($object) use ($object1, $object2) {
                 if (isset($object['id'])) {
                     return $object1;
                 }
@@ -460,11 +460,11 @@  discard block
 block discarded – undo
         $invalidUnion = new UnionType([
             'name'        => 'TestUnion',
             'types'       => [$object1, $object2],
-            'resolveType' => function ($object) use ($object3) {
+            'resolveType' => function($object) use ($object3) {
                 return $object3;
             }
         ]);
-        $processor    = new Processor(new Schema([
+        $processor = new Processor(new Schema([
             'query' => new ObjectType([
                 'name'   => 'RootQuery',
                 'fields' => [
@@ -474,7 +474,7 @@  discard block
 block discarded – undo
                             'type' => ['type' => 'string']
                         ],
                         'cost'    => 10,
-                        'resolve' => function ($value, $args) {
+                        'resolve' => function($value, $args) {
                             if ($args['type'] == 'object1') {
                                 return [
                                     'id' => 43
@@ -488,7 +488,7 @@  discard block
 block discarded – undo
                     ],
                     'invalidUnion' => [
                         'type'    => $invalidUnion,
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['name' => 'name resolved'];
                         }
                     ],
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
 
     public function testComplexityReducer()
     {
-        $schema    = new Schema(
+        $schema = new Schema(
             [
                 'query' => new ObjectType(
                     [
@@ -549,7 +549,7 @@  discard block
 block discarded – undo
                                                 'args'    => [
                                                     'shorten' => new BooleanType()
                                                 ],
-                                                'resolve' => function ($value, $args) {
+                                                'resolve' => function($value, $args) {
                                                     return empty($args['shorten']) ? $value : $value;
                                                 }
                                             ],
@@ -558,19 +558,19 @@  discard block
 block discarded – undo
                                             'likes'     => [
                                                 'type'    => new IntType(),
                                                 'cost'    => 10,
-                                                'resolve' => function () {
+                                                'resolve' => function() {
                                                     return 42;
                                                 }
                                             ]
                                         ]
                                     ]
                                 ),
-                                'cost'    => function ($args, $context, $childCost) {
+                                'cost'    => function($args, $context, $childCost) {
                                     $argsCost = isset($args['cost']) ? $args['cost'] : 1;
 
                                     return 1 + $argsCost * $childCost;
                                 },
-                                'resolve' => function ($value, $args) {
+                                'resolve' => function($value, $args) {
                                     $data = ['firstName' => 'John', 'code' => '007'];
 
                                     return $data;

Please login to merge, or discard this patch.

		@@ -95,14 +95,14 @@ discard block
		block discarded – undo
95	95	'fields' => [
96	96	'list' => [
97	97	'type' => new ListType(new StringType()),
98		- 'resolve' => function () {
	98	+ 'resolve' => function() {
99	99	return null;
100	100	}
101	101	]
102	102	]
103	103	])
104	104	]));
105		- $data = $processor->processPayload(' { list }')->getResponseData();
	105	+ $data = $processor->processPayload(' { list }')->getResponseData();
106	106	$this->assertEquals(['data' => ['list' => null]], $data);
107	107	}
108	108
		@@ -115,20 +115,20 @@ discard block
		block discarded – undo
115	115	'fields' => [
116	116	'list' => [
117	117	'type' => new ListType(new StringType()),
118		- 'resolve' => function () {
	118	+ 'resolve' => function() {
119	119	return null;
120	120	}
121	121	]
122	122	]
123	123	])
124	124	]));
125		- $data = $processor->processPayload(' { __schema { subscriptionType { name } } }')->getResponseData();
	125	+ $data = $processor->processPayload(' { __schema { subscriptionType { name } } }')->getResponseData();
126	126	$this->assertEquals(['data' => ['__schema' => ['subscriptionType' => null]]], $data);
127	127	}
128	128
129	129	public function testSchemaOperations()
130	130	{
131		- $schema = new Schema([
	131	+ $schema = new Schema([
132	132	'query' => new ObjectType([
133	133	'name' => 'RootQuery',
134	134	'fields' => [
		@@ -141,13 +141,13 @@ discard block
		block discarded – undo
141	141	'args' => [
142	142	'shorten' => new BooleanType()
143	143	],
144		- 'resolve' => function ($value, $args) {
	144	+ 'resolve' => function($value, $args) {
145	145	return empty($args['shorten']) ? $value['firstName'] : $value['firstName'];
146	146	}
147	147	],
148	148	'id_alias' => [
149	149	'type' => new IdType(),
150		- 'resolve' => function ($value) {
	150	+ 'resolve' => function($value) {
151	151	return $value['id'];
152	152	}
153	153	],
		@@ -155,7 +155,7 @@ discard block
		block discarded – undo
155	155	'code' => new StringType(),
156	156	]
157	157	]),
158		- 'resolve' => function ($value, $args) {
	158	+ 'resolve' => function($value, $args) {
159	159	$data = ['id' => '123', 'firstName' => 'John', 'code' => '007'];
160	160	if (!empty($args['upper'])) {
161	161	foreach ($data as $key => $value) {
		@@ -174,19 +174,19 @@ discard block
		block discarded – undo
174	174	],
175	175	'randomUser' => [
176	176	'type' => new TestObjectType(),
177		- 'resolve' => function () {
	177	+ 'resolve' => function() {
178	178	return ['invalidField' => 'John'];
179	179	}
180	180	],
181	181	'invalidValueQuery' => [
182	182	'type' => new TestObjectType(),
183		- 'resolve' => function () {
	183	+ 'resolve' => function() {
184	184	return 'stringValue';
185	185	}
186	186	],
187	187	'labels' => [
188	188	'type' => new ListType(new StringType()),
189		- 'resolve' => function () {
	189	+ 'resolve' => function() {
190	190	return ['one', 'two'];
191	191	}
192	192	]
		@@ -217,7 +217,7 @@ discard block
		block discarded – undo
217	217	->addField(new Field([
218	218	'name' => 'increaseCounter',
219	219	'type' => new IntType(),
220		- 'resolve' => function ($value, $args, ResolveInfo $info) {
	220	+ 'resolve' => function($value, $args, ResolveInfo $info) {
221	221	return $this->_counter += $args['amount'];
222	222	},
223	223	'args' => [
		@@ -229,13 +229,13 @@ discard block
		block discarded – undo
229	229	]))->addField(new Field([
230	230	'name' => 'invalidResolveTypeMutation',
231	231	'type' => new NonNullType(new IntType()),
232		- 'resolve' => function () {
	232	+ 'resolve' => function() {
233	233	return null;
234	234	}
235	235	]))->addField(new Field([
236	236	'name' => 'interfacedMutation',
237	237	'type' => new TestInterfaceType(),
238		- 'resolve' => function () {
	238	+ 'resolve' => function() {
239	239	return ['name' => 'John'];
240	240	}
241	241	]));
		@@ -296,7 +296,7 @@ discard block
		block discarded – undo
296	296	]))
297	297	],
298	298	'type' => new StringType(),
299		- 'resolve' => function ($value, $args) {
	299	+ 'resolve' => function($value, $args) {
300	300	return $args['argument1'];
301	301	}
302	302	]
		@@ -329,43 +329,43 @@ discard block
		block discarded – undo
329	329	'fields' => [
330	330	'listQuery' => [
331	331	'type' => new ListType(new TestEnumType()),
332		- 'resolve' => function () {
	332	+ 'resolve' => function() {
333	333	return 'invalid list';
334	334	}
335	335	],
336	336	'listEnumQuery' => [
337	337	'type' => new ListType(new TestEnumType()),
338		- 'resolve' => function () {
	338	+ 'resolve' => function() {
339	339	return ['invalid enum'];
340	340	}
341	341	],
342	342	'invalidEnumQuery' => [
343	343	'type' => new TestEnumType(),
344		- 'resolve' => function () {
	344	+ 'resolve' => function() {
345	345	return 'invalid enum';
346	346	}
347	347	],
348	348	'enumQuery' => [
349	349	'type' => new TestEnumType(),
350		- 'resolve' => function () {
	350	+ 'resolve' => function() {
351	351	return 1;
352	352	}
353	353	],
354	354	'invalidNonNullQuery' => [
355	355	'type' => new NonNullType(new IntType()),
356		- 'resolve' => function () {
	356	+ 'resolve' => function() {
357	357	return null;
358	358	}
359	359	],
360	360	'invalidNonNullInsideQuery' => [
361	361	'type' => new NonNullType(new IntType()),
362		- 'resolve' => function () {
	362	+ 'resolve' => function() {
363	363	return 'hello';
364	364	}
365	365	],
366	366	'objectQuery' => [
367	367	'type' => new TestObjectType(),
368		- 'resolve' => function () {
	368	+ 'resolve' => function() {
369	369	return ['name' => 'John'];
370	370	}
371	371	],
		@@ -377,7 +377,7 @@ discard block
		block discarded – undo
377	377	'enum' => new TestEnumType(),
378	378	],
379	379	]),
380		- 'resolve' => function () {
	380	+ 'resolve' => function() {
381	381	return [
382	382	'object' => [
383	383	'name' => 'John'
		@@ -446,10 +446,10 @@ discard block
		block discarded – undo
446	446	]
447	447	]);
448	448
449		- $union = new UnionType([
	449	+ $union = new UnionType([
450	450	'name' => 'TestUnion',
451	451	'types' => [$object1, $object2],
452		- 'resolveType' => function ($object) use ($object1, $object2) {
	452	+ 'resolveType' => function($object) use ($object1, $object2) {
453	453	if (isset($object['id'])) {
454	454	return $object1;
455	455	}
		@@ -460,11 +460,11 @@ discard block
		block discarded – undo
460	460	$invalidUnion = new UnionType([
461	461	'name' => 'TestUnion',
462	462	'types' => [$object1, $object2],
463		- 'resolveType' => function ($object) use ($object3) {
	463	+ 'resolveType' => function($object) use ($object3) {
464	464	return $object3;
465	465	}
466	466	]);
467		- $processor = new Processor(new Schema([
	467	+ $processor = new Processor(new Schema([
468	468	'query' => new ObjectType([
469	469	'name' => 'RootQuery',
470	470	'fields' => [
		@@ -474,7 +474,7 @@ discard block
		block discarded – undo
474	474	'type' => ['type' => 'string']
475	475	],
476	476	'cost' => 10,
477		- 'resolve' => function ($value, $args) {
	477	+ 'resolve' => function($value, $args) {
478	478	if ($args['type'] == 'object1') {
479	479	return [
480	480	'id' => 43
		@@ -488,7 +488,7 @@ discard block
		block discarded – undo
488	488	],
489	489	'invalidUnion' => [
490	490	'type' => $invalidUnion,
491		- 'resolve' => function () {
	491	+ 'resolve' => function() {
492	492	return ['name' => 'name resolved'];
493	493	}
494	494	],
		@@ -533,7 +533,7 @@ discard block
		block discarded – undo
533	533
534	534	public function testComplexityReducer()
535	535	{
536		- $schema = new Schema(
	536	+ $schema = new Schema(
537	537	[
538	538	'query' => new ObjectType(
539	539	[
		@@ -549,7 +549,7 @@ discard block
		block discarded – undo
549	549	'args' => [
550	550	'shorten' => new BooleanType()
551	551	],
552		- 'resolve' => function ($value, $args) {
	552	+ 'resolve' => function($value, $args) {
553	553	return empty($args['shorten']) ? $value : $value;
554	554	}
555	555	],
		@@ -558,19 +558,19 @@ discard block
		block discarded – undo
558	558	'likes' => [
559	559	'type' => new IntType(),
560	560	'cost' => 10,
561		- 'resolve' => function () {
	561	+ 'resolve' => function() {
562	562	return 42;
563	563	}
564	564	]
565	565	]
566	566	]
567	567	),
568		- 'cost' => function ($args, $context, $childCost) {
	568	+ 'cost' => function($args, $context, $childCost) {
569	569	$argsCost = isset($args['cost']) ? $args['cost'] : 1;
570	570
571	571	return 1 + $argsCost * $childCost;
572	572	},
573		- 'resolve' => function ($value, $args) {
	573	+ 'resolve' => function($value, $args) {
574	574	$data = ['firstName' => 'John', 'code' => '007'];
575	575
576	576	return $data;

Youshido / GraphQL

Push — master ( 48a1e6...3c3b08 )

Status

Category

Spacing +34 added lines, -34 removed lines patch added patch discarded remove patch