Inspection of "added test for the field alias" - Youshido/GraphQL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f8e797...0b7ef3 )

by Alexandr

created 2016-08-14 16:04 UTC

Status

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -164,19 +164,19 @@
 block discarded – undo
         $this->assertEquals(['data' => ['me' => ['firstName' => 'JOHN']]], $processor->getResponseData());
 
         $schema->getMutationType()
-               ->addField(new Field([
-                   'name'    => 'increaseCounter',
-                   'type'    => new IntType(),
-                   'resolve' => function ($value, $args, ResolveInfo $info) {
-                       return $this->_counter += $args['amount'];
-                   },
-                   'args'    => [
-                       'amount' => [
-                           'type'    => new IntType(),
-                           'default' => 1
-                       ]
-                   ]
-               ]))->addField(new Field([
+                ->addField(new Field([
+                    'name'    => 'increaseCounter',
+                    'type'    => new IntType(),
+                    'resolve' => function ($value, $args, ResolveInfo $info) {
+                        return $this->_counter += $args['amount'];
+                    },
+                    'args'    => [
+                        'amount' => [
+                            'type'    => new IntType(),
+                            'default' => 1
+                        ]
+                    ]
+                ]))->addField(new Field([
                 'name'    => 'invalidResolveTypeMutation',
                 'type'    => new NonNullType(new IntType()),
                 'resolve' => function () {

Please login to merge, or discard this patch.

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

@@ -93,14 +93,14 @@  discard block
 block discarded – undo
                 'fields' => [
                     'list' => [
                         'type'    => new ListType(new StringType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
                 ]
             ])
         ]));
-        $data      = $processor->processPayload(' { list }')->getResponseData();
+        $data = $processor->processPayload(' { list }')->getResponseData();
         $this->assertEquals(['data' => ['list' => null]], $data);
     }
 
@@ -113,20 +113,20 @@  discard block
 block discarded – undo
                 'fields' => [
                     'list' => [
                         'type'    => new ListType(new StringType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ]
                 ]
             ])
         ]));
-        $data      = $processor->processPayload(' { __schema { subscriptionType { name } } }')->getResponseData();
+        $data = $processor->processPayload(' { __schema { subscriptionType { name } } }')->getResponseData();
         $this->assertEquals(['data' => ['__schema' => ['subscriptionType' => null]]], $data);
     }
 
     public function testSchemaOperations()
     {
-        $schema    = new Schema([
+        $schema = new Schema([
             'query' => new ObjectType([
                 'name'   => 'RootQuery',
                 'fields' => [
@@ -139,13 +139,13 @@  discard block
 block discarded – undo
                                     'args'    => [
                                         'shorten' => new BooleanType()
                                     ],
-                                    'resolve' => function ($value, $args) {
+                                    'resolve' => function($value, $args) {
                                         return empty($args['shorten']) ? $value : $value;
                                     }
                                 ],
                                 'id_alias'  => [
                                     'type'    => new IdType(),
-                                    'resolve' => function ($value) {
+                                    'resolve' => function($value) {
                                         return $value['id'];
                                     }
                                 ],
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
                                 'code'      => new StringType(),
                             ]
                         ]),
-                        'resolve' => function ($value, $args) {
+                        'resolve' => function($value, $args) {
                             $data = ['id' => '123', 'firstName' => 'John', 'code' => '007'];
                             if (!empty($args['upper'])) {
                                 foreach ($data as $key => $value) {
@@ -172,19 +172,19 @@  discard block
 block discarded – undo
                     ],
                     'randomUser'        => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['invalidField' => 'John'];
                         }
                     ],
                     'invalidValueQuery' => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'stringValue';
                         }
                     ],
                     'labels'            => [
                         'type'    => new ListType(new StringType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['one', 'two'];
                         }
                     ]
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
                ->addField(new Field([
                    'name'    => 'increaseCounter',
                    'type'    => new IntType(),
-                   'resolve' => function ($value, $args, ResolveInfo $info) {
+                   'resolve' => function($value, $args, ResolveInfo $info) {
                        return $this->_counter += $args['amount'];
                    },
                    'args'    => [
@@ -227,13 +227,13 @@  discard block
 block discarded – undo
                ]))->addField(new Field([
                 'name'    => 'invalidResolveTypeMutation',
                 'type'    => new NonNullType(new IntType()),
-                'resolve' => function () {
+                'resolve' => function() {
                     return null;
                 }
             ]))->addField(new Field([
                 'name'    => 'interfacedMutation',
                 'type'    => new TestInterfaceType(),
-                'resolve' => function () {
+                'resolve' => function() {
                     return ['name' => 'John'];
                 }
             ]));
@@ -279,43 +279,43 @@  discard block
 block discarded – undo
                 'fields' => [
                     'listQuery'                 => [
                         'type'    => new ListType(new TestEnumType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'invalid list';
                         }
                     ],
                     'listEnumQuery'             => [
                         'type'    => new ListType(new TestEnumType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['invalid enum'];
                         }
                     ],
                     'invalidEnumQuery'          => [
                         'type'    => new TestEnumType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'invalid enum';
                         }
                     ],
                     'enumQuery'                 => [
                         'type'    => new TestEnumType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 1;
                         }
                     ],
                     'invalidNonNullQuery'       => [
                         'type'    => new NonNullType(new IntType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return null;
                         }
                     ],
                     'invalidNonNullInsideQuery' => [
                         'type'    => new NonNullType(new IntType()),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return 'hello';
                         }
                     ],
                     'objectQuery'               => [
                         'type'    => new TestObjectType(),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['name' => 'John'];
                         }
                     ],
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
                                 'enum'   => new TestEnumType(),
                             ],
                         ]),
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return [
                                 'object' => [
                                     'name' => 'John'
@@ -396,10 +396,10 @@  discard block
 block discarded – undo
             ]
         ]);
 
-        $union        = new UnionType([
+        $union = new UnionType([
             'name'        => 'TestUnion',
             'types'       => [$object1, $object2],
-            'resolveType' => function ($object) use ($object1, $object2) {
+            'resolveType' => function($object) use ($object1, $object2) {
                 if (isset($object['id'])) {
                     return $object1;
                 }
@@ -410,11 +410,11 @@  discard block
 block discarded – undo
         $invalidUnion = new UnionType([
             'name'        => 'TestUnion',
             'types'       => [$object1, $object2],
-            'resolveType' => function ($object) use ($object3) {
+            'resolveType' => function($object) use ($object3) {
                 return $object3;
             }
         ]);
-        $processor    = new Processor(new Schema([
+        $processor = new Processor(new Schema([
             'query' => new ObjectType([
                 'name'   => 'RootQuery',
                 'fields' => [
@@ -423,7 +423,7 @@  discard block
 block discarded – undo
                         'args'    => [
                             'type' => ['type' => 'string']
                         ],
-                        'resolve' => function ($value, $args) {
+                        'resolve' => function($value, $args) {
                             if ($args['type'] == 'object1') {
                                 return [
                                     'id' => 43
@@ -437,7 +437,7 @@  discard block
 block discarded – undo
                     ],
                     'invalidUnion' => [
                         'type'    => $invalidUnion,
-                        'resolve' => function () {
+                        'resolve' => function() {
                             return ['name' => 'name resolved'];
                         }
                     ],

Please login to merge, or discard this patch.

		@@ -164,19 +164,19 @@
		block discarded – undo
164	164	$this->assertEquals(['data' => ['me' => ['firstName' => 'JOHN']]], $processor->getResponseData());
165	165
166	166	$schema->getMutationType()
167		- ->addField(new Field([
168		- 'name' => 'increaseCounter',
169		- 'type' => new IntType(),
170		- 'resolve' => function ($value, $args, ResolveInfo $info) {
171		- return $this->_counter += $args['amount'];
172		- },
173		- 'args' => [
174		- 'amount' => [
175		- 'type' => new IntType(),
176		- 'default' => 1
177		- ]
178		- ]
179		- ]))->addField(new Field([
	167	+ ->addField(new Field([
	168	+ 'name' => 'increaseCounter',
	169	+ 'type' => new IntType(),
	170	+ 'resolve' => function ($value, $args, ResolveInfo $info) {
	171	+ return $this->_counter += $args['amount'];
	172	+ },
	173	+ 'args' => [
	174	+ 'amount' => [
	175	+ 'type' => new IntType(),
	176	+ 'default' => 1
	177	+ ]
	178	+ ]
	179	+ ]))->addField(new Field([
180	180	'name' => 'invalidResolveTypeMutation',
181	181	'type' => new NonNullType(new IntType()),
182	182	'resolve' => function () {

		@@ -93,14 +93,14 @@ discard block
		block discarded – undo
93	93	'fields' => [
94	94	'list' => [
95	95	'type' => new ListType(new StringType()),
96		- 'resolve' => function () {
	96	+ 'resolve' => function() {
97	97	return null;
98	98	}
99	99	]
100	100	]
101	101	])
102	102	]));
103		- $data = $processor->processPayload(' { list }')->getResponseData();
	103	+ $data = $processor->processPayload(' { list }')->getResponseData();
104	104	$this->assertEquals(['data' => ['list' => null]], $data);
105	105	}
106	106
		@@ -113,20 +113,20 @@ discard block
		block discarded – undo
113	113	'fields' => [
114	114	'list' => [
115	115	'type' => new ListType(new StringType()),
116		- 'resolve' => function () {
	116	+ 'resolve' => function() {
117	117	return null;
118	118	}
119	119	]
120	120	]
121	121	])
122	122	]));
123		- $data = $processor->processPayload(' { __schema { subscriptionType { name } } }')->getResponseData();
	123	+ $data = $processor->processPayload(' { __schema { subscriptionType { name } } }')->getResponseData();
124	124	$this->assertEquals(['data' => ['__schema' => ['subscriptionType' => null]]], $data);
125	125	}
126	126
127	127	public function testSchemaOperations()
128	128	{
129		- $schema = new Schema([
	129	+ $schema = new Schema([
130	130	'query' => new ObjectType([
131	131	'name' => 'RootQuery',
132	132	'fields' => [
		@@ -139,13 +139,13 @@ discard block
		block discarded – undo
139	139	'args' => [
140	140	'shorten' => new BooleanType()
141	141	],
142		- 'resolve' => function ($value, $args) {
	142	+ 'resolve' => function($value, $args) {
143	143	return empty($args['shorten']) ? $value : $value;
144	144	}
145	145	],
146	146	'id_alias' => [
147	147	'type' => new IdType(),
148		- 'resolve' => function ($value) {
	148	+ 'resolve' => function($value) {
149	149	return $value['id'];
150	150	}
151	151	],
		@@ -153,7 +153,7 @@ discard block
		block discarded – undo
153	153	'code' => new StringType(),
154	154	]
155	155	]),
156		- 'resolve' => function ($value, $args) {
	156	+ 'resolve' => function($value, $args) {
157	157	$data = ['id' => '123', 'firstName' => 'John', 'code' => '007'];
158	158	if (!empty($args['upper'])) {
159	159	foreach ($data as $key => $value) {
		@@ -172,19 +172,19 @@ discard block
		block discarded – undo
172	172	],
173	173	'randomUser' => [
174	174	'type' => new TestObjectType(),
175		- 'resolve' => function () {
	175	+ 'resolve' => function() {
176	176	return ['invalidField' => 'John'];
177	177	}
178	178	],
179	179	'invalidValueQuery' => [
180	180	'type' => new TestObjectType(),
181		- 'resolve' => function () {
	181	+ 'resolve' => function() {
182	182	return 'stringValue';
183	183	}
184	184	],
185	185	'labels' => [
186	186	'type' => new ListType(new StringType()),
187		- 'resolve' => function () {
	187	+ 'resolve' => function() {
188	188	return ['one', 'two'];
189	189	}
190	190	]
		@@ -215,7 +215,7 @@ discard block
		block discarded – undo
215	215	->addField(new Field([
216	216	'name' => 'increaseCounter',
217	217	'type' => new IntType(),
218		- 'resolve' => function ($value, $args, ResolveInfo $info) {
	218	+ 'resolve' => function($value, $args, ResolveInfo $info) {
219	219	return $this->_counter += $args['amount'];
220	220	},
221	221	'args' => [
		@@ -227,13 +227,13 @@ discard block
		block discarded – undo
227	227	]))->addField(new Field([
228	228	'name' => 'invalidResolveTypeMutation',
229	229	'type' => new NonNullType(new IntType()),
230		- 'resolve' => function () {
	230	+ 'resolve' => function() {
231	231	return null;
232	232	}
233	233	]))->addField(new Field([
234	234	'name' => 'interfacedMutation',
235	235	'type' => new TestInterfaceType(),
236		- 'resolve' => function () {
	236	+ 'resolve' => function() {
237	237	return ['name' => 'John'];
238	238	}
239	239	]));
		@@ -279,43 +279,43 @@ discard block
		block discarded – undo
279	279	'fields' => [
280	280	'listQuery' => [
281	281	'type' => new ListType(new TestEnumType()),
282		- 'resolve' => function () {
	282	+ 'resolve' => function() {
283	283	return 'invalid list';
284	284	}
285	285	],
286	286	'listEnumQuery' => [
287	287	'type' => new ListType(new TestEnumType()),
288		- 'resolve' => function () {
	288	+ 'resolve' => function() {
289	289	return ['invalid enum'];
290	290	}
291	291	],
292	292	'invalidEnumQuery' => [
293	293	'type' => new TestEnumType(),
294		- 'resolve' => function () {
	294	+ 'resolve' => function() {
295	295	return 'invalid enum';
296	296	}
297	297	],
298	298	'enumQuery' => [
299	299	'type' => new TestEnumType(),
300		- 'resolve' => function () {
	300	+ 'resolve' => function() {
301	301	return 1;
302	302	}
303	303	],
304	304	'invalidNonNullQuery' => [
305	305	'type' => new NonNullType(new IntType()),
306		- 'resolve' => function () {
	306	+ 'resolve' => function() {
307	307	return null;
308	308	}
309	309	],
310	310	'invalidNonNullInsideQuery' => [
311	311	'type' => new NonNullType(new IntType()),
312		- 'resolve' => function () {
	312	+ 'resolve' => function() {
313	313	return 'hello';
314	314	}
315	315	],
316	316	'objectQuery' => [
317	317	'type' => new TestObjectType(),
318		- 'resolve' => function () {
	318	+ 'resolve' => function() {
319	319	return ['name' => 'John'];
320	320	}
321	321	],
		@@ -327,7 +327,7 @@ discard block
		block discarded – undo
327	327	'enum' => new TestEnumType(),
328	328	],
329	329	]),
330		- 'resolve' => function () {
	330	+ 'resolve' => function() {
331	331	return [
332	332	'object' => [
333	333	'name' => 'John'
		@@ -396,10 +396,10 @@ discard block
		block discarded – undo
396	396	]
397	397	]);
398	398
399		- $union = new UnionType([
	399	+ $union = new UnionType([
400	400	'name' => 'TestUnion',
401	401	'types' => [$object1, $object2],
402		- 'resolveType' => function ($object) use ($object1, $object2) {
	402	+ 'resolveType' => function($object) use ($object1, $object2) {
403	403	if (isset($object['id'])) {
404	404	return $object1;
405	405	}
		@@ -410,11 +410,11 @@ discard block
		block discarded – undo
410	410	$invalidUnion = new UnionType([
411	411	'name' => 'TestUnion',
412	412	'types' => [$object1, $object2],
413		- 'resolveType' => function ($object) use ($object3) {
	413	+ 'resolveType' => function($object) use ($object3) {
414	414	return $object3;
415	415	}
416	416	]);
417		- $processor = new Processor(new Schema([
	417	+ $processor = new Processor(new Schema([
418	418	'query' => new ObjectType([
419	419	'name' => 'RootQuery',
420	420	'fields' => [
		@@ -423,7 +423,7 @@ discard block
		block discarded – undo
423	423	'args' => [
424	424	'type' => ['type' => 'string']
425	425	],
426		- 'resolve' => function ($value, $args) {
	426	+ 'resolve' => function($value, $args) {
427	427	if ($args['type'] == 'object1') {
428	428	return [
429	429	'id' => 43
		@@ -437,7 +437,7 @@ discard block
		block discarded – undo
437	437	],
438	438	'invalidUnion' => [
439	439	'type' => $invalidUnion,
440		- 'resolve' => function () {
	440	+ 'resolve' => function() {
441	441	return ['name' => 'name resolved'];
442	442	}
443	443	],

Youshido / GraphQL

Push — master ( f8e797...0b7ef3 )

Status

Category

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch