Youshido / GraphQL

src/Validator/ResolveValidator/ResolveValidator.php

Doc Comments +3 added lines, -2 removed lines

@@ -42,8 +42,8 @@ 
 
     /**
      * @param AbstractObjectType      $objectType
-     * @param Mutation|Query|AstField $field
-     * @return null
+     * @param AstField $field
+     * @return boolean
      */
     public function objectHasField($objectType, $field)
     {
@@ -58,6 +58,7 @@ 
 
     /**
      * @inheritdoc
+     * @param Query $query
      */
     public function validateArguments(AbstractField $field, $query, Request $request)
     {

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use Youshido\GraphQL\Parser\Ast\Mutation;
 use Youshido\GraphQL\Parser\Ast\Query;
 use Youshido\GraphQL\Type\AbstractType;
-use Youshido\GraphQL\Type\CompositeTypeInterface;
 use Youshido\GraphQL\Type\InputObject\AbstractInputObjectType;
 use Youshido\GraphQL\Type\InterfaceType\AbstractInterfaceType;
 use Youshido\GraphQL\Type\ListType\AbstractListType;

src/Execution/Processor.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use Youshido\GraphQL\Schema\AbstractSchema;
 use Youshido\GraphQL\Type\AbstractType;
 use Youshido\GraphQL\Type\Object\AbstractObjectType;
-use Youshido\GraphQL\Type\Scalar\AbstractScalarType;
 use Youshido\GraphQL\Type\TypeInterface;
 use Youshido\GraphQL\Type\TypeMap;
 use Youshido\GraphQL\Type\TypeService;

Spacing +1 added lines, -1 removed lines

@@ -236,7 +236,7 @@
 
             $value = $listValue;
         } else {
-            $value = $this->getOutputValue($field->getType(), $preResolvedValue);//$this->getFieldValidatedValue($field, $preResolvedValue);
+            $value = $this->getOutputValue($field->getType(), $preResolvedValue); //$this->getFieldValidatedValue($field, $preResolvedValue);
         }
 
         return $value;

Tests/Performance/LoadTest.php

Spacing +3 added lines, -3 removed lines

@@ -43,12 +43,12 @@ 
             $authors = [];
             while (count($authors) < rand(1, 4)) {
                 $authors[] = [
-                    'name' => 'Author ' . substr(md5(time()), 0, 4)
+                    'name' => 'Author '.substr(md5(time()), 0, 4)
                 ];
             }
             $data[] = [
                 'id'      => $i,
-                'title'   => 'Title of ' . $i,
+                'title'   => 'Title of '.$i,
                 'authors' => $authors,
             ];
         }
@@ -69,7 +69,7 @@ 
 //        return true;
         $p->processPayload('{ posts { id, title, authors { name } } }');
         $res = $p->getResponseData();
-        echo "Count: " . count($res['data']['posts']) . "\n";
+        echo "Count: ".count($res['data']['posts'])."\n";
         printf("Test Time: %04f\n", microtime(true) - $time);
 //        $p->getResponseData();
     }

Tests/Schema/ProcessorTest.php

Indentation +76 added lines, -76 removed lines

@@ -212,19 +212,19 @@ 
         $this->assertEquals(['data' => ['labels' => ['one', 'two']]], $processor->getResponseData());
 
         $schema->getMutationType()
-               ->addField(new Field([
-                   'name'    => 'increaseCounter',
-                   'type'    => new IntType(),
-                   'resolve' => function ($value, $args, ResolveInfo $info) {
-                       return $this->_counter += $args['amount'];
-                   },
-                   'args'    => [
-                       'amount' => [
-                           'type'    => new IntType(),
-                           'default' => 1
-                       ]
-                   ]
-               ]))->addField(new Field([
+                ->addField(new Field([
+                    'name'    => 'increaseCounter',
+                    'type'    => new IntType(),
+                    'resolve' => function ($value, $args, ResolveInfo $info) {
+                        return $this->_counter += $args['amount'];
+                    },
+                    'args'    => [
+                        'amount' => [
+                            'type'    => new IntType(),
+                            'default' => 1
+                        ]
+                    ]
+                ]))->addField(new Field([
                 'name'    => 'invalidResolveTypeMutation',
                 'type'    => new NonNullType(new IntType()),
                 'resolve' => function () {
@@ -482,82 +482,82 @@ 
     }
 
     public function testComplexityReducer() {
-      $schema = new Schema(
-          [
-              'query' => new ObjectType(
-                  [
-                      'name'   => 'RootQuery',
-                      'fields' => [
-                          'me' => [
-                              'type'    => new ObjectType(
-                                  [
-                                      'name'   => 'User',
-                                      'fields' => [
-                                          'firstName' => [
-                                              'type'    => new StringType(),
-                                              'args'    => [
-                                                  'shorten' => new BooleanType()
-                                              ],
-                                              'resolve' => function ($value, $args) {
+        $schema = new Schema(
+            [
+                'query' => new ObjectType(
+                    [
+                        'name'   => 'RootQuery',
+                        'fields' => [
+                            'me' => [
+                                'type'    => new ObjectType(
+                                    [
+                                        'name'   => 'User',
+                                        'fields' => [
+                                            'firstName' => [
+                                                'type'    => new StringType(),
+                                                'args'    => [
+                                                    'shorten' => new BooleanType()
+                                                ],
+                                                'resolve' => function ($value, $args) {
                                                 return empty($args['shorten']) ? $value : $value;
-                                              }
-                                          ],
-                                          'lastName'  => new StringType(),
-                                          'code'      => new StringType(),
-                                          'likes'     => [
-                                              'type'    => new IntType(),
-                                              'cost'    => 10,
-                                              'resolve' => function () {
+                                                }
+                                            ],
+                                            'lastName'  => new StringType(),
+                                            'code'      => new StringType(),
+                                            'likes'     => [
+                                                'type'    => new IntType(),
+                                                'cost'    => 10,
+                                                'resolve' => function () {
                                                 return 42;
-                                              }
-                                          ]
-                                      ]
-                                  ]
-                              ),
-                              'cost' => function ($args, $context, $childCost) {
+                                                }
+                                            ]
+                                        ]
+                                    ]
+                                ),
+                                'cost' => function ($args, $context, $childCost) {
                                 $argsCost = isset($args['cost']) ? $args['cost'] : 1;
                                 return 1 + $argsCost * $childCost;
-                              },
-                              'resolve' => function ($value, $args) {
+                                },
+                                'resolve' => function ($value, $args) {
                                 $data = ['firstName' => 'John', 'code' => '007'];
 
                                 return $data;
-                              },
-                              'args'    => [
-                                  'cost' => [
-                                      'type'    => new IntType(),
-                                      'default' => 1
-                                  ]
-                              ]
-                          ]
-                      ]
-                  ]
-              )
-          ]
-      );
-      $processor = new Processor($schema);
-
-      $processor->setMaxComplexity(10);
-
-      $processor->processPayload('{ me { firstName, lastName } }');
-      $this->assertArrayNotHasKey('error', $processor->getResponseData());
-
-      $processor->processPayload('{ me { firstName, likes } }');
-      $this->assertEquals(['errors' => [['message' => 'query exceeded max allowed complexity of 10']]], $processor->getResponseData());
-
-      // don't let complexity reducer affect query errors
-      $processor->processPayload('{ me { badfield } }');
-      $this->assertArraySubset(['errors' => [['message' => 'Field "badfield" is not found in type "User"']]], $processor->getResponseData());
+                                },
+                                'args'    => [
+                                    'cost' => [
+                                        'type'    => new IntType(),
+                                        'default' => 1
+                                    ]
+                                ]
+                            ]
+                        ]
+                    ]
+                )
+            ]
+        );
+        $processor = new Processor($schema);
 
-      foreach (range(1,5) as $cost_multiplier) {
+        $processor->setMaxComplexity(10);
+
+        $processor->processPayload('{ me { firstName, lastName } }');
+        $this->assertArrayNotHasKey('error', $processor->getResponseData());
+
+        $processor->processPayload('{ me { firstName, likes } }');
+        $this->assertEquals(['errors' => [['message' => 'query exceeded max allowed complexity of 10']]], $processor->getResponseData());
+
+        // don't let complexity reducer affect query errors
+        $processor->processPayload('{ me { badfield } }');
+        $this->assertArraySubset(['errors' => [['message' => 'Field "badfield" is not found in type "User"']]], $processor->getResponseData());
+
+        foreach (range(1,5) as $cost_multiplier) {
         $visitor = new \Youshido\GraphQL\Execution\Visitor\MaxComplexityQueryVisitor(1000); // arbitrarily high cost
         $processor->processPayload("{ me (cost: $cost_multiplier) { firstName, lastName, code, likes } }", ['cost' => $cost_multiplier], [$visitor]);
         $expected = 1 + 13 * (1 + $cost_multiplier);
         $this->assertEquals($expected, $visitor->getMemo());
-      }
+        }
 
-      // TODO, variables not yet supported
-      /*$query = 'query costQuery ($cost: Int) { me (cost: $cost) { firstName, lastName, code, likes } }';
+        // TODO, variables not yet supported
+        /*$query = 'query costQuery ($cost: Int) { me (cost: $cost) { firstName, lastName, code, likes } }';
       foreach (range(1,5) as $cost_multiplier) {
         $visitor = new \Youshido\GraphQL\Execution\Visitor\MaxComplexityQueryVisitor(1000); // arbitrarily high cost
         $processor->processPayload($query, ['cost' => $cost_multiplier], [$visitor]);