Inspection of "Fix configuration template for phone field" - YetiForceCompany/YetiForceCRM - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — developer ( 777d92...98467c )

by Radosław

created 2023-11-07 07:06 UTC

Status

Spacing +23 added lines, -23 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@  discard block
 block discarded – undo
 		'enabledServices' => [
 			'default' => [],
 			'description' => 'List of active services. Available: dav, webservice',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return \is_array($arg) && empty(array_diff($arg, ['dav', 'webservice']));
 			},
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
 		'upload_maxsize' => [
 			'default' => 52428800,
 			'description' => 'Maximum file size for uploaded files in bytes also used when uploading import files: upload_maxsize default value = 52428800 (50MB)',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return $arg && \App\Validator::naturalNumber($arg) && ($arg * 1048576) <= \App\Config::getMaxUploadSize(false);
 			},
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
 		'allow_exports' => [
 			'default' => 'all',
 			'description' => 'Flag to allow export functionality: "all" - to allow anyone to use exports, "admin" - to only allow admins to export, "none" -  to block exports completely',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return \in_array($arg, ['all', 'admin', 'none']);
 			},
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
 		'list_max_entries_per_page' => [
 			'default' => 20,
 			'description' => 'List max entries per page: default value = 20',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return $arg && \App\Validator::naturalNumber($arg) && (100 >= $arg) && (0 < $arg);
 			},
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
 		'default_module' => [
 			'default' => 'Home',
 			'description' => 'Default module: default value = Home',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return true === \App\Module::isModuleActive($arg);
 			},
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
 		'listview_max_textlength' => [
 			'default' => 40,
 			'description' => 'Trim descriptions, titles in listviews to this value',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return $arg && \App\Validator::naturalNumber($arg) && (100 >= $arg) && (0 < $arg);
 			},
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
 		'default_timezone' => [
 			'default' => '_TIMEZONE_',
 			'description' => 'Set the default timezone as per your preference',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return \in_array($arg, timezone_identifiers_list());
 			},
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
 		'title_max_length' => [
 			'default' => 60,
 			'description' => 'Maximum length of characters for title',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return $arg && \App\Validator::naturalNumber($arg) && (100 >= $arg) && (0 < $arg);
 			},
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
 		'href_max_length' => [
 			'default' => 50,
 			'description' => 'Maximum length for href tag',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return $arg && \App\Validator::naturalNumber($arg) && (100 >= $arg) && (0 < $arg);
 			},
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
 		'MINIMUM_CRON_FREQUENCY' => [
 			'default' => 1,
 			'description' => 'Minimum cron frequency [min]',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return $arg && \App\Validator::naturalNumber($arg) && (100 >= $arg) && (0 < $arg);
 			},
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
 		'listMaxEntriesMassEdit' => [
 			'default' => 500,
 			'description' => 'Maximum number of records in a mass edition',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return $arg && \App\Validator::naturalNumber($arg) && (5000 >= $arg);
 			},
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
 		'phoneFieldAdvancedHrefFormat' => [
 			'default' => new \Nette\PhpGenerator\PhpLiteral('\libphonenumber\PhoneNumberFormat::RFC3966'),
 			'description' => "Phone number display format. Values:\nfalse - formatting is disabled \n\\libphonenumber\\PhoneNumberFormat::RFC3966 - +48-44-668-18-00\n\\libphonenumber\\PhoneNumberFormat::E164 - +48446681800 \n\\libphonenumber\\PhoneNumberFormat::INTERNATIONAL - 044 668 18 00\n\\libphonenumber\\PhoneNumberFormat::NATIONAL - +48 44 668 18 00",
-			'validation' => function () {
+			'validation' => function() {
 				return \in_array(func_get_arg(0), [
 					false,
 					\libphonenumber\PhoneNumberFormat::RFC3966,
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
 		'LOG_LEVELS' => [
 			'default' => false,
 			'description' => 'Level of saved/displayed logs. Values: false = All / 3 = error and warning / ["error", "warning", "info", "trace", "profile"]',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return false === $arg || (\is_array($arg) && array_diff(['error', 'warning', 'info', 'trace', 'profile'], $arg));
 			},
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
 		'SMARTY_ERROR_REPORTING' => [
 			'default' => new \Nette\PhpGenerator\PhpLiteral('E_ALL & ~E_NOTICE'),
 			'description' => 'Do not show Smarty Notice in phpError.log',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = (string) func_get_arg(0);
 				return \in_array($arg, ['E_ALL', 'E_ALL & ~E_NOTICE']);
 			},
@@ -413,7 +413,7 @@  discard block
 block discarded – undo
 		'EXCEPTION_ERROR_LEVEL' => [
 			'default' => new \Nette\PhpGenerator\PhpLiteral('E_ALL & ~E_NOTICE'),
 			'description' => "Set the error reporting level. The parameter is either an integer representing a bit field, or named constants.\nhttps://secure.php.net/manual/en/errorfunc.configuration.php#ini.error-reporting\nAll errors - E_ALL & ~E_NOTICE & ~E_STRICT & ~E_DEPRECATED / Critical errors - E_ERROR | E_WARNING | E_CORE_ERROR | E_COMPILE_ERROR | E_USER_ERROR",
-			'validation' => function () {
+			'validation' => function() {
 				$arg = (string) func_get_arg(0);
 				return \in_array($arg, ['E_ALL', 'E_ALL & ~E_NOTICE']);
 			},
@@ -585,7 +585,7 @@  discard block
 block discarded – undo
 		'CACHING_DRIVER' => [
 			'default' => 'Base',
 			'description' => 'Data caching is about storing some PHP variables in cache and retrieving it later from cache. Drivers: Base, Apcu',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return 'Basic' === $arg || 'Apcu' === $arg;
 			},
@@ -783,7 +783,7 @@  discard block
 block discarded – undo
 		'MODULES_SPLITTED_EDIT_VIEW_LAYOUT' => [
 			'default' => [],
 			'description' => 'List of modules with splitted edit view layout',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return \is_array($arg) && array_diff($arg, App\Module::getAllModuleNames());
 			},
@@ -888,7 +888,7 @@  discard block
 block discarded – undo
 		'GLOBAL_SEARCH_SORTING_RESULTS' => [
 			'default' => 0,
 			'description' => 'Global search - Should the results be sorted in MySQL or PHP while displaying (None = 0, PHP = 1, Mysql = 2). The parameter impacts system efficiency.',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return \is_int($arg) && \in_array($arg, [0, 1, 2]);
 			},
@@ -902,7 +902,7 @@  discard block
 block discarded – undo
 		'GLOBAL_SEARCH_AUTOCOMPLETE' => [
 			'default' => 1,
 			'description' => 'Global search - Search for records while entering text  (1/0).',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return \is_int($arg) && \in_array($arg, [0, 1]);
 			},
@@ -941,7 +941,7 @@  discard block
 block discarded – undo
 		'encryptionMethod' => [
 			'default' => 'aes-256-cbc',
 			'description' => 'Encryption method.',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return empty($arg) || ($arg && \in_array($arg, \App\Encryption::getMethods()));
 			},
@@ -1009,7 +1009,7 @@  discard block
 block discarded – undo
 		'permittedModulesByCreatorField' => [
 			'default' => [],
 			'description' => 'List of modules to which access is based on the record creation.',
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return \is_array($arg) && array_diff($arg, App\Module::getAllModuleNames());
 			},
@@ -1080,7 +1080,7 @@  discard block
 block discarded – undo
 		'cookieForceHttpOnly' => [
 			'default' => true,
 			'description' => "Force the use of https only for cookie.\nValues: true, false, null",
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return null === $arg ? $arg : \is_bool($arg);
 			},
@@ -1098,7 +1098,7 @@  discard block
 block discarded – undo
 		'USER_AUTHY_MODE' => [
 			'default' => 'TOTP_OPTIONAL',
 			'description' => "User authentication mode.\n\n@see \\Users_Totp_Authmethod::ALLOWED_USER_AUTHY_MODE\nAvailable values:\nTOTP_OFF - 2FA TOTP is checking off\nTOTP_OPTIONAL - It is defined by the user\nTOTP_OBLIGATORY - It is obligatory.",
-			'validation' => function () {
+			'validation' => function() {
 				$arg = func_get_arg(0);
 				return \in_array($arg, \Users_Totp_Authmethod::ALLOWED_USER_AUTHY_MODE);
 			},

Please login to merge, or discard this patch.

		@@ -10,7 +10,7 @@ discard block
		block discarded – undo
10	10	'enabledServices' => [
11	11	'default' => [],
12	12	'description' => 'List of active services. Available: dav, webservice',
13		- 'validation' => function () {
	13	+ 'validation' => function() {
14	14	$arg = func_get_arg(0);
15	15	return \is_array($arg) && empty(array_diff($arg, ['dav', 'webservice']));
16	16	},
		@@ -100,7 +100,7 @@ discard block
		block discarded – undo
100	100	'upload_maxsize' => [
101	101	'default' => 52428800,
102	102	'description' => 'Maximum file size for uploaded files in bytes also used when uploading import files: upload_maxsize default value = 52428800 (50MB)',
103		- 'validation' => function () {
	103	+ 'validation' => function() {
104	104	$arg = func_get_arg(0);
105	105	return $arg && \App\Validator::naturalNumber($arg) && ($arg * 1048576) <= \App\Config::getMaxUploadSize(false);
106	106	},
		@@ -109,7 +109,7 @@ discard block
		block discarded – undo
109	109	'allow_exports' => [
110	110	'default' => 'all',
111	111	'description' => 'Flag to allow export functionality: "all" - to allow anyone to use exports, "admin" - to only allow admins to export, "none" - to block exports completely',
112		- 'validation' => function () {
	112	+ 'validation' => function() {
113	113	$arg = func_get_arg(0);
114	114	return \in_array($arg, ['all', 'admin', 'none']);
115	115	},
		@@ -121,7 +121,7 @@ discard block
		block discarded – undo
121	121	'list_max_entries_per_page' => [
122	122	'default' => 20,
123	123	'description' => 'List max entries per page: default value = 20',
124		- 'validation' => function () {
	124	+ 'validation' => function() {
125	125	$arg = func_get_arg(0);
126	126	return $arg && \App\Validator::naturalNumber($arg) && (100 >= $arg) && (0 < $arg);
127	127	},
		@@ -130,7 +130,7 @@ discard block
		block discarded – undo
130	130	'default_module' => [
131	131	'default' => 'Home',
132	132	'description' => 'Default module: default value = Home',
133		- 'validation' => function () {
	133	+ 'validation' => function() {
134	134	$arg = func_get_arg(0);
135	135	return true === \App\Module::isModuleActive($arg);
136	136	},
		@@ -154,7 +154,7 @@ discard block
		block discarded – undo
154	154	'listview_max_textlength' => [
155	155	'default' => 40,
156	156	'description' => 'Trim descriptions, titles in listviews to this value',
157		- 'validation' => function () {
	157	+ 'validation' => function() {
158	158	$arg = func_get_arg(0);
159	159	return $arg && \App\Validator::naturalNumber($arg) && (100 >= $arg) && (0 < $arg);
160	160	},
		@@ -167,7 +167,7 @@ discard block
		block discarded – undo
167	167	'default_timezone' => [
168	168	'default' => '_TIMEZONE_',
169	169	'description' => 'Set the default timezone as per your preference',
170		- 'validation' => function () {
	170	+ 'validation' => function() {
171	171	$arg = func_get_arg(0);
172	172	return \in_array($arg, timezone_identifiers_list());
173	173	},
		@@ -175,7 +175,7 @@ discard block
		block discarded – undo
175	175	'title_max_length' => [
176	176	'default' => 60,
177	177	'description' => 'Maximum length of characters for title',
178		- 'validation' => function () {
	178	+ 'validation' => function() {
179	179	$arg = func_get_arg(0);
180	180	return $arg && \App\Validator::naturalNumber($arg) && (100 >= $arg) && (0 < $arg);
181	181	},
		@@ -184,7 +184,7 @@ discard block
		block discarded – undo
184	184	'href_max_length' => [
185	185	'default' => 50,
186	186	'description' => 'Maximum length for href tag',
187		- 'validation' => function () {
	187	+ 'validation' => function() {
188	188	$arg = func_get_arg(0);
189	189	return $arg && \App\Validator::naturalNumber($arg) && (100 >= $arg) && (0 < $arg);
190	190	},
		@@ -193,7 +193,7 @@ discard block
		block discarded – undo
193	193	'MINIMUM_CRON_FREQUENCY' => [
194	194	'default' => 1,
195	195	'description' => 'Minimum cron frequency [min]',
196		- 'validation' => function () {
	196	+ 'validation' => function() {
197	197	$arg = func_get_arg(0);
198	198	return $arg && \App\Validator::naturalNumber($arg) && (100 >= $arg) && (0 < $arg);
199	199	},
		@@ -211,7 +211,7 @@ discard block
		block discarded – undo
211	211	'listMaxEntriesMassEdit' => [
212	212	'default' => 500,
213	213	'description' => 'Maximum number of records in a mass edition',
214		- 'validation' => function () {
	214	+ 'validation' => function() {
215	215	$arg = func_get_arg(0);
216	216	return $arg && \App\Validator::naturalNumber($arg) && (5000 >= $arg);
217	217	},
		@@ -265,7 +265,7 @@ discard block
		block discarded – undo
265	265	'phoneFieldAdvancedHrefFormat' => [
266	266	'default' => new \Nette\PhpGenerator\PhpLiteral('\libphonenumber\PhoneNumberFormat::RFC3966'),
267	267	'description' => "Phone number display format. Values:\nfalse - formatting is disabled \n\\libphonenumber\\PhoneNumberFormat::RFC3966 - +48-44-668-18-00\n\\libphonenumber\\PhoneNumberFormat::E164 - +48446681800 \n\\libphonenumber\\PhoneNumberFormat::INTERNATIONAL - 044 668 18 00\n\\libphonenumber\\PhoneNumberFormat::NATIONAL - +48 44 668 18 00",
268		- 'validation' => function () {
	268	+ 'validation' => function() {
269	269	return \in_array(func_get_arg(0), [
270	270	false,
271	271	\libphonenumber\PhoneNumberFormat::RFC3966,
		@@ -324,7 +324,7 @@ discard block
		block discarded – undo
324	324	'LOG_LEVELS' => [
325	325	'default' => false,
326	326	'description' => 'Level of saved/displayed logs. Values: false = All / 3 = error and warning / ["error", "warning", "info", "trace", "profile"]',
327		- 'validation' => function () {
	327	+ 'validation' => function() {
328	328	$arg = func_get_arg(0);
329	329	return false === $arg \|\| (\is_array($arg) && array_diff(['error', 'warning', 'info', 'trace', 'profile'], $arg));
330	330	},
		@@ -405,7 +405,7 @@ discard block
		block discarded – undo
405	405	'SMARTY_ERROR_REPORTING' => [
406	406	'default' => new \Nette\PhpGenerator\PhpLiteral('E_ALL & ~E_NOTICE'),
407	407	'description' => 'Do not show Smarty Notice in phpError.log',
408		- 'validation' => function () {
	408	+ 'validation' => function() {
409	409	$arg = (string) func_get_arg(0);
410	410	return \in_array($arg, ['E_ALL', 'E_ALL & ~E_NOTICE']);
411	411	},
		@@ -413,7 +413,7 @@ discard block
		block discarded – undo
413	413	'EXCEPTION_ERROR_LEVEL' => [
414	414	'default' => new \Nette\PhpGenerator\PhpLiteral('E_ALL & ~E_NOTICE'),
415	415	'description' => "Set the error reporting level. The parameter is either an integer representing a bit field, or named constants.\nhttps://secure.php.net/manual/en/errorfunc.configuration.php#ini.error-reporting\nAll errors - E_ALL & ~E_NOTICE & ~E_STRICT & ~E_DEPRECATED / Critical errors - E_ERROR \| E_WARNING \| E_CORE_ERROR \| E_COMPILE_ERROR \| E_USER_ERROR",
416		- 'validation' => function () {
	416	+ 'validation' => function() {
417	417	$arg = (string) func_get_arg(0);
418	418	return \in_array($arg, ['E_ALL', 'E_ALL & ~E_NOTICE']);
419	419	},
		@@ -585,7 +585,7 @@ discard block
		block discarded – undo
585	585	'CACHING_DRIVER' => [
586	586	'default' => 'Base',
587	587	'description' => 'Data caching is about storing some PHP variables in cache and retrieving it later from cache. Drivers: Base, Apcu',
588		- 'validation' => function () {
	588	+ 'validation' => function() {
589	589	$arg = func_get_arg(0);
590	590	return 'Basic' === $arg \|\| 'Apcu' === $arg;
591	591	},
		@@ -783,7 +783,7 @@ discard block
		block discarded – undo
783	783	'MODULES_SPLITTED_EDIT_VIEW_LAYOUT' => [
784	784	'default' => [],
785	785	'description' => 'List of modules with splitted edit view layout',
786		- 'validation' => function () {
	786	+ 'validation' => function() {
787	787	$arg = func_get_arg(0);
788	788	return \is_array($arg) && array_diff($arg, App\Module::getAllModuleNames());
789	789	},
		@@ -888,7 +888,7 @@ discard block
		block discarded – undo
888	888	'GLOBAL_SEARCH_SORTING_RESULTS' => [
889	889	'default' => 0,
890	890	'description' => 'Global search - Should the results be sorted in MySQL or PHP while displaying (None = 0, PHP = 1, Mysql = 2). The parameter impacts system efficiency.',
891		- 'validation' => function () {
	891	+ 'validation' => function() {
892	892	$arg = func_get_arg(0);
893	893	return \is_int($arg) && \in_array($arg, [0, 1, 2]);
894	894	},
		@@ -902,7 +902,7 @@ discard block
		block discarded – undo
902	902	'GLOBAL_SEARCH_AUTOCOMPLETE' => [
903	903	'default' => 1,
904	904	'description' => 'Global search - Search for records while entering text (1/0).',
905		- 'validation' => function () {
	905	+ 'validation' => function() {
906	906	$arg = func_get_arg(0);
907	907	return \is_int($arg) && \in_array($arg, [0, 1]);
908	908	},
		@@ -941,7 +941,7 @@ discard block
		block discarded – undo
941	941	'encryptionMethod' => [
942	942	'default' => 'aes-256-cbc',
943	943	'description' => 'Encryption method.',
944		- 'validation' => function () {
	944	+ 'validation' => function() {
945	945	$arg = func_get_arg(0);
946	946	return empty($arg) \|\| ($arg && \in_array($arg, \App\Encryption::getMethods()));
947	947	},
		@@ -1009,7 +1009,7 @@ discard block
		block discarded – undo
1009	1009	'permittedModulesByCreatorField' => [
1010	1010	'default' => [],
1011	1011	'description' => 'List of modules to which access is based on the record creation.',
1012		- 'validation' => function () {
	1012	+ 'validation' => function() {
1013	1013	$arg = func_get_arg(0);
1014	1014	return \is_array($arg) && array_diff($arg, App\Module::getAllModuleNames());
1015	1015	},
		@@ -1080,7 +1080,7 @@ discard block
		block discarded – undo
1080	1080	'cookieForceHttpOnly' => [
1081	1081	'default' => true,
1082	1082	'description' => "Force the use of https only for cookie.\nValues: true, false, null",
1083		- 'validation' => function () {
	1083	+ 'validation' => function() {
1084	1084	$arg = func_get_arg(0);
1085	1085	return null === $arg ? $arg : \is_bool($arg);
1086	1086	},
		@@ -1098,7 +1098,7 @@ discard block
		block discarded – undo
1098	1098	'USER_AUTHY_MODE' => [
1099	1099	'default' => 'TOTP_OPTIONAL',
1100	1100	'description' => "User authentication mode.\n\n@see \\Users_Totp_Authmethod::ALLOWED_USER_AUTHY_MODE\nAvailable values:\nTOTP_OFF - 2FA TOTP is checking off\nTOTP_OPTIONAL - It is defined by the user\nTOTP_OBLIGATORY - It is obligatory.",
1101		- 'validation' => function () {
	1101	+ 'validation' => function() {
1102	1102	$arg = func_get_arg(0);
1103	1103	return \in_array($arg, \Users_Totp_Authmethod::ALLOWED_USER_AUTHY_MODE);
1104	1104	},

YetiForceCompany / YetiForceCRM

Push — developer ( 777d92...98467c )

Status

Category

Spacing +23 added lines, -23 removed lines patch added patch discarded remove patch