YetiForceCompany / YetiForceCRM

modules/Accounts/Accounts.php

Doc Comments +2 added lines, -1 removed lines

@@ -611,6 +611,7 @@ 
 	 * @param  integer   $id      		- accountid
 	 * @param  array   $parent_accounts   - Array of all the parent accounts
 	 * returns All the parent accounts of the given accountid in array format
+	 * @param integer[] $encountered_accounts
 	 */
 	public function __getParentAccounts($id, &$parent_accounts, &$encountered_accounts, $depthBase = 0)
 	{
@@ -673,7 +674,7 @@ 
 	 * Function to Recursively get all the child accounts of a given Account
 	 * @param  integer   $id      		- accountid
 	 * @param  array   $child_accounts   - Array of all the child accounts
-	 * @param  integer   $depth          - Depth at which the particular account has to be placed in the hierarchy
+	 * @param  integer   $depthBase          - Depth at which the particular account has to be placed in the hierarchy
 	 * returns All the child accounts of the given accountid in array format
 	 */
 	public function __getChildAccounts($id, &$child_accounts, $depthBase)

Braces +23 added lines, -16 removed lines

@@ -111,10 +111,11 @@ 
 		$query .= $this->getNonAdminAccessControlQuery('Accounts', $current_user);
 		$where_auto = " vtiger_crmentity.deleted = 0 ";
 
-		if ($where != '')
-			$query .= sprintf(' where (%s) && %s', $where, $where_auto);
-		else
-			$query .= sprintf(' where %s', $where_auto);
+		if ($where != '') {
+					$query .= sprintf(' where (%s) && %s', $where, $where_auto);
+		} else {
+					$query .= sprintf(' where %s', $where_auto);
+		}
 
 		\App\Log::trace("Exiting create_export_query method ...");
 		return $query;
@@ -430,8 +431,9 @@ 
 	public function unlinkRelationship($id, $return_module, $return_id, $relatedName = false)
 	{
 
-		if (empty($return_module) || empty($return_id))
-			return;
+		if (empty($return_module) || empty($return_id)) {
+					return;
+		}
 
 		if ($return_module === 'Campaigns') {
 			App\Db::getInstance()->createCommand()->delete('vtiger_campaign_records', ['crmid' => $id, 'campaignid' => $return_id])->execute();
@@ -444,8 +446,9 @@ 
 
 	public function save_related_module($module, $crmid, $with_module, $with_crmids, $relatedName = false)
 	{
-		if (!is_array($with_crmids))
-			$with_crmids = [$with_crmids];
+		if (!is_array($with_crmids)) {
+					$with_crmids = [$with_crmids];
+		}
 		if (!in_array($with_module, ['Products', 'Campaigns'])) {
 			parent::save_related_module($module, $crmid, $with_module, $with_crmids, $relatedName);
 		} else {
@@ -495,10 +498,12 @@ 
 					continue;
 				}
 				// Setup the default JOIN conditions if not specified
-				if (empty($relmap[1]))
-					$relmap[1] = $other->table_name;
-				if (empty($relmap[2]))
-					$relmap[2] = $relmap[0];
+				if (empty($relmap[1])) {
+									$relmap[1] = $other->table_name;
+				}
+				if (empty($relmap[2])) {
+									$relmap[2] = $relmap[0];
+				}
 				$join .= " LEFT JOIN $tname ON $tname.$relmap[0] = $relmap[1].$relmap[2]";
 			}
 		}
@@ -523,14 +528,16 @@ 
 	public function getRelatedContactsIds($id = null)
 	{
 
-		if ($id === null)
-			$id = $this->id;
+		if ($id === null) {
+					$id = $this->id;
+		}
 		$query = (new \App\Db\Query())->select('contactid')->from('vtiger_contactdetails')
 			->innerJoin('vtiger_crmentity', 'vtiger_contactdetails.contactid = vtiger_crmentity.crmid')
 			->where(['vtiger_contactdetails.parentid' => $id, 'vtiger_crmentity.deleted' => 0]);
 		$entityIds = $query->column();
-		if (empty($entityIds))
-			$entityIds = [];
+		if (empty($entityIds)) {
+					$entityIds = [];
+		}
 
 		return $entityIds;
 	}

modules/Calendar/actions/Calendar.php

Doc Comments +3 added lines

@@ -109,6 +109,9 @@
 		$response->emit();
 	}
 
+	/**
+	 * @param string $datetime
+	 */
 	public function changeDateTime($datetime, $delta)
 	{
 		$date = new DateTime($datetime);

modules/Calendar/actions/DragDropAjax.php

Doc Comments +3 added lines

@@ -119,6 +119,9 @@
 	 * Function adds days and minutes to datetime string
 	 */
 
+	/**
+	 * @param string $datetime
+	 */
 	public function changeDateTime($datetime, $daysToAdd, $minutesToAdd)
 	{
 		$datetime = strtotime($datetime);

Braces +11 added lines, -8 removed lines

@@ -51,8 +51,9 @@ 
 			$resultDateTime = $this->changeDateTime($oldDateTime, $dayDelta, $minuteDelta);
 			$parts = explode(' ', $resultDateTime);
 			$record->set('due_date', $parts[0]);
-			if (activitytype != 'Task')
-				$record->set('time_end', $parts[1]);
+			if (activitytype != 'Task') {
+							$record->set('time_end', $parts[1]);
+			}
 
 			$startDateTime[] = $record->get('date_start');
 			$startDateTime[] = $record->get('time_start');
@@ -64,10 +65,11 @@ 
 			$endDateTime = implode(' ', $endDateTime);
 			$endDateTime = new DateTime($endDateTime);
 			//Checking if startDateTime is less than or equal to endDateTime
-			if ($startDateTime <= $endDateTime)
-				$record->save();
-			else
-				$result['error'] = true;
+			if ($startDateTime <= $endDateTime) {
+							$record->save();
+			} else {
+							$result['error'] = true;
+			}
 
 			$response->setResult($result);
 			$response->emit();
@@ -107,8 +109,9 @@ 
 			$resultDateTime = $this->changeDateTime($oldEndDateTime, $dayDelta, $minuteDelta);
 			$parts = explode(' ', $resultDateTime);
 			$record->set('due_date', $parts[0]);
-			if (activitytype != 'Task')
-				$record->set('time_end', $parts[1]);
+			if (activitytype != 'Task') {
+							$record->set('time_end', $parts[1]);
+			}
 			$record->save();
 
 			$response->setResult($result);

modules/Calendar/Date.php

Doc Comments +1 added lines, -5 removed lines

@@ -384,7 +384,7 @@ 
 
 	/**
 	 *
-	 * @return Date
+	 * @return string
 	 */
 	public function get_DB_formatted_date()
 	{
@@ -529,10 +529,6 @@ 
 	 * This should be used whereever possible
 	 *
 	 * @param integer       $index - number between 0 to 42
-	 * @param string        $day   - date
-	 * @param string        $month - month
-	 * @param string        $year  - year
-	 * return vt_DateTime obj  $datetimevalue
 	 */
 	public function getThisMonthsDayByIndex($index)
 	{

Braces +37 added lines, -26 removed lines

@@ -87,12 +87,15 @@ 
 	 */
 	public function getTodayDatetimebyIndex($index, $day = '', $month = '', $year = '')
 	{
-		if ($day === '')
-			$day = $this->day;
-		if ($month === '')
-			$month = $this->month;
-		if ($year === '')
-			$year = $this->year;
+		if ($day === '') {
+					$day = $this->day;
+		}
+		if ($month === '') {
+					$month = $this->month;
+		}
+		if ($year === '') {
+					$year = $this->year;
+		}
 		$day_array = [];
 
 		if ($index < 0 || $index > 23) {
@@ -140,12 +143,15 @@ 
 	 */
 	public function getThismonthDaysbyIndex($index, $day = '', $month = '', $year = '')
 	{
-		if ($day == '')
-			$day = $index + 1;
-		if ($month == '')
-			$month = $this->month;
-		if ($year == '')
-			$year = $this->year;
+		if ($day == '') {
+					$day = $index + 1;
+		}
+		if ($month == '') {
+					$month = $this->month;
+		}
+		if ($year == '') {
+					$year = $this->year;
+		}
 		$month_array = [];
 		$month_array['day'] = $day;
 		$month_array['month'] = $month;
@@ -355,8 +361,9 @@ 
 		} else {
 			throw new \App\Exceptions\AppException('year was not set');
 		}
-		if (empty($hour) && $hour !== 0)
-			$hour = 0;
+		if (empty($hour) && $hour !== 0) {
+					$hour = 0;
+		}
 		$this->ts = mktime($hour, $minute, $second, $month, $day, $year);
 		$this->setDateTime($this->ts);
 	}
@@ -398,10 +405,12 @@ 
 	{
 		$hour = $this->z_hour;
 		$min = $this->minute;
-		if (empty($hour))
-			$hour = '00';
-		if (empty($min))
-			$min = '00';
+		if (empty($hour)) {
+					$hour = '00';
+		}
+		if (empty($min)) {
+					$min = '00';
+		}
 		return $hour . ':' . $min;
 	}
 
@@ -412,10 +421,11 @@ 
 	 */
 	public function get_changed_day($mode)
 	{
-		if ($mode == 'increment')
-			$day = $this->day + 1;
-		else
-			$day = $this->day - 1;
+		if ($mode == 'increment') {
+					$day = $this->day + 1;
+		} else {
+					$day = $this->day - 1;
+		}
 		$date_data = array('day' => $day,
 			'month' => $this->month,
 			'year' => $this->year
@@ -431,10 +441,11 @@ 
 	public function get_first_day_of_changed_week($mode)
 	{
 		$first_day = $this->getThisweekDaysbyIndex(1);
-		if ($mode == 'increment')
-			$day = $first_day->day + 7;
-		else
-			$day = $first_day->day - 7;
+		if ($mode == 'increment') {
+					$day = $first_day->day + 7;
+		} else {
+					$day = $first_day->day - 7;
+		}
 		$date_data = array('day' => $day,
 			'month' => $first_day->month,
 			'year' => $first_day->year

modules/OSSEmployees/OSSEmployees.php

Doc Comments +7 added lines

@@ -149,6 +149,10 @@ 
 		return $hierarchy;
 	}
 
+	/**
+	 * @param integer $id
+	 * @param integer[] $encountered_accounts
+	 */
 	public function __getParentEmployees($id, &$parent_accounts, &$encountered_accounts)
 	{
 		$adb = PearDatabase::getInstance();
@@ -200,6 +204,9 @@ 
 		return $parent_accounts;
 	}
 
+	/**
+	 * @param integer $id
+	 */
 	public function __getChildEmployees($id, &$child_accounts, $depth)
 	{
 		$adb = PearDatabase::getInstance();

Braces +3 added lines, -2 removed lines

@@ -257,8 +257,9 @@
 			$modcommentsModuleInstance = vtlib\Module::getInstance('ModComments');
 			if ($modcommentsModuleInstance && file_exists('modules/ModComments/ModComments.php')) {
 				include_once 'modules/ModComments/ModComments.php';
-				if (class_exists('ModComments'))
-					ModComments::addWidgetTo(array('OSSEmployees'));
+				if (class_exists('ModComments')) {
+									ModComments::addWidgetTo(array('OSSEmployees'));
+				}
 			}
 		} else if ($event_type == 'module.disabled') {
 			

modules/PaymentsIn/helpers/mt940.php

Doc Comments +15 added lines

@@ -50,6 +50,9 @@ 
 		return $xml;
 	}
 
+	/**
+	 * @param integer $level
+	 */
 	protected function createXML($key, $value, $level)
 	{
 		$indent = '';
@@ -69,6 +72,9 @@ 
 		return $xml;
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -114,6 +120,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(
@@ -124,6 +133,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseBalance($value)
 	{
 		return array(
@@ -134,6 +146,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(

Braces +19 added lines, -14 removed lines

@@ -34,8 +34,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	public function getXML()
@@ -53,13 +54,15 @@ 
 	protected function createXML($key, $value, $level)
 	{
 		$indent = '';
-		for ($i = 0; $i <= $level; $i++)
-			$indent .= "\t";
+		for ($i = 0; $i <= $level; $i++) {
+					$indent .= "\t";
+		}
 		if (is_array($value)) {
 			$xml = "$indent<$key>\n";
 			foreach ($value as $subKey => $subVal) {
-				if (is_numeric($subKey))
-					$subKey = substr($key, 0, -1);
+				if (is_numeric($subKey)) {
+									$subKey = substr($key, 0, -1);
+				}
 				$xml .= $this->createXML($subKey, $subVal, $level + 1);
 			}
 			$xml .= "$indent</$key>\n";
@@ -85,10 +88,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -103,10 +107,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;

modules/PaymentsIn/helpers/subclass/mt940_Alior.php

Doc Comments +9 added lines

@@ -20,6 +20,9 @@ 
 			$this->parseLine($line);
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -65,6 +68,9 @@ 
 		$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(
@@ -129,6 +135,9 @@ 
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(

Braces +13 added lines, -10 removed lines

@@ -16,8 +16,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	protected function parseLine($line)
@@ -36,10 +37,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -54,10 +56,11 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;

modules/PaymentsIn/helpers/subclass/mt940_BGK.php

Doc Comments +9 added lines

@@ -20,6 +20,9 @@ 
 			$this->parseLine($line);
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 		$tag = substr($line, 1, strpos($line, ':', 1) - 1);
@@ -66,6 +69,9 @@ 
 			$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(
@@ -84,6 +90,9 @@ 
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(

Braces +11 added lines, -8 removed lines

@@ -16,8 +16,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	protected function parseLine($line)
@@ -36,10 +37,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -62,8 +64,9 @@ 
 			default:
 				break;
 		}
-		if ($tag)
-			$this->_lastTag = $tag;
+		if ($tag) {
+					$this->_lastTag = $tag;
+		}
 	}
 
 	protected function parseTransaction($value)

modules/PaymentsIn/helpers/subclass/mt940_Citi.php

Doc Comments +9 added lines

@@ -20,6 +20,9 @@ 
 			$this->parseLine($line);
 	}
 
+	/**
+	 * @param string $line
+	 */
 	protected function parseLine($line)
 	{
 
@@ -68,6 +71,9 @@ 
 			$this->_lastTag = $tag;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseTransaction($value)
 	{
 		$transaction = array(
@@ -113,6 +119,9 @@ 
 		$this->operations[count($this->operations) - 1]['details'] = $transaction;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	protected function parseOperation($value)
 	{
 		$this->operations[] = array(

Braces +16 added lines, -12 removed lines

@@ -18,8 +18,9 @@ 
 	public function parse()
 	{
 		$tab = $this->prepareFile();
-		foreach ($tab as $line)
-			$this->parseLine($line);
+		foreach ($tab as $line) {
+					$this->parseLine($line);
+		}
 	}
 
 	protected function parseLine($line)
@@ -38,10 +39,11 @@ 
 				break;
 			case 'NS':
 				$code = substr($value, 0, 2);
-				if ($code == '22')
-					$this->ownerName = substr($value, 2);
-				else if ($code == '23')
-					$this->accountName = substr($value, 2);
+				if ($code == '22') {
+									$this->ownerName = substr($value, 2);
+				} else if ($code == '23') {
+									$this->accountName = substr($value, 2);
+				}
 				break;
 			case '60F':
 				$this->openBalance = $this->parseBalance($value);
@@ -56,16 +58,18 @@ 
 				self::parseOperation($value);
 				break;
 			case '86':
-				if ($this->_lastTag == '61')
-					$this->parseTransaction($value);
-				else
-					$this->info .= $value;
+				if ($this->_lastTag == '61') {
+									$this->parseTransaction($value);
+				} else {
+									$this->info .= $value;
+				}
 				break;
 			default:
 				break;
 		}
-		if ($tag)
-			$this->_lastTag = $tag;
+		if ($tag) {
+					$this->_lastTag = $tag;
+		}
 	}
 
 	protected function parseTransaction($value)