Yapeal / yapeal-ng

lib/FileSystem/CommonFileHandlingTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
 trait CommonFileHandlingTrait
 {
     /**
-     * @param                   $fileName
+     * @param                   string $fileName
      * @param MediatorInterface $yem
      * @param string            $mode
      *

Spacing +4 added lines, -4 removed lines

@@ -135,17 +135,17 @@ 
     protected function isWritablePath($path, MediatorInterface $yem)
     {
         if (!is_readable($path)) {
-            $mess = 'Cache path is NOT readable or does NOT exist, was given ' . $path;
+            $mess = 'Cache path is NOT readable or does NOT exist, was given '.$path;
             $yem->triggerLogEvent('Yapeal.Log.log', Logger::NOTICE, $mess);
             return false;
         }
         if (!is_dir($path)) {
-            $mess = 'Cache path is NOT a directory, was given ' . $path;
+            $mess = 'Cache path is NOT a directory, was given '.$path;
             $yem->triggerLogEvent('Yapeal.Log.log', Logger::NOTICE, $mess);
             return false;
         }
         if (!is_writable($path)) {
-            $mess = 'Cache path is NOT writable, was given ' . $path;
+            $mess = 'Cache path is NOT writable, was given '.$path;
             $yem->triggerLogEvent('Yapeal.Log.log', Logger::NOTICE, $mess);
             return false;
         }
@@ -214,7 +214,7 @@ 
     protected function safeFileRead($fileName, MediatorInterface $yem)
     {
         if (!is_readable($fileName) || !is_file($fileName)) {
-            $mess = 'Could NOT find accessible file, was given ' . $fileName;
+            $mess = 'Could NOT find accessible file, was given '.$fileName;
             $yem->triggerLogEvent('Yapeal.Log.log', Logger::INFO, $mess);
             return false;
         }

lib/Log/MessageBuilderTrait.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
      */
     protected function createEveApiMessage($messagePrefix, EveApiReadWriteInterface $data)
     {
-        $mess = $messagePrefix . ' Eve API %1$s/%2$s';
+        $mess = $messagePrefix.' Eve API %1$s/%2$s';
         $subs = [lcfirst($data->getEveApiSectionName()), $data->getEveApiName()];
         if ($data->hasEveApiArgument('keyID')) {
             $mess .= ' for keyID = %3$s';

lib/FileSystem/CachePreserver.php

Spacing +2 added lines, -2 removed lines

@@ -103,10 +103,10 @@
     public function setCachePath($value = null)
     {
         if ($value === null) {
-            $value = dirname(dirname(__DIR__)) . '/cache/';
+            $value = dirname(dirname(__DIR__)).'/cache/';
         }
         if (!is_string($value)) {
-            $mess = 'Cache path MUST be string, but was given ' . gettype($value);
+            $mess = 'Cache path MUST be string, but was given '.gettype($value);
             throw new InvalidArgumentException($mess);
         }
         if ('' === $this->cachePath) {

lib/Sql/CommonSqlQueries.php

Spacing +2 added lines, -2 removed lines

@@ -380,11 +380,11 @@
     public function getUpsert($tableName, array $columnNameList, $rowCount)
     {
         $columns = implode('","', $columnNameList);
-        $rowPrototype = '(' . implode(',', array_fill(0, count($columnNameList), '?')) . ')';
+        $rowPrototype = '('.implode(',', array_fill(0, count($columnNameList), '?')).')';
         $rows = implode(',', array_fill(0, $rowCount, $rowPrototype));
         $updates = [];
         foreach ($columnNameList as $column) {
-            $updates[] = '"' . $column . '"=VALUES("' . $column . '")';
+            $updates[] = '"'.$column.'"=VALUES("'.$column.'")';
         }
         $updates = implode(',', $updates);
         $sql = sprintf(

Doc Comments +1 added lines, -1 removed lines

@@ -372,7 +372,7 @@
     }
     /**
      * @param string $tableName
-     * @param array  $columnNameList
+     * @param string[]  $columnNameList
      * @param string $rowCount
      *
      * @return string

lib/Xml/ErrorCacheIntervalSubscriber.php

Spacing +2 added lines, -2 removed lines

@@ -80,7 +80,7 @@ 
         }
         if ($code < 200) {
             if (false !== strpos($mess, 'retry after')) {
-                $data->setCacheInterval(strtotime(substr($mess, -19) . '+00:00') - time());
+                $data->setCacheInterval(strtotime(substr($mess, -19).'+00:00') - time());
             }
             $yem->triggerLogEvent('Yapeal.Log.log', Logger::WARNING,
                 $this->createEventMessage($mess, $data, $eventName));
@@ -97,7 +97,7 @@ 
             $data->setCacheInterval(300);
         }
         $apiName = $data->getEveApiName();
-        $data->setEveApiName('Error_' . $apiName);
+        $data->setEveApiName('Error_'.$apiName);
         // Cache error XML.
         $this->emitEvents($data, 'cache');
         $data->setEveApiName($apiName);

lib/Configuration/EventWiring.php

Spacing +3 added lines, -3 removed lines

@@ -50,20 +50,20 @@
     {
         if (empty($dic['Yapeal.Event.EveApiEvent'])) {
             $dic['Yapeal.Event.EveApi'] = $dic->factory(
-                function ($dic) {
+                function($dic) {
                     return new $dic['Yapeal.Event.Factories.eveApi']();
                 }
             );
         }
         if (empty($dic['Yapeal.Event.LogEvent'])) {
             $dic['Yapeal.Event.LogEvent'] = $dic->factory(
-                function ($dic) {
+                function($dic) {
                     return new $dic['Yapeal.Event.Factories.log'];
                 }
             );
         }
         if (empty($dic['Yapeal.Event.Mediator'])) {
-            $dic['Yapeal.Event.Mediator'] = function ($dic) {
+            $dic['Yapeal.Event.Mediator'] = function($dic) {
                 return new $dic['Yapeal.Event.mediator']($dic);
             };
         }

lib/Sql/PreserverTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
      * @param array               $columnDefaults
      * @param \SimpleXMLElement[] $rows
      *
-     * @return array
+     * @return string[]
      */
     protected function processXmlRows(array $columnDefaults, array $rows)
     {

Spacing +3 added lines, -3 removed lines

@@ -169,7 +169,7 @@ 
             ->triggerLogEvent('Yapeal.Log.log', Logger::INFO, $mess);
         $mess = implode(',', $columns);
         if (512 < strlen($mess)) {
-            $mess = substr($mess, 0, 512) . '...';
+            $mess = substr($mess, 0, 512).'...';
         }
         $this->getYem()
             ->triggerLogEvent('Yapeal.Log.log', Logger::DEBUG, $mess);
@@ -226,7 +226,7 @@ 
             }
         }
         $required = array_reduce($columnDefaults,
-            function ($carry, $item) {
+            function($carry, $item) {
                 return $carry + (int)(null === $item);
             },
             0);
@@ -234,7 +234,7 @@ 
             return $this;
         }
         uksort($columnDefaults,
-            function ($alpha, $beta) {
+            function($alpha, $beta) {
                 $alpha = strtolower($alpha);
                 $beta = strtolower($beta);
                 if ($alpha < $beta) {

lib/Xml/EveApiXmlData.php

Spacing +7 added lines, -7 removed lines

@@ -57,7 +57,7 @@ 
             return $this;
         }
         if (!is_string($name)) {
-            $mess = 'Name MUST be string but was given ' . gettype($name);
+            $mess = 'Name MUST be string but was given '.gettype($name);
             throw new InvalidArgumentException($mess);
         }
         $this->eveApiArguments[$name] = (string)$value;
@@ -89,7 +89,7 @@ 
     {
         $name = (string)$name;
         if (!array_key_exists($name, $this->eveApiArguments)) {
-            $mess = 'Unknown argument ' . $name;
+            $mess = 'Unknown argument '.$name;
             throw new DomainException($mess);
         }
         return $this->eveApiArguments[$name];
@@ -151,14 +151,14 @@ 
      */
     public function getHash()
     {
-        $hash = $this->getEveApiName() . $this->getEveApiSectionName();
+        $hash = $this->getEveApiName().$this->getEveApiSectionName();
         $arguments = $this->getEveApiArguments();
         ksort($arguments);
         foreach ($arguments as $key => $value) {
             if ('mask' === $key) {
                 continue;
             }
-            $hash .= $key . $value;
+            $hash .= $key.$value;
         }
         return hash('md5', $hash);
     }
@@ -228,7 +228,7 @@ 
     public function setEveApiName($value)
     {
         if (!is_string($value)) {
-            $mess = 'Name MUST be string but was given ' . gettype($value);
+            $mess = 'Name MUST be string but was given '.gettype($value);
             throw new InvalidArgumentException($mess);
         }
         $this->eveApiName = $value;
@@ -245,7 +245,7 @@ 
     public function setEveApiSectionName($value)
     {
         if (!is_string($value)) {
-            $mess = 'Section name MUST be string but was given ' . gettype($value);
+            $mess = 'Section name MUST be string but was given '.gettype($value);
             throw new InvalidArgumentException($mess);
         }
         $this->eveApiSectionName = $value;
@@ -265,7 +265,7 @@ 
             $xml = '';
         }
         if (!is_string($xml)) {
-            $mess = 'Xml MUST be string but was given ' . gettype($xml);
+            $mess = 'Xml MUST be string but was given '.gettype($xml);
             throw new InvalidArgumentException($mess);
         }
         $this->eveApiXml = $xml;

lib/Console/Command/AbstractDatabaseCommon.php

Spacing +3 added lines, -3 removed lines

@@ -123,7 +123,7 @@ 
          */
         $statements = str_replace(array_keys($replacements), array_values($replacements), explode(';', $sqlStatements));
         // 5 is a 'magic' number that I think is shorter than any legal SQL statement.
-        $statements = array_filter($statements, function ($value) {
+        $statements = array_filter($statements, function($value) {
             return 5 <= strlen(trim($value));
         });
         $progress = null;
@@ -151,7 +151,7 @@ 
                     $progress->finish();
                     $output->writeln('');
                 }
-                $mess = $sql . PHP_EOL;
+                $mess = $sql.PHP_EOL;
                 $mess .= sprintf(
                     'Sql failed in %1$s on statement %2$s with (%3$s) %4$s',
                     $fileName,
@@ -182,7 +182,7 @@ 
         $dic = $this->getDic();
         foreach (['class', 'database', 'hostName', 'password', 'platform', 'tablePrefix', 'userName'] as $option) {
             if (!empty($options[$option])) {
-                $dic[$base . $option] = $options[$option];
+                $dic[$base.$option] = $options[$option];
             }
         }
         if (!empty($options['configFile'])) {