Issues in ez_sql_pdo_yourls.php - Fixed Issues - Inspection of "Remove ezSQL, use PDO" - YOURLS/YOURLS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2282)

by ྅༻ Ǭɀħ

created 2017-09-03 17:39 UTC

includes/ezSQL/ez_sql_pdo_yourls.php (11 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class ezSQL_pdo_YOURLS extends ezSQL_pdo {

	/**
	* Constructor - Overwrite original to use MySQL and handle custom port
	* 
	* @since 1.7
	*/
	function __construct( $dbuser='', $dbpassword='', $dbname='', $dbhost='localhost', $encoding='' ) {

        $this->show_errors = defined( 'YOURLS_DEBUG' ) && YOURLS_DEBUG; // comply to YOURLS debug mode
		$this->dbuser = $dbuser;
class MyClass { }

$x = new MyClass();
$x->foo = true;
		$this->dbpassword = $dbpassword;

		$this->dbname = $dbname;
class MyClass { }

$x = new MyClass();
$x->foo = true;
		// Get custom port if any
		if ( false !== strpos( $dbhost, ':' ) ) {
			list( $dbhost, $dbport ) = explode( ':', $dbhost );
			$dbhost = sprintf( '%1$s;port=%2$d', $dbhost, $dbport );
		}
		$this->dbhost = $dbhost;
class MyClass { }

$x = new MyClass();
$x->foo = true;
		$this->encoding = $encoding;
class MyClass { }

$x = new MyClass();
$x->foo = true;
		$dsn = 'mysql:host=' . $dbhost . ';dbname=' . $dbname ;
		$this->dsn = $dsn;
		
		// Turn on track errors 
		ini_set('track_errors',1);
		
		$this->connect( $dsn, $dbuser, $dbpassword );
		
	}

	/**
	 * Return MySQL server version
	 *
	 * @since 1.7
	 */
	function mysql_version() {

		return ( $this->dbh->getAttribute(PDO::ATTR_SERVER_VERSION) );
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}
	
	/**
	 * Perform mySQL query
	 *
	 * Added to the original function: logging of all queries
	 *
	 * @since 1.7
	 */
	function query( $query ) {

	
		// Keep history of all queries
		$this->debug_log[] = $query;
class MyClass { }

$x = new MyClass();
$x->foo = true;

		// Original function
		return parent::query( $query );
	}

	/**
	* Disconnect
	* 
	* Actually not needed for PDO it seems, the function is there only for consistency with
	* other classes
	*
	* @since 1.7
	*/
	function disconnect() {

		// bleh
	}	
	

}



1			<?php
2
3			class ezSQL_pdo_YOURLS extends ezSQL_pdo {
4
5			/**
6			* Constructor - Overwrite original to use MySQL and handle custom port
7			*
8			* @since 1.7
9			*/
10			function __construct( $dbuser='', $dbpassword='', $dbname='', $dbhost='localhost', $encoding='' ) {
			0 ignored issues – show Best Practice introduced 2015-11-27 01:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
11			$this->show_errors = defined( 'YOURLS_DEBUG' ) && YOURLS_DEBUG; // comply to YOURLS debug mode
12			$this->dbuser = $dbuser;
			0 ignored issues – show Bug introduced 2015-11-27 01:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `dbuser` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
13			$this->dbpassword = $dbpassword;
			0 ignored issues – show Bug introduced 2015-11-27 01:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `dbpassword` does not seem to exist. Did you mean `password`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
14			$this->dbname = $dbname;
			0 ignored issues – show Bug introduced 2015-11-27 01:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `dbname` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
15			// Get custom port if any
16			if ( false !== strpos( $dbhost, ':' ) ) {
17			list( $dbhost, $dbport ) = explode( ':', $dbhost );
18			$dbhost = sprintf( '%1$s;port=%2$d', $dbhost, $dbport );
19			}
20			$this->dbhost = $dbhost;
			0 ignored issues – show Bug introduced 2017-04-18 10:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `dbhost` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21			$this->encoding = $encoding;
			0 ignored issues – show Bug introduced 2015-11-27 01:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `encoding` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22			$dsn = 'mysql:host=' . $dbhost . ';dbname=' . $dbname ;
23			$this->dsn = $dsn;
24
25			// Turn on track errors
26			ini_set('track_errors',1);
27
28			$this->connect( $dsn, $dbuser, $dbpassword );
29
30			}
31
32			/**
33			* Return MySQL server version
34			*
35			* @since 1.7
36			*/
37			function mysql_version() {
			0 ignored issues – show Best Practice introduced 2015-11-27 01:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
38			return ( $this->dbh->getAttribute(PDO::ATTR_SERVER_VERSION) );
			0 ignored issues – show Bug introduced 2015-11-27 01:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `dbh` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
39			}
40
41			/**
42			* Perform mySQL query
43			*
44			* Added to the original function: logging of all queries
45			*
46			* @since 1.7
47			*/
48			function query( $query ) {
			0 ignored issues – show Best Practice introduced 2015-11-27 01:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
49
50			// Keep history of all queries
51			$this->debug_log[] = $query;
			0 ignored issues – show Bug introduced 2017-04-18 10:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `debug_log` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
52
53			// Original function
54			return parent::query( $query );
55			}
56
57			/**
58			* Disconnect
59			*
60			* Actually not needed for PDO it seems, the function is there only for consistency with
61			* other classes
62			*
63			* @since 1.7
64			*/
65			function disconnect() {
			0 ignored issues – show Best Practice introduced 2015-11-27 01:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
66			// bleh
67			}
68
69
70			}
71
72

YOURLS / YOURLS

Pull Request — master (#2282)

includes/ezSQL/ez_sql_pdo_yourls.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like