Issues in video.php (master) - Issues in master - XoopsModules25x/xoopstube - Measure and Improve Code Quality continuously with Scrutinizer

Issues (267)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

include/video.php (3 issues)

Labels

Severity

Minor 3

<?php

/**
 * Module: XoopsTube
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * PHP version 5
 *
 * @param $returnsource
 *
 * @return string
 * @author          XOOPS Development Team
 * @copyright       2001-2016 XOOPS Project (https://xoops.org)
 * @license         GNU GPL 2 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @link            https://xoops.org/
 * @since           1.0.6
 *
 * @category        Module
 * @package         Xoopstube
 */
function xtubeReturnSource($returnsource)
{
    switch ($returnsource) {
        case 0:
            $returnsource = _AM_XOOPSTUBE_YOUTUBE;
            break;
        case 1:
            $returnsource = _AM_XOOPSTUBE_METACAFE;
            break;
        case 2:
            $returnsource = _AM_XOOPSTUBE_IFILM;
            break;
        case 3:
            $returnsource = _AM_XOOPSTUBE_PHOTOBUCKET;
            break;
        case 4:
            $returnsource = _AM_XOOPSTUBE_VIDDLER;
            break;
        case 100:
            $returnsource = _AM_XOOPSTUBE_GOOGLEVIDEO;
            break;
        case 101:
            $returnsource = _AM_XOOPSTUBE_MYSPAVETV;
            break;
        case 102:
            $returnsource = _AM_XOOPSTUBE_DAILYMOTION;
            break;
        case 103:
            $returnsource = _AM_XOOPSTUBE_BLIPTV;
            break;
        case 104:
            $returnsource = _AM_XOOPSTUBE_CLIPFISH;
            break;
        case 105:
            $returnsource = _AM_XOOPSTUBE_LIVELEAK;
            break;
        case 106:
            $returnsource = _AM_XOOPSTUBE_MAKTOOB;
            break;
        case 107:
            $returnsource = _AM_XOOPSTUBE_VEOH;
            break;
        case 108:
            $returnsource = _AM_XOOPSTUBE_VIMEO;
            break;
        case 109:
            $returnsource = _AM_XOOPSTUBE_MEGAVIDEO;
            break;
        case 200:
            $returnsource = _AM_XOOPSTUBE_XOOPSTUBE;
            break;
    }

    return $returnsource;
}

// *******************************************************
// Function for determining source for creating screenshot
// *******************************************************
/**
 * @param        $vidid
 * @param        $title
 * @param        $source
 * @param        $picurl
 * @param        $screenshot
 * @param string $width
 * @param string $height
 *
 * @return string
 */
function xtubeGetVideoThumb($vidid, $title, $source, $picurl, $screenshot, $width = '', $height = '')
{
    if ('' === $width || '' === $height) {
        $width  = $GLOBALS['xoopsModuleConfig']['shotwidth'];
        $height = $GLOBALS['xoopsModuleConfig']['shotheight'];
    }
    $thumb = '';
    switch ($source) {
        // YouTube
        case 0:
            $thumb = '<img src="https://img.youtube.com/vi/' . $vidid . '/default.jpg"  title="' . $title . '" alt="' . $title . '" width="' . $width . '" height="' . $height . '" style="padding: 0px; border-style: none;">';
            break;
        // MetaCafe
        case 1:
            [$metaclip] = explode('[/]', $vidid);
            $videothumb['metathumb'] = $metaclip;

            $thumb                   = '<img src="https://www.metacafe.com/thumb/' . $videothumb['metathumb'] . '.jpg" title="' . $title . '" alt="' . $title . '" width="' . $width . '" height="' . $height . '" style="padding: 0px; border-style: none;">';
            break;
        // iFilm/Spike
        case 2:
            $thumb = '<img src="https://img3.ifilmpro.com/resize/image/stills/films/resize/istd/' . $vidid . '.jpg?width=' . $width . '"  title="' . $title . '" alt="' . $title . '" style="padding: 0px; border-style: none;">';
            break;
        // Photobucket
        case 3:
            $thumb = '<img src="https://i153.photobucket.com/albums/' . $vidid . '.jpg" width="' . $width . '" height="' . $height . '"  title="' . $title . '" alt="' . $title . '" style="padding: 0px; border-style: none;">';
            break;
        // Photobucket
        case 4:
            $thumb = '<img src="https://cdn-thumbs.viddler.com/thumbnail_2_' . $vidid . '.jpg" width="' . $width . '" height="' . $height . '"  title="' . $title . '" alt="' . $title . '" style="padding: 0px; border-style: none;">';
            break;
        // Google Video, MySpace TV, DailyMotion, BrightCove, Blip.tv, ClipFish, LiveLeak, Maktoob, Veoh
        case 100:
        case 101:
        case 102:
        case 103:
        case 104:
        case 105:
        case 106:
        case 107:
        case 108:
        case 109:
            $thumb = '<img src="' . $picurl . '" width="' . $width . '" height="' . $height . '"  title="' . $title . '" alt="' . $title . '" style="padding: 0px; border-style: none;">';
            break;
        // Determine if video source is XoopsTube for thumbnail
        case 200:
            $thumb = '<img src="' . XOOPS_URL . '/' . $screenshot . '" width="' . $width . '" height="' . $height . '"  title="' . $title . '" alt="' . $title . '" style="padding: 0px; border-style: none;">';
            break;
    }

    return $thumb;
}

// **********************************
// Function for determining publisher
// **********************************
/**
 * @param     $vidid
 * @param     $publisher
 * @param int $source
 *
 * @return string
 */
function xtubeGetVideoPublisher($vidid, $publisher, $source = 0)
{
    switch ($source) {
        // Determine if video source YouTube for publisher
        case 0:
            $publisher = '<a href="https://www.youtube.com/profile?user=' . $publisher . '" target="_blank">' . $publisher . '</a>';
            break;
        // Determine if video source MetaCafe for publisher
        case 1:
            $publisher = '<a href="https://www.metacafe.com/channels/' . $publisher . '" target="_blank">' . $publisher . '</a>';
            break;
        // Determine if video source iFilm/Spike for publisher
        case 2:
            $publisher = '<a href="https://www.ifilm.com/profile/' . $publisher . '" target="_blank">' . $publisher . '</a>';
            break;
        // Determine if video source Photobucket for publisher
        case 3:
            $string = 'th_';
            [$photobucket] = explode($string, $vidid);
            $ppublisher['ppublisher'] = $photobucket;

            $publisher                = '<a href="https://s39.photobucket.com/albums/' . $ppublisher['ppublisher'] . '" target="_blank">' . $publisher . '</a>';
            break;
        // Determine if video source is Viddler for publisher
        case 4:
            $publisher = '<a href="https://www.viddler.com/explore/' . $publisher . '/" target="_blank">' . $publisher . '</a>';
            break;
        // Determine if video source is Google Video for publisher
        case 100:
        case 101:
        case 103:
        case 106:
        case 108:
        case 109:
            //            $publisher = $publisher;
            break;
        // Determine if video source is DailyMotion for publisher
        case 102:
            $publisher = '<a href="https://www.dailymotion.com/' . $publisher . '" target="_blank">' . $publisher . '</a>';
            break;
        // Determine if video source is ClipFish for publisher
        case 104:
            $publisher = '<a href="https://www.clipfish.de/user/' . $publisher . '" target="_blank">' . $publisher . '</a>';
            break;
        // Determine if video source is LiveLeak for publisher
        case 105:
            $publisher = '<a href="https://www.liveleak.com/user/' . $publisher . '" target="_blank">' . $publisher . '</a>';
            break;
        // Determine if video source is Veoh for publisher
        case 107:
            $publisher = '<a href="https://www.veoh.com/users/' . $publisher . '" target="_blank">' . $publisher . '</a>';
            break;
        // Determine if video source is XoopsTube for publisher
        case 200:
            //            $publisher = $publisher;
            break;
    }

    return $publisher;
}

// ************************************************
//Function for displaying videoclip (embedded code)
// ************************************************
/**
 * @param $vidid
 * @param $source
 * @param $screenshot
 * @param $picurl
 *
 * @return string
 */
function xtubeShowVideo($vidid, $source, $screenshot, $picurl)
function xtubeShowVideo($vidid, $source, /** @scrutinizer ignore-unused */ $screenshot, $picurl)
{
    global $xoopsModule;
    $showvideo = '';
    $autoplay  = $GLOBALS['xoopsModuleConfig']['autoplay'];
    if ($GLOBALS['xoopsModuleConfig']['autoplay']) {
        $autoplay2   = 'yes';
        $autoplay3   = 'true';
        $photobucket = '&ap=1';
        $google      = 'FlashVars="autoPlay=true"';
        $viddler     = 'flashvars="autoplay=t"';
    } else {
        $autoplay2   = 'no';
        $autoplay3   = 'false';
        $photobucket = '';
        $google      = '';
        $viddler     = '';
    }

    //  $hquality = '';
    //  if ($hq == 1) {
    //      $hquality = '&ap=%2526fmt%3D18&';
    //  }

    switch ($source) {
        // YouTube
        case 0:
            //  $showvideo = '<object width="480" height="295"><param name="movie" value="https://www.youtube.com/v/' . $vidid . '&ap=%2526fmt%3D18&&autoplay=' . $autoplay . '&rel=1&fs=1&color1=0x999999&color2=0x999999&border=0&loop=0"></param><param name="wmode" value="transparent"></param><embed src="https://www.youtube.com/v/' . $vidid . '&ap=%2526fmt%3D18&&autoplay=' . $autoplay . '&rel=1&fs=1&color1=0x999999&color2=0x999999&border=0&loop=0" type="application/x-shockwave-flash" allowscriptaccess="always" allowfullscreen="true" wmode="transparent" width="480" height="295"></embed></object>';
            //            $showvideo = '<embed src="https://www.youtube.com/v/' . $vidid . '&autoplay=' . $autoplay
            //                         . '&fs=1" type="application/x-shockwave-flash" allowscriptaccess="always" allowfullscreen="true" width="480" height="295"></embed>';

            $showvideo = '<iframe src="https://www.youtube.com/embed/' . $vidid . '?html5=1&amp;rel=0&amp;hl=en_US&amp;version=3' . '&autoplay=' . $autoplay . '&fs=1" type="application/x-shockwave-flash" allowscriptaccess="always" allowfullscreen="true" width="480" height="295"></iframe>';
            break;
        // MetaCafe
        case 1:
            $showvideo = '<embed flashVars="playerVars=showStats=no|autoPlay='
                         . $autoplay2
                         . '" src="https://www.metacafe.com/fplayer/'
                         . $vidid
                         . '.swf" width="480" height="295" wmode="transparent" pluginspage="https://www.macromedia.com/go/getflashplayer" type="application/x-shockwave-flash"></embed>';
            break;
        // iFilm/Spike
        case 2:
            $showvideo = '<embed width="480" height="295" src="https://www.spike.com/efp" quality="high" bgcolor="000000" name="efp" align="middle" type="application/x-shockwave-flash" pluginspage="https://www.macromedia.com/go/getflashplayer" flashvars="flvbaseclip='
                         . $vidid
                         . '" allowfullscreen="true"> </embed>';
            break;
        // Photobucket
        case 3:
            $vidid     = str_replace('th_', '', $vidid);
            $showvideo = '<embed width="480" height="295" type="application/x-shockwave-flash" wmode="transparent" src="https://i51.photobucket.com/player.swf?file=https://vid51.photobucket.com/albums/' . $vidid . '.flv' . $photobucket . '"></embed>';
            break;
        // Viddler
        case 4:
            $showvideo = '<embed src="https://www.viddler.com/player/' . $vidid . '/" width="480" height="295" type="application/x-shockwave-flash" ' . $viddler . ' allowScriptAccess="always" allowFullScreen="true" name="viddler_' . $vidid . '" ></embed>';
            break;
        // Google Video
        case 100:
            $showvideo = '<embed style="width:480px; height:295px;" id="VideoPlayback" type="application/x-shockwave-flash" src="https://video.google.com/googleplayer.swf?docId=' . $vidid . '&hl=en" ' . $google . '> </embed>';
            break;
        // MySpace TV
        case 101:
            $showvideo = '<embed src="https://mediaservices.myspace.com/services/media/embed.aspx/m=' . $vidid . ',t=1,mt=video,ap=' . $autoplay . '" width="480" height="295" allowFullScreen="true" type="application/x-shockwave-flash"></embed>';
            break;
        // DailyMotion
        case 102:
            $showvideo = '<embed src="https://www.dailymotion.com/swf/' . $vidid . '&autoPlay=' . $autoplay . '" type="application/x-shockwave-flash" width="480" height="295" allowFullScreen="true" allowScriptAccess="always"></embed>';
            break;
        // Blip.tv
        case 103:
            $showvideo = '<embed src="https://blip.tv/play/' . $vidid . '" type="application/x-shockwave-flash" width="480" height="295" allowscriptaccess="always" allowfullscreen="true" flashvars="autostart=' . $autoplay3 . '"></embed>';
            break;
        // ClipFish
        case 104:
            $showvideo = '<embed src="https://www.clipfish.de/videoplayer.swf?as='
                         . $autoplay
                         . '&videoid='
                         . $vidid
                         . '==&r=1&c=0067B3" quality="high" bgcolor="#0067B3" width="464" height="380" name="player" align="middle" allowFullScreen="true" allowScriptAccess="always"  type="application/x-shockwave-flash" pluginspage="https://www.macromedia.com/go/getflashplayer"></embed>'; // Change c=0067B3 for different player color
            break;
        // LiveLeak
        case 105:
            $showvideo = '<embed src="https://www.liveleak.com/e/' . $vidid . '" type="application/x-shockwave-flash" flashvars="autostart=' . $autoplay3 . '" wmode="transparent" width="450" height="370"></embed>';
            break;
        // Maktoob
        case 106:
            $showvideo = '<embed width="448" height="320" align="middle" pluginspage="https://www.macromedia.com/go/getflashplayer" type="application/x-shockwave-flash" name="flvplayer" bgcolor="#ffffff" devicefont="true" wmode="transparent" quality="high" src="https://clipat.maktoob.com/flvplayerOurJS.swf?file=https://'
                         . $vidid
                         . '.flv&enablejs=true&image='
                         . $picurl
                         . '&lightcolor=0x557722&backcolor=0x000000&frontcolor=0xCCCCCC&showfsbutton=true&autostart='
                         . $autoplay3
                         . '&logo=https://clipat.maktoob.com/language/ar_sa/images/clipat-icon.png&displaywidth=448">';
            break;
        // Veoh
        case 107:
            $showvideo = '<embed src="https://www.veoh.com/veohplayer.swf?permalinkId='
                         . $vidid
                         . '&id=anonymous&player=videodetailsembedded&affiliateId=&videoAutoPlay='
                         . $autoplay
                         . '" allowFullScreen="true" width="480" height="295" bgcolor="#FFFFFF" type="application/x-shockwave-flash" pluginspage="https://www.macromedia.com/go/getflashplayer"></embed>';
            break;
        // Vimeo
        case 108:
            $showvideo = '<embed src="https://vimeo.com/moogaloop.swf?clip_id='
                         . $vidid
                         . '&server=vimeo.com&show_title=1&show_byline=1&show_portrait=0&color=&fullscreen=1&autoplay='
                         . $autoplay
                         . '" type="application/x-shockwave-flash" allowfullscreen="true" allowscriptaccess="always" quality="best" width="400" height="321"></embed>';
            break;
        // Megavideo
        case 109:
            $showvideo = '<object width="640" height="363"><param name="movie" value="https://www.megavideo.com/v/'
                         . $vidid
                         . '"></param><param name="allowFullScreen" value="true"></param><embed src="https://www.megavideo.com/v/'
                         . $vidid
                         . '" type="application/x-shockwave-flash" allowfullscreen="true" width="640" height="363"></embed></object>';
            break;
        // XoopsTube
        case 200:
            //        $showvideo = '<embed src="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname')
            //            . '/include/mediaplayer.swf" width="425" height="350" allowScriptAccess="always" allowFullScreen="true" flashvars="width=425&height=350&file='
            //            . XOOPS_URL . '/' . $GLOBALS['xoopsModuleConfig']['videodir'] . '/' . $vidid . '&image=' . XOOPS_URL . '/'
            //            . $GLOBALS['xoopsModuleConfig']['videoimgdir'] . '/' . $screenshot . '&autostart=' . $autoplay3 . '"></embed>';

            $showvideo = '
                     <script type="text/javascript" src="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/flvplayer/flowplayer/flowplayer.min.js"></script>
                     <a href="' . XOOPS_URL . '/' . $xoopsModule->getVar('dirname') . '/' . $vidid . '" style="display: block; width: 520px; height: 330px;" id="player"></a>
                     <script>
                         flowplayer("player", "' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/flvplayer/flowplayer/flowplayer.swf", {
                             clip: {
                                 autoPlay: ' . $autoplay3 . ',
                                 autoBuffering: true
                                 }
                             }
                         );
                     </script>
                     ';

            break;
    }

    return $showvideo;
}


XoopsModules25x / xoopstube

Issues (267)

Security Analysis not enabled

include/video.php (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like