| Conditions | 18 | 
| Paths | 34 | 
| Total Lines | 143 | 
| Code Lines | 98 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php | ||
| 227 | function xtubeShowVideo($vidid, $source, $screenshot, $picurl) | ||
| 228 | { | ||
| 229 | global $xoopsModule; | ||
| 230 | $showvideo = ''; | ||
| 231 | $autoplay = $GLOBALS['xoopsModuleConfig']['autoplay']; | ||
| 232 |     if ($GLOBALS['xoopsModuleConfig']['autoplay']) { | ||
| 233 | $autoplay2 = 'yes'; | ||
| 234 | $autoplay3 = 'true'; | ||
| 235 | $photobucket = '&ap=1'; | ||
| 236 | $google = 'FlashVars="autoPlay=true"'; | ||
| 237 | $viddler = 'flashvars="autoplay=t"'; | ||
| 238 |     } else { | ||
| 239 | $autoplay2 = 'no'; | ||
| 240 | $autoplay3 = 'false'; | ||
| 241 | $photobucket = ''; | ||
| 242 | $google = ''; | ||
| 243 | $viddler = ''; | ||
| 244 | } | ||
| 245 | |||
| 246 | // $hquality = ''; | ||
| 247 |     //  if ($hq == 1) { | ||
| 248 | // $hquality = '&ap=%2526fmt%3D18&'; | ||
| 249 | // } | ||
| 250 | |||
| 251 |     switch ($source) { | ||
| 252 | // YouTube | ||
| 253 | case 0: | ||
| 254 | // $showvideo = '<object width="480" height="295"><param name="movie" value="https://www.youtube.com/v/' . $vidid . '&ap=%2526fmt%3D18&&autoplay=' . $autoplay . '&rel=1&fs=1&color1=0x999999&color2=0x999999&border=0&loop=0"></param><param name="wmode" value="transparent"></param><embed src="https://www.youtube.com/v/' . $vidid . '&ap=%2526fmt%3D18&&autoplay=' . $autoplay . '&rel=1&fs=1&color1=0x999999&color2=0x999999&border=0&loop=0" type="application/x-shockwave-flash" allowscriptaccess="always" allowfullscreen="true" wmode="transparent" width="480" height="295"></embed></object>'; | ||
| 255 | // $showvideo = '<embed src="https://www.youtube.com/v/' . $vidid . '&autoplay=' . $autoplay | ||
| 256 | // . '&fs=1" type="application/x-shockwave-flash" allowscriptaccess="always" allowfullscreen="true" width="480" height="295"></embed>'; | ||
| 257 | |||
| 258 | $showvideo = '<iframe src="https://www.youtube.com/embed/' . $vidid . '?html5=1&rel=0&hl=en_US&version=3' . '&autoplay=' . $autoplay . '&fs=1" type="application/x-shockwave-flash" allowscriptaccess="always" allowfullscreen="true" width="480" height="295"></iframe>'; | ||
| 259 | break; | ||
| 260 | // MetaCafe | ||
| 261 | case 1: | ||
| 262 | $showvideo = '<embed flashVars="playerVars=showStats=no|autoPlay=' | ||
| 263 | . $autoplay2 | ||
| 264 | . '" src="https://www.metacafe.com/fplayer/' | ||
| 265 | . $vidid | ||
| 266 | . '.swf" width="480" height="295" wmode="transparent" pluginspage="https://www.macromedia.com/go/getflashplayer" type="application/x-shockwave-flash"></embed>'; | ||
| 267 | break; | ||
| 268 | // iFilm/Spike | ||
| 269 | case 2: | ||
| 270 | $showvideo = '<embed width="480" height="295" src="https://www.spike.com/efp" quality="high" bgcolor="000000" name="efp" align="middle" type="application/x-shockwave-flash" pluginspage="https://www.macromedia.com/go/getflashplayer" flashvars="flvbaseclip=' | ||
| 271 | . $vidid | ||
| 272 | . '" allowfullscreen="true"> </embed>'; | ||
| 273 | break; | ||
| 274 | // Photobucket | ||
| 275 | case 3: | ||
| 276 |             $vidid     = str_replace('th_', '', $vidid); | ||
| 277 | $showvideo = '<embed width="480" height="295" type="application/x-shockwave-flash" wmode="transparent" src="https://i51.photobucket.com/player.swf?file=https://vid51.photobucket.com/albums/' . $vidid . '.flv' . $photobucket . '"></embed>'; | ||
| 278 | break; | ||
| 279 | // Viddler | ||
| 280 | case 4: | ||
| 281 | $showvideo = '<embed src="https://www.viddler.com/player/' . $vidid . '/" width="480" height="295" type="application/x-shockwave-flash" ' . $viddler . ' allowScriptAccess="always" allowFullScreen="true" name="viddler_' . $vidid . '" ></embed>'; | ||
| 282 | break; | ||
| 283 | // Google Video | ||
| 284 | case 100: | ||
| 285 | $showvideo = '<embed style="width:480px; height:295px;" id="VideoPlayback" type="application/x-shockwave-flash" src="https://video.google.com/googleplayer.swf?docId=' . $vidid . '&hl=en" ' . $google . '> </embed>'; | ||
| 286 | break; | ||
| 287 | // MySpace TV | ||
| 288 | case 101: | ||
| 289 | $showvideo = '<embed src="https://mediaservices.myspace.com/services/media/embed.aspx/m=' . $vidid . ',t=1,mt=video,ap=' . $autoplay . '" width="480" height="295" allowFullScreen="true" type="application/x-shockwave-flash"></embed>'; | ||
| 290 | break; | ||
| 291 | // DailyMotion | ||
| 292 | case 102: | ||
| 293 | $showvideo = '<embed src="https://www.dailymotion.com/swf/' . $vidid . '&autoPlay=' . $autoplay . '" type="application/x-shockwave-flash" width="480" height="295" allowFullScreen="true" allowScriptAccess="always"></embed>'; | ||
| 294 | break; | ||
| 295 | // Blip.tv | ||
| 296 | case 103: | ||
| 297 | $showvideo = '<embed src="https://blip.tv/play/' . $vidid . '" type="application/x-shockwave-flash" width="480" height="295" allowscriptaccess="always" allowfullscreen="true" flashvars="autostart=' . $autoplay3 . '"></embed>'; | ||
| 298 | break; | ||
| 299 | // ClipFish | ||
| 300 | case 104: | ||
| 301 | $showvideo = '<embed src="https://www.clipfish.de/videoplayer.swf?as=' | ||
| 302 | . $autoplay | ||
| 303 | . '&videoid=' | ||
| 304 | . $vidid | ||
| 305 | . '==&r=1&c=0067B3" quality="high" bgcolor="#0067B3" width="464" height="380" name="player" align="middle" allowFullScreen="true" allowScriptAccess="always" type="application/x-shockwave-flash" pluginspage="https://www.macromedia.com/go/getflashplayer"></embed>'; // Change c=0067B3 for different player color | ||
| 306 | break; | ||
| 307 | // LiveLeak | ||
| 308 | case 105: | ||
| 309 | $showvideo = '<embed src="https://www.liveleak.com/e/' . $vidid . '" type="application/x-shockwave-flash" flashvars="autostart=' . $autoplay3 . '" wmode="transparent" width="450" height="370"></embed>'; | ||
| 310 | break; | ||
| 311 | // Maktoob | ||
| 312 | case 106: | ||
| 313 | $showvideo = '<embed width="448" height="320" align="middle" pluginspage="https://www.macromedia.com/go/getflashplayer" type="application/x-shockwave-flash" name="flvplayer" bgcolor="#ffffff" devicefont="true" wmode="transparent" quality="high" src="https://clipat.maktoob.com/flvplayerOurJS.swf?file=https://' | ||
| 314 | . $vidid | ||
| 315 | . '.flv&enablejs=true&image=' | ||
| 316 | . $picurl | ||
| 317 | . '&lightcolor=0x557722&backcolor=0x000000&frontcolor=0xCCCCCC&showfsbutton=true&autostart=' | ||
| 318 | . $autoplay3 | ||
| 319 | . '&logo=https://clipat.maktoob.com/language/ar_sa/images/clipat-icon.png&displaywidth=448">'; | ||
| 320 | break; | ||
| 321 | // Veoh | ||
| 322 | case 107: | ||
| 323 | $showvideo = '<embed src="https://www.veoh.com/veohplayer.swf?permalinkId=' | ||
| 324 | . $vidid | ||
| 325 | . '&id=anonymous&player=videodetailsembedded&affiliateId=&videoAutoPlay=' | ||
| 326 | . $autoplay | ||
| 327 | . '" allowFullScreen="true" width="480" height="295" bgcolor="#FFFFFF" type="application/x-shockwave-flash" pluginspage="https://www.macromedia.com/go/getflashplayer"></embed>'; | ||
| 328 | break; | ||
| 329 | // Vimeo | ||
| 330 | case 108: | ||
| 331 | $showvideo = '<embed src="https://vimeo.com/moogaloop.swf?clip_id=' | ||
| 332 | . $vidid | ||
| 333 | . '&server=vimeo.com&show_title=1&show_byline=1&show_portrait=0&color=&fullscreen=1&autoplay=' | ||
| 334 | . $autoplay | ||
| 335 | . '" type="application/x-shockwave-flash" allowfullscreen="true" allowscriptaccess="always" quality="best" width="400" height="321"></embed>'; | ||
| 336 | break; | ||
| 337 | // Megavideo | ||
| 338 | case 109: | ||
| 339 | $showvideo = '<object width="640" height="363"><param name="movie" value="https://www.megavideo.com/v/' | ||
| 340 | . $vidid | ||
| 341 | . '"></param><param name="allowFullScreen" value="true"></param><embed src="https://www.megavideo.com/v/' | ||
| 342 | . $vidid | ||
| 343 | . '" type="application/x-shockwave-flash" allowfullscreen="true" width="640" height="363"></embed></object>'; | ||
| 344 | break; | ||
| 345 | // XoopsTube | ||
| 346 | case 200: | ||
| 347 |             //        $showvideo = '<embed src="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') | ||
| 348 | // . '/include/mediaplayer.swf" width="425" height="350" allowScriptAccess="always" allowFullScreen="true" flashvars="width=425&height=350&file=' | ||
| 349 | // . XOOPS_URL . '/' . $GLOBALS['xoopsModuleConfig']['videodir'] . '/' . $vidid . '&image=' . XOOPS_URL . '/' | ||
| 350 | // . $GLOBALS['xoopsModuleConfig']['videoimgdir'] . '/' . $screenshot . '&autostart=' . $autoplay3 . '"></embed>'; | ||
| 351 | |||
| 352 | $showvideo = ' | ||
| 353 |                      <script type="text/javascript" src="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/flvplayer/flowplayer/flowplayer.min.js"></script> | ||
| 354 |                      <a href="' . XOOPS_URL . '/' . $xoopsModule->getVar('dirname') . '/' . $vidid . '" style="display: block; width: 520px; height: 330px;" id="player"></a> | ||
| 355 | <script> | ||
| 356 |                          flowplayer("player", "' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/flvplayer/flowplayer/flowplayer.swf", { | ||
| 357 |                              clip: { | ||
| 358 | autoPlay: ' . $autoplay3 . ', | ||
| 359 | autoBuffering: true | ||
| 360 | } | ||
| 361 | } | ||
| 362 | ); | ||
| 363 | </script> | ||
| 364 | '; | ||
| 365 | |||
| 366 | break; | ||
| 367 | } | ||
| 368 | |||
| 369 | return $showvideo; | ||
| 370 | } | ||
| 371 |