XoopsModules25x / xnewsletter

blocks/blocks_letter.php

<?php
/**
 * ****************************************************************************
 *  - A Project by Developers TEAM For Xoops - ( https://xoops.org )
 * ****************************************************************************
 *  XNEWSLETTER - MODULE FOR XOOPS
 *  Copyright (c) 2007 - 2012
 *  Goffy ( wedega.com )
 *
 *  You may not change or alter any portion of this comment or credits
 *  of supporting developers from this source code or any supporting
 *  source code which is considered copyrighted (c) material of the
 *  original comment or credit authors.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *  ---------------------------------------------------------------------------
 * @copyright  Goffy ( wedega.com )
 * @license    GPL 2.0
 * @package    xnewsletter
 * @author     Goffy ( webmaster@wedega.com )
 *
 *  Version : 1 Mon 2012/11/05 14:31:32 :  Exp $
 * ****************************************************************************
 */

use XoopsModules\Xnewsletter;

// defined("XOOPS_ROOT_PATH") || die("XOOPS root path not defined");
require_once dirname(__DIR__) . '/include/common.php';

/**
 * @param $options
 *
 * @return array
 */
function b_xnewsletter_letter($options)
{
    global $xoopsUser;
    $myts             = \MyTextSanitizer::getInstance();

$myts is not used, you could remove the assignment.

    /** @var \XoopsGroupPermHandler $grouppermHandler */
    $grouppermHandler = xoops_getHandler('groupperm');
    /** @var \XoopsMemberHandler $memberHandler */
    $memberHandler = xoops_getHandler('member');
    $helper        = Xnewsletter\Helper::getInstance();

    $letter       = [];
    $type_block   = $options[0];
    $nb_letter    = $options[1];
    $length_title = $options[2];

    array_shift($options);
    array_shift($options);
    array_shift($options);

    $letterCriteria = new \CriteriaCompo();
    switch ($type_block) {

This code seems to be duplicated across your project.

        // For the block: letter recents
        case 'recent':
            $letterCriteria->setSort('letter_created');
            $letterCriteria->setOrder('DESC');
            break;
        // For the block: letter of today
        case 'day':
            $letterCriteria->add(new \Criteria('letter_created', strtotime(date('Y/m/d')), '>='));
            $letterCriteria->add(new \Criteria('letter_created', strtotime(date('Y/m/d')) + 86400, '<='));
            $letterCriteria->setSort('letter_created');
            $letterCriteria->setOrder('ASC');
            break;
        // For the block: letter random
        case 'random':
            $letterCriteria->setSort('RAND()');
            break;
    }

    $uid = (is_object($xoopsUser) && isset($xoopsUser)) ? $xoopsUser->uid() : 0;
    if (0 == $uid) {
        $groups = [XOOPS_GROUP_ANONYMOUS];
    } else {
        $groups = $memberHandler->getGroupsByUser($uid);
    }

    $letterCriteria->setLimit($nb_letter);
    $letterObjs = $helper->getHandler('Letter')->getAll($letterCriteria);
    foreach ($letterObjs as $letter_id => $letterObj) {
        $letter_cats = [];

$letter_cats is not used, you could remove the assignment.

        $letter_cats = explode('|', $letterObj->getVar('letter_cats'));
        $showCat     = false;

$showCat is not used, you could remove the assignment.

        foreach ($letter_cats as $cat_id) {
            $showCat = $grouppermHandler->checkRight('newsletter_read_cat', $cat_id, $groups, $helper->getModule()->mid());
            if (true === $showCat) {
                $letter[$letter_id]['letter_id'] = $letterObj->getVar('letter_id');
                $letter_title                    = $letterObj->getVar('letter_title');
                if ($length_title > 0 && mb_strlen($letter_title) > $length_title) {
                    $letter_title = mb_substr($letter_title, 0, $length_title) . '...';
                }
                $letter[$letter_id]['letter_title'] = $letter_title;
                // $letter[$letter_id]["letter_content"] = $letterObj->getVar("letter_content");
                // $letter[$letter_id]["letter_cats"] = $letterObj->getVar("letter_cats");
                // $letter[$letter_id]["letter_submitter"] = $letterObj->getVar("letter_submitter");
                $letter[$letter_id]['letter_created'] = formatTimestamp($letterObj->getVar('letter_created'), 'S');
                $letter[$letter_id]['href']           = XOOPS_URL . "/modules/{$helper->getModule()->dirname()}/letter.php?op=show_preview&letter_id={$letterObj->getVar('letter_id')}";
            }
        }
    }

    return $letter;
}

/**
 * @param $options
 *
 * @return string
 */
function b_xnewsletter_letter_edit($options)
{
    $form = '' . _MB_XNEWSLETTER_LETTER_DISPLAY . "\n";
    $form .= "<input type=\"hidden\" name=\"options[0]\" value=\"{$options[0]}\">";
    $form .= "<input name=\"options[1]\" size=\"5\" maxlength=\"255\" value=\"{$options[1]}\" type=\"text\">";
    $form .= '<br>';
    $form .= '' . _MB_XNEWSLETTER_LETTER_TITLELENGTH . " : <input name=\"options[2]\" size=\"5\" maxlength=\"255\" value=\"{$options[2]}\" type=\"text\">";
    $form .= '<br><br>';
    array_shift($options);
    array_shift($options);
    array_shift($options);
    $form .= "<label name='lbl_cattodisplay'>" . _MB_XNEWSLETTER_LETTER_CATTODISPLAY . '</label>';
    $form .= '<br><br>';

    return $form;
}