XoopsModules25x /
xnewsletter
| Conditions | 12 |
| Paths | 160 |
| Total Lines | 72 |
| Lines | 18 |
| Ratio | 25 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 39 | function b_xnewsletter_letter($options) |
||
| 40 | { |
||
| 41 | global $xoopsUser; |
||
| 42 | $myts = \MyTextSanitizer::getInstance(); |
||
|
|
|||
| 43 | /** @var \XoopsGroupPermHandler $grouppermHandler */ |
||
| 44 | $grouppermHandler = xoops_getHandler('groupperm'); |
||
| 45 | /** @var \XoopsMemberHandler $memberHandler */ |
||
| 46 | $memberHandler = xoops_getHandler('member'); |
||
| 47 | $helper = Xnewsletter\Helper::getInstance(); |
||
| 48 | |||
| 49 | $letter = []; |
||
| 50 | $type_block = $options[0]; |
||
| 51 | $nb_letter = $options[1]; |
||
| 52 | $length_title = $options[2]; |
||
| 53 | |||
| 54 | array_shift($options); |
||
| 55 | array_shift($options); |
||
| 56 | array_shift($options); |
||
| 57 | |||
| 58 | $letterCriteria = new \CriteriaCompo(); |
||
| 59 | View Code Duplication | switch ($type_block) { |
|
| 60 | // For the block: letter recents |
||
| 61 | case 'recent': |
||
| 62 | $letterCriteria->setSort('letter_created'); |
||
| 63 | $letterCriteria->setOrder('DESC'); |
||
| 64 | break; |
||
| 65 | // For the block: letter of today |
||
| 66 | case 'day': |
||
| 67 | $letterCriteria->add(new \Criteria('letter_created', strtotime(date('Y/m/d')), '>=')); |
||
| 68 | $letterCriteria->add(new \Criteria('letter_created', strtotime(date('Y/m/d')) + 86400, '<=')); |
||
| 69 | $letterCriteria->setSort('letter_created'); |
||
| 70 | $letterCriteria->setOrder('ASC'); |
||
| 71 | break; |
||
| 72 | // For the block: letter random |
||
| 73 | case 'random': |
||
| 74 | $letterCriteria->setSort('RAND()'); |
||
| 75 | break; |
||
| 76 | } |
||
| 77 | |||
| 78 | $uid = (is_object($xoopsUser) && isset($xoopsUser)) ? $xoopsUser->uid() : 0; |
||
| 79 | if (0 == $uid) { |
||
| 80 | $groups = [XOOPS_GROUP_ANONYMOUS]; |
||
| 81 | } else { |
||
| 82 | $groups = $memberHandler->getGroupsByUser($uid); |
||
| 83 | } |
||
| 84 | |||
| 85 | $letterCriteria->setLimit($nb_letter); |
||
| 86 | $letterObjs = $helper->getHandler('Letter')->getAll($letterCriteria); |
||
| 87 | foreach ($letterObjs as $letter_id => $letterObj) { |
||
| 88 | $letter_cats = []; |
||
| 89 | $letter_cats = explode('|', $letterObj->getVar('letter_cats')); |
||
| 90 | $showCat = false; |
||
| 91 | foreach ($letter_cats as $cat_id) { |
||
| 92 | $showCat = $grouppermHandler->checkRight('newsletter_read_cat', $cat_id, $groups, $helper->getModule()->mid()); |
||
| 93 | if (true === $showCat) { |
||
| 94 | $letter[$letter_id]['letter_id'] = $letterObj->getVar('letter_id'); |
||
| 95 | $letter_title = $letterObj->getVar('letter_title'); |
||
| 96 | if ($length_title > 0 && mb_strlen($letter_title) > $length_title) { |
||
| 97 | $letter_title = mb_substr($letter_title, 0, $length_title) . '...'; |
||
| 98 | } |
||
| 99 | $letter[$letter_id]['letter_title'] = $letter_title; |
||
| 100 | // $letter[$letter_id]["letter_content"] = $letterObj->getVar("letter_content"); |
||
| 101 | // $letter[$letter_id]["letter_cats"] = $letterObj->getVar("letter_cats"); |
||
| 102 | // $letter[$letter_id]["letter_submitter"] = $letterObj->getVar("letter_submitter"); |
||
| 103 | $letter[$letter_id]['letter_created'] = formatTimestamp($letterObj->getVar('letter_created'), 'S'); |
||
| 104 | $letter[$letter_id]['href'] = XOOPS_URL . "/modules/{$helper->getModule()->dirname()}/letter.php?op=show_preview&letter_id={$letterObj->getVar('letter_id')}"; |
||
| 105 | } |
||
| 106 | } |
||
| 107 | } |
||
| 108 | |||
| 109 | return $letter; |
||
| 110 | } |
||
| 111 | |||
| 133 |
Loading history...
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.