Issues in fields.php (master) - Issues in master - XoopsModules25x/xhelp - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1844)

Security Analysis not enabled

File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
Response Splitting
Response Splitting can be used to send arbitrary responses.
File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
Header Injection
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.
admin/fields.php (15 issues)

Labels

Severity

<?php declare(strict_types=1);

/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    {@link https://xoops.org/ XOOPS Project}
 * @license      {@link https://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
 * @author       Brian Wahoff <[email protected]>
 * @author       Eric Juden <[email protected]>
 * @author       XOOPS Development Team
 */

use Xmf\Module\Admin;
use Xmf\Request;
use XoopsModules\Xhelp;
use XoopsModules\Xhelp\Helper;

require_once __DIR__ . '/admin_header.php';
xoops_load('XoopsPagenav');
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
// require_once XHELP_CLASS_PATH . '/Form.php';
// require_once XHELP_CLASS_PATH . '/FormRegex.php';

define('_XHELP_FIELD_MINLEN', 2);
define('_XHELP_FIELD_MAXLEN', 16777215);

global $xoopsModule;
$module_id = $xoopsModule->getVar('mid');

$op = 'default';

if (Request::hasVar('op', 'REQUEST')) {
    $op = $_REQUEST['op'];
}

switch ($op) {
    case 'delfield':
        deleteField();
        break;
    case 'editfield':
        editField();
        break;
    case 'clearAddSession':
        clearAddSession();
        break;
    case 'clearEditSession':
        clearEditSession();
        break;
    case 'setFieldRequired':
        setFieldRequired();
        break;
    case 'manageFields':
    default:
        manageFields();
        break;
}

/**
 *
 */
function manageFields()
{
    global $icons;
    $helper = Helper::getInstance();
    $errors = [];

    $session     = Xhelp\Session::getInstance();
    $regex_array = &getRegexArray();
    /** @var \XoopsModules\Xhelp\TicketFieldHandler $ticketFieldHandler */
    $ticketFieldHandler = $helper->getHandler('TicketField');

    $start = $limit = 0;

    if (Request::hasVar('limit', 'GET')) {
        $limit = Request::getInt('limit', 0, 'GET');
    }

    if (Request::hasVar('start', 'GET')) {
        $start = Request::getInt('start', 0, 'GET');
    }

    if (!$limit) {
        $limit = 15;
    }

    if (isset($_POST['addField'])) {
        //Validate Field Information
        $has_errors = false;
        /** @var \XoopsModules\Xhelp\TicketFieldHandler $ticketFieldHandler */
        $ticketFieldHandler = $helper->getHandler('TicketField');

        $values = parseValues($_POST['fld_values']);

        if (!$control = xhelpGetControl($_POST['fld_controltype'])) {
            $has_errors                  = true;
            $errors['fld_controltype'][] = _AM_XHELP_VALID_ERR_CONTROLTYPE;
        }

        $fld_needslength = $control['needs_length'];
        $fld_needsvalues = $control['needs_values'];

        //name field filled?
        if ('' === trim($_POST['fld_name'])) {
            $has_errors           = true;
            $errors['fld_name'][] = _AM_XHELP_VALID_ERR_NAME;
        }

        $fld_fieldname = sanitizeFieldName(\Xmf\Request::getString('fld_fieldname', '', 'POST'));

        //fieldname filled
        if ('' === trim($fld_fieldname)) {
            $has_errors                = true;
            $errors['fld_fieldname'][] = _AM_XHELP_VALID_ERR_FIELDNAME;
        }

        //fieldname unique?
        $criteria = new \CriteriaCompo(new \Criteria('fieldname', $fld_fieldname));
        if ($ticketFieldHandler->getCount($criteria)) {
            $has_errors                = true;
            $errors['fld_fieldname'][] = _AM_XHELP_VALID_ERR_FIELDNAME_UNIQUE;
        }

        //Length filled
        if (0 == Request::getInt('fld_length', 0, 'POST') && true === $fld_needslength) {
            $has_errors             = true;
            $errors['fld_length'][] = sprintf(_AM_XHELP_VALID_ERR_LENGTH, 2, 16777215);
        }

        //Departments Chosen?

        //default value in value set?
        if (count($values)) {
            if (!in_array($_POST['fld_defaultvalue'], $values)
                && !array_key_exists($_POST['fld_defaultvalue'], $values)) {
                $has_errors                   = true;
                $errors['fld_defaultvalue'][] = _AM_XHELP_VALID_ERR_DEFAULTVALUE;
            }

            //length larger than longest value?
            $length = Request::getInt('fld_length', 0, 'POST');
            foreach ($values as $key => $value) {
                if (mb_strlen($key) > $length) {
                    $has_errors             = true;
                    $errors['fld_values'][] = sprintf(_AM_XHELP_VALID_ERR_VALUE_LENGTH, htmlentities($key, ENT_QUOTES | ENT_HTML5), $length);
                }
            }
            //Values are all of the correct datatype?
        } elseif ($fld_needsvalues) {
            $has_errors             = true;
            $errors['fld_values'][] = _AM_XHELP_VALID_ERR_VALUE;
        }

        if ($has_errors) {
            $afield = [];

            $afield['name']         = \Xmf\Request::getString('fld_name', '', 'POST');
            $afield['description']  = \Xmf\Request::getString('fld_description', '', 'POST');
            $afield['fieldname']    = $fld_fieldname;
            $afield['departments']  = $_POST['fld_departments'];
            $afield['controltype']  = $_POST['fld_controltype'];
            $afield['datatype']     = $_POST['fld_datatype'];
            $afield['required']     = $_POST['fld_required'];
            $afield['weight']       = $_POST['fld_weight'];
            $afield['defaultvalue'] = $_POST['fld_defaultvalue'];
            $afield['values']       = $_POST['fld_values'];
            $afield['length']       = $_POST['fld_length'];
            $afield['validation']   = ($_POST['fld_valid_select'] == $_POST['fld_valid_txtbox'] ? $_POST['fld_valid_select'] : $_POST['fld_valid_txtbox']);
            $session->set('xhelp_addField', $afield);
            $session->set('xhelp_addFieldErrors', $errors);
            $helper->redirect('admin/fields.php');
        }

        //Save field
        /** @var \XoopsModules\Xhelp\TicketFieldHandler $ticketFieldHandler */
        $ticketFieldHandler = $helper->getHandler('TicketField');
        /** @var \XoopsModules\Xhelp\TicketField $ticketField */
        $ticketField = $ticketFieldHandler->create();
        $ticketField->setVar('name', \Xmf\Request::getString('fld_name', '', 'POST'));
        $ticketField->setVar('description', \Xmf\Request::getString('fld_description', '', 'POST'));
        $ticketField->setVar('fieldname', $fld_fieldname);
        $ticketField->setVar('controltype', $_POST['fld_controltype']);
        $ticketField->setVar('datatype', $_POST['fld_datatype']);
        $ticketField->setVar('fieldlength', $_POST['fld_length']);
        $ticketField->setVar('required', $_POST['fld_required']);
        $ticketField->setVar('weight', $_POST['fld_weight']);
        $ticketField->setVar('defaultvalue', $_POST['fld_defaultvalue']);
        $ticketField->setVar('validation', ($_POST['fld_valid_select'] == $_POST['fld_valid_txtbox'] ? $_POST['fld_valid_select'] : $_POST['fld_valid_txtbox']));
        $ticketField->addValues($values);
        $ticketField->addDepartments($_POST['fld_departments']);

        if ($ticketFieldHandler->insert($ticketField)) {
            clearAddSessionVars();
            $helper->redirect('admin/fields.php', 3, _AM_XHELP_MSG_FIELD_ADD_OK);
        } else {
            $errors = $ticketField->getHtmlErrors();
            $helper->redirect('admin/fields.php', 3, _AM_XHELP_MSG_FIELD_ADD_ERR . $errors);
        }
    } else {
        $criteria = new \Criteria('', '');
        $criteria->setLimit($limit);
        $criteria->setStart($start);
        $criteria->setSort('weight');
        $criteria->setOrder('ASC');

        $count       = $ticketFieldHandler->getCount($criteria);
        $fieldsArray = $ticketFieldHandler->getObjects($criteria);

        //Display List of Current Fields, form for new field
        xoops_cp_header();
        //echo $oAdminButton->renderButtons('manfields');
        $adminObject = Admin::getInstance();
        $adminObject->displayNavigation(basename(__FILE__));

        if ($count) {
            $nav = new \XoopsPageNav($count, $limit, $start, 'start', "op=manageFields&amp;limit=$limit");

            echo "<table width='100%' cellspacing='1' class='outer'>
                <tr><th colspan='7'><label>" . _AM_XHELP_TEXT_MANAGE_FIELDS . '</label></th></tr>';
            echo "<tr class='head'>
                <td>" . _AM_XHELP_TEXT_ID . '</td>
                <td>' . _AM_XHELP_TEXT_NAME . '</td>
                <td>' . _AM_XHELP_TEXT_DESCRIPTION . '</td>
                <td>' . _AM_XHELP_TEXT_FIELDNAME . '</td>
                <td>' . _AM_XHELP_TEXT_CONTROLTYPE . '</td>
                <td>' . _AM_XHELP_TEXT_REQUIRED . '</td>
                <td>' . _AM_XHELP_TEXT_ACTIONS . '</td>
            </tr>';

            $req_link_params = [
                'op'          => 'setFieldRequired',
                'setrequired' => 1,
                'id'          => 0,
            ];

            foreach ($fieldsArray as $field) {
                $req_link_params['id'] = $field->getVar('id');

                if ($field->getVar('required')) {
                    $req_link_params['setrequired'] = 0;
                    $req_img                        = $icons['online'];
                    $req_title                      = _AM_XHELP_MESSAGE_DEACTIVATE;
                } else {
                    $req_link_params['setrequired'] = 1;
                    $req_img                        = $icons['offline'] ?? '';
                    $req_title                      = _AM_XHELP_MESSAGE_ACTIVATE;
                }

                $edit_url = Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'editfield', 'id' => $field->getVar('id')]);

                $del_url  = Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'delfield', 'id' => $field->getVar('id')]);

                echo "<tr class='even'><td>" . $field->getVar('id') . '</td>
                    <td>' . $field->getVar('name') . '</td>
                    <td>' . $field->getVar('description') . '</td>
                    <td>' . $field->getVar('fieldname') . '</td>
                    <td>' . xhelpGetControlLabel((string)$field->getVar('controltype')) . "</td>
                    <td><a href='" . Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', $req_link_params) . "' title='$req_title'>$req_img</a></td>
                    <td><a href='$edit_url'>" . ($icons['edit'] ?? '') . "</a>
                        <a href='$del_url'>" . ($icons['delete'] ?? '') . '</a></td>
                    </tr>';
            }
            echo '</table>';
            //Render Page Nav
            echo "<div id='pagenav'>" . $nav->renderNav() . '</div><br>';
        }

        //Get Custom Field From session (if exists)
        $field_info   = $session->get('xhelp_addField');
        $field_errors = $session->get('xhelp_addFieldErrors');

        /** @var \XoopsModules\Xhelp\DepartmentHandler $departmentHandler */
        $departmentHandler = $helper->getHandler('Department');
        $depts             = $departmentHandler->getObjects();
        $deptarr           = [];

        foreach ($depts as $obj) {
            $deptarr[$obj->getVar('id')] = $obj->getVar('department');
        }

        if (false === !$field_info) {
            //extract($field_info , EXTR_PREFIX_ALL , 'fld_');
            $fld_controltype  = $field_info['controltype'];
            $fld_datatype     = $field_info['datatype'];
            $fld_departments  = $field_info['departments'];
            $fld_name         = $field_info['name'];
            $fld_fieldname    = $field_info['fieldname'];
            $fld_description  = $field_info['description'];
            $fld_required     = $field_info['required'];
            $fld_length       = $field_info['length'];
            $fld_weight       = $field_info['weight'];
            $fld_defaultvalue = $field_info['defaultvalue'];
            $fld_values       = $field_info['values'];
            $fld_validation   = $field_info['validation'];
        } else {
            $fld_controltype  = '';
            $fld_datatype     = '';
            $fld_departments  = array_keys($deptarr);
            $fld_name         = '';
            $fld_fieldname    = '';
            $fld_description  = '';
            $fld_required     = '';
            $fld_length       = '';
            $fld_weight       = '';
            $fld_defaultvalue = '';
            $fld_values       = '';
            $fld_validation   = '';
        }

        if (false === !$field_errors) {
            xhelpRenderErrors($field_errors, Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'clearAddSession']));
            xhelpRenderErrors(/** @scrutinizer ignore-type */ $field_errors, Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'clearAddSession']));
        }

        //Add Field Form
        $controls       = xhelpGetControlArray();
        $control_select = new \XoopsFormSelect(_AM_XHELP_TEXT_CONTROLTYPE, 'fld_controltype', $fld_controltype);
        foreach ($controls as $key => $control) {
            $control_select->addOption($key, $control['label']);
        }

        $datatypes = [
            _XHELP_DATATYPE_TEXT       => _XHELP_DATATYPE_TEXT,
            _XHELP_DATATYPE_NUMBER_INT => _XHELP_DATATYPE_NUMBER_INT,
            _XHELP_DATATYPE_NUMBER_DEC => _XHELP_DATATYPE_NUMBER_DEC,
        ];

        $datatype_select = new \XoopsFormSelect(_AM_XHELP_TEXT_DATATYPE, 'fld_datatype', $fld_datatype);
        $datatype_select->addOptionArray($datatypes);

        $dept_select = new \XoopsFormSelect(_AM_XHELP_TEXT_DEPARTMENTS, 'fld_departments', $fld_departments, 5, true);
        foreach ($depts as $obj) {
            $dept_select->addOptionArray($deptarr);
        }
        unset($depts);

        $form    = new Xhelp\Form(_AM_XHELP_ADD_FIELD, 'add_field', Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'managefields']));
        $nameEle = new \XoopsFormText(_AM_XHELP_TEXT_NAME, 'fld_name', 30, 64, $fld_name);
        $nameEle->setDescription(_AM_XHELP_TEXT_NAME_DESC);
        $form->addElement($nameEle);

        $fieldnameEle = new \XoopsFormText(_AM_XHELP_TEXT_FIELDNAME, 'fld_fieldname', 30, 64, $fld_fieldname);
        $fieldnameEle->setDescription(_AM_XHELP_TEXT_FIELDNAME_DESC);
        $form->addElement($fieldnameEle);

        $descriptionEle = new \XoopsFormTextArea(_AM_XHELP_TEXT_DESCRIPTION, 'fld_description', $fld_description, 5, 60);
        $descriptionEle->setDescription(_AM_XHELP_TEXT_DESCRIPTION_DESC);
        $form->addElement($descriptionEle);

        $dept_select->setDescription(_AM_XHELP_TEXT_DEPT_DESC);
        $control_select->setDescription(_AM_XHELP_TEXT_CONTROLTYPE_DESC);
        $datatype_select->setDescription(_AM_XHELP_TEXT_DATATYPE_DESC);

        $form->addElement($dept_select);
        $form->addElement($control_select);
        $form->addElement($datatype_select);

        $required = new \XoopsFormRadioYN(_AM_XHELP_TEXT_REQUIRED, 'fld_required', $fld_required);
        $required->setDescription(_AM_XHELP_TEXT_REQUIRED_DESC);
        $form->addElement($required);

        $lengthEle = new \XoopsFormText(_AM_XHELP_TEXT_LENGTH, 'fld_length', 5, 5, $fld_length);
        $lengthEle->setDescription(_AM_XHELP_TEXT_LENGTH_DESC);
        $weightEle = new \XoopsFormText(_AM_XHELP_TEXT_WEIGHT, 'fld_weight', 5, 5, $fld_weight);
        $weightEle->setDescription(_AM_XHELP_TEXT_WEIGHT_DESC);

        $form->addElement($lengthEle);
        $form->addElement($weightEle);

        $regex_control = new Xhelp\FormRegex(_AM_XHELP_TEXT_VALIDATION, 'fld_valid', $fld_validation);
        $regex_control->addOptionArray($regex_array);
        $regex_control->setDescription(_AM_XHELP_TEXT_VALIDATION_DESC);

        $form->addElement($regex_control);

        $defaultValueEle = new \XoopsFormText(_AM_XHELP_TEXT_DEFAULTVALUE, 'fld_defaultvalue', 30, 100, $fld_defaultvalue);
        $defaultValueEle->setDescription(_AM_XHELP_TEXT_DEFAULTVALUE_DESC);
        $form->addElement($defaultValueEle);
        $values = new \XoopsFormTextArea(_AM_XHELP_TEXT_FIELDVALUES, 'fld_values', $fld_values, 5, 60);
        $values->setDescription(_AM_XHELP_TEXT_FIELDVALUES_DESC);
        $form->addElement($values);

        $btn_tray = new \XoopsFormElementTray('');
        $btn_tray->addElement(new \XoopsFormButton('', 'addField', _SUBMIT, 'submit'));

        $form->addElement($btn_tray);
        echo $form->render();

        require_once __DIR__ . '/admin_footer.php';
    }
}

/**
 * @param array $values_arr
 * @return string
 */
function formatValues(array $values_arr): string
{
    $ret = '';
    foreach ($values_arr as $key => $value) {
        $ret .= "$key=$value\r\n";
    }

    return $ret;
}

/**
 * @param string $raw_values
 * @return array
 */
function &parseValues(string $raw_values): array
{
    $_inValue = false;

    $values   = [];

    if ('' === $raw_values) {
        return $values;
    }

    //Split values into name/value pairs
    $lines = explode("\r\n", $raw_values);

    //Parse each line into name=value
    foreach ($lines as $line) {
        if ('' === trim($line)) {
            continue;
        }
        $name     = $value = '';
        $_inValue = false;
        $chrs     = mb_strlen($line);
        for ($i = 0; $i <= $chrs; ++$i) {
            $chr = mb_substr($line, $i, 1);
            if ('=' === $chr && !$_inValue) {
                $_inValue = true;
            } elseif ($_inValue) {
                $name .= $chr;
            } else {
                $value .= $chr;
            }
        }
        //Add value to array
        if ('' === $value) {
            $values[$name] = $name;
        } else {
            $values[$value] = $name;
        }

        //Reset name / value vars
        $name = $value = '';

    }

    return $values;
}

/**
 *
 */
function deleteField()
{
    global $eventService;
    $helper = Xhelp\Helper::getInstance();
    if (!isset($_REQUEST['id'])) {
        redirect_header(Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'manageDepartments'], false), 3, _AM_XHELP_MESSAGE_NO_FIELD);

    }

    $id = Request::getInt('id', 0, 'REQUEST');

    if (isset($_POST['ok'])) {
        /** @var \XoopsModules\Xhelp\TicketFieldHandler $ticketFieldHandler */
        $ticketFieldHandler = $helper->getHandler('TicketField');
        $ticketField        = $ticketFieldHandler->get($id);
        if ($ticketFieldHandler->delete($ticketField, true)) {
            $eventService->trigger('delete_field', [&$ticketField]);
            redirect_header(Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'manageFields'], false));
        }

        redirect_header(Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'manageFields'], false), 3, $message);

    } else {
        xoops_cp_header();
        //echo $oAdminButton->renderButtons('manfields');
        $adminObject = Admin::getInstance();
        $adminObject->displayNavigation(basename(__FILE__));

        xoops_confirm(['op' => 'delfield', 'id' => $id, 'ok' => 1], XHELP_ADMIN_URL . '/fields.php', sprintf(_AM_XHELP_MSG_FIELD_DEL_CFRM, $id));
        xoops_cp_footer();
    }
}

/**
 *
 */
function editField()
{
    $eventsrv    = Xhelp\EventService::getInstance();

    $session     = Xhelp\Session::getInstance();
    $regex_array = getRegexArray();
    $helper      = Helper::getInstance();

    if (!isset($_REQUEST['id'])) {
        redirect_header(Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'manageDepartments'], false), 3, _AM_XHELP_MESSAGE_NO_FIELD);

    }

    $fld_id = Request::getInt('id', 0, 'REQUEST');
    /** @var \XoopsModules\Xhelp\TicketFieldHandler $ticketFieldHandler */
    $ticketFieldHandler = $helper->getHandler('TicketField');
    if (!$ticketField = $ticketFieldHandler->get($fld_id)) {
        redirect_header(Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'manageDepartments'], false), 3, _AM_XHELP_MESSAGE_NO_FIELD);
    }

    if (isset($_POST['editField'])) {
        //Validate Field Information
        $has_errors = false;
        $errors     = [];
        $values     = parseValues($_POST['fld_values']);

        if (!$control = xhelpGetControl($_POST['fld_controltype'])) {
            $has_errors                  = true;
            $errors['fld_controltype'][] = _AM_XHELP_VALID_ERR_CONTROLTYPE;
        }

        $fld_needslength = $control['needs_length'];
        $fld_needsvalues = $control['needs_values'];

        //name field filled?
        if ('' === trim(\Xmf\Request::getString('fld_name', '', 'POST'))) {
            $has_errors           = true;
            $errors['fld_name'][] = _AM_XHELP_VALID_ERR_NAME;
        }

        //fieldname filled
        if ('' === trim(\Xmf\Request::getString('fld_fieldname', '', 'POST'))) {
            $has_errors                = true;
            $errors['fld_fieldname'][] = _AM_XHELP_VALID_ERR_FIELDNAME;
        }

        //fieldname unique?
        $criteria = new \CriteriaCompo(new \Criteria('id', (string)$fld_id, '!='));
        $criteria->add(new \Criteria('fieldname', \Xmf\Request::getString('fld_fieldname', '', 'POST')));
        if ($ticketFieldHandler->getCount($criteria)) {
            $has_errors                = true;
            $errors['fld_fieldname'][] = _AM_XHELP_VALID_ERR_FIELDNAME_UNIQUE;
        }

        //Length filled
        if (0 == Request::getInt('fld_length', 0, 'POST') && true === $fld_needslength) {
            $has_errors             = true;
            $errors['fld_length'][] = sprintf(_AM_XHELP_VALID_ERR_LENGTH, _XHELP_FIELD_MINLEN, _XHELP_FIELD_MAXLEN);
        }

        //default value in value set?
        if (count($values)) {
            if (!in_array($_POST['fld_defaultvalue'], $values)
                && !array_key_exists($_POST['fld_defaultvalue'], $values)) {
                $has_errors                   = true;
                $errors['fld_defaultvalue'][] = _AM_XHELP_VALID_ERR_DEFAULTVALUE;
            }

            //length larger than longest value?
            $length = Request::getInt('fld_length', 0, 'POST');
            foreach ($values as $key => $value) {
                if (mb_strlen($key) > $length) {
                    $has_errors             = true;
                    $errors['fld_values'][] = sprintf(_AM_XHELP_VALID_ERR_VALUE_LENGTH, htmlentities($key, ENT_QUOTES | ENT_HTML5), $length);
                }
            }
        } elseif ($fld_needsvalues) {
            $has_errors             = true;
            $errors['fld_values'][] = _AM_XHELP_VALID_ERR_VALUE;
        }

        if ($has_errors) {
            $afield                 = [];
            $afield['name']         = \Xmf\Request::getString('fld_name', '', 'POST');
            $afield['description']  = \Xmf\Request::getString('fld_description', '', 'POST');
            $afield['fieldname']    = \Xmf\Request::getString('fld_fieldname', '', 'POST');
            $afield['departments']  = $_POST['fld_departments'];
            $afield['controltype']  = $_POST['fld_controltype'];
            $afield['datatype']     = $_POST['fld_datatype'];
            $afield['required']     = $_POST['fld_required'];
            $afield['weight']       = \Xmf\Request::getInt('fld_weight', 0, 'POST');
            $afield['defaultvalue'] = \Xmf\Request::getInt('fld_defaultvalue', 0, 'POST');
            $afield['values']       = $_POST['fld_values'];
            $afield['length']       = \Xmf\Request::getInt('fld_length', 0, 'POST');
            $afield['validation']   = ($_POST['fld_valid_select'] == $_POST['fld_valid_txtbox'] ? $_POST['fld_valid_select'] : $_POST['fld_valid_txtbox']);
            $session->set('xhelp_editField_' . $fld_id, $afield);
            $session->set('xhelp_editFieldErrors_' . $fld_id, $errors);
            //Redirect to edit page (display errors);
            redirect_header(Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'editfield', 'id' => $fld_id], false));
        }
        //Store Modified Field info

        $ticketField->setVar('name', \Xmf\Request::getString('fld_name', '', 'POST'));
        $ticketField->setVar('description', \Xmf\Request::getString('fld_description', '', 'POST'));
        $ticketField->setVar('fieldname', \Xmf\Request::getString('fld_fieldname', '', 'POST'));
        $ticketField->setVar('controltype', $_POST['fld_controltype']);
        $ticketField->setVar('datatype', $_POST['fld_datatype']);
        $ticketField->setVar('fieldlength', \Xmf\Request::getInt('fld_length', 0, 'POST'));
        $ticketField->setVar('required', $_POST['fld_required']);
        $ticketField->setVar('weight', \Xmf\Request::getInt('fld_weight', 0, 'POST'));
        $ticketField->setVar('defaultvalue', $_POST['fld_defaultvalue']);
        $ticketField->setVar('validation', ($_POST['fld_valid_select'] == $_POST['fld_valid_txtbox'] ? $_POST['fld_valid_select'] : $_POST['fld_valid_txtbox']));
        $ticketField->setValues($values);
                      setValues($values);
        $ticketField->addDepartments($_POST['fld_departments']);
                      addDepartments($_POST['fld_departments']);

        if ($ticketFieldHandler->insert($ticketField)) {
            clearEditSessionVars($fld_id);
            $helper->redirect('admin/fields.php', 3, _AM_XHELP_MSG_FIELD_UPD_OK);
        } else {
            redirect_header(Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'editfield', 'id' => $fld_id], false), 3, _AM_XHELP_MSG_FIELD_UPD_ERR);
        }
    } else {
        //Get Custom Field From session (if exists)
        $field_info   = $session->get('xhelp_editField_' . $fld_id);
        $field_errors = $session->get('xhelp_editFieldErrors_' . $fld_id);

        if (false === !$field_info) {
            $fld_controltype  = $field_info['controltype'];
            $fld_datatype     = $field_info['datatype'];
            $fld_departments  = $field_info['departments'];
            $fld_name         = $field_info['name'];
            $fld_fieldname    = $field_info['fieldname'];
            $fld_description  = $field_info['description'];
            $fld_required     = $field_info['required'];
            $fld_length       = $field_info['length'];
            $fld_weight       = $field_info['weight'];
            $fld_defaultvalue = $field_info['defaultvalue'];
            $fld_values       = $field_info['values'];
            $fld_validation   = $field_info['validation'];
        } else {
            /** @var \XoopsModules\Xhelp\TicketFieldDepartmentHandler $ticketFieldDepartmentHandler */
            $ticketFieldDepartmentHandler = $helper->getHandler('TicketFieldDepartment');
            $depts                        = $ticketFieldDepartmentHandler->departmentsByField($ticketField->getVar('id'), true);

            $fld_controltype  = $ticketField->getVar('controltype');
            $fld_datatype     = $ticketField->getVar('datatype');
            $fld_departments  = array_keys($depts);
            $fld_name         = $ticketField->getVar('name');
            $fld_fieldname    = $ticketField->getVar('fieldname');
            $fld_description  = $ticketField->getVar('description');
            $fld_required     = $ticketField->getVar('required');
            $fld_length       = $ticketField->getVar('fieldlength');
            $fld_weight       = $ticketField->getVar('weight');
            $fld_defaultvalue = $ticketField->getVar('defaultvalue');
            $fld_values       = formatValues($ticketField->getVar('fieldvalues'));
            $fld_values       = formatValues(/** @scrutinizer ignore-type */ $ticketField->getVar('fieldvalues'));
            $fld_validation   = $ticketField->getVar('validation');
        }

        //Display Field modification
        xoops_cp_header();
        //echo $oAdminButton->renderButtons('manfields');
        $adminObject = Admin::getInstance();
        $adminObject->displayNavigation(basename(__FILE__));

        //Edit Field Form

        $controls       = xhelpGetControlArray();
        $control_select = new \XoopsFormSelect(_AM_XHELP_TEXT_CONTROLTYPE, 'fld_controltype', $fld_controltype);
        $control_select->setDescription(_AM_XHELP_TEXT_CONTROLTYPE_DESC);
        foreach ($controls as $key => $control) {
            $control_select->addOption($key, $control['label']);
        }

        $datatypes = [
            _XHELP_DATATYPE_TEXT       => _XHELP_DATATYPE_TEXT,
            _XHELP_DATATYPE_NUMBER_INT => _XHELP_DATATYPE_NUMBER_INT,
            _XHELP_DATATYPE_NUMBER_DEC => _XHELP_DATATYPE_NUMBER_DEC,
        ];

        $datatype_select = new \XoopsFormSelect(_AM_XHELP_TEXT_DATATYPE, 'fld_datatype', $fld_datatype);
        $datatype_select->setDescription(_AM_XHELP_TEXT_DATATYPE_DESC);
        $datatype_select->addOptionArray($datatypes);

        /** @var \XoopsModules\Xhelp\DepartmentHandler $departmentHandler */
        $departmentHandler = $helper->getHandler('Department');
        $depts             = $departmentHandler->getObjects();
        $dept_select       = new \XoopsFormSelect(_AM_XHELP_TEXT_DEPARTMENTS, 'fld_departments', $fld_departments, 5, true);
        $dept_select->setDescription(_AM_XHELP_TEXT_DEPT_DESC);
        foreach ($depts as $obj) {
            $dept_select->addOption($obj->getVar('id'), $obj->getVar('department'));
        }
        unset($depts);

        if (false === !$field_errors) {
            xhelpRenderErrors($field_errors, Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'clearEditSession', 'id' => $fld_id]));
            xhelpRenderErrors(/** @scrutinizer ignore-type */ $field_errors, Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'clearEditSession', 'id' => $fld_id]));
        }

        $form = new Xhelp\Form(
            _AM_XHELP_EDIT_FIELD, 'edit_field', Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', [
            'op' => 'editfield',
            'id' => $fld_id,
        ])
        );

        $nameEle = new \XoopsFormText(_AM_XHELP_TEXT_NAME, 'fld_name', 30, 64, $fld_name);
        $nameEle->setDescription(_AM_XHELP_TEXT_NAME_DESC);
        $form->addElement($nameEle);

        $fieldnameEle = new \XoopsFormText(_AM_XHELP_TEXT_FIELDNAME, 'fld_fieldname', 30, 64, $fld_fieldname);
        $fieldnameEle->setDescription(_AM_XHELP_TEXT_FIELDNAME_DESC);
        $form->addElement($fieldnameEle);

        $descriptionEle = new \XoopsFormTextArea(_AM_XHELP_TEXT_DESCRIPTION, 'fld_description', $fld_description, 5, 60);
        $descriptionEle->setDescription(_AM_XHELP_TEXT_DESCRIPTION_DESC);
        $form->addElement($descriptionEle);

        $form->addElement($dept_select);
        $form->addElement($control_select);
        $form->addElement($datatype_select);

        $required = new \XoopsFormRadioYN(_AM_XHELP_TEXT_REQUIRED, 'fld_required', $fld_required);
        $required->setDescription(_AM_XHELP_TEXT_REQUIRED_DESC);
        $form->addElement($required);

        $lengthEle = new \XoopsFormText(_AM_XHELP_TEXT_LENGTH, 'fld_length', 5, 5, $fld_length);
        $lengthEle->setDescription(_AM_XHELP_TEXT_LENGTH_DESC);
        $form->addElement($lengthEle);

        $widthEle = new \XoopsFormText(_AM_XHELP_TEXT_WEIGHT, 'fld_weight', 5, 5, $fld_weight);
        $widthEle->setDescription(_AM_XHELP_TEXT_WEIGHT_DESC);
        $form->addElement($widthEle);

        $regex_control = new Xhelp\FormRegex(_AM_XHELP_TEXT_VALIDATION, 'fld_valid', $fld_validation);
        $regex_control->setDescription(_AM_XHELP_TEXT_VALIDATION_DESC);
        $regex_control->addOptionArray($regex_array);

        $form->addElement($regex_control);

        $defaultValueEle = new \XoopsFormText(_AM_XHELP_TEXT_DEFAULTVALUE, 'fld_defaultvalue', 30, 100, $fld_defaultvalue);
        $defaultValueEle->setDescription(_AM_XHELP_TEXT_DEFAULTVALUE_DESC);
        $form->addElement($defaultValueEle);
        $values = new \XoopsFormTextArea(_AM_XHELP_TEXT_FIELDVALUES, 'fld_values', $fld_values, 5, 60);
        $values->setDescription(_AM_XHELP_TEXT_FIELDVALUES_DESC);
        $form->addElement($values);

        $btn_tray = new \XoopsFormElementTray('');
        $btn_tray->addElement(new \XoopsFormButton('', 'editField', _SUBMIT, 'submit'));
        $btn_tray->addElement(new \XoopsFormButton('', 'cancel', _CANCEL));
        $btn_tray->addElement(new \XoopsFormHidden('id', (string)$fld_id));

        $form->addElement($btn_tray);
        echo $form->render();

        require_once __DIR__ . '/admin_footer.php';
    }
}

/**
 * @return array
 */
function &getRegexArray(): array
{
    $regex_array = [
        ''                                                       => _AM_XHELP_TEXT_REGEX_CUSTOM,
        '^\d{3}-\d{3}-\d{4}$'                                    => _AM_XHELP_TEXT_REGEX_USPHONE,
        '^\d{5}(-\d{4})?'                                        => _AM_XHELP_TEXT_REGEX_USZIP,
        '^\w(?:\w|-|\.(?!\.|@))*@\w(?:\w|-|\.(?!\.))*\.\w{2,3}$' => _AM_XHELP_TEXT_REGEX_EMAIL,
    ];

    return $regex_array;
}

/**
 *
 */
function setFieldRequired()
{
    $helper      = Helper::getInstance();
    $setRequired = Request::getInt('setrequired', 0, 'GET');
    $id          = Request::getInt('id', 0, 'GET');

    $setRequired = (0 != $setRequired ? 1 : 0);

    /** @var \XoopsModules\Xhelp\TicketFieldHandler $ticketFieldHandler */
    $ticketFieldHandler = $helper->getHandler('TicketField');

    $ticketField = $ticketFieldHandler->get($id);
    if ($ticketField) {

        $ticketField->setVar('required', $setRequired);
        $ret = $ticketFieldHandler->insert($ticketField, true);
        if ($ret) {
            $helper->redirect('admin/fields.php');
        } else {
            $helper->redirect('admin/fields.php', 3, _AM_XHELP_MSG_FIELD_UPD_ERR);
        }
    } else {
        $helper->redirect('admin/fields.php', 3, _AM_XHELP_MESSAGE_NO_FIELD);
    }
}

/**
 *
 */
function clearAddSession()
{
    $helper = Helper::getInstance();
    clearAddSessionVars();
    $helper->redirect('admin/fields.php');
}

/**
 *
 */
function clearEditSession()
{
    $fieldid = \Xmf\Request::getInt('id', 0, 'REQUEST');
    clearEditSessionVars($fieldid);
    redirect_header(Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'editfield', 'id' => $fieldid], false));

}

/**
 *
 */
function clearAddSessionVars()
{
    $session = Xhelp\Session::getInstance();
    $session->del('xhelp_addField');
    $session->del('xhelp_addFieldErrors');
}

/**
 * @param int $id
 */
function clearEditSessionVars(int $id)
{
    $id      = $id;
    $session = Xhelp\Session::getInstance();
    $session->del("xhelp_editField_$id");
    $session->del("xhelp_editFieldErrors_$id");
}

XoopsModules25x / xhelp

Issues (1844)

Security Analysis not enabled

admin/fields.php (15 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like
