XoopsModules25x /
xhelp
| Conditions | 29 |
| Paths | 6656 |
| Total Lines | 326 |
| Code Lines | 224 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php declare(strict_types=1); |
||
| 69 | function manageFields() |
||
| 70 | { |
||
| 71 | global $icons; |
||
| 72 | $helper = Helper::getInstance(); |
||
| 73 | $errors = []; |
||
| 74 | |||
| 75 | $session = Xhelp\Session::getInstance(); |
||
| 76 | $regex_array = &getRegexArray(); |
||
| 77 | /** @var \XoopsModules\Xhelp\TicketFieldHandler $ticketFieldHandler */ |
||
| 78 | $ticketFieldHandler = $helper->getHandler('TicketField'); |
||
| 79 | |||
| 80 | $start = $limit = 0; |
||
| 81 | |||
| 82 | if (Request::hasVar('limit', 'GET')) { |
||
| 83 | $limit = Request::getInt('limit', 0, 'GET'); |
||
| 84 | } |
||
| 85 | |||
| 86 | if (Request::hasVar('start', 'GET')) { |
||
| 87 | $start = Request::getInt('start', 0, 'GET'); |
||
| 88 | } |
||
| 89 | |||
| 90 | if (!$limit) { |
||
| 91 | $limit = 15; |
||
| 92 | } |
||
| 93 | |||
| 94 | if (isset($_POST['addField'])) { |
||
| 95 | //Validate Field Information |
||
| 96 | $has_errors = false; |
||
| 97 | /** @var \XoopsModules\Xhelp\TicketFieldHandler $ticketFieldHandler */ |
||
| 98 | $ticketFieldHandler = $helper->getHandler('TicketField'); |
||
| 99 | |||
| 100 | $values = parseValues($_POST['fld_values']); |
||
| 101 | |||
| 102 | if (!$control = xhelpGetControl($_POST['fld_controltype'])) { |
||
| 103 | $has_errors = true; |
||
| 104 | $errors['fld_controltype'][] = _AM_XHELP_VALID_ERR_CONTROLTYPE; |
||
| 105 | } |
||
| 106 | |||
| 107 | $fld_needslength = $control['needs_length']; |
||
| 108 | $fld_needsvalues = $control['needs_values']; |
||
| 109 | |||
| 110 | //name field filled? |
||
| 111 | if ('' === trim($_POST['fld_name'])) { |
||
| 112 | $has_errors = true; |
||
| 113 | $errors['fld_name'][] = _AM_XHELP_VALID_ERR_NAME; |
||
| 114 | } |
||
| 115 | |||
| 116 | $fld_fieldname = sanitizeFieldName(\Xmf\Request::getString('fld_fieldname', '', 'POST')); |
||
| 117 | |||
| 118 | //fieldname filled |
||
| 119 | if ('' === trim($fld_fieldname)) { |
||
| 120 | $has_errors = true; |
||
| 121 | $errors['fld_fieldname'][] = _AM_XHELP_VALID_ERR_FIELDNAME; |
||
| 122 | } |
||
| 123 | |||
| 124 | //fieldname unique? |
||
| 125 | $criteria = new \CriteriaCompo(new \Criteria('fieldname', $fld_fieldname)); |
||
| 126 | if ($ticketFieldHandler->getCount($criteria)) { |
||
| 127 | $has_errors = true; |
||
| 128 | $errors['fld_fieldname'][] = _AM_XHELP_VALID_ERR_FIELDNAME_UNIQUE; |
||
| 129 | } |
||
| 130 | |||
| 131 | //Length filled |
||
| 132 | if (0 == Request::getInt('fld_length', 0, 'POST') && true === $fld_needslength) { |
||
| 133 | $has_errors = true; |
||
| 134 | $errors['fld_length'][] = sprintf(_AM_XHELP_VALID_ERR_LENGTH, 2, 16777215); |
||
| 135 | } |
||
| 136 | |||
| 137 | //Departments Chosen? |
||
| 138 | |||
| 139 | //default value in value set? |
||
| 140 | if (count($values)) { |
||
| 141 | if (!in_array($_POST['fld_defaultvalue'], $values) |
||
| 142 | && !array_key_exists($_POST['fld_defaultvalue'], $values)) { |
||
| 143 | $has_errors = true; |
||
| 144 | $errors['fld_defaultvalue'][] = _AM_XHELP_VALID_ERR_DEFAULTVALUE; |
||
| 145 | } |
||
| 146 | |||
| 147 | //length larger than longest value? |
||
| 148 | $length = Request::getInt('fld_length', 0, 'POST'); |
||
| 149 | foreach ($values as $key => $value) { |
||
| 150 | if (mb_strlen($key) > $length) { |
||
| 151 | $has_errors = true; |
||
| 152 | $errors['fld_values'][] = sprintf(_AM_XHELP_VALID_ERR_VALUE_LENGTH, htmlentities($key, ENT_QUOTES | ENT_HTML5), $length); |
||
| 153 | } |
||
| 154 | } |
||
| 155 | //Values are all of the correct datatype? |
||
| 156 | } elseif ($fld_needsvalues) { |
||
| 157 | $has_errors = true; |
||
| 158 | $errors['fld_values'][] = _AM_XHELP_VALID_ERR_VALUE; |
||
| 159 | } |
||
| 160 | |||
| 161 | if ($has_errors) { |
||
| 162 | $afield = []; |
||
| 163 | |||
| 164 | $afield['name'] = \Xmf\Request::getString('fld_name', '', 'POST'); |
||
| 165 | $afield['description'] = \Xmf\Request::getString('fld_description', '', 'POST'); |
||
| 166 | $afield['fieldname'] = $fld_fieldname; |
||
| 167 | $afield['departments'] = $_POST['fld_departments']; |
||
| 168 | $afield['controltype'] = $_POST['fld_controltype']; |
||
| 169 | $afield['datatype'] = $_POST['fld_datatype']; |
||
| 170 | $afield['required'] = $_POST['fld_required']; |
||
| 171 | $afield['weight'] = $_POST['fld_weight']; |
||
| 172 | $afield['defaultvalue'] = $_POST['fld_defaultvalue']; |
||
| 173 | $afield['values'] = $_POST['fld_values']; |
||
| 174 | $afield['length'] = $_POST['fld_length']; |
||
| 175 | $afield['validation'] = ($_POST['fld_valid_select'] == $_POST['fld_valid_txtbox'] ? $_POST['fld_valid_select'] : $_POST['fld_valid_txtbox']); |
||
| 176 | $session->set('xhelp_addField', $afield); |
||
| 177 | $session->set('xhelp_addFieldErrors', $errors); |
||
| 178 | $helper->redirect('admin/fields.php'); |
||
| 179 | } |
||
| 180 | |||
| 181 | //Save field |
||
| 182 | /** @var \XoopsModules\Xhelp\TicketFieldHandler $ticketFieldHandler */ |
||
| 183 | $ticketFieldHandler = $helper->getHandler('TicketField'); |
||
| 184 | /** @var \XoopsModules\Xhelp\TicketField $ticketField */ |
||
| 185 | $ticketField = $ticketFieldHandler->create(); |
||
| 186 | $ticketField->setVar('name', \Xmf\Request::getString('fld_name', '', 'POST')); |
||
| 187 | $ticketField->setVar('description', \Xmf\Request::getString('fld_description', '', 'POST')); |
||
| 188 | $ticketField->setVar('fieldname', $fld_fieldname); |
||
| 189 | $ticketField->setVar('controltype', $_POST['fld_controltype']); |
||
| 190 | $ticketField->setVar('datatype', $_POST['fld_datatype']); |
||
| 191 | $ticketField->setVar('fieldlength', $_POST['fld_length']); |
||
| 192 | $ticketField->setVar('required', $_POST['fld_required']); |
||
| 193 | $ticketField->setVar('weight', $_POST['fld_weight']); |
||
| 194 | $ticketField->setVar('defaultvalue', $_POST['fld_defaultvalue']); |
||
| 195 | $ticketField->setVar('validation', ($_POST['fld_valid_select'] == $_POST['fld_valid_txtbox'] ? $_POST['fld_valid_select'] : $_POST['fld_valid_txtbox'])); |
||
| 196 | $ticketField->addValues($values); |
||
| 197 | $ticketField->addDepartments($_POST['fld_departments']); |
||
| 198 | |||
| 199 | if ($ticketFieldHandler->insert($ticketField)) { |
||
| 200 | clearAddSessionVars(); |
||
| 201 | $helper->redirect('admin/fields.php', 3, _AM_XHELP_MSG_FIELD_ADD_OK); |
||
| 202 | } else { |
||
| 203 | $errors = $ticketField->getHtmlErrors(); |
||
| 204 | $helper->redirect('admin/fields.php', 3, _AM_XHELP_MSG_FIELD_ADD_ERR . $errors); |
||
| 205 | } |
||
| 206 | } else { |
||
| 207 | $criteria = new \Criteria('', ''); |
||
| 208 | $criteria->setLimit($limit); |
||
| 209 | $criteria->setStart($start); |
||
| 210 | $criteria->setSort('weight'); |
||
| 211 | $criteria->setOrder('ASC'); |
||
| 212 | |||
| 213 | $count = $ticketFieldHandler->getCount($criteria); |
||
| 214 | $fieldsArray = $ticketFieldHandler->getObjects($criteria); |
||
| 215 | |||
| 216 | //Display List of Current Fields, form for new field |
||
| 217 | xoops_cp_header(); |
||
| 218 | //echo $oAdminButton->renderButtons('manfields'); |
||
| 219 | $adminObject = Admin::getInstance(); |
||
| 220 | $adminObject->displayNavigation(basename(__FILE__)); |
||
| 221 | |||
| 222 | if ($count) { |
||
| 223 | $nav = new \XoopsPageNav($count, $limit, $start, 'start', "op=manageFields&limit=$limit"); |
||
| 224 | |||
| 225 | echo "<table width='100%' cellspacing='1' class='outer'> |
||
| 226 | <tr><th colspan='7'><label>" . _AM_XHELP_TEXT_MANAGE_FIELDS . '</label></th></tr>'; |
||
| 227 | echo "<tr class='head'> |
||
| 228 | <td>" . _AM_XHELP_TEXT_ID . '</td> |
||
| 229 | <td>' . _AM_XHELP_TEXT_NAME . '</td> |
||
| 230 | <td>' . _AM_XHELP_TEXT_DESCRIPTION . '</td> |
||
| 231 | <td>' . _AM_XHELP_TEXT_FIELDNAME . '</td> |
||
| 232 | <td>' . _AM_XHELP_TEXT_CONTROLTYPE . '</td> |
||
| 233 | <td>' . _AM_XHELP_TEXT_REQUIRED . '</td> |
||
| 234 | <td>' . _AM_XHELP_TEXT_ACTIONS . '</td> |
||
| 235 | </tr>'; |
||
| 236 | |||
| 237 | $req_link_params = [ |
||
| 238 | 'op' => 'setFieldRequired', |
||
| 239 | 'setrequired' => 1, |
||
| 240 | 'id' => 0, |
||
| 241 | ]; |
||
| 242 | |||
| 243 | foreach ($fieldsArray as $field) { |
||
| 244 | $req_link_params['id'] = $field->getVar('id'); |
||
| 245 | |||
| 246 | if ($field->getVar('required')) { |
||
| 247 | $req_link_params['setrequired'] = 0; |
||
| 248 | $req_img = $icons['online']; |
||
| 249 | $req_title = _AM_XHELP_MESSAGE_DEACTIVATE; |
||
| 250 | } else { |
||
| 251 | $req_link_params['setrequired'] = 1; |
||
| 252 | $req_img = $icons['offline'] ?? ''; |
||
| 253 | $req_title = _AM_XHELP_MESSAGE_ACTIVATE; |
||
| 254 | } |
||
| 255 | |||
| 256 | $edit_url = Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'editfield', 'id' => $field->getVar('id')]); |
||
|
Bug
introduced
by
|
|||
| 257 | $del_url = Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'delfield', 'id' => $field->getVar('id')]); |
||
| 258 | |||
| 259 | echo "<tr class='even'><td>" . $field->getVar('id') . '</td> |
||
| 260 | <td>' . $field->getVar('name') . '</td> |
||
| 261 | <td>' . $field->getVar('description') . '</td> |
||
| 262 | <td>' . $field->getVar('fieldname') . '</td> |
||
| 263 | <td>' . xhelpGetControlLabel((string)$field->getVar('controltype')) . "</td> |
||
| 264 | <td><a href='" . Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', $req_link_params) . "' title='$req_title'>$req_img</a></td> |
||
| 265 | <td><a href='$edit_url'>" . ($icons['edit'] ?? '') . "</a> |
||
| 266 | <a href='$del_url'>" . ($icons['delete'] ?? '') . '</a></td> |
||
| 267 | </tr>'; |
||
| 268 | } |
||
| 269 | echo '</table>'; |
||
| 270 | //Render Page Nav |
||
| 271 | echo "<div id='pagenav'>" . $nav->renderNav() . '</div><br>'; |
||
| 272 | } |
||
| 273 | |||
| 274 | //Get Custom Field From session (if exists) |
||
| 275 | $field_info = $session->get('xhelp_addField'); |
||
| 276 | $field_errors = $session->get('xhelp_addFieldErrors'); |
||
| 277 | |||
| 278 | /** @var \XoopsModules\Xhelp\DepartmentHandler $departmentHandler */ |
||
| 279 | $departmentHandler = $helper->getHandler('Department'); |
||
| 280 | $depts = $departmentHandler->getObjects(); |
||
| 281 | $deptarr = []; |
||
| 282 | |||
| 283 | foreach ($depts as $obj) { |
||
| 284 | $deptarr[$obj->getVar('id')] = $obj->getVar('department'); |
||
| 285 | } |
||
| 286 | |||
| 287 | if (false === !$field_info) { |
||
| 288 | //extract($field_info , EXTR_PREFIX_ALL , 'fld_'); |
||
| 289 | $fld_controltype = $field_info['controltype']; |
||
| 290 | $fld_datatype = $field_info['datatype']; |
||
| 291 | $fld_departments = $field_info['departments']; |
||
| 292 | $fld_name = $field_info['name']; |
||
| 293 | $fld_fieldname = $field_info['fieldname']; |
||
| 294 | $fld_description = $field_info['description']; |
||
| 295 | $fld_required = $field_info['required']; |
||
| 296 | $fld_length = $field_info['length']; |
||
| 297 | $fld_weight = $field_info['weight']; |
||
| 298 | $fld_defaultvalue = $field_info['defaultvalue']; |
||
| 299 | $fld_values = $field_info['values']; |
||
| 300 | $fld_validation = $field_info['validation']; |
||
| 301 | } else { |
||
| 302 | $fld_controltype = ''; |
||
| 303 | $fld_datatype = ''; |
||
| 304 | $fld_departments = array_keys($deptarr); |
||
| 305 | $fld_name = ''; |
||
| 306 | $fld_fieldname = ''; |
||
| 307 | $fld_description = ''; |
||
| 308 | $fld_required = ''; |
||
| 309 | $fld_length = ''; |
||
| 310 | $fld_weight = ''; |
||
| 311 | $fld_defaultvalue = ''; |
||
| 312 | $fld_values = ''; |
||
| 313 | $fld_validation = ''; |
||
| 314 | } |
||
| 315 | |||
| 316 | if (false === !$field_errors) { |
||
| 317 | xhelpRenderErrors($field_errors, Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'clearAddSession'])); |
||
| 318 | } |
||
| 319 | |||
| 320 | //Add Field Form |
||
| 321 | $controls = xhelpGetControlArray(); |
||
| 322 | $control_select = new \XoopsFormSelect(_AM_XHELP_TEXT_CONTROLTYPE, 'fld_controltype', $fld_controltype); |
||
| 323 | foreach ($controls as $key => $control) { |
||
| 324 | $control_select->addOption($key, $control['label']); |
||
| 325 | } |
||
| 326 | |||
| 327 | $datatypes = [ |
||
| 328 | _XHELP_DATATYPE_TEXT => _XHELP_DATATYPE_TEXT, |
||
| 329 | _XHELP_DATATYPE_NUMBER_INT => _XHELP_DATATYPE_NUMBER_INT, |
||
| 330 | _XHELP_DATATYPE_NUMBER_DEC => _XHELP_DATATYPE_NUMBER_DEC, |
||
| 331 | ]; |
||
| 332 | |||
| 333 | $datatype_select = new \XoopsFormSelect(_AM_XHELP_TEXT_DATATYPE, 'fld_datatype', $fld_datatype); |
||
| 334 | $datatype_select->addOptionArray($datatypes); |
||
| 335 | |||
| 336 | $dept_select = new \XoopsFormSelect(_AM_XHELP_TEXT_DEPARTMENTS, 'fld_departments', $fld_departments, 5, true); |
||
| 337 | foreach ($depts as $obj) { |
||
| 338 | $dept_select->addOptionArray($deptarr); |
||
| 339 | } |
||
| 340 | unset($depts); |
||
| 341 | |||
| 342 | $form = new Xhelp\Form(_AM_XHELP_ADD_FIELD, 'add_field', Xhelp\Utility::createURI(XHELP_ADMIN_URL . '/fields.php', ['op' => 'managefields'])); |
||
| 343 | $nameEle = new \XoopsFormText(_AM_XHELP_TEXT_NAME, 'fld_name', 30, 64, $fld_name); |
||
| 344 | $nameEle->setDescription(_AM_XHELP_TEXT_NAME_DESC); |
||
| 345 | $form->addElement($nameEle); |
||
| 346 | |||
| 347 | $fieldnameEle = new \XoopsFormText(_AM_XHELP_TEXT_FIELDNAME, 'fld_fieldname', 30, 64, $fld_fieldname); |
||
| 348 | $fieldnameEle->setDescription(_AM_XHELP_TEXT_FIELDNAME_DESC); |
||
| 349 | $form->addElement($fieldnameEle); |
||
| 350 | |||
| 351 | $descriptionEle = new \XoopsFormTextArea(_AM_XHELP_TEXT_DESCRIPTION, 'fld_description', $fld_description, 5, 60); |
||
| 352 | $descriptionEle->setDescription(_AM_XHELP_TEXT_DESCRIPTION_DESC); |
||
| 353 | $form->addElement($descriptionEle); |
||
| 354 | |||
| 355 | $dept_select->setDescription(_AM_XHELP_TEXT_DEPT_DESC); |
||
| 356 | $control_select->setDescription(_AM_XHELP_TEXT_CONTROLTYPE_DESC); |
||
| 357 | $datatype_select->setDescription(_AM_XHELP_TEXT_DATATYPE_DESC); |
||
| 358 | |||
| 359 | $form->addElement($dept_select); |
||
| 360 | $form->addElement($control_select); |
||
| 361 | $form->addElement($datatype_select); |
||
| 362 | |||
| 363 | $required = new \XoopsFormRadioYN(_AM_XHELP_TEXT_REQUIRED, 'fld_required', $fld_required); |
||
| 364 | $required->setDescription(_AM_XHELP_TEXT_REQUIRED_DESC); |
||
| 365 | $form->addElement($required); |
||
| 366 | |||
| 367 | $lengthEle = new \XoopsFormText(_AM_XHELP_TEXT_LENGTH, 'fld_length', 5, 5, $fld_length); |
||
| 368 | $lengthEle->setDescription(_AM_XHELP_TEXT_LENGTH_DESC); |
||
| 369 | $weightEle = new \XoopsFormText(_AM_XHELP_TEXT_WEIGHT, 'fld_weight', 5, 5, $fld_weight); |
||
| 370 | $weightEle->setDescription(_AM_XHELP_TEXT_WEIGHT_DESC); |
||
| 371 | |||
| 372 | $form->addElement($lengthEle); |
||
| 373 | $form->addElement($weightEle); |
||
| 374 | |||
| 375 | $regex_control = new Xhelp\FormRegex(_AM_XHELP_TEXT_VALIDATION, 'fld_valid', $fld_validation); |
||
| 376 | $regex_control->addOptionArray($regex_array); |
||
| 377 | $regex_control->setDescription(_AM_XHELP_TEXT_VALIDATION_DESC); |
||
| 378 | |||
| 379 | $form->addElement($regex_control); |
||
| 380 | |||
| 381 | $defaultValueEle = new \XoopsFormText(_AM_XHELP_TEXT_DEFAULTVALUE, 'fld_defaultvalue', 30, 100, $fld_defaultvalue); |
||
| 382 | $defaultValueEle->setDescription(_AM_XHELP_TEXT_DEFAULTVALUE_DESC); |
||
| 383 | $form->addElement($defaultValueEle); |
||
| 384 | $values = new \XoopsFormTextArea(_AM_XHELP_TEXT_FIELDVALUES, 'fld_values', $fld_values, 5, 60); |
||
| 385 | $values->setDescription(_AM_XHELP_TEXT_FIELDVALUES_DESC); |
||
| 386 | $form->addElement($values); |
||
| 387 | |||
| 388 | $btn_tray = new \XoopsFormElementTray(''); |
||
| 389 | $btn_tray->addElement(new \XoopsFormButton('', 'addField', _SUBMIT, 'submit')); |
||
| 390 | |||
| 391 | $form->addElement($btn_tray); |
||
| 392 | echo $form->render(); |
||
| 393 | |||
| 394 | require_once __DIR__ . '/admin_footer.php'; |
||
| 395 | } |
||
| 835 |
Loading history...