CategoryController::show() - Code Metrics - Inspection of "Re-add scrutinizer" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (a6481d)

by Fèvre

created 2017-05-04 00:16 UTC

CategoryController::show() B

↳ Parent: CategoryController

Complexity

Conditions	2
Paths	2

Size

Total Lines	27
Code Lines	17

Duplication

Lines	27
Ratio	100 %

Importance

Changes

Metric	Value
dl	27
loc	27
rs	8.8571
c	0
b	0
f	0
cc	2
eloc	17
nc	2
nop	3

<?php
namespace Xetaravel\Http\Controllers\Blog;

use Xetaravel\Http\Controllers\Controller;
use Xetaravel\Models\Category;
use Illuminate\Http\Request;

class CategoryController extends Controller
{

    public function __construct()
    {
        parent::__construct();

        $this->breadcrumbs->addCrumb('Blog', route('blog_article_index'));
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Show the article by his id.
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\View\View

     */
    public function show(Request $request, $slug, $id)

    {
        $category = Category::with('articles')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->where('id', $id)
            ->first();

        if (is_null($category)) {
            return redirect()
                ->route('blog_article_index')
                ->with('danger', 'This category doesn\'t exist or has been deleted !');
        }

        $articles = $category->articles()->paginate(config('xetaravel.pagination.blog.article_per_page'));

        $this->breadcrumbs->addCrumb(
            "Category : " . e($category->title),
            route(
                'blog_article_show',
                ['slug' => $category->slug, 'id' => $category->id]
            )
        );

        return view(
            'Blog::category.show',
            ['articles' => $articles, 'category' => $category, 'breadcrumbs' => $this->breadcrumbs]
        );
    }
}


1		<?php
2		namespace Xetaravel\Http\Controllers\Blog;
3
4		use Xetaravel\Http\Controllers\Controller;
5		use Xetaravel\Models\Category;
6		use Illuminate\Http\Request;
7
8		class CategoryController extends Controller
9		{
10
11		public function __construct()
12		{
13		parent::__construct();
14
15		$this->breadcrumbs->addCrumb('Blog', route('blog_article_index'));
		0 ignored issues – show Bug introduced 2017-05-03 18:29 UTC by Report Bug Copy Issue Report The property `breadcrumbs` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16		}
17
18		/**
19		* Show the article by his id.
20		*
21		* @return \Illuminate\Http\RedirectResponse\|\Illuminate\View\View
		0 ignored issues – show Documentation introduced 2017-05-04 00:08 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\Redirec...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
22		*/
23	View Code Duplication	public function show(Request $request, $slug, $id)
		0 ignored issues – show Unused Code introduced 2017-05-03 18:29 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-05-03 18:29 UTC by Report Bug Copy Issue Report The parameter `$slug` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2017-05-03 18:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
24		{
25		$category = Category::with('articles')
		0 ignored issues – show Bug introduced 2017-05-03 18:29 UTC by Report Bug Copy Issue Report The method `where` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
26		->where('id', $id)
27		->first();
28
29		if (is_null($category)) {
30		return redirect()
31		->route('blog_article_index')
32		->with('danger', 'This category doesn\'t exist or has been deleted !');
33		}
34
35		$articles = $category->articles()->paginate(config('xetaravel.pagination.blog.article_per_page'));
36
37		$this->breadcrumbs->addCrumb(
38		"Category : " . e($category->title),
39		route(
40		'blog_article_show',
41		['slug' => $category->slug, 'id' => $category->id]
42		)
43		);
44
45		return view(
46		'Blog::category.show',
47		['articles' => $articles, 'category' => $category, 'breadcrumbs' => $this->breadcrumbs]
48		);
49		}
50		}
51

XetaIO / Xetaravel

Branch — master (a6481d)

CategoryController::show() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like